85897 2012-05-08 10:35:30 -0700 [Chromium] OS(ANDROID) ImageDiff requires us to build WTF for both host and target 2012-05-08 20:36:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85904 66687 1 abarth abarth eric johnme peter tony webkit.review.bot zhenghao oldest_to_newest 618607 0 abarth 2012-05-08 10:35:30 -0700 [Chromium] OS(ANDROID) ImageDiff requires us to build WTF for both host and target 618611 1 140739 abarth 2012-05-08 10:36:46 -0700 Created attachment 140739 Patch 618616 2 140739 tony 2012-05-08 10:48:27 -0700 Comment on attachment 140739 Patch What is android_build_type? 618635 3 140739 tony 2012-05-08 11:05:47 -0700 Comment on attachment 140739 Patch Peter explained to me what android_build_type is. LGTM. 618647 4 peter 2012-05-08 11:14:50 -0700 Confirmed this works fine, patch LGTM as well. Thanks Adam! 618665 5 140739 webkit.review.bot 2012-05-08 11:44:30 -0700 Comment on attachment 140739 Patch Clearing flags on attachment: 140739 Committed r116440: <http://trac.webkit.org/changeset/116440> 618666 6 webkit.review.bot 2012-05-08 11:44:35 -0700 All reviewed patches have been landed. Closing bug. 618691 7 webkit.review.bot 2012-05-08 12:08:27 -0700 Re-opened since this is blocked by 85904 619125 8 zhenghao 2012-05-08 19:50:10 -0700 I remember I have removed the dependency on wtf of ImageDiff. Why we need it again? 619126 9 zhenghao 2012-05-08 19:51:17 -0700 Oh, sorry. I didn't notice replying the bug would reopen it. 619142 10 abarth 2012-05-08 20:36:11 -0700 (In reply to comment #8) > I remember I have removed the dependency on wtf of ImageDiff. Why we need it again? Ah, that means we can fix this downstream. Thanks! 140739 2012-05-08 10:36:46 -0700 2012-05-08 11:44:30 -0700 Patch bug-85897-20120508103645.patch text/plain 1550 abarth SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMTY0MzQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA1LTA4ICBBZGFtIEJhcnRoICA8YWJhcnRo QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBPUyhBTkRST0lEKSBJbWFnZURpZmYg cmVxdWlyZXMgdXMgdG8gYnVpbGQgV1RGIGZvciBib3RoIGhvc3QgYW5kIHRhcmdldAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU4OTcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdURi5neXAvV1RGLmd5 cDoKKwogMjAxMi0wNS0wOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAg ICAgIFtDaHJvbWl1bV0gQXNzZXJ0aW9ucy5jcHAgc2hvdWxkIHdvcmsgb24gT1MoQU5EUk9JRCkK SW5kZXg6IFNvdXJjZS9XVEYvV1RGLmd5cC9XVEYuZ3lwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X VEYvV1RGLmd5cC9XVEYuZ3lwCShyZXZpc2lvbiAxMTY0MzQpCisrKyBTb3VyY2UvV1RGL1dURi5n eXAvV1RGLmd5cAkod29ya2luZyBjb3B5KQpAQCAtOTMsNyArOTMsMTQgQEAKICAgICAgICAgICAg IF0sCiAgICAgICAgICAgfV0sCiAgICAgICAgIF0sCi0gICAgICB9CisgICAgICB9LAorICAgICAg J2NvbmRpdGlvbnMnOiBbCisgICAgICAgIFsnT1M9PSJhbmRyb2lkIiBhbmQgYW5kcm9pZF9idWls ZF90eXBlPT0wJywgeworICAgICAgICAgICMgQW5kcm9pZCBidWlsZHMgSW1hZ2VEaWZmIGZvciBo b3N0LCB3aGljaCBoYXMgYSBkZXBlbmRlbmN5IG9uIHd0Zi4KKyAgICAgICAgICAjIFRoYXQgbWVh bnMgd2UgbmVlZCB0byBidWlsZCB0aGlzIHRhcmdldCBmb3IgYm90aCBob3N0IGFuZCB0YXJnZXQu CisgICAgICAgICAgJ3Rvb2xzZXRzJzogWydob3N0JywgJ3RhcmdldCddLAorICAgICAgICB9XSwK KyAgICAgIF0KICAgICB9LAogICAgIHsKICAgICAgICd0YXJnZXRfbmFtZSc6ICd3dGYnLApAQCAt MTgyLDYgKzE4OSwxMSBAQAogICAgICAgICAgICAgfV0sCiAgICAgICAgICAgXSwKICAgICAgICAg fV0sCisgICAgICAgIFsnT1M9PSJhbmRyb2lkIiBhbmQgYW5kcm9pZF9idWlsZF90eXBlPT0wJywg eworICAgICAgICAgICMgQW5kcm9pZCBidWlsZHMgSW1hZ2VEaWZmIGZvciBob3N0LCB3aGljaCBo YXMgYSBkZXBlbmRlbmN5IG9uIHd0Zi4KKyAgICAgICAgICAjIFRoYXQgbWVhbnMgd2UgbmVlZCB0 byBidWlsZCB0aGlzIHRhcmdldCBmb3IgYm90aCBob3N0IGFuZCB0YXJnZXQuCisgICAgICAgICAg J3Rvb2xzZXRzJzogWydob3N0JywgJ3RhcmdldCddLAorICAgICAgICB9XSwKICAgICAgIF0sCiAg ICAgfSwKICAgXQo=