85889 2012-05-08 09:15:14 -0700 [EFL] Memory leaks found in EFL DRT 2012-05-10 06:42:15 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis gustavo gyuyoung.kim lucas.de.marchi mrobinson rakuco tonikitoo webkit.review.bot oldest_to_newest 618554 0 naginenis 2012-05-08 09:15:14 -0700 Valgrind report memory leaks. It seems JSString created with JSStringCreateWithUTF8CString needs to be released explicitly or use JSRetainPtr ==19762== 22 bytes in 1 blocks are indirectly lost in loss record 826 of 6,796 ==19762== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==19762== by 0x55F1AEA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==19762== by 0x532FE08: OpaqueJSString::OpaqueJSString(unsigned short const*, unsigned int) (FastMalloc.h:269) ==19762== by 0x532FD3D: OpaqueJSString::create(unsigned short const*, unsigned int) (OpaqueJSString.h:46) ==19762== by 0x532FA3D: JSStringCreateWithUTF8CString (JSStringRef.cpp:50) ==19762== by 0x463660: DumpRenderTreeChrome::onWindowObjectCleared(void*, _Evas_Object*, void*) (DumpRenderTreeChrome.cpp:364) ==19762== by 0x4E794F2: evas_object_smart_callback_call (evas_object_smart.c:460) ==19762== by 0xBFE3CDF: WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld(WebCore::DOMWrapperWorld*) (FrameLoaderClientEfl.cpp:437) ==19762== by 0x88FE87A: WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld(WebCore::DOMWrapperWorld*) (FrameLoader.cpp:3101) ==19762== by 0x900C0F8: WebCore::ScriptController::initScript(WebCore::DOMWrapperWorld*) (ScriptController.cpp:223) ==19762== by 0x83DDCAC: WebCore::ScriptController::windowShell(WebCore::DOMWrapperWorld*) (ScriptController.h:75) ==19762== by 0x900BB06: WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld*) (ScriptController.cpp:131) ==19762== by 0x900BD31: WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) (ScriptController.cpp:162) ==19762== by 0x862DC8B: WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) (ScriptElement.cpp:290) ==19762== by 0x87CB633: WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent(WebCore::PendingScript&) (HTMLScriptRunner.cpp:139) ==19762== by 0x87CB489: WebCore::HTMLScriptRunner::executeParsingBlockingScript() (HTMLScriptRunner.cpp:118) ==19762== by 0x87CB9F2: WebCore::HTMLScriptRunner::executeParsingBlockingScripts() (HTMLScriptRunner.cpp:195) ==19762== by 0x87CBB69: WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad(WebCore::CachedResource*) (HTMLScriptRunner.cpp:206) ==19762== by 0x87BF755: WebCore::HTMLDocumentParser::notifyFinished(WebCore::CachedResource*) (HTMLDocumentParser.cpp:517) ==19762== by 0x89590D3: WebCore::CachedResource::checkNotify() (CachedResource.cpp:248) ==19762== by 0x896A5CE: WebCore::CachedScript::data(WTF::PassRefPtr<WebCore::SharedBuffer>, bool) (CachedScript.cpp:104) ==19762== by 0x8924364: WebCore::SubresourceLoader::didFinishLoading(double) (SubresourceLoader.cpp:276) ==19762== by 0x8920772: WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) (ResourceLoader.cpp:435) ==19762== by 0x93E6B4A: WebCore::readCallback(_GObject*, _GAsyncResult*, void*) (ResourceHandleSoup.cpp:864) ==19762== by 0xECC9DE4: async_ready_callback_wrapper (ginputstream.c:470) ==19762== by 0xECDB80C: g_simple_async_result_complete (gsimpleasyncresult.c:744) ==19762== by 0xECDB8A7: complete_in_idle_cb_for_thread (gsimpleasyncresult.c:812) ==19762== by 0xD677FC9: g_main_context_dispatch (gmain.c:2513) ==19762== by 0x414C5E0: _ecore_glib_select (ecore_glib.c:171) ==19762== by 0x41469AC: _ecore_main_select (ecore_main.c:1419) ==19762== by 0x4147444: _ecore_main_loop_iterate_internal (ecore_main.c:1835) ==19762== by 0x4147726: ecore_main_loop_begin (ecore_main.c:906) ==19762== by 0x45F895: runTest(char const*) (DumpRenderTree.cpp:248) ==19762== by 0x46009A: main (DumpRenderTree.cpp:411) ==19762== 240 bytes in 20 blocks are indirectly lost in loss record 5,852 of 6,796 ==19762== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==19762== by 0x55F1AEA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==19762== by 0x532FE08: OpaqueJSString::OpaqueJSString(unsigned short const*, unsigned int) (FastMalloc.h:269) ==19762== by 0x532FD3D: OpaqueJSString::create(unsigned short const*, unsigned int) (OpaqueJSString.h:46) ==19762== by 0x532FA3D: JSStringCreateWithUTF8CString (JSStringRef.cpp:50) ==19762== by 0x469CCC: modifiersFromJSValue(OpaqueJSContext const*, OpaqueJSValue const*) (EventSender.cpp:228) ==19762== by 0x46AA27: createKeyEventInfo(OpaqueJSContext const*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (EventSender.cpp:441) ==19762== by 0x46AC73: keyDownCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (EventSender.cpp:468) ==19762== by 0x5311DA3: JSC::JSCallbackFunction::call(JSC::ExecState*) (JSCallbackFunction.cpp:73) ==19762== by 0x549F5C5: cti_op_call_NotJSFunction (JITStubs.cpp:2312) ==19762== by 0x549AD77: JSC::JITThunks::tryCacheGetByID(JSC::ExecState*, JSC::CodeBlock*, JSC::ReturnAddressPtr, JSC::JSValue, JSC::Identifier const&, JSC::PropertySlot const&, JSC::StructureStubInfo*) ==19762== by 0x7FEFFE0EF: ??? 618565 1 140728 naginenis 2012-05-08 09:26:30 -0700 Created attachment 140728 patch Fix memory leaks. 619733 2 140728 rakuco 2012-05-09 12:35:50 -0700 Comment on attachment 140728 patch Looks good, thanks. 620240 3 140728 gyuyoung.kim 2012-05-09 21:53:45 -0700 Comment on attachment 140728 patch Looks fine as well. 620541 4 140728 webkit.review.bot 2012-05-10 06:42:10 -0700 Comment on attachment 140728 patch Clearing flags on attachment: 140728 Committed r116638: <http://trac.webkit.org/changeset/116638> 620542 5 webkit.review.bot 2012-05-10 06:42:15 -0700 All reviewed patches have been landed. Closing bug. 140728 2012-05-08 09:26:30 -0700 2012-05-10 06:42:10 -0700 patch 85889.patch text/plain 2746 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlOTlk YmNkLi45YWYzZWUyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDUtMDggIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gTWVt b3J5IGxlYWtzIGZvdW5kIGluIEVGTCBEUlQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg1ODg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4IHR3byBtZW1vcnkgbGVha3MgaW4gRUZMJ3MgRFJUIGJ5IHVz aW5nIEpTUmV0YWluUHRyIGZvciBKU1N0cmluZworICAgICAgICBjcmVhdGVkIHdpdGggSlNTdHJp bmdDcmVhdGVXaXRoVVRGOENTdHJpbmcuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwv RHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwOgorICAgICAgICAoRHVtcFJlbmRlclRyZWVDaHJvbWU6 Om9uV2luZG93T2JqZWN0Q2xlYXJlZCk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZWZsL0V2 ZW50U2VuZGVyLmNwcDoKKyAgICAgICAgKG1vZGlmaWVyc0Zyb21KU1ZhbHVlKToKKwogMjAxMi0w NS0wOCAgR2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbd2Vi a2l0LXBhdGNoXSBSZXR1cm4gbWVhbmluZ2Z1bCByZXN1bHRzIGZyb20gc2luZ2xlLXJlc3VsdCBx dWVyaWVzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJU cmVlQ2hyb21lLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNo cm9tZS5jcHAKaW5kZXggMGNmZTNmZC4uNjQ5YzM1YyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcAorKysgYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCkBAIC0zNjEsNyArMzYxLDcgQEAg dm9pZCBEdW1wUmVuZGVyVHJlZUNocm9tZTo6b25XaW5kb3dPYmplY3RDbGVhcmVkKHZvaWQqIHVz ZXJEYXRhLCBFdmFzX09iamVjdCosIHYKICAgICBnY0NvbnRyb2xsZXItPm1ha2VXaW5kb3dPYmpl Y3Qob2JqZWN0Q2xlYXJlZEluZm8tPmNvbnRleHQsIG9iamVjdENsZWFyZWRJbmZvLT53aW5kb3dP YmplY3QsICZleGNlcHRpb24pOwogICAgIEFTU0VSVCghZXhjZXB0aW9uKTsKIAotICAgIEpTUmV0 YWluUHRyPEpTU3RyaW5nUmVmPiBjb250cm9sbGVyTmFtZShKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4 Q1N0cmluZygiZXZlbnRTZW5kZXIiKSk7CisgICAgSlNSZXRhaW5QdHI8SlNTdHJpbmdSZWY+IGNv bnRyb2xsZXJOYW1lKEFkb3B0LCBKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygiZXZlbnRT ZW5kZXIiKSk7CiAgICAgSlNPYmplY3RTZXRQcm9wZXJ0eShvYmplY3RDbGVhcmVkSW5mby0+Y29u dGV4dCwgb2JqZWN0Q2xlYXJlZEluZm8tPndpbmRvd09iamVjdCwKICAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnRyb2xsZXJOYW1lLmdldCgpLAogICAgICAgICAgICAgICAgICAgICAgICAgbWFr ZUV2ZW50U2VuZGVyKG9iamVjdENsZWFyZWRJbmZvLT5jb250ZXh0LCAhRHVtcFJlbmRlclRyZWVT dXBwb3J0RWZsOjpmcmFtZVBhcmVudChvYmplY3RDbGVhcmVkSW5mby0+ZnJhbWUpKSwKZGlmZiAt LWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9FdmVudFNlbmRlci5jcHAgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9lZmwvRXZlbnRTZW5kZXIuY3BwCmluZGV4IDJiZWQ1YzkuLjI4YmQ3NTAg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9FdmVudFNlbmRlci5jcHAKKysr IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0V2ZW50U2VuZGVyLmNwcApAQCAtMjI1LDcgKzIy NSw4IEBAIHN0YXRpYyBFdmFzS2V5TW9kaWZpZXIgbW9kaWZpZXJzRnJvbUpTVmFsdWUoSlNDb250 ZXh0UmVmIGNvbnRleHQsIGNvbnN0IEpTVmFsdWVSCiAgICAgICAgIHJldHVybiBFdmFzS2V5TW9k aWZpZXJOb25lOwogCiAgICAgdW5zaWduZWQgbW9kaWZpZXIgPSAwOwotICAgIGludCBtb2RpZmll cnNDb3VudCA9IEpTVmFsdWVUb051bWJlcihjb250ZXh0LCBKU09iamVjdEdldFByb3BlcnR5KGNv bnRleHQsIG1vZGlmaWVyc0FycmF5LCBKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygibGVu Z3RoIiksIDApLCAwKTsKKyAgICBKU1JldGFpblB0cjxKU1N0cmluZ1JlZj4gbGVuZ3RoUHJvcGVy dHkoQWRvcHQsIEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJsZW5ndGgiKSk7CisgICAg aW50IG1vZGlmaWVyc0NvdW50ID0gSlNWYWx1ZVRvTnVtYmVyKGNvbnRleHQsIEpTT2JqZWN0R2V0 UHJvcGVydHkoY29udGV4dCwgbW9kaWZpZXJzQXJyYXksIGxlbmd0aFByb3BlcnR5LmdldCgpLCAw KSwgMCk7CiAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBtb2RpZmllcnNDb3VudDsgKytpKQogICAg ICAgICBtb2RpZmllciB8PSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4obW9kaWZpZXJGcm9tSlNWYWx1 ZShjb250ZXh0LCBKU09iamVjdEdldFByb3BlcnR5QXRJbmRleChjb250ZXh0LCBtb2RpZmllcnNB cnJheSwgaSwgMCkpKTsKICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8RXZhc0tleU1vZGlmaWVyPiht b2RpZmllcik7Cg==