85886 2012-05-08 08:34:40 -0700 [GTK] Memory leak in DRT EventSender.cpp 2012-05-08 10:14:06 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis mrobinson webkit.review.bot oldest_to_newest 618539 0 naginenis 2012-05-08 08:34:40 -0700 Valgrind report a memory leak inside the gdkModifersFromJSValue(). It seems JSString created with JSStringCreateWithUTF8CString needs to be released. ==19010== 240 bytes in 20 blocks are indirectly lost in loss record 10,113 of 11,527 ==19010== at 0x4C2AC27: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==19010== by 0x5219944: OpaqueJSString::OpaqueJSString(unsigned short const*, unsigned int) (OpaqueJSString.h:69) ==19010== by 0x5219881: OpaqueJSString::create(unsigned short const*, unsigned int) (OpaqueJSString.h:46) ==19010== by 0x5219581: JSStringCreateWithUTF8CString (JSStringRef.cpp:50) ==19010== by 0x4635E1: gdkModifersFromJSValue(OpaqueJSContext const*, OpaqueJSValue const*) (EventSender.cpp:301) ==19010== by 0x4647DC: createKeyPressEvent(OpaqueJSContext const*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (EventSender.cpp:622) ==19010== by 0x464F30: keyDownCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (EventSender.cpp:760) ==19010== by 0x51FBA93: JSC::JSCallbackFunction::call(JSC::ExecState*) (JSCallbackFunction.cpp:73) ==19010== by 0x53874C9: cti_op_call_NotJSFunction (JITStubs.cpp:2312) ==19010== by 0x5382C7B: JSC::JITThunks::tryCacheGetByID(JSC::ExecState*, JSC::CodeBlock*, JSC::ReturnAddressPtr, JSC::JSValue, JSC::Identifier const&, JSC::PropertySlot const&, JSC::StructureStubInfo*) ==19010== by 0x7FEFFDF8F: ??? 618552 1 140726 naginenis 2012-05-08 09:12:04 -0700 Created attachment 140726 patch Fix a memory leak 618596 2 140726 webkit.review.bot 2012-05-08 10:14:01 -0700 Comment on attachment 140726 patch Clearing flags on attachment: 140726 Committed r116434: <http://trac.webkit.org/changeset/116434> 618597 3 webkit.review.bot 2012-05-08 10:14:06 -0700 All reviewed patches have been landed. Closing bug. 140726 2012-05-08 09:12:04 -0700 2012-05-08 10:14:00 -0700 patch 85886.patch text/plain 1614 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkZDYy Y2VjLi5jZDMxMzZlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMDggIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gTWVt b3J5IGxlYWsgaW4gRFJUIEV2ZW50U2VuZGVyLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU4ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYSBtZW1vcnkgbGVhayBpbiBnZGtNb2RpZmVyc0Zy b21KU1ZhbHVlKCkgYnkgdXNpbmcgSlNSZXRhaW5QdHIgZm9yCisgICAgICAgIEpTU3RyaW5nIGNy ZWF0ZWQgd2l0aCBKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZy4KKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHA6CisgICAgICAgIChnZGtNb2RpZmVyc0Zy b21KU1ZhbHVlKToKKwogMjAxMi0wNS0wNyAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5tZW5hcmRA b3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBbUXRdIFVuYnJlYWsgZGVidWdnaW5nIG9mIFdlYktp dDIuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3Bw IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcAppbmRleCBkMzk2YzUy Li45MmFjYmU3IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5k ZXIuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAKQEAg LTI5OCw3ICsyOTgsOCBAQCBzdGF0aWMgZ3VpbnQgZ2RrTW9kaWZlcnNGcm9tSlNWYWx1ZShKU0Nv bnRleHRSZWYgY29udGV4dCwgY29uc3QgSlNWYWx1ZVJlZiBtb2RpZgogICAgICAgICByZXR1cm4g MDsKIAogICAgIGd1aW50IGdka01vZGlmaWVycyA9IDA7Ci0gICAgaW50IG1vZGlmaWVyc0NvdW50 ID0gSlNWYWx1ZVRvTnVtYmVyKGNvbnRleHQsIEpTT2JqZWN0R2V0UHJvcGVydHkoY29udGV4dCwg bW9kaWZpZXJzQXJyYXksIEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJsZW5ndGgiKSwg MCksIDApOworICAgIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBsZW5ndGhQcm9wZXJ0eShBZG9w dCwgSlNTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoImxlbmd0aCIpKTsKKyAgICBpbnQgbW9k aWZpZXJzQ291bnQgPSBKU1ZhbHVlVG9OdW1iZXIoY29udGV4dCwgSlNPYmplY3RHZXRQcm9wZXJ0 eShjb250ZXh0LCBtb2RpZmllcnNBcnJheSwgbGVuZ3RoUHJvcGVydHkuZ2V0KCksIDApLCAwKTsK ICAgICBmb3IgKGludCBpID0gMDsgaSA8IG1vZGlmaWVyc0NvdW50OyArK2kpCiAgICAgICAgIGdk a01vZGlmaWVycyB8PSBnZGtNb2RpZmllckZyb21KU1ZhbHVlKGNvbnRleHQsIEpTT2JqZWN0R2V0 UHJvcGVydHlBdEluZGV4KGNvbnRleHQsIG1vZGlmaWVyc0FycmF5LCBpLCAwKSk7CiAgICAgcmV0 dXJuIGdka01vZGlmaWVyczsK