85869 2012-05-08 00:09:26 -0700 OS(ANDROID) JNI AttachCurrentThread take JNIEnv** as a parameter, not void** 2012-05-08 01:59:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 abarth abarth andersca eric johnme peter webkit.review.bot oldest_to_newest 618374 0 abarth 2012-05-08 00:09:26 -0700 Modern JNI AttachCurrentThread take JNIEnv** as a parameter, not void** 618377 1 140685 abarth 2012-05-08 00:13:08 -0700 Created attachment 140685 Patch 618378 2 140685 eric 2012-05-08 00:13:41 -0700 Comment on attachment 140685 Patch So long as this passes all the EWSes, this is good to go. 618382 3 140685 buildbot 2012-05-08 00:31:42 -0700 Comment on attachment 140685 Patch Attachment 140685 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12646272 618390 4 abarth 2012-05-08 01:06:18 -0700 Sigh. Mac and its ancient Java. 618401 5 140687 abarth 2012-05-08 01:19:00 -0700 Created attachment 140687 Patch 618404 6 140687 eric 2012-05-08 01:25:13 -0700 Comment on attachment 140687 Patch OK. 618424 7 140687 webkit.review.bot 2012-05-08 01:59:27 -0700 Comment on attachment 140687 Patch Clearing flags on attachment: 140687 Committed r116405: <http://trac.webkit.org/changeset/116405> 618425 8 webkit.review.bot 2012-05-08 01:59:41 -0700 All reviewed patches have been landed. Closing bug. 140685 2012-05-08 00:13:08 -0700 2012-05-08 01:18:56 -0700 Patch bug-85869-20120508001306.patch text/plain 1633 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNjQwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTA4ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTW9kZXJuIEpOSSBBdHRhY2hDdXJy ZW50VGhyZWFkIHRha2UgSk5JRW52KiogYXMgYSBwYXJhbWV0ZXIsIG5vdCB2b2lkKioKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1ODY5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjb3JkaW5nIHRvCisg ICAgICAgIGh0dHA6Ly9kb2NzLm9yYWNsZS5jb20vamF2YXNlLzEuNS4wL2RvY3MvZ3VpZGUvam5p L3NwZWMvaW52b2NhdGlvbi5odG1sLAorICAgICAgICBBdHRhY2hDdXJyZW50VGhyZWFkIHRha2Vz IGEgSk5JRW52KiogcmF0aGVyIHRoYW4gYSB2b2lkKiouICBBcHBhcmVudGx5LAorICAgICAgICBK REsgMS4wIHRvb2sgYSB2b2lkKiosIGJ1dCBtb3JlIG1vZGVybiBKREtzIHRha2UgSk5JRW52Kiou CisKKyAgICAgICAgKiBicmlkZ2Uvam5pL0pOSVV0aWxpdHkuY3BwOgorICAgICAgICAoSlNDOjpC aW5kaW5nczo6Z2V0Sk5JRW52KToKKwogMjAxMi0wNS0wNSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBtYWtlIEphdmFTY3Jp cHRTb3VyY2VGcmFtZSB1c2UgYnJlYWtwb2ludCBtYW5hZ2VyJ3MgYnJlYWtwb2ludHMgc3RvcmUu CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9icmlkZ2Uvam5pL0pOSVV0aWxpdHkuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JyaWRnZS9qbmkvSk5JVXRpbGl0eS5jcHAJKHJldmlzaW9u IDExNjM5NykKKysrIFNvdXJjZS9XZWJDb3JlL2JyaWRnZS9qbmkvSk5JVXRpbGl0eS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTg0LDE2ICs4NCwxMyBAQCBKYXZhVk0qIGdldEphdmFWTSgpCiAKIEpO SUVudiogZ2V0Sk5JRW52KCkKIHsKLSAgICB1bmlvbiB7Ci0gICAgICAgIEpOSUVudiogZW52Owot ICAgICAgICB2b2lkKiBkdW1teTsKLSAgICB9IHU7CisgICAgSk5JRW52KiBlbnY7CiAgICAgamlu dCBqbmlFcnJvciA9IDA7CiAKLSAgICBqbmlFcnJvciA9IGdldEphdmFWTSgpLT5BdHRhY2hDdXJy ZW50VGhyZWFkKCZ1LmR1bW15LCAwKTsKKyAgICBqbmlFcnJvciA9IGdldEphdmFWTSgpLT5BdHRh Y2hDdXJyZW50VGhyZWFkKCZlbnYsIDApOwogCiAgICAgaWYgKGpuaUVycm9yID09IEpOSV9PSykK LSAgICAgICAgcmV0dXJuIHUuZW52OworICAgICAgICByZXR1cm4gZW52OwogICAgIExPR19FUlJP UigiQXR0YWNoQ3VycmVudFRocmVhZCBmYWlsZWQsIHJldHVybmVkICVsZCIsIHN0YXRpY19jYXN0 PGxvbmc+KGpuaUVycm9yKSk7CiAgICAgcmV0dXJuIDA7CiB9Cg== 140687 2012-05-08 01:19:00 -0700 2012-05-08 01:59:27 -0700 Patch bug-85869-20120508011859.patch text/plain 2036 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNjQwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTA4ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgT1MoQU5EUk9JRCkgSk5JIEF0dGFj aEN1cnJlbnRUaHJlYWQgdGFrZSBKTklFbnYqKiBhcyBhIHBhcmFtZXRlciwgbm90IHZvaWQqKgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU4NjkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBY2NvcmRpbmcg dG8KKyAgICAgICAgaHR0cDovL2RvY3Mub3JhY2xlLmNvbS9qYXZhc2UvMS41LjAvZG9jcy9ndWlk ZS9qbmkvc3BlYy9pbnZvY2F0aW9uLmh0bWwsCisgICAgICAgIEF0dGFjaEN1cnJlbnRUaHJlYWQg dGFrZXMgYSBKTklFbnYqKiByYXRoZXIgdGhhbiBhIHZvaWQqKi4gIEFwcGFyZW50bHksCisgICAg ICAgIG1vc3QgaW1wbGVtZW50YXRpb25zIGFjdHVhbGx5IHRha2UgYSB2b2lkKiouICBUaGUgT1Mo QU5EUk9JRCkKKyAgICAgICAgaW1wbGVtZW50YXRpb24sIGhvd2V2ZXIsIGFjdHVhbGx5IHRha2Vz IGFuIEpOSUVudioqLiAgVGhpcyBwYXRjaAorICAgICAgICBpbnRyb2R1Y2VzIGEgdHlwZWRlZiB0 byBnaXZlIGVhY2ggaW1wbGVtZW50YXRpb24gd2hhdCBpdCBkZXNpcmVzLgorCisgICAgICAgICog YnJpZGdlL2puaS9KTklVdGlsaXR5LmNwcDoKKyAgICAgICAgKEpTQzo6QmluZGluZ3M6OmdldEpO SUVudik6CisKIDIwMTItMDUtMDUgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogbWFrZSBKYXZhU2NyaXB0U291cmNlRnJhbWUg dXNlIGJyZWFrcG9pbnQgbWFuYWdlcidzIGJyZWFrcG9pbnRzIHN0b3JlLgpJbmRleDogU291cmNl L1dlYkNvcmUvYnJpZGdlL2puaS9KTklVdGlsaXR5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9icmlkZ2Uvam5pL0pOSVV0aWxpdHkuY3BwCShyZXZpc2lvbiAxMTYzOTcpCisrKyBT b3VyY2UvV2ViQ29yZS9icmlkZ2Uvam5pL0pOSVV0aWxpdHkuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC04MiwxMSArODIsMjMgQEAgSmF2YVZNKiBnZXRKYXZhVk0oKQogICAgIHJldHVybiBqdm07CiB9 CiAKKy8vIEpESyAxLjAgbWlzdGFrZW5seSBkZWNsYXJlZCB0aGUgZmlyc3QgcGFyYW1ldGVyIHRv IEF0dGFjaEN1cnJlbnRUaHJlYWQgYXMKKy8vIHZvaWQqKiByYXRoZXIgdGhhbiBhcyBKTklFbnYq Ki4gVGhpcyBxdWlyayBhcHBlYXJzIHRvIGhhdmUgYmVlbiBjYXJyaWVkCisvLyBmb3J3YXJkIGlu IGltcGxlbWVudGF0aW9ucyBvZiBKYXZhIGRlc3BpdGUgd2hhdCB0aGUgZG9jdW1lbnRhdGlvbiBz YXlzLgorLy8gT24gT1MoQU5EUk9JRCksIGhvd2V2ZXIsIEF0dGFjaEN1cnJlbnRUaHJlYWQgYXBw ZWFycyB0byBmb2xsb3cgdGhlCisvLyBkb2N1bWVudGF0aW9uIGFuZCBleHBlY3RzIGEgSk5JRW52 KiogcGFyYW1ldGVyLiBUaGUgZm9sbG93aW5nIHR5cGVkZWYgc2hvdWxkCisvLyBnaXZlIGVhY2gg aW1wbGVtZW50YXRpb24gd2hhdCBpdCBkZXNpcmVzLgorI2lmIE9TKEFORFJPSUQpCit0eXBlZGVm IEpOSUVudiogSk5JRW52RHVtbXk7CisjZWxzZQordHlwZWRlZiB2b2lkKiBKTklFbnZEdW1teTsK KyNlbmRpZgorCiBKTklFbnYqIGdldEpOSUVudigpCiB7CiAgICAgdW5pb24gewogICAgICAgICBK TklFbnYqIGVudjsKLSAgICAgICAgdm9pZCogZHVtbXk7CisgICAgICAgIEpOSUVudkR1bW15IGR1 bW15OwogICAgIH0gdTsKICAgICBqaW50IGpuaUVycm9yID0gMDsKIAo=