85855 2012-05-07 20:51:33 -0700 Compositing layers with transformed children not large enough to show contents 2012-05-07 22:46:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser achicu enne eric jamesr simon.fraser webkit-bug-importer webkit.review.bot oldest_to_newest 618264 0 simon.fraser 2012-05-07 20:51:33 -0700 http://trac.webkit.org/changeset/109851/ regressed (or revealed) a bug in some compositing content (test case attached). The size of the #slider layer is not big enough to contain the transformed children. 618265 1 140660 simon.fraser 2012-05-07 20:51:52 -0700 Created attachment 140660 Testcase 618266 2 simon.fraser 2012-05-07 20:52:13 -0700 <rdar://problem/11401995> 618267 3 webkit-bug-importer 2012-05-07 20:52:45 -0700 <rdar://problem/11402771> 618273 4 simon.fraser 2012-05-07 21:08:13 -0700 RenderLayer::calculateLayerBounds() is using convertToLayerCoords() which ignores transforms! 618306 5 simon.fraser 2012-05-07 22:11:15 -0700 Ah, the actual bug was caused by http://trac.webkit.org/changeset/114518, by the newly added UseLocalClipRectIfPossible code path in RenderLayer::calculateLayerBounds() which didn't handle transforms. 618319 6 140675 simon.fraser 2012-05-07 22:33:54 -0700 Created attachment 140675 Patch 618320 7 140675 mitz 2012-05-07 22:36:29 -0700 Comment on attachment 140675 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140675&action=review > Source/WebCore/rendering/RenderLayer.cpp:4163 > + TransformationMatrix* affineTrans = layer->transform(); Weird name for a local variable that’s not really needed. 618323 8 simon.fraser 2012-05-07 22:46:04 -0700 http://trac.webkit.org/changeset/116395 140660 2012-05-07 20:51:52 -0700 2012-05-07 20:51:52 -0700 Testcase daum-reduction.html text/html 701 simon.fraser PCFET0NUWVBFIGh0bWw+Cgo8aHRtbD4KPGhlYWQ+CiAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBt ZWRpYT0ic2NyZWVuIj4KICAgIAogICAgI3NsaWRlciB7CiAgICAgIHBvc2l0aW9uOiByZWxhdGl2 ZTsKICAgICAgbWFyZ2luLWxlZnQ6IDkwcHg7CiAgICAgIGhlaWdodDogMjc4cHg7CiAgICAgIHdp ZHRoOiAzMDBweDsKICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKC0yMCUsIDAs IDApOwogICAgICBib3JkZXI6IDFweCBzb2xpZCBibGFjazsKICAgIH0KICAgIAogICAgLmJveCB7 CiAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAgICAgdG9wOiAwOwogICAgICBvdmVyZmxvdzog aGlkZGVuOwogICAgICBoZWlnaHQ6IDI1MHB4OwogICAgICB3aWR0aDogMjUwcHg7CiAgICAgIGJh Y2tncm91bmQtY29sb3I6IHNpbHZlcjsKICAgIH0KICA8L3N0eWxlPgo8L2hlYWQ+Cjxib2R5PgoK ICA8cD5TaG91bGQgc2VlIHR3byBncmF5IGJveGVzIG9mIGVxdWFsIHdpZHRoPC9wPgogICAgPGRp diBpZD0ic2xpZGVyIj4KICAgICAgPGRpdiBjbGFzcz0iYm94IiBzdHlsZT0iLXdlYmtpdC10cmFu c2Zvcm06IHRyYW5zbGF0ZVgoMCkiPjwvZGl2PgogICAgICA8ZGl2IGNsYXNzPSJib3giIHN0eWxl PSItd2Via2l0LXRyYW5zZm9ybTogdHJhbnNsYXRlWCgxMDElKSI+PC9kaXY+CiAgICA8L2Rpdj4K CjwvYm9keT4KPC9odG1sPgo= 140675 2012-05-07 22:33:54 -0700 2012-05-07 22:36:29 -0700 Patch bug-85855-20120507223352.patch text/plain 6258 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2Mzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzU1Yzg2YWFiOGYwZDdl ZTI1NzJhNmYzOGUwYmM0NGNjNGJjYmNjOS4uMzFlM2ZiNjBhY2U1YzVhMzc1ZDc5YjFiYjQzOGYx NjhmZWQxZjc4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA1LTA3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENvbXBvc2l0aW5n IGxheWVycyB3aXRoIHRyYW5zZm9ybWVkIGNoaWxkcmVuIG5vdCBsYXJnZSBlbm91Z2ggdG8gc2hv dyBjb250ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODU4NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAg CisgICAgICAgIHIxMTQ1MTggYWRkZWQgYSBjb2RlIHBhdGggdG8gUmVuZGVyTGF5ZXI6OmNhbGN1 bGF0ZUxheWVyQm91bmRzKCkgd2hpY2gKKyAgICAgICAgZG9lcyBhbiBlYXJseSByZXR1cm4gaWYg dGhlIGxheWVyIGhhcyBjbGlwcGluZy4gSG93ZXZlciwgdGhpcyBjb2RlCisgICAgICAgIHBhdGgg b21pdHRlZCB0byB0YWtlIGxvY2FsIHRyYW5zZm9ybXMgaW50byBhY2NvdW50LgorICAgICAgICAK KyAgICAgICAgRml4IGlzIHRvIGhhbmRsZSB0cmFuc2Zvcm1zIGFzIHdlIGRvIGluIHRoZSBub24t Y2xpcHBlZCBjYXNlLgorCisgICAgICAgIFRlc3Q6IGNvbXBvc2l0aW5nL2dlb21ldHJ5L2JvdW5k cy1jbGlwcGVkLWNvbXBvc2l0ZWQtY2hpbGQuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpjYWxjdWxhdGVM YXllckJvdW5kcyk6CisKIDIwMTItMDUtMDcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KIAogICAgICAgICBbQ2hyb21pdW1dIEFuZHJvaWQgd2lzaGVzIHRvIHVzZSBhbiBlbXB0eSBp bXBsZW1lbnRhdGlvbiBpZiBBWE9iamVjdENhY2hlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyLmNwcAppbmRleCAzMzM3OWNmMjQ4M2I3MmU3ODc1MDdkMWViZTE5NDUzYWYzYTBh ZDIwLi5jOTFkN2QxYzhhMWQyNWYzNjExZTAxNzc0ZjE1ZDllMWRlMWFiNDNkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTQxNTksNiArNDE1OSwxMSBAQCBJ bnRSZWN0IFJlbmRlckxheWVyOjpjYWxjdWxhdGVMYXllckJvdW5kcyhjb25zdCBSZW5kZXJMYXll ciogbGF5ZXIsIGNvbnN0IFJlbmRlcgogICAgIGlmIChmbGFncyAmIFVzZUxvY2FsQ2xpcFJlY3RJ ZlBvc3NpYmxlKSB7CiAgICAgICAgIExheW91dFJlY3QgbG9jYWxDbGlwUmVjdCA9IGxheWVyLT5s b2NhbENsaXBSZWN0KCk7CiAgICAgICAgIGlmIChsb2NhbENsaXBSZWN0ICE9IFBhaW50SW5mbzo6 aW5maW5pdGVSZWN0KCkpIHsKKyAgICAgICAgICAgIGlmICgoZmxhZ3MgJiBJbmNsdWRlU2VsZlRy YW5zZm9ybSkgJiYgbGF5ZXItPnBhaW50c1dpdGhUcmFuc2Zvcm0oUGFpbnRCZWhhdmlvck5vcm1h bCkpIHsKKyAgICAgICAgICAgICAgICBUcmFuc2Zvcm1hdGlvbk1hdHJpeCogYWZmaW5lVHJhbnMg PSBsYXllci0+dHJhbnNmb3JtKCk7CisgICAgICAgICAgICAgICAgbG9jYWxDbGlwUmVjdCA9IGFm ZmluZVRyYW5zLT5tYXBSZWN0KGxvY2FsQ2xpcFJlY3QpOworICAgICAgICAgICAgfQorCiAgICAg ICAgICAgICBMYXlvdXRQb2ludCBhbmNlc3RvclJlbE9mZnNldDsKICAgICAgICAgICAgIGxheWVy LT5jb252ZXJ0VG9MYXllckNvb3JkcyhhbmNlc3RvckxheWVyLCBhbmNlc3RvclJlbE9mZnNldCk7 CiAgICAgICAgICAgICBsb2NhbENsaXBSZWN0Lm1vdmVCeShhbmNlc3RvclJlbE9mZnNldCk7CmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggOGI4MjMwNTZkYmFlNGJjYTNiYzM0YzI1MThiZjRjMWEyODMxNDYxYi4uNjZmNjdiMDY1 OTU1OGNlZWFhZmU5N2FiZjA4MjUxYTQ2ODAzNzFhNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisy MDEyLTA1LTA3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAg ICAgIENvbXBvc2l0aW5nIGxheWVycyB3aXRoIHRyYW5zZm9ybWVkIGNoaWxkcmVuIG5vdCBsYXJn ZSBlbm91Z2ggdG8gc2hvdyBjb250ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODU4NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKyAgICAgICAgCisgICAgICAgIFRlc3QgaGF2aW5nIGNvbXBvc2l0ZWQgZWxlbWVudCB3 aXRoIGNsaXBwZWQsIHRyYW5zZm9ybWVkIGNoaWxkcmVuLgorCisgICAgICAgICogY29tcG9zaXRp bmcvZ2VvbWV0cnkvYm91bmRzLWNsaXBwZWQtY29tcG9zaXRlZC1jaGlsZC1leHBlY3RlZC5wbmc6 IEFkZGVkLgorICAgICAgICAqIGNvbXBvc2l0aW5nL2dlb21ldHJ5L2JvdW5kcy1jbGlwcGVkLWNv bXBvc2l0ZWQtY2hpbGQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBjb21wb3NpdGlu Zy9nZW9tZXRyeS9ib3VuZHMtY2xpcHBlZC1jb21wb3NpdGVkLWNoaWxkLmh0bWw6IEFkZGVkLgor CiAyMDEyLTA1LTA3ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBB ZGQgcGxhdGZvcm0vbWFjLyByZXN1bHRzIGZvciBuZXcgdGVzdHMgYWRkZWQgYnkgcjExNjM3My4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2dlb21ldHJ5L2JvdW5kcy1jbGlw cGVkLWNvbXBvc2l0ZWQtY2hpbGQtZXhwZWN0ZWQucG5nIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRp bmcvZ2VvbWV0cnkvYm91bmRzLWNsaXBwZWQtY29tcG9zaXRlZC1jaGlsZC1leHBlY3RlZC5wbmcK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uMmZiOThhN2I3NGNkMWI4YzcwOTMzNDA3OGViZTMzZTVjZGQ4NDUxZgpHSVQg YmluYXJ5IHBhdGNoCmxpdGVyYWwgMzMxNAp6Y21lQVNATj8ob2xIeWB1VkJxIWlhMHl+eVV7K3ZZ VjJhPmkxQiVRbFlicFJ6bmtCOWdDQ000NyQ9U3VGeGVRNHUKelcrckxvaEd5bXxXfm5LTE13WF5Z c2l1al5XK0BnJT03eUZnN0E4aDl1e1JoUGN2P0pOOTc4SlJ5dUdgVF9wcEhnCnppe3NeaGAlVCpR UXghQks0Xyl2JV5XZjReXzg0UGhjP08xdDFMZmE9YzA5MFU7YjM1eEFQQlZGIUwwIShBaiF6WQp6 ej50Q3ZlNzIpe0wqNDJkalA7cCpfZ15xRCpnUnhIbUIqQFNSMWhyYGhoS29Db2p2bkxqKik/M1Bj dHxFMVRfNC0KektJKUBrcFNuaypjcj1QZmkjMSRyZzM7VkRubWF+dyQ3dEByPkA5I3hoTUMtKGda TmtLRk4/R1FfOXF4VFVIeDN2CklJVkNnITA5Ym1Mb0Ijai0KCmxpdGVyYWwgMApIY21WP2QwMDAw MQoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2dlb21ldHJ5L2JvdW5kcy1j bGlwcGVkLWNvbXBvc2l0ZWQtY2hpbGQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvY29tcG9z aXRpbmcvZ2VvbWV0cnkvYm91bmRzLWNsaXBwZWQtY29tcG9zaXRlZC1jaGlsZC1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uYzcxNjAwMGQzNGI4NjRjN2EyZDQzMzQzMDE1YTFlNjg4NTIzODI1MAot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2dlb21ldHJ5L2JvdW5k cy1jbGlwcGVkLWNvbXBvc2l0ZWQtY2hpbGQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTggQEAK KyhHcmFwaGljc0xheWVyCisgIChib3VuZHMgODAwLjAwIDYwMC4wMCkKKyAgKGNoaWxkcmVuIDEK KyAgICAoR3JhcGhpY3NMYXllcgorICAgICAgKGJvdW5kcyA4MDAuMDAgNjAwLjAwKQorICAgICAg KGNoaWxkcmVuIDEKKyAgICAgICAgKEdyYXBoaWNzTGF5ZXIKKyAgICAgICAgICAocG9zaXRpb24g NTguMDAgOC4wMCkKKyAgICAgICAgICAoYW5jaG9yIDAuMjUgMC41MCkKKyAgICAgICAgICAoYm91 bmRzIDIwMC4wMCAxMDAuMDApCisgICAgICAgICAgKGRyYXdzQ29udGVudCAxKQorICAgICAgICAg ICh0cmFuc2Zvcm0gWzEuMDAgMC4wMCAwLjAwIDAuMDBdIFswLjAwIDEuMDAgMC4wMCAwLjAwXSBb MC4wMCAwLjAwIDEuMDAgMC4wMF0gWy01MC4wMCAwLjAwIDAuMDAgMS4wMF0pCisgICAgICAgICkK KyAgICAgICkKKyAgICApCisgICkKKykKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29tcG9z aXRpbmcvZ2VvbWV0cnkvYm91bmRzLWNsaXBwZWQtY29tcG9zaXRlZC1jaGlsZC5odG1sIGIvTGF5 b3V0VGVzdHMvY29tcG9zaXRpbmcvZ2VvbWV0cnkvYm91bmRzLWNsaXBwZWQtY29tcG9zaXRlZC1j aGlsZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjZiNmQ5NDkxMDBhN2MwMWNhZTM0YjdlZGU5MDY5MTFmNmU1 NDEyNzMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9nZW9tZXRy eS9ib3VuZHMtY2xpcHBlZC1jb21wb3NpdGVkLWNoaWxkLmh0bWwKQEAgLTAsMCArMSw2MCBAQAor PCFET0NUWVBFIGh0bWw+CisKKzxodG1sPgorPGhlYWQ+CisgIDxzdHlsZT4KKyAgICBib2R5IHsK KyAgICAgIG92ZXJmbG93OiBoaWRkZW47CisgICAgfQorICAgIC5jb250YWluZXIgeworICAgICAg bWFyZ2luLWxlZnQ6IDUwcHg7CisgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgd2lkdGg6IDEw MHB4OworICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZTNkKC01MCUsIDAsIDApOwor ICAgIH0KKyAgICAKKyAgICAuYm94IHsKKyAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAg IHRvcDogMDsKKyAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICB3aWR0aDogMTAwcHg7CisgICAg ICBvdmVyZmxvdzogaGlkZGVuOworICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CisgICAg fQorICAgIAorICAgICNpbmRpY2F0b3IgeworICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAg ICAgdG9wOiA4cHg7CisgICAgICBsZWZ0OiA4cHg7CisgICAgICB3aWR0aDogMjAwcHg7CisgICAg ICBoZWlnaHQ6IDEwMHB4OworICAgICAgYmFja2dyb3VuZC1jb2xvcjogcmVkOworICAgIH0KKyAg ICAKKyAgICAjbGF5ZXJzIHsKKyAgICAgIG9wYWNpdHk6IDA7IC8qIGhpZGUgZnJvbSBwaXhlbCBy ZXN1bHQgKi8KKyAgICB9CisgIDwvc3R5bGU+CisgIDxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1Rl eHQodHJ1ZSk7CisKKyAgICBmdW5jdGlvbiBkdW1wTGF5ZXJzKCkKKyAgICB7CisgICAgICBpZiAo d2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnbGF5ZXJzJykuaW5uZXJUZXh0ID0gbGF5b3V0VGVzdENvbnRyb2xsZXIubGF5ZXJUcmVl QXNUZXh0KCk7CisgICAgfQorCisgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBk dW1wTGF5ZXJzLCBmYWxzZSk7CisgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisgIDwhLS0g WW91IHNob3VsZCBzZWUgYSBncmVlbiByZWN0YW5nbGUsIGFuZCBubyByZWQuIC0tPgorICA8ZGl2 IGlkPSJpbmRpY2F0b3IiPjwvZGl2PgorICA8ZGl2IGNsYXNzPSJjb250YWluZXIiPgorICAgIDxk aXYgY2xhc3M9ImJveCIgc3R5bGU9Ii13ZWJraXQtdHJhbnNmb3JtOiB0cmFuc2xhdGVYKDApIj48 L2Rpdj4KKyAgICA8ZGl2IGNsYXNzPSJib3giIHN0eWxlPSItd2Via2l0LXRyYW5zZm9ybTogdHJh bnNsYXRlWCgxMDAlKSI+PC9kaXY+CisgIDwvZGl2PgorPHByZSBpZD0ibGF5ZXJzIj5MYXllciB0 cmVlIGdvZXMgaGVyZSBpbiBEUlQ8L3ByZT4KKzwvYm9keT4KKzwvaHRtbD4K