85848 2012-05-07 17:36:42 -0700 [Chromium] Use ThrottledTextureUploader with threaded compositing. 2012-05-16 11:31:18 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85893 1 reveman reveman cc-bugs enne jamesr nduca webkit.review.bot oldest_to_newest 618161 0 reveman 2012-05-07 17:36:42 -0700 Can land as soon as http://code.google.com/p/chromium/issues/detail?id=123414 is fixed. 618172 1 140638 reveman 2012-05-07 17:43:27 -0700 Created attachment 140638 Patch 618183 2 140638 jamesr 2012-05-07 18:00:30 -0700 Comment on attachment 140638 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140638&action=review > Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:808 > + OwnPtr<TextureUploader> uploader = ThrottledTextureUploader::create(m_contextBeforeInitializationOnImplThread.get()); seems odd to create this uploader before we check if initialization is going to succeed or not. Is this ordering intentional - i.e. do we need an uploader to make it through initialization? 618598 3 reveman 2012-05-08 10:17:01 -0700 (In reply to comment #2) > (From update of attachment 140638 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140638&action=review > > > Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:808 > > + OwnPtr<TextureUploader> uploader = ThrottledTextureUploader::create(m_contextBeforeInitializationOnImplThread.get()); > > seems odd to create this uploader before we check if initialization is going to succeed or not. Is this ordering intentional - i.e. do we need an uploader to make it through initialization? Good point. This is odd and need to be fixed. We don't need the uploader to make it through initialization but I also find it a bit odd to give the LRC an uploader instance post initialization that has certain requirements for when to be destroyed. I think the best solution is to do land this change: https://bugs.webkit.org/show_bug.cgi?id=85893 which makes the change required to enable the throttled uploader: s/layerRenderer()->unthrottledTextureUploader()/layerRenderer()->throttledTextureUploader()/ in CCThreadProxy::scheduledActionUpdateMoreResources(). 618603 4 140737 reveman 2012-05-08 10:23:56 -0700 Created attachment 140737 Patch 621898 5 141478 reveman 2012-05-11 12:45:45 -0700 Created attachment 141478 Patch Rebase 622130 6 141478 enne 2012-05-11 17:07:55 -0700 Comment on attachment 141478 Patch R=me, since the Chromium side fix is in now and the unit tests all passed. 624884 7 141478 reveman 2012-05-15 19:39:20 -0700 Comment on attachment 141478 Patch Finished the testing I wanted to do. I think this is ready to land. 625680 8 141478 webkit.review.bot 2012-05-16 11:31:13 -0700 Comment on attachment 141478 Patch Clearing flags on attachment: 141478 Committed r117312: <http://trac.webkit.org/changeset/117312> 625681 9 webkit.review.bot 2012-05-16 11:31:18 -0700 All reviewed patches have been landed. Closing bug. 140638 2012-05-07 17:43:27 -0700 2012-05-08 10:23:56 -0700 Patch bug-85848-20120507204326.patch text/plain 3841 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2Mzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGU2YmI4MWU4MGYyOGVm NzA1ZjQ3MmUzNTE0ODU3Mzg0Zjc4Zjc0YS4uZTZmMjU2YmE4YTgyNGU0ZTU3MzczYWEwZmU4NTcy ZmUzY2I2ODVhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTA3ICBEYXZp ZCBSZXZlbWFuICA8cmV2ZW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBV c2UgVGhyb3R0bGVkVGV4dHVyZVVwbG9hZGVyIHdpdGggdGhyZWFkZWQgY29tcG9zaXRpbmcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTg0OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBUaHJvdHRs ZWRUZXh0dXJlVXBsb2FkZXIgaW4gQ0NUaHJlYWRQcm94eS4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGhyZWFkUHJveHkuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Q0NUaHJlYWRQcm94eTo6aW5pdGlhbGl6ZUxheWVyUmVuZGVyZXJPbkltcGxUaHJlYWQpOgor ICAgICAgICAoV2ViQ29yZTo6Q0NUaHJlYWRQcm94eTo6cmVjcmVhdGVDb250ZXh0T25JbXBsVGhy ZWFkKToKKwogMjAxMi0wNS0wNyAgRGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZWdpb246OmludGVyc2VjdHMoKSBhbmQgUmVnaW9uOjpjb250YWlucygpIGFy ZSBzbG93IGR1ZSB0byBjb3B5IG92ZXJoZWFkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1RocmVhZFByb3h5LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGhyZWFkUHJveHkuY3BwCmlu ZGV4IDE1N2ZjMWRmMDg2M2I3YmRiOTdkYmQ0M2Q1ZDMyMDhkMzVmM2Y1YWEuLjRiMjU4YTkyNDZi NzQ1Mzc4YmZkMmRiMWI4ODA5YzI4NmUwOTY0ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGhyZWFkUHJveHkuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGhyZWFkUHJveHku Y3BwCkBAIC01NywyNSArNTcsNiBAQCBzdGF0aWMgY29uc3QgZG91YmxlIGNvbnRleHRSZWNyZWF0 aW9uVGlja1JhdGUgPSAwLjAzOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLS8vIEZJWE1FOiBy ZW1vdmUgd2hlbiBUaHJvdHRsZWRUZXh0dXJlVXBsb2FkZXIgaXMgcmVhZHkgdG8gYmUgdXNlZC4K LWNsYXNzIFVudGhyb3R0bGVkVGV4dHVyZVVwbG9hZGVyIDogcHVibGljIFRleHR1cmVVcGxvYWRl ciB7Ci0gICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoVW50aHJvdHRsZWRUZXh0dXJlVXBsb2FkZXIp OwotcHVibGljOgotICAgIHN0YXRpYyBQYXNzT3duUHRyPFVudGhyb3R0bGVkVGV4dHVyZVVwbG9h ZGVyPiBjcmVhdGUoUGFzc1JlZlB0cjxHcmFwaGljc0NvbnRleHQzRD4gY29udGV4dCkKLSAgICB7 Ci0gICAgICAgIHJldHVybiBhZG9wdFB0cihuZXcgVW50aHJvdHRsZWRUZXh0dXJlVXBsb2FkZXIo Y29udGV4dCkpOwotICAgIH0KLSAgICB2aXJ0dWFsIH5VbnRocm90dGxlZFRleHR1cmVVcGxvYWRl cigpIHsgfQotCi0gICAgdmlydHVhbCBib29sIGlzQnVzeSgpIHsgcmV0dXJuIGZhbHNlOyB9Ci0g ICAgdmlydHVhbCB2b2lkIGJlZ2luVXBsb2FkcygpIHsgfQotICAgIHZpcnR1YWwgdm9pZCBlbmRV cGxvYWRzKCkgeyB9Ci0gICAgdmlydHVhbCB2b2lkIHVwbG9hZFRleHR1cmUoR3JhcGhpY3NDb250 ZXh0M0QqIGNvbnRleHQsIExheWVyVGV4dHVyZVVwZGF0ZXI6OlRleHR1cmUqIHRleHR1cmUsIFRl eHR1cmVBbGxvY2F0b3IqIGFsbG9jYXRvciwgY29uc3QgSW50UmVjdCBzb3VyY2VSZWN0LCBjb25z dCBJbnRSZWN0IGRlc3RSZWN0KSB7IHRleHR1cmUtPnVwZGF0ZVJlY3QoY29udGV4dCwgYWxsb2Nh dG9yLCBzb3VyY2VSZWN0LCBkZXN0UmVjdCk7IH0KLQotcHJvdGVjdGVkOgotICAgIGV4cGxpY2l0 IFVudGhyb3R0bGVkVGV4dHVyZVVwbG9hZGVyKFBhc3NSZWZQdHI8R3JhcGhpY3NDb250ZXh0M0Q+ KSB7IH0KLX07Ci0KIFBhc3NPd25QdHI8Q0NQcm94eT4gQ0NUaHJlYWRQcm94eTo6Y3JlYXRlKEND TGF5ZXJUcmVlSG9zdCogbGF5ZXJUcmVlSG9zdCkKIHsKICAgICByZXR1cm4gYWRvcHRQdHIobmV3 IENDVGhyZWFkUHJveHkobGF5ZXJUcmVlSG9zdCkpOwpAQCAtODI0LDcgKzgwNSw3IEBAIHZvaWQg Q0NUaHJlYWRQcm94eTo6aW5pdGlhbGl6ZUxheWVyUmVuZGVyZXJPbkltcGxUaHJlYWQoQ0NDb21w bGV0aW9uRXZlbnQqIGNvbXBsCiAgICAgVFJBQ0VfRVZFTlQoIkNDVGhyZWFkUHJveHk6OmluaXRp YWxpemVMYXllclJlbmRlcmVyT25JbXBsVGhyZWFkIiwgdGhpcywgMCk7CiAgICAgQVNTRVJUKGlz SW1wbFRocmVhZCgpKTsKICAgICBBU1NFUlQobV9jb250ZXh0QmVmb3JlSW5pdGlhbGl6YXRpb25P bkltcGxUaHJlYWQpOwotICAgIE93blB0cjxUZXh0dXJlVXBsb2FkZXI+IHVwbG9hZGVyID0gVW50 aHJvdHRsZWRUZXh0dXJlVXBsb2FkZXI6OmNyZWF0ZShtX2NvbnRleHRCZWZvcmVJbml0aWFsaXph dGlvbk9uSW1wbFRocmVhZC5nZXQoKSk7CisgICAgT3duUHRyPFRleHR1cmVVcGxvYWRlcj4gdXBs b2FkZXIgPSBUaHJvdHRsZWRUZXh0dXJlVXBsb2FkZXI6OmNyZWF0ZShtX2NvbnRleHRCZWZvcmVJ bml0aWFsaXphdGlvbk9uSW1wbFRocmVhZC5nZXQoKSk7CiAgICAgKmluaXRpYWxpemVTdWNjZWVk ZWQgPSBtX2xheWVyVHJlZUhvc3RJbXBsLT5pbml0aWFsaXplTGF5ZXJSZW5kZXJlcihtX2NvbnRl eHRCZWZvcmVJbml0aWFsaXphdGlvbk9uSW1wbFRocmVhZC5yZWxlYXNlKCksIHVwbG9hZGVyLnJl bGVhc2UoKSk7CiAgICAgaWYgKCppbml0aWFsaXplU3VjY2VlZGVkKSB7CiAgICAgICAgICpjYXBh YmlsaXRpZXMgPSBtX2xheWVyVHJlZUhvc3RJbXBsLT5sYXllclJlbmRlcmVyQ2FwYWJpbGl0aWVz KCk7CkBAIC04NzUsNyArODU2LDcgQEAgdm9pZCBDQ1RocmVhZFByb3h5OjpyZWNyZWF0ZUNvbnRl eHRPbkltcGxUaHJlYWQoQ0NDb21wbGV0aW9uRXZlbnQqIGNvbXBsZXRpb24sIEcKICAgICBUUkFD RV9FVkVOVDAoImNjIiwgIkNDVGhyZWFkUHJveHk6OnJlY3JlYXRlQ29udGV4dE9uSW1wbFRocmVh ZCIpOwogICAgIEFTU0VSVChpc0ltcGxUaHJlYWQoKSk7CiAgICAgbV9sYXllclRyZWVIb3N0LT5k ZWxldGVDb250ZW50c1RleHR1cmVzT25JbXBsVGhyZWFkKG1fbGF5ZXJUcmVlSG9zdEltcGwtPmNv bnRlbnRzVGV4dHVyZUFsbG9jYXRvcigpKTsKLSAgICBPd25QdHI8VGV4dHVyZVVwbG9hZGVyPiB1 cGxvYWRlciA9IFVudGhyb3R0bGVkVGV4dHVyZVVwbG9hZGVyOjpjcmVhdGUoY29udGV4dFB0cik7 CisgICAgT3duUHRyPFRleHR1cmVVcGxvYWRlcj4gdXBsb2FkZXIgPSBUaHJvdHRsZWRUZXh0dXJl VXBsb2FkZXI6OmNyZWF0ZShjb250ZXh0UHRyKTsKICAgICAqcmVjcmVhdGVTdWNjZWVkZWQgPSBt X2xheWVyVHJlZUhvc3RJbXBsLT5pbml0aWFsaXplTGF5ZXJSZW5kZXJlcihhZG9wdFJlZihjb250 ZXh0UHRyKSwgdXBsb2FkZXIucmVsZWFzZSgpKTsKICAgICBpZiAoKnJlY3JlYXRlU3VjY2VlZGVk KSB7CiAgICAgICAgICpjYXBhYmlsaXRpZXMgPSBtX2xheWVyVHJlZUhvc3RJbXBsLT5sYXllclJl bmRlcmVyQ2FwYWJpbGl0aWVzKCk7Cg== 140737 2012-05-08 10:23:56 -0700 2012-05-11 12:45:36 -0700 Patch enable-throttled.diff text/plain 1217 reveman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2Nj L0NDVGhyZWFkUHJveHkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vY2MvQ0NUaHJlYWRQcm94eS5jcHAKaW5kZXggMWFkOTkxYS4uOWY0MzViMCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaHJl YWRQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vY2MvQ0NUaHJlYWRQcm94eS5jcHAKQEAgLTU2OCw3ICs1NjgsNyBAQCB2b2lkIENDVGhyZWFk UHJveHk6OnNjaGVkdWxlZEFjdGlvblVwZGF0ZU1vcmVSZXNvdXJjZXMoKQogICAgIFRSQUNFX0VW RU5UKCJDQ1RocmVhZFByb3h5OjpzY2hlZHVsZWRBY3Rpb25VcGRhdGVNb3JlUmVzb3VyY2VzIiwg dGhpcywgMCk7CiAgICAgQVNTRVJUKG1fY3VycmVudFRleHR1cmVVcGRhdGVyT25JbXBsVGhyZWFk KTsKICAgICAvLyBGSVhNRTogVXNlIHRocm90dGxlZFRleHR1cmVVcGxvYWRlcigpIHdoZW4gVGhy b3R0bGVkVGV4dHVyZVVwbG9hZGVyIGlzIHJlYWR5IHRvIGJlIHVzZWQuCi0gICAgbV9jdXJyZW50 VGV4dHVyZVVwZGF0ZXJPbkltcGxUaHJlYWQtPnVwZGF0ZShtX2xheWVyVHJlZUhvc3RJbXBsLT5j b250ZXh0KCksIG1fbGF5ZXJUcmVlSG9zdEltcGwtPmNvbnRlbnRzVGV4dHVyZUFsbG9jYXRvcigp LCBtX2xheWVyVHJlZUhvc3RJbXBsLT5sYXllclJlbmRlcmVyKCktPnRleHR1cmVDb3BpZXIoKSwg bV9sYXllclRyZWVIb3N0SW1wbC0+bGF5ZXJSZW5kZXJlcigpLT51bnRocm90dGxlZFRleHR1cmVV cGxvYWRlcigpLCB0ZXh0dXJlVXBkYXRlc1BlckZyYW1lKTsKKyAgICBtX2N1cnJlbnRUZXh0dXJl VXBkYXRlck9uSW1wbFRocmVhZC0+dXBkYXRlKG1fbGF5ZXJUcmVlSG9zdEltcGwtPmNvbnRleHQo KSwgbV9sYXllclRyZWVIb3N0SW1wbC0+Y29udGVudHNUZXh0dXJlQWxsb2NhdG9yKCksIG1fbGF5 ZXJUcmVlSG9zdEltcGwtPmxheWVyUmVuZGVyZXIoKS0+dGV4dHVyZUNvcGllcigpLCBtX2xheWVy VHJlZUhvc3RJbXBsLT5sYXllclJlbmRlcmVyKCktPnRocm90dGxlZFRleHR1cmVVcGxvYWRlcigp LCB0ZXh0dXJlVXBkYXRlc1BlckZyYW1lKTsKIH0KIAogdm9pZCBDQ1RocmVhZFByb3h5OjpzY2hl ZHVsZWRBY3Rpb25Db21taXQoKQo= 141478 2012-05-11 12:45:45 -0700 2012-05-16 11:31:13 -0700 Patch bug-85848-20120511154544.patch text/plain 1452 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2Nzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWE0Zjk3MjFjNDg2MTA1 MzA3NTgwYzY1MTdhZjA2MTkyYTE0MWM5Zi4uNjMxN2U3MWYwMjdjMDkyYWRjNzczMDAyYTIxODI4 ZGRlNmY3YTQzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTExICBEYXZp ZCBSZXZlbWFuICA8cmV2ZW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBV c2UgVGhyb3R0bGVkVGV4dHVyZVVwbG9hZGVyIHdpdGggdGhyZWFkZWQgY29tcG9zaXRpbmcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTg0OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN3aXRjaCB0byBU aHJvdHRsZWRVcGxvYWRlciBpbiBDQ1RocmVhZFByb3h5LgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUaHJlYWRQcm94eS5jcHA6CisKIDIwMTItMDUtMTEgIElh biBWb2xsaWNrICA8dm9sbGlja0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBF bnN1cmUgdGhhdCBhbmltYXRpb25zIGNvbnRpbnVlIHRvIHJ1biB3aGVuIHRyYW5zZm9ybS1zdHls ZSBpcyBjaGFuZ2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9jYy9DQ1RocmVhZFByb3h5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGhyZWFkUHJveHkuY3BwCmluZGV4IDYzNzVkN2Y5YzNl MmM5NTliOGEyZWJlZDFmYzFkOTM2Y2ZjOTcwMjQuLjk2NGU1NWNjZTYzYWNmZTMwNDJiZDAyOWIw MGJhZmIyNWE5YTg4N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL2NjL0NDVGhyZWFkUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGhyZWFkUHJveHkuY3BwCkBAIC01OSw4ICs1 OSw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogbmFtZXNwYWNlIHsKIAotLy8gRklYTUU6IFVz ZSBUaHJvdHRsZWRVcGxvYWRlciBieSBkZWZhdWx0Lgotc3RhdGljIFRleHR1cmVVcGxvYWRlck9w dGlvbiB0ZXh0dXJlVXBsb2FkZXIgPSBVbnRocm90dGxlZFVwbG9hZGVyOworLy8gVHlwZSBvZiB0 ZXh0dXJlIHVwbG9hZGVyIHRvIHVzZSBmb3IgdGV4dHVyZSB1cGRhdGVzLgorc3RhdGljIFRleHR1 cmVVcGxvYWRlck9wdGlvbiB0ZXh0dXJlVXBsb2FkZXIgPSBUaHJvdHRsZWRVcGxvYWRlcjsKIAog fSAvLyBhbm9ueW1vdXMgbmFtZXNwYWNlCiAK