85842 2012-05-07 16:29:10 -0700 [Chromium] Android wishes to use an empty implementation if AXObjectCache 2012-05-07 19:46:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 abarth abarth eric johnme peter webkit.review.bot oldest_to_newest 618078 0 abarth 2012-05-07 16:29:10 -0700 [Chromium] Android wishes to use an empty implementation if AXObjectCache 618082 1 140618 abarth 2012-05-07 16:30:38 -0700 Created attachment 140618 Patch 618094 2 140618 tony 2012-05-07 16:45:06 -0700 Comment on attachment 140618 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140618&action=review > Source/WebCore/accessibility/chromium/AXObjectCacheChromiumAndroid.cpp:76 > +bool nodeHasRole(Node*, const String& role) > +{ > + UNUSED_PARAM(role); Nit: Can you just remove |role| on line 74 and not have to call UNUSED_PARAM? > Source/WebCore/accessibility/chromium/AXObjectCacheChromiumAndroid.cpp:150 > +void AXObjectCache::postNotification(RenderObject*, AXNotification, bool postToElement, PostType) > +{ > + UNUSED_PARAM(postToElement); > +} Ditto. > Source/WebCore/accessibility/chromium/AXObjectCacheChromiumAndroid.cpp:155 > +void AXObjectCache::postNotification(AccessibilityObject*, Document*, AXNotification, bool postToElement, PostType) > +{ > + UNUSED_PARAM(postToElement); > +} Ditto. > Source/WebCore/accessibility/chromium/AXObjectCacheChromiumAndroid.cpp:168 > +void AXObjectCache::nodeTextChangeNotification(RenderObject*, AXTextChange, unsigned offset, const String&) > +{ > + UNUSED_PARAM(offset); > +} Ditto. > Source/WebCore/accessibility/chromium/AXObjectCacheChromiumAndroid.cpp:200 > +void AXObjectCache::handleFocusedUIElementChanged(RenderObject*, RenderObject* newFocusedRenderer) > +{ > + UNUSED_PARAM(newFocusedRenderer); > +} Ditto. 618096 3 abarth 2012-05-07 16:50:26 -0700 (In reply to comment #2) > (From update of attachment 140618 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140618&action=review > > > Source/WebCore/accessibility/chromium/AXObjectCacheChromiumAndroid.cpp:76 > > +bool nodeHasRole(Node*, const String& role) > > +{ > > + UNUSED_PARAM(role); > > Nit: Can you just remove |role| on line 74 and not have to call UNUSED_PARAM? I can if you like. I left in the parameters names for parameters that weren't obvious to me. Maybe I should just remove them all given that this file is just an empty implementation. 618101 4 eric 2012-05-07 16:53:39 -0700 Why do they even want an AXObjectCache? Seems they just want to disable ACCESSIBILITY. :) 618110 5 abarth 2012-05-07 17:00:57 -0700 > Seems they just want to disable ACCESSIBILITY. :) It might be possible to go that route. I know that Chrome uses some accessibility features internally, for example for testing. There does appear to be a HAVE(ACCESSIBILITY) flag and some evidence that it can be turned off. 618112 6 eric 2012-05-07 17:02:06 -0700 I suspect they may have ended up this route, because the PLATFORM(CHROMIUM) && !HAVE(ACCESSIBILITY) path may not build cleanly. 618113 7 eric 2012-05-07 17:02:47 -0700 Of course disabling HAVE(ACCESSIBILITY) could make their binary smaller too. :) 618170 8 140637 abarth 2012-05-07 17:43:00 -0700 Created attachment 140637 Patch 618176 9 140637 eric 2012-05-07 17:48:11 -0700 Comment on attachment 140637 Patch LGTM. 618232 10 140637 webkit.review.bot 2012-05-07 19:46:31 -0700 Comment on attachment 140637 Patch Clearing flags on attachment: 140637 Committed r116385: <http://trac.webkit.org/changeset/116385> 618233 11 webkit.review.bot 2012-05-07 19:46:36 -0700 All reviewed patches have been landed. Closing bug. 140618 2012-05-07 16:30:38 -0700 2012-05-07 17:42:56 -0700 Patch bug-85842-20120507163036.patch text/plain 8126 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNjM2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQ3IEBACisyMDEyLTA1LTA3ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBBbmRyb2lkIHdp c2hlcyB0byB1c2UgYW4gZW1wdHkgaW1wbGVtZW50YXRpb24gaWYgQVhPYmplY3RDYWNoZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU4NDIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaHJvbWl1bSBvbiBB bmRyb2lkIHVzZXMgYW4gZW1wdHkgaW1wbGVtZW50YXRpb24gb2YgQVhPYmplY3RDYWNoZS4KKyAg ICAgICAgVGhpcyBwYXRjaCBqdXN0IGFkZCB0aGUgZW1wdHkgaW1wbGVtZW50YXRpb24gZmlsZS4g IEEgZnV0dXJlIHBhdGNoIHdpbGwKKyAgICAgICAgYWN0dWFsbHkgd2lyZSBpdCBpbnRvIHRoZSBi dWlsZCBzeXN0ZW0uCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2Nocm9taXVtL0FYT2JqZWN0 Q2FjaGVDaHJvbWl1bUFuZHJvaWQuY3BwOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmUpOgorICAg ICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6QVhPYmplY3RDYWNoZSk6CisgICAgICAgIChX ZWJDb3JlOjpBWE9iamVjdENhY2hlOjp+QVhPYmplY3RDYWNoZSk6CisgICAgICAgIChXZWJDb3Jl OjpBWE9iamVjdENhY2hlOjpmb2N1c2VkSW1hZ2VNYXBVSUVsZW1lbnQpOgorICAgICAgICAoV2Vi Q29yZTo6QVhPYmplY3RDYWNoZTo6Zm9jdXNlZFVJRWxlbWVudEZvclBhZ2UpOgorICAgICAgICAo V2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6Z2V0KToKKyAgICAgICAgKFdlYkNvcmU6Om5vZGVIYXNS b2xlKToKKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OmdldE9yQ3JlYXRlKToKKyAg ICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnJvb3RPYmplY3QpOgorICAgICAgICAoV2Vi Q29yZTo6QVhPYmplY3RDYWNoZTo6cm9vdE9iamVjdEZvckZyYW1lKToKKyAgICAgICAgKFdlYkNv cmU6OkFYT2JqZWN0Q2FjaGU6OnJlbW92ZSk6CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVjdENh Y2hlOjpwbGF0Zm9ybUdlbmVyYXRlQVhJRCk6CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVjdENh Y2hlOjpnZXRBWElEKToKKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnJlbW92ZUFY SUQpOgorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6Y29udGVudENoYW5nZWQpOgor ICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6Y2hpbGRyZW5DaGFuZ2VkKToKKyAgICAg ICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6Om5vdGlmaWNhdGlvblBvc3RUaW1lckZpcmVkKToK KyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnBvc3ROb3RpZmljYXRpb24pOgorICAg ICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6Y2hlY2tlZFN0YXRlQ2hhbmdlZCk6CisgICAg ICAgIChXZWJDb3JlOjpBWE9iamVjdENhY2hlOjpzZWxlY3RlZENoaWxkcmVuQ2hhbmdlZCk6Cisg ICAgICAgIChXZWJDb3JlOjpBWE9iamVjdENhY2hlOjpub2RlVGV4dENoYW5nZU5vdGlmaWNhdGlv bik6CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVjdENhY2hlOjpoYW5kbGVTY3JvbGxiYXJVcGRh dGUpOgorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6aGFuZGxlQXJpYUV4cGFuZGVk Q2hhbmdlKToKKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OmhhbmRsZUFjdGl2ZURl c2NlbmRhbnRDaGFuZ2VkKToKKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OmhhbmRs ZUFyaWFSb2xlQ2hhbmdlZCk6CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVjdENhY2hlOjp2aXNp YmxlUG9zaXRpb25Gb3JUZXh0TWFya2VyRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVj dENhY2hlOjp0ZXh0TWFya2VyRGF0YUZvclZpc2libGVQb3NpdGlvbik6CisgICAgICAgIChXZWJD b3JlOjpBWE9iamVjdENhY2hlOjpoYW5kbGVGb2N1c2VkVUlFbGVtZW50Q2hhbmdlZCk6CisgICAg ICAgIChXZWJDb3JlOjpBWE9iamVjdENhY2hlOjpoYW5kbGVTY3JvbGxlZFRvQW5jaG9yKToKKyAg ICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OmZyYW1lTG9hZGluZ0V2ZW50Tm90aWZpY2F0 aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnJvb3RBWEVkaXRhYmxlRWxl bWVudCk6CisKIDIwMTItMDUtMDcgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OIChyMTAxNTc1KTogQ2hpbmVzZSBpbnB1dCBpcyBicm9rZW4g d2hlbiBjb21wb3NpbmcgbWFpbCBpbiBpQ2xvdWQgdXNpbmcgU2FmYXJpLgpJbmRleDogU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9jaHJvbWl1bS9BWE9iamVjdENhY2hlQ2hyb21pdW1BbmRy b2lkLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2Nocm9t aXVtL0FYT2JqZWN0Q2FjaGVDaHJvbWl1bUFuZHJvaWQuY3BwCShyZXZpc2lvbiAwKQorKysgU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9jaHJvbWl1bS9BWE9iamVjdENhY2hlQ2hyb21pdW1B bmRyb2lkLmNwcAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyMjAgQEAKKy8qCisgKiBDb3B5cmln aHQgKEMpIDIwMTEgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRp c3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdp dGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBm b2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyAqIG1ldDoKKyAqCisgKiAgICAgKiBSZWRpc3RyaWJ1 dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICog bm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFp bWVyLgorICogICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9k dWNlIHRoZSBhYm92ZQorICogY29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlv bnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorICogaW4gdGhlIGRvY3VtZW50YXRpb24g YW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQorICogZGlzdHJpYnV0aW9u LgorICogICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVz IG9mIGl0cworICogY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90 ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KKyAqIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZp YyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9W SURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUworICogIkFTIElT IiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBO T1QKKyAqIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklM SVRZIEFORCBGSVRORVNTIEZPUgorICogQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlN RUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyAqIE9XTkVSIE9SIENPTlRSSUJV VE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAorICog U1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywg QlVUIE5PVAorICogTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBP UiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisgKiBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVT UyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyAqIFRIRU9SWSBPRiBM SUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQK KyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdB WSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9G IFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaW5jbHVkZSAiY29uZmln LmgiCisjaW5jbHVkZSAiQVhPYmplY3RDYWNoZS5oIgorCisjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQ dHIuaD4KKworLy8gRklNWEU6IFdlIHNob3VsZCBidWlsZCB0aGlzIGZpbGUgcmF0aGVyIHRoYW4g QVhPYmplY3RDYWNoZUNocm9taXVtLmNwcCB3aGVuIGJ1aWxkaW5nCisvLyBQTEFURk9STShDSFJP TUlVTSkgb24gT1MoQU5EUk9JRCkuCisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworYm9vbCBBWE9i amVjdENhY2hlOjpnQWNjZXNzaWJpbGl0eUVuYWJsZWQgPSBmYWxzZTsKK2Jvb2wgQVhPYmplY3RD YWNoZTo6Z0FjY2Vzc2liaWxpdHlFbmhhbmNlZFVzZXJJbnRlcmZhY2VFbmFibGVkID0gZmFsc2U7 CisKK0FYT2JqZWN0Q2FjaGU6OkFYT2JqZWN0Q2FjaGUoY29uc3QgRG9jdW1lbnQqIGRvY3VtZW50 KQorICAgIDogbV9ub3RpZmljYXRpb25Qb3N0VGltZXIodGhpcywgJkFYT2JqZWN0Q2FjaGU6Om5v dGlmaWNhdGlvblBvc3RUaW1lckZpcmVkKQoreworICAgIG1fZG9jdW1lbnQgPSBjb25zdF9jYXN0 PERvY3VtZW50Kj4oZG9jdW1lbnQpOworfQorCitBWE9iamVjdENhY2hlOjp+QVhPYmplY3RDYWNo ZSgpCit7Cit9CisKK0FjY2Vzc2liaWxpdHlPYmplY3QqIEFYT2JqZWN0Q2FjaGU6OmZvY3VzZWRJ bWFnZU1hcFVJRWxlbWVudChIVE1MQXJlYUVsZW1lbnQqKQoreworICAgIHJldHVybiAwOworfQor CitBY2Nlc3NpYmlsaXR5T2JqZWN0KiBBWE9iamVjdENhY2hlOjpmb2N1c2VkVUlFbGVtZW50Rm9y UGFnZShjb25zdCBQYWdlKikKK3sKKyAgICByZXR1cm4gMDsKK30KKworQWNjZXNzaWJpbGl0eU9i amVjdCogQVhPYmplY3RDYWNoZTo6Z2V0KFdpZGdldCopCit7CisgICAgcmV0dXJuIDA7Cit9CisK K0FjY2Vzc2liaWxpdHlPYmplY3QqIEFYT2JqZWN0Q2FjaGU6OmdldChSZW5kZXJPYmplY3QqKQor eworICAgIHJldHVybiAwOworfQorCitib29sIG5vZGVIYXNSb2xlKE5vZGUqLCBjb25zdCBTdHJp bmcmIHJvbGUpCit7CisgICAgVU5VU0VEX1BBUkFNKHJvbGUpOworICAgIHJldHVybiBmYWxzZTsK K30KKworQWNjZXNzaWJpbGl0eU9iamVjdCogQVhPYmplY3RDYWNoZTo6Z2V0T3JDcmVhdGUoV2lk Z2V0KikKK3sKKyAgICByZXR1cm4gMDsKK30KKworQWNjZXNzaWJpbGl0eU9iamVjdCogQVhPYmpl Y3RDYWNoZTo6Z2V0T3JDcmVhdGUoUmVuZGVyT2JqZWN0KikKK3sKKyAgICByZXR1cm4gMDsKK30K KworQWNjZXNzaWJpbGl0eU9iamVjdCogQVhPYmplY3RDYWNoZTo6cm9vdE9iamVjdCgpCit7Cisg ICAgcmV0dXJuIDA7Cit9CisKK0FjY2Vzc2liaWxpdHlPYmplY3QqIEFYT2JqZWN0Q2FjaGU6OnJv b3RPYmplY3RGb3JGcmFtZShGcmFtZSopCit7CisgICAgcmV0dXJuIDA7Cit9CisKK0FjY2Vzc2li aWxpdHlPYmplY3QqIEFYT2JqZWN0Q2FjaGU6OmdldE9yQ3JlYXRlKEFjY2Vzc2liaWxpdHlSb2xl KQoreworICAgIHJldHVybiAwOworfQorCit2b2lkIEFYT2JqZWN0Q2FjaGU6OnJlbW92ZShBWElE KQoreworfQorCit2b2lkIEFYT2JqZWN0Q2FjaGU6OnJlbW92ZShSZW5kZXJPYmplY3QqKQorewor fQorCit2b2lkIEFYT2JqZWN0Q2FjaGU6OnJlbW92ZShXaWRnZXQqKQoreworfQorCitBWElEIEFY T2JqZWN0Q2FjaGU6OnBsYXRmb3JtR2VuZXJhdGVBWElEKCkgY29uc3QKK3sKKyAgICByZXR1cm4g MDsKK30KKworQVhJRCBBWE9iamVjdENhY2hlOjpnZXRBWElEKEFjY2Vzc2liaWxpdHlPYmplY3Qq KQoreworICAgIHJldHVybiAwOworfQorCit2b2lkIEFYT2JqZWN0Q2FjaGU6OnJlbW92ZUFYSUQo QWNjZXNzaWJpbGl0eU9iamVjdCopCit7Cit9CisKKyNpZiBIQVZFKEFDQ0VTU0lCSUxJVFkpCit2 b2lkIEFYT2JqZWN0Q2FjaGU6OmNvbnRlbnRDaGFuZ2VkKFJlbmRlck9iamVjdCopCit7Cit9Cisj ZW5kaWYKKwordm9pZCBBWE9iamVjdENhY2hlOjpjaGlsZHJlbkNoYW5nZWQoUmVuZGVyT2JqZWN0 KikKK3sKK30KKwordm9pZCBBWE9iamVjdENhY2hlOjpub3RpZmljYXRpb25Qb3N0VGltZXJGaXJl ZChUaW1lcjxBWE9iamVjdENhY2hlPiopCit7Cit9CisKKyNpZiBIQVZFKEFDQ0VTU0lCSUxJVFkp CisKK3ZvaWQgQVhPYmplY3RDYWNoZTo6cG9zdE5vdGlmaWNhdGlvbihSZW5kZXJPYmplY3QqLCBB WE5vdGlmaWNhdGlvbiwgYm9vbCBwb3N0VG9FbGVtZW50LCBQb3N0VHlwZSkKK3sKKyAgICBVTlVT RURfUEFSQU0ocG9zdFRvRWxlbWVudCk7Cit9CisKK3ZvaWQgQVhPYmplY3RDYWNoZTo6cG9zdE5v dGlmaWNhdGlvbihBY2Nlc3NpYmlsaXR5T2JqZWN0KiwgRG9jdW1lbnQqLCBBWE5vdGlmaWNhdGlv biwgYm9vbCBwb3N0VG9FbGVtZW50LCBQb3N0VHlwZSkKK3sKKyAgICBVTlVTRURfUEFSQU0ocG9z dFRvRWxlbWVudCk7Cit9CisKK3ZvaWQgQVhPYmplY3RDYWNoZTo6Y2hlY2tlZFN0YXRlQ2hhbmdl ZChSZW5kZXJPYmplY3QqKQoreworfQorCit2b2lkIEFYT2JqZWN0Q2FjaGU6OnNlbGVjdGVkQ2hp bGRyZW5DaGFuZ2VkKFJlbmRlck9iamVjdCopCit7Cit9CisKK3ZvaWQgQVhPYmplY3RDYWNoZTo6 bm9kZVRleHRDaGFuZ2VOb3RpZmljYXRpb24oUmVuZGVyT2JqZWN0KiwgQVhUZXh0Q2hhbmdlLCB1 bnNpZ25lZCBvZmZzZXQsIGNvbnN0IFN0cmluZyYpCit7CisgICAgVU5VU0VEX1BBUkFNKG9mZnNl dCk7Cit9CisKK3ZvaWQgQVhPYmplY3RDYWNoZTo6aGFuZGxlU2Nyb2xsYmFyVXBkYXRlKFNjcm9s bFZpZXcqKQoreworfQorCit2b2lkIEFYT2JqZWN0Q2FjaGU6OmhhbmRsZUFyaWFFeHBhbmRlZENo YW5nZShSZW5kZXJPYmplY3QqKQoreworfQorCit2b2lkIEFYT2JqZWN0Q2FjaGU6OmhhbmRsZUFj dGl2ZURlc2NlbmRhbnRDaGFuZ2VkKFJlbmRlck9iamVjdCopCit7Cit9CisKK3ZvaWQgQVhPYmpl Y3RDYWNoZTo6aGFuZGxlQXJpYVJvbGVDaGFuZ2VkKFJlbmRlck9iamVjdCopCit7Cit9CisKKyNl bmRpZgorCitWaXNpYmxlUG9zaXRpb24gQVhPYmplY3RDYWNoZTo6dmlzaWJsZVBvc2l0aW9uRm9y VGV4dE1hcmtlckRhdGEoVGV4dE1hcmtlckRhdGEmKQoreworICAgIHJldHVybiBWaXNpYmxlUG9z aXRpb24oKTsKK30KKwordm9pZCBBWE9iamVjdENhY2hlOjp0ZXh0TWFya2VyRGF0YUZvclZpc2li bGVQb3NpdGlvbihUZXh0TWFya2VyRGF0YSYsIGNvbnN0IFZpc2libGVQb3NpdGlvbiYpCit7Cit9 CisKK3ZvaWQgQVhPYmplY3RDYWNoZTo6aGFuZGxlRm9jdXNlZFVJRWxlbWVudENoYW5nZWQoUmVu ZGVyT2JqZWN0KiwgUmVuZGVyT2JqZWN0KiBuZXdGb2N1c2VkUmVuZGVyZXIpCit7CisgICAgVU5V U0VEX1BBUkFNKG5ld0ZvY3VzZWRSZW5kZXJlcik7Cit9CisKK3ZvaWQgQVhPYmplY3RDYWNoZTo6 aGFuZGxlU2Nyb2xsZWRUb0FuY2hvcihjb25zdCBOb2RlKikKK3sKK30KKwordm9pZCBBWE9iamVj dENhY2hlOjpmcmFtZUxvYWRpbmdFdmVudE5vdGlmaWNhdGlvbihGcmFtZSosIEFYTG9hZGluZ0V2 ZW50KQoreworfQorCitjb25zdCBFbGVtZW50KiBBWE9iamVjdENhY2hlOjpyb290QVhFZGl0YWJs ZUVsZW1lbnQoY29uc3QgTm9kZSopCit7CisgICAgcmV0dXJuIDA7Cit9CisKK0VsZW1lbnQqIEFY T2JqZWN0Q2FjaGU6OnJvb3RBWEVkaXRhYmxlRWxlbWVudChOb2RlKikKK3sKKyAgICByZXR1cm4g MDsKK30KKworfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 140637 2012-05-07 17:43:00 -0700 2012-05-07 19:46:31 -0700 Patch bug-85842-20120507174258.patch text/plain 3127 abarth SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMTYzNzgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTA3ICBBZGFtIEJhcnRoICA8YWJhcnRo QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBBbmRyb2lkIHdpc2hlcyB0byB1c2Ug YW4gZW1wdHkgaW1wbGVtZW50YXRpb24gaWYgQVhPYmplY3RDYWNoZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU4NDIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNhYmxlIGFjY2Vzc2liaWxpdHkgb24g T1MoQU5EUk9JRCkgZm9yIFBMQVRGT1JNKENIUk9NSVVNKS4KKworICAgICAgICAqIHd0Zi9QbGF0 Zm9ybS5oOgorCiAyMDEyLTA1LTA0ICBKZWZmIFJvZ2VycyAgPGpyb2dlcnNAcmltLmNvbT4KIAog ICAgICAgICBbQmxhY2tCZXJyeV0gSW1wbGVtZW50IG51bWJlck9mUHJvY2Vzc29yQ29yZXMoKSBm b3IgUU5YCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDExNjM1NCkKKysrIFNvdXJjZS9XVEYv d3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTY1MSw3ICs2NTEsNyBAQAogI2VuZGlm CiAKICNpZiAhZGVmaW5lZChIQVZFX0FDQ0VTU0lCSUxJVFkpCi0jaWYgUExBVEZPUk0oSU9TKSB8 fCBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFdJTikgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFU Rk9STShDSFJPTUlVTSkKKyNpZiBQTEFURk9STShJT1MpIHx8IFBMQVRGT1JNKE1BQykgfHwgUExB VEZPUk0oV0lOKSB8fCBQTEFURk9STShHVEspIHx8IChQTEFURk9STShDSFJPTUlVTSkgJiYgIU9T KEFORFJPSUQpKQogI2RlZmluZSBIQVZFX0FDQ0VTU0lCSUxJVFkgMQogI2VuZGlmCiAjZW5kaWYg LyogIWRlZmluZWQoSEFWRV9BQ0NFU1NJQklMSVRZKSAqLwpJbmRleDogU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNp b24gMTE2Mzc4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMDcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBbQ2hyb21pdW1dIEFuZHJvaWQgd2lzaGVzIHRvIHVzZSBhbiBlbXB0eSBp bXBsZW1lbnRhdGlvbiBpZiBBWE9iamVjdENhY2hlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTg0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBwcm9wZXIgSEFWRShBQ0NFU1NJQklMSVRZKSBpZmRl ZnMgc28gdGhhdCBDaHJvbWl1bSBidWlsZHMgd2l0aG91dAorICAgICAgICBhY2Nlc3NpYmlsaXR5 LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9jaHJvbWl1bS9BWE9iamVjdENhY2hlQ2hyb21p dW0uY3BwOgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvY2hyb21pdW0vQWNjZXNzaWJpbGl0eU9i amVjdENocm9taXVtLmNwcDoKKwogMjAxMi0wNS0wNyAgRGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZWdpb246OmludGVyc2VjdHMoKSBhbmQgUmVnaW9uOjpj b250YWlucygpIGFyZSBzbG93IGR1ZSB0byBjb3B5IG92ZXJoZWFkCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L2Nocm9taXVtL0FYT2JqZWN0Q2FjaGVDaHJvbWl1bS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9jaHJvbWl1bS9BWE9iamVj dENhY2hlQ2hyb21pdW0uY3BwCShyZXZpc2lvbiAxMTYzNTQpCisrKyBTb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2Nocm9taXVtL0FYT2JqZWN0Q2FjaGVDaHJvbWl1bS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTI1LDYgKzI1LDkgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCisKKyNp ZiBIQVZFKEFDQ0VTU0lCSUxJVFkpCisKICNpbmNsdWRlICJBWE9iamVjdENhY2hlLmgiCiAKICNp bmNsdWRlICJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgiCkBAIC0xMzUsMyArMTM4LDUgQEAgdm9pZCBB WE9iamVjdENhY2hlOjpoYW5kbGVTY3JvbGxlZFRvQW5jaAogfQogCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCisKKyNlbmRpZiAvLyBIQVZFKEFDQ0VTU0lCSUxJVFkpCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L2Nocm9taXVtL0FjY2Vzc2liaWxpdHlPYmplY3RDaHJvbWl1bS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9jaHJvbWl1bS9B Y2Nlc3NpYmlsaXR5T2JqZWN0Q2hyb21pdW0uY3BwCShyZXZpc2lvbiAxMTYzNTQpCisrKyBTb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2Nocm9taXVtL0FjY2Vzc2liaWxpdHlPYmplY3RDaHJv bWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1LDYgKzI1LDkgQEAKICAqLwogCiAjaW5jbHVk ZSAiY29uZmlnLmgiCisKKyNpZiBIQVZFKEFDQ0VTU0lCSUxJVFkpCisKICNpbmNsdWRlICJBY2Nl c3NpYmlsaXR5T2JqZWN0LmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTQzLDMgKzQ2LDUg QEAgQWNjZXNzaWJpbGl0eU9iamVjdEluY2x1c2lvbiBBY2Nlc3NpYmlsaQogfQogCiB9IC8vIG5h bWVzcGFjZSBXZWJDb3JlCisKKyNlbmRpZiAvLyBIQVZFKEFDQ0VTU0lCSUxJVFkpCg==