85819 RAF_returning_zero 2012-05-07 12:54:15 -0700 Initial call to webkitRequestAnimationFrame returns 0, Spec indicates the handle should always be > 0 2012-08-14 18:52:21 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Minor --- 1 ctrlfrk dino dino jamesr pimvdb webkit-bug-importer oldest_to_newest 617843 0 ctrlfrk 2012-05-07 12:54:15 -0700 Looking at http://www.w3.org/TR/animation-timing/ there is a section that reads: "The requestAnimationFrame method is used to signal to the user agent that a script-based animation needs to be resampled. When requestAnimationFrame(callback) is called, the user agent must schedule a script-based animation resampling by appending to the end of the animation frame request callback list an entry whose handle is a user-agent-defined integer greater than zero that uniquely identifies the entry in the list and whose callback is callback." However the first call to webkitRequestAnimationFrame seems to be returning a handle of 0. It's minor, but worth mentioning. 618747 1 dino 2012-05-08 13:21:36 -0700 Yeah, easy fix. 618758 2 jamesr 2012-05-08 13:33:47 -0700 Whoops! Pre-increment when it should be a post-increment. For the record, the intent of that text is that the return value should never be false-y and it should match setTimeout/setInterval 695572 3 webkit-bug-importer 2012-08-14 17:13:58 -0700 <rdar://problem/12100411> 695623 4 158471 dino 2012-08-14 18:18:01 -0700 Created attachment 158471 Patch 695647 5 dino 2012-08-14 18:52:21 -0700 Committed r125633: <http://trac.webkit.org/changeset/125633> 158471 2012-08-14 18:18:01 -0700 2012-08-14 18:18:28 -0700 Patch bug-85819-20120815111727.patch text/plain 4009 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjJmMjc3ZjE3YjIwNzMy OWIwZjVjMGVkZWIwMDVlNzkyN2Q1MzcwZS4uNGRjZGJlNGU0NjZlODQwYjg4NWJlZDhiMzRiOGY4 M2U0YmVhODYyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTE0ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBJbml0aWFsIGNhbGwgdG8gd2Vi a2l0UmVxdWVzdEFuaW1hdGlvbkZyYW1lIHJldHVybnMgMCwgU3BlYyBpbmRpY2F0ZXMgdGhlIGhh bmRsZSBzaG91bGQgYWx3YXlzIGJlID4gMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODU4MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgY2FsbGJhY2sgaWQgcmV0dXJuZWQgYnkgcmVxdWVzdEFuaW1h dGlvbkZyYW1lIHdhcyBiZWdpbm5pbmcgYXQgemVybywgd2hlbiB0aGUgc3BlYworICAgICAgICBz YXlzIGl0IHNob3VsZCBiZSBhYm92ZSBvbmUuIFVzZSBhIHByZS1pbmNyZW1lbnQgcmF0aGVyIHRo YW4gYSBwb3N0LWluY3JlbWVudC4KKworICAgICAgICBUZXN0OiBmYXN0L2FuaW1hdGlvbi9yZXF1 ZXN0LWFuaW1hdGlvbi1mcmFtZS1jYWxsYmFjay1pZC5odG1sCisKKyAgICAgICAgKiBkb20vU2Ny aXB0ZWRBbmltYXRpb25Db250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdGVk QW5pbWF0aW9uQ29udHJvbGxlcjo6cmVnaXN0ZXJDYWxsYmFjayk6IFByZS1pbmNyZW1lbnQgcmF0 aGVyIHRoYW4gcG9zdC1pbmNyZW1lbnQuCisKIDIwMTItMDgtMTQgIEtpaG9uZyBLd29uICA8a2lo b25nLmt3b25Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgQ2xlYXIgcGF0dGVybiB0byBwcmV2ZW50 IHRpbWluZyBwcm9ibGVtIGJldHdlZW4gY2FuY2VsVmlicmF0aW9uIGFuZCB2aWJyYXRlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIuY3BwCmlu ZGV4IDk3NDQ4M2RkNGJlMjA0NGEyOGIxMDc1ZDA3YjlkMzQxMGFlMTRjOGYuLjYyOGYxMDkyYjQ3 Y2I3YzZmZGFmYmRhNzg5ZDhiZTZhMzdhMWIyZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9TY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9TY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIuY3BwCkBAIC04Myw3ICs4Myw3IEBAIHZv aWQgU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyOjpyZXN1bWUoKQogCiBTY3JpcHRlZEFuaW1h dGlvbkNvbnRyb2xsZXI6OkNhbGxiYWNrSWQgU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyOjpy ZWdpc3RlckNhbGxiYWNrKFBhc3NSZWZQdHI8UmVxdWVzdEFuaW1hdGlvbkZyYW1lQ2FsbGJhY2s+ IGNhbGxiYWNrKQogewotICAgIFNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcjo6Q2FsbGJhY2tJ ZCBpZCA9IG1fbmV4dENhbGxiYWNrSWQrKzsKKyAgICBTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xs ZXI6OkNhbGxiYWNrSWQgaWQgPSArK21fbmV4dENhbGxiYWNrSWQ7CiAgICAgY2FsbGJhY2stPm1f ZmlyZWRPckNhbmNlbGxlZCA9IGZhbHNlOwogICAgIGNhbGxiYWNrLT5tX2lkID0gaWQ7CiAgICAg bV9jYWxsYmFja3MuYXBwZW5kKGNhbGxiYWNrKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyY2JkNWIwOGExMzA4NGE5ZmIz MTMxMDQ1MjI1NTdlY2EyNjg5NzMxLi43MTJiN2NlYzA2ZGIxNmMwNGNlMWY4YzVmMDUyMzNkYzZi M2UwOWQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDgtMTQgIERlYW4gSmFja3NvbiAg PGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIEluaXRpYWwgY2FsbCB0byB3ZWJraXRSZXF1ZXN0 QW5pbWF0aW9uRnJhbWUgcmV0dXJucyAwLCBTcGVjIGluZGljYXRlcyB0aGUgaGFuZGxlIHNob3Vs ZCBhbHdheXMgYmUgPiAwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04NTgxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZmFzdC9hbmltYXRpb24vcmVxdWVzdC1hbmltYXRpb24tZnJhbWUtY2FsbGJhY2st aWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2FuaW1hdGlvbi9yZXF1ZXN0 LWFuaW1hdGlvbi1mcmFtZS1jYWxsYmFjay1pZC5odG1sOiBBZGRlZC4KKwogMjAxMi0wOC0xNCAg QWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBnb29nbGUuY29tPgogCiAgICAgICAgIFtjaHJvbWl1bV0g QWRkIGJhc2VsaW5lcyBmb3IgdmlkZW8tY29udHJvbHMtbGF5ZXItY3JlYXRpb24gbGF5b3V0IHRl c3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvYW5pbWF0aW9uL3JlcXVlc3QtYW5pbWF0 aW9uLWZyYW1lLWNhbGxiYWNrLWlkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvYW5p bWF0aW9uL3JlcXVlc3QtYW5pbWF0aW9uLWZyYW1lLWNhbGxiYWNrLWlkLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi42ZjlkZjFjOGEzZWE2MjcwNTUwOGMzN2RmNjJjYjgxN2NhYjU3OTZkCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9hbmltYXRpb24vcmVxdWVzdC1hbmltYXRp b24tZnJhbWUtY2FsbGJhY2staWQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1BBU1NFRDog Q2FsbGJhY2sgaWQgd2FzID4gMApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9hbmltYXRp b24vcmVxdWVzdC1hbmltYXRpb24tZnJhbWUtY2FsbGJhY2staWQuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvYW5pbWF0aW9uL3JlcXVlc3QtYW5pbWF0aW9uLWZyYW1lLWNhbGxiYWNrLWlkLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uOGRlZWQ0Y2M3MDFiNjI5YTdmNDVhN2FmZDZmNzFhOTBiNDc1YTQ0MwotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvYW5pbWF0aW9uL3JlcXVlc3QtYW5pbWF0 aW9uLWZyYW1lLWNhbGxiYWNrLWlkLmh0bWwKQEAgLTAsMCArMSwyMiBAQAorPHNjcmlwdD4KK2lm ICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgIHdpbmRvdy50ZXN0UnVubmVyLmR1bXBBc1RleHQo KTsKKyAgICB3aW5kb3cudGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7Cit9CisKK2Z1bmN0aW9u IHJ1blRlc3QoKSB7CisgICAgdmFyIGlkID0gd2luZG93LndlYmtpdFJlcXVlc3RBbmltYXRpb25G cmFtZShmdW5jdGlvbiAoKSB7fSk7CisgICAgdmFyIHJlc3VsdHMgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgicmVzdWx0cyIpOworCisgICAgaWYgKGlkID4gMCkKKyAgICAgICAgcmVzdWx0cy5p bm5lclRleHQgPSAiUEFTU0VEOiBDYWxsYmFjayBpZCB3YXMgPiAwIjsKKyAgICBlbHNlCisgICAg ICAgIHJlc3VsdHMuaW5uZXJUZXh0ID0gIkZBSUxFRDogQ2FsbGJhY2sgaWQgd2FzIDw9IDAiOwor CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICB3aW5kb3cudGVzdFJ1bm5lci5u b3RpZnlEb25lKCk7Cit9CisKK3dpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgcnVuVGVz dCwgZmFsc2UpOworPC9zY3JpcHQ+Cis8ZGl2IGlkPSJyZXN1bHRzIj48L2Rpdj4KXCBObyBuZXds aW5lIGF0IGVuZCBvZiBmaWxlCg==