85812 2012-05-07 11:22:36 -0700 [BlackBerry] Delete previous buffer when new over-scroll image path is set 2012-05-07 13:37:07 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 anlo anlo rwlbuis tonikitoo webkit.review.bot oldest_to_newest 617753 0 anlo 2012-05-07 11:22:36 -0700 When a new file path for over-scroll image path is set, the old buffer is not deleted before creating a new one. 617776 1 140564 anlo 2012-05-07 11:36:37 -0700 Created attachment 140564 Patch 617824 2 140564 rwlbuis 2012-05-07 12:22:32 -0700 Comment on attachment 140564 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140564&action=review Looks good, but please fix the period. > Source/WebKit/blackberry/Api/BackingStore.cpp:1221 > + // For now we fallback to solid color if sizes don't match, later we can implement tiling It is preferred to end these sentences with a period. 617827 3 140571 anlo 2012-05-07 12:28:25 -0700 Created attachment 140571 Patch 617831 4 140571 rwlbuis 2012-05-07 12:36:57 -0700 Comment on attachment 140571 Patch Looks good. 617888 5 140571 webkit.review.bot 2012-05-07 13:37:02 -0700 Comment on attachment 140571 Patch Clearing flags on attachment: 140571 Committed r116350: <http://trac.webkit.org/changeset/116350> 617889 6 webkit.review.bot 2012-05-07 13:37:07 -0700 All reviewed patches have been landed. Closing bug. 140564 2012-05-07 11:36:37 -0700 2012-05-07 12:28:16 -0700 Patch bug-85812-20120507144147.patch text/plain 1867 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAwMmIyZDQ0NTJjNWFmOTE2ZmIwMTVlZTI0MWFhNTk0Yjk4ZGFhMDMzLi40ZGU0MzdhYzQx YTkzYmRjNzJlMDZiOWU5NWNjZWQ2MmRiM2VkYjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNS0wNyAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBEZWxldGUgcHJldmlvdXMgYnVmZmVyIHdoZW4g bmV3IG92ZXItc2Nyb2xsIGltYWdlIHBhdGggaXMgc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTgxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gYSBuZXcgb3Zlci1zY3JvbGwgaW1hZ2UgcGF0 aCBpcyBzZXQsIGRlbGV0ZSBvbGQgYnVmZmVyIGJlZm9yZSBjcmVhdGluZworICAgICAgICBhIG5l dyBvbmUuCisKKyAgICAgICAgKiBBcGkvQmFja2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKEJsYWNr QmVycnk6OldlYktpdDo6QmFja2luZ1N0b3JlUHJpdmF0ZTo6ZW5zdXJlT3ZlclNjcm9sbEltYWdl KToKKwogMjAxMi0wNS0wNyAgQ3J5c3RhbCBaaGFuZyAgPGhhaXpoYW5nQHJpbS5jb20+CiAKICAg ICAgICAgW0JsYWNrQmVycnldIEFkZCBtZXRob2RzIG5lZWQgYnkgY2xpZW50IHNpZGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcCBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcAppbmRleCBlZWRhN2Rk OGFmNjQ2ZDQ3ODY0MDRmZDA2ODc5NGRlMjJkNTJmYzE0Li4zODcxZjJhNjYwMzlkNTQ3ZGVkNzcx ODlkNzRlYmM1MTVjMzhhNjdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL0JhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9C YWNraW5nU3RvcmUuY3BwCkBAIC0xMjE4LDEwICsxMjE4LDExIEBAIGJvb2wgQmFja2luZ1N0b3Jl UHJpdmF0ZTo6ZW5zdXJlT3ZlclNjcm9sbEltYWdlKCkKICAgICB9CiAKICAgICAvLyBGSVhNRTog TWFrZSBpdCBvcmllbnRhdGlvbiBhbmQgcmVzb2x1dGlvbiBhZ25vc3RpYworICAgIC8vIEZvciBu b3cgd2UgZmFsbGJhY2sgdG8gc29saWQgY29sb3IgaWYgc2l6ZXMgZG9uJ3QgbWF0Y2gsIGxhdGVy IHdlIGNhbiBpbXBsZW1lbnQgdGlsaW5nCiAgICAgaWYgKGJpdG1hcC53aWR0aCgpICE9IHN1cmZh Y2VTaXplKCkud2lkdGgoKSB8fCBiaXRtYXAuaGVpZ2h0KCkgIT0gc3VyZmFjZVNpemUoKS5oZWln aHQoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgLy8gRklYTUU6IEZvciBub3cgd2Ug ZmFsbGJhY2sgdG8gc29saWQgY29sb3IgaWYgc2l6ZXMgZG9uJ3QgbWF0Y2gsIGxhdGVyIHdlIGNh biBpbXBsZW1lbnQgdGlsaW5nCisgICAgZGVzdHJveUJ1ZmZlcihzX292ZXJTY3JvbGxJbWFnZSk7 CiAgICAgc19vdmVyU2Nyb2xsSW1hZ2UgPSBjcmVhdGVCdWZmZXIoUGxhdGZvcm06OkludFNpemUo Yml0bWFwLndpZHRoKCksIGJpdG1hcC5oZWlnaHQoKSksIFBsYXRmb3JtOjpHcmFwaGljczo6VGVt cG9yYXJ5QnVmZmVyKTsKIAogICAgIFNrQ2FudmFzKiBjYW52YXMgPSBQbGF0Zm9ybTo6R3JhcGhp Y3M6OmxvY2tCdWZmZXJEcmF3YWJsZShzX292ZXJTY3JvbGxJbWFnZSk7Cg== 140571 2012-05-07 12:28:25 -0700 2012-05-07 13:37:02 -0700 Patch bug-85812-20120507153335.patch text/plain 1951 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAwMmIyZDQ0NTJjNWFmOTE2ZmIwMTVlZTI0MWFhNTk0Yjk4ZGFhMDMzLi40ZGU0MzdhYzQx YTkzYmRjNzJlMDZiOWU5NWNjZWQ2MmRiM2VkYjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNS0wNyAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBEZWxldGUgcHJldmlvdXMgYnVmZmVyIHdoZW4g bmV3IG92ZXItc2Nyb2xsIGltYWdlIHBhdGggaXMgc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTgxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gYSBuZXcgb3Zlci1zY3JvbGwgaW1hZ2UgcGF0 aCBpcyBzZXQsIGRlbGV0ZSBvbGQgYnVmZmVyIGJlZm9yZSBjcmVhdGluZworICAgICAgICBhIG5l dyBvbmUuCisKKyAgICAgICAgKiBBcGkvQmFja2luZ1N0b3JlLmNwcDoKKyAgICAgICAgKEJsYWNr QmVycnk6OldlYktpdDo6QmFja2luZ1N0b3JlUHJpdmF0ZTo6ZW5zdXJlT3ZlclNjcm9sbEltYWdl KToKKwogMjAxMi0wNS0wNyAgQ3J5c3RhbCBaaGFuZyAgPGhhaXpoYW5nQHJpbS5jb20+CiAKICAg ICAgICAgW0JsYWNrQmVycnldIEFkZCBtZXRob2RzIG5lZWQgYnkgY2xpZW50IHNpZGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcCBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcAppbmRleCBlZWRhN2Rk OGFmNjQ2ZDQ3ODY0MDRmZDA2ODc5NGRlMjJkNTJmYzE0Li5hZjJmNWI1MmU2Y2ViZDFhMDk0ZjJk MjMxNDQxYzZlZDdlYzk4NDBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL0JhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9C YWNraW5nU3RvcmUuY3BwCkBAIC0xMjE3LDExICsxMjE3LDEyIEBAIGJvb2wgQmFja2luZ1N0b3Jl UHJpdmF0ZTo6ZW5zdXJlT3ZlclNjcm9sbEltYWdlKCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgIH0KIAotICAgIC8vIEZJWE1FOiBNYWtlIGl0IG9yaWVudGF0aW9uIGFuZCByZXNvbHV0aW9u IGFnbm9zdGljCisgICAgLy8gRklYTUU6IE1ha2UgaXQgb3JpZW50YXRpb24gYW5kIHJlc29sdXRp b24gYWdub3N0aWMuCisgICAgLy8gRm9yIG5vdyB3ZSBmYWxsYmFjayB0byBzb2xpZCBjb2xvciBp ZiBzaXplcyBkb24ndCBtYXRjaCwgbGF0ZXIgd2UgY2FuIGltcGxlbWVudCB0aWxpbmcuCiAgICAg aWYgKGJpdG1hcC53aWR0aCgpICE9IHN1cmZhY2VTaXplKCkud2lkdGgoKSB8fCBiaXRtYXAuaGVp Z2h0KCkgIT0gc3VyZmFjZVNpemUoKS5oZWlnaHQoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwog Ci0gICAgLy8gRklYTUU6IEZvciBub3cgd2UgZmFsbGJhY2sgdG8gc29saWQgY29sb3IgaWYgc2l6 ZXMgZG9uJ3QgbWF0Y2gsIGxhdGVyIHdlIGNhbiBpbXBsZW1lbnQgdGlsaW5nCisgICAgZGVzdHJv eUJ1ZmZlcihzX292ZXJTY3JvbGxJbWFnZSk7CiAgICAgc19vdmVyU2Nyb2xsSW1hZ2UgPSBjcmVh dGVCdWZmZXIoUGxhdGZvcm06OkludFNpemUoYml0bWFwLndpZHRoKCksIGJpdG1hcC5oZWlnaHQo KSksIFBsYXRmb3JtOjpHcmFwaGljczo6VGVtcG9yYXJ5QnVmZmVyKTsKIAogICAgIFNrQ2FudmFz KiBjYW52YXMgPSBQbGF0Zm9ybTo6R3JhcGhpY3M6OmxvY2tCdWZmZXJEcmF3YWJsZShzX292ZXJT Y3JvbGxJbWFnZSk7Cg==