85810 2012-05-07 10:53:32 -0700 IndexedDB: LevelDB coding for bools is broken 2012-05-07 11:54:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jsbell jsbell alecflett dgrogan ojan tony webkit.review.bot oldest_to_newest 617718 0 jsbell 2012-05-07 10:53:32 -0700 IndexedDB: LevelDB coding for bools is broken 617724 1 140553 jsbell 2012-05-07 10:59:15 -0700 Created attachment 140553 Patch 617729 2 jsbell 2012-05-07 11:02:26 -0700 Fix for http://crbug.com/126388 broken by webkit roll including http://webkit.org/b/85557 My bad. My patch for http://webkit.org/b/85557 expanded after review and (1) I didn't get it re-reviewed, and (2) I didn't add unit tests despite a lovely pre-existing setup for them. Fix is simple, and added unit tests. tony@ - r? 617790 3 140553 webkit.review.bot 2012-05-07 11:54:05 -0700 Comment on attachment 140553 Patch Clearing flags on attachment: 140553 Committed r116333: <http://trac.webkit.org/changeset/116333> 617791 4 webkit.review.bot 2012-05-07 11:54:10 -0700 All reviewed patches have been landed. Closing bug. 140553 2012-05-07 10:59:15 -0700 2012-05-07 11:54:04 -0700 Patch bug-85810-20120507105914.patch text/plain 3678 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2Mjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI3MzZkMTEwOWRjNjNh NjlmNzVhYWEwZWVjNjI5YzdkMTFhMDUyMS4uMTU1MDQzNzA4ZWU1Mzk1ZGUwMWQ2NzA4YWMxNmY3 MmFmYjVkZDBlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA1LTA3ICBKb3No dWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhlZERCOiBMZXZl bERCIGNvZGluZyBmb3IgYm9vbHMgaXMgYnJva2VuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTgxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENvZGUgd2FzIGFwcGVuZGluZyB0byBhIHByZS1zaXplZCBW ZWN0b3IsIHJhdGhlciB0aGFuIHVzaW5nIGFuCisgICAgICAgIGluZGV4IHNldHRlci4gVGhpcyBj YXVzZWQgdW5pbml0aWFsaXplZCBkYXRhIHRvIGJlIHdyaXR0ZW4gb3V0LgorICAgICAgICBJc3N1 ZSB3YXMgZGV0ZWN0ZWQgb24gdGhlIENocm9taXVtIHNpZGUgaW4gaHR0cDovL2NyYnVnLmNvbS8x MjYzODgKKworICAgICAgICBUZXN0czogd2Via2l0X3VuaXRfdGVzdHMgLS1ndGVzdF9maWx0ZXI9 J0lEQkxldmVsREJDb2RpbmdUZXN0Lipjb2RlQm9vbCcKKworICAgICAgICAqIE1vZHVsZXMvaW5k ZXhlZGRiL0lEQkxldmVsREJDb2RpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCTGV2ZWxE QkNvZGluZzo6ZW5jb2RlQm9vbCk6CisKIDIwMTItMDUtMDcgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZGZpeCBmb3IgYnVnZ3kgR0NDCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDc3MzE2NWYzNDI4YTk4MzgxMGFjOWU3OWZiMDI0ZjMx MjViY2ZlY2EuLjY0MWUzM2Q1MjNlNmRjMDY4MDcxZjY0NmY3NWU1MWQ1NDE4M2NjNzQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMDcgIEpvc2h1 YSBCZWxsICA8anNiZWxsQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbmRleGVkREI6IExldmVs REIgY29kaW5nIGZvciBib29scyBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg1ODEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGVzdHMgZm9yIGVuY29kZUJvb2wvZGVjb2RlQm9v bC4KKworICAgICAgICAqIHRlc3RzL0lEQkxldmVsREJDb2RpbmdUZXN0LmNwcDoKKyAgICAgICAg KElEQkxldmVsREJDb2Rpbmc6OlRFU1QpOgorICAgICAgICAoSURCTGV2ZWxEQkNvZGluZyk6CisK IDIwMTItMDUtMDcgIEtpbnVrbyBZYXN1ZGEgIDxraW51a29AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQ6IHRoZSBzYW1lIGZpeCBpbiBhbm90aGVyIGZpbGUgZm9yIGNocm9taXVt IHdpbiBidWlsZC4gIEFkZGluZyBXZWJDb3JlIG5hbWVzcGFjZSB0byBGaWxlU3lzdGVtVHlwZXMu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJMZXZlbERC Q29kaW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkxldmVsREJD b2RpbmcuY3BwCmluZGV4IDFlYTU2MWU0NzUwZjk0NDc0Y2I3ZjZiNGY0OTNhNDNkYWExYmRiNGQu LjUwZGUxMmYzN2JlNDQyYzA4ZGQ3NmE2ZmU0MzBiYTViNGMxMTA5OTQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkxldmVsREJDb2RpbmcuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkxldmVsREJDb2RpbmcuY3BwCkBA IC0xODAsNyArMTgwLDcgQEAgVmVjdG9yPGNoYXI+IG1pbklEQktleSgpCiBWZWN0b3I8Y2hhcj4g ZW5jb2RlQm9vbChib29sIGIpCiB7CiAgICAgVmVjdG9yPGNoYXI+IHJldCgxKTsKLSAgICByZXQu YXBwZW5kKGIgPyAxIDogMCk7CisgICAgcmV0WzBdID0gYiA/IDEgOiAwOwogICAgIHJldHVybiBy ZXQ7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvSURCTGV2 ZWxEQkNvZGluZ1Rlc3QuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9JREJMZXZl bERCQ29kaW5nVGVzdC5jcHAKaW5kZXggNjAzMzEwNTFmMzJkYWVjMjI0OWU0YmM5NGUzMDY5NzAx NTM1ZDE0ZC4uZWI5OTYyZDU4MmY5ZGFjZDFjOWFjNTk4ZDBhZjQ5MjE0MjQyYWUyMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9JREJMZXZlbERCQ29kaW5nVGVzdC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9JREJMZXZlbERCQ29kaW5nVGVz dC5jcHAKQEAgLTgzLDYgKzgzLDIwIEBAIFRFU1QoSURCTGV2ZWxEQkNvZGluZ1Rlc3QsIEVuY29k ZUJ5dGUpCiAgICAgRVhQRUNUX0VRKGV4cGVjdGVkLCBlbmNvZGVCeXRlKGMpKTsKIH0KIAorVEVT VChJREJMZXZlbERCQ29kaW5nVGVzdCwgRW5jb2RlQm9vbCkKK3sKKyAgICB7CisgICAgICAgIFZl Y3RvcjxjaGFyPiBleHBlY3RlZDsKKyAgICAgICAgZXhwZWN0ZWQuYXBwZW5kKDEpOworICAgICAg ICBFWFBFQ1RfRVEoZXhwZWN0ZWQsIGVuY29kZUJvb2wodHJ1ZSkpOworICAgIH0KKyAgICB7Cisg ICAgICAgIFZlY3RvcjxjaGFyPiBleHBlY3RlZDsKKyAgICAgICAgZXhwZWN0ZWQuYXBwZW5kKDAp OworICAgICAgICBFWFBFQ1RfRVEoZXhwZWN0ZWQsIGVuY29kZUJvb2woZmFsc2UpKTsKKyAgICB9 Cit9CisKIFRFU1QoSURCTGV2ZWxEQkNvZGluZ1Rlc3QsIE1heElEQktleSkKIHsKICAgICBWZWN0 b3I8Y2hhcj4gbWF4S2V5ID0gbWF4SURCS2V5KCk7CkBAIC0xMjYsNiArMTQwLDIwIEBAIFRFU1Qo SURCTGV2ZWxEQkNvZGluZ1Rlc3QsIEVuY29kZUludCkKICAgICBFWFBFQ1RfRVEoc3RhdGljX2Nh c3Q8c2l6ZV90Pig0KSwgZW5jb2RlSW50KDB4ZmZmZmZmZmYpLnNpemUoKSk7CiB9CiAKK1RFU1Qo SURCTGV2ZWxEQkNvZGluZ1Rlc3QsIERlY29kZUJvb2wpCit7CisgICAgeworICAgICAgICBWZWN0 b3I8Y2hhcj4gZW5jb2RlZDsKKyAgICAgICAgZW5jb2RlZC5hcHBlbmQoMSk7CisgICAgICAgIEVY UEVDVF9UUlVFKGRlY29kZUJvb2woZW5jb2RlZC5kYXRhKCksIGVuY29kZWQuZGF0YSgpICsgZW5j b2RlZC5zaXplKCkpKTsKKyAgICB9CisgICAgeworICAgICAgICBWZWN0b3I8Y2hhcj4gZW5jb2Rl ZDsKKyAgICAgICAgZW5jb2RlZC5hcHBlbmQoMCk7CisgICAgICAgIEVYUEVDVF9GQUxTRShkZWNv ZGVCb29sKGVuY29kZWQuZGF0YSgpLCBlbmNvZGVkLmRhdGEoKSArIGVuY29kZWQuc2l6ZSgpKSk7 CisgICAgfQorfQorCiBURVNUKElEQkxldmVsREJDb2RpbmdUZXN0LCBEZWNvZGVJbnQpCiB7CiAg ICAgVmVjdG9yPGludDY0X3Q+IHRlc3RDYXNlczsK