85809 2012-05-07 10:35:03 -0700 webkit-patch upload fails with "UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 31: ordinal not in range(128)" 2012-05-15 03:15:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vestbo vestbo dpranke eric oldest_to_newest 617704 0 vestbo 2012-05-07 10:35:03 -0700 [whopper:~/dev/webkit/wip] $ webkit-patch upload Total errors found: 0 in 2 files Please enter a bug number or a title for a new bug: WebPageProxy::activeURL() should return the pending API request, even when there's no main frame Reading Keychain for bugs.webkit.org account and password. Click "Allow" to continue... Logging in as vestbo@webkit.org... Creating bug with title "WebPageProxy::activeURL() should return the pending API request, even when there's no main frame" Bug 85806 created. https://bugs.webkit.org/show_bug.cgi?id=85806 Running status to find changed, added, or removed files. Reviewing diff to determine which lines changed. Traceback (most recent call last): File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkit-patch", line 69, in <module> main() File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkit-patch", line 64, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 311, in main result = command.check_arguments_and_execute(options, args, self) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 120, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 74, in run self._tool.executive.run_and_throw_if_fail(args, self._options.quiet, cwd=self._tool.scm().checkout_root) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/common/system/executive.py", line 140, in run_and_throw_if_fail exit_code = self._run_command_with_teed_output(args, child_stdout, **kwargs) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/common/system/executive.py", line 125, in _run_command_with_teed_output teed_output.write(output_line) File "/Users/torarne/dev/webkit/wip/Tools/Scripts/webkitpy/common/system/deprecated_logging.py", line 55, in write file.write(bytes) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 351, in write data, consumed = self.encode(object, self.errors) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 31: ordinal not in range(128) webkit-patch upload 3.04s user 0.81s system 6% cpu 57.152 total [whopper:~/dev/webkit/wip] $ git diff diff --git i/Source/WebKit2/ChangeLog w/Source/WebKit2/ChangeLog index 1f27c0a..95167be 100644 --- i/Source/WebKit2/ChangeLog +++ w/Source/WebKit2/ChangeLog @@ -1,3 +1,12 @@ +2012-05-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> + + WebPageProxy::activeURL() should return the pending API request, even when there's no main frame + https://bugs.webkit.org/show_bug.cgi?id=85806 + + Reviewed by NOBODY (OOPS!). + + * UIProcess/WebPageProxy.cpp: + 2012-05-07 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r116299, r116301, and r116303. 617707 1 vestbo 2012-05-07 10:35:23 -0700 Running "webkit-patch post" with the resulting working directory diff works fine. 623030 2 141738 vestbo 2012-05-14 09:07:05 -0700 Created attachment 141738 Patch 623149 3 eric 2012-05-14 11:32:14 -0700 Seems reasonable to me. Dirk? 623179 4 141738 dpranke 2012-05-14 12:01:59 -0700 Comment on attachment 141738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141738&action=review Seems plausible. > w/Tools/Scripts/webkit-patch:57 > + # wrong, and the stacktrace should show you were we Typo: "where", not "were". 623862 5 vestbo 2012-05-15 03:15:51 -0700 Committed r117049: <http://trac.webkit.org/changeset/117049> 141738 2012-05-14 09:07:05 -0700 2012-05-14 12:01:59 -0700 Patch bug-85809-20120514180703.patch text/plain 3384 vestbo U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2OTM2CmRpZmYgLS1naXQgYy9Ub29scy9DaGFuZ2VMb2cg dy9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDI1YzQ5NzYwM2Q1MjYwNDVlMzA4ZDE3NGVjM2Y5OTIw NTllZDQyYS4uNDBlYWVlNjNjMzA4M2VhMDhkOTZmMzZkZjQ1NjM5MjAwNWM2ZWI0MSAxMDA2NDQK LS0tIGMvVG9vbHMvQ2hhbmdlTG9nCisrKyB3L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4 IEBACisyMDEyLTA1LTE0ICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lh LmNvbT4KKworICAgICAgICBUZWFjaCB3ZWJraXQtcGF0Y2ggdG8gZ3JhY2VmdWxseSBoYW5kbGUg d3JpdGVzIG9mIHJhdyB1dGYtOCBlbmNvZGVkIHN0cmluZ3MgdG8gc3lzLnN0ZG91dAorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTgwOQorCisgICAg ICAgIHdlYmtpdC1wYXRjaCBvdmVycmlkZXMgc3lzLnN0ZG91dCB3aXRoIGEgU3RyZWFtV3JpdGVy IHRoYXQgZW5zdXJlcyB3ZSB3cml0ZSB1dGY4CisgICAgICAgIG91dHB1dCB0byBzdGRvdXQsIGJ1 dCBTdHJlYW1Xcml0ZXIgd2lsbCBieSBkZWZhdWx0IGFsd2F5cyBlbmNvZGUgdGhlIG9iamVjdCB0 aGF0J3MKKyAgICAgICAgcGFzc2VkIHRvIHdyaXRlKCkuIFRoaXMgYmxvd3MgdXAgd2hlbiB0aGUg b2JqZWN0IGlzIGEgcmF3IHN0cmluZywgYWxyZWFkeSBlbmNvZGVkCisgICAgICAgIGFzIHV0Zjgs IGFuZCBkb2VzIG5vdCBtYXRjaCB0aGUgZGVmYXVsdCBiZWhhdmlvciBvZiBzeXMuc3Rkb3V0Lgor CisgICAgICAgIFRvIHNvbHZlIHRoaXMgaW4gb25lIHBsYWNlLCBpbnN0ZWFkIG9mIGV2ZXJ5IHNp bmdsZSBjYWxsLXNpdGUgdGhhdCBtaWdodCB3cml0ZQorICAgICAgICByYXcgc3RyaW5ncywgd2Ug ZXh0ZW5kIHRoZSBzdGRvdXQtd3JhcHBlciB0byBhc3N1bWUgcmF3IHN0cmluZ3MgYXJlIHV0Zjgg YmVmb3JlCisgICAgICAgIHBhc3NpbmcgdGhlbSBvbiB0byBTdHJlYW1Xcml0ZXIud3JpdGUoKS4g VGhpcyBoYXMgdGhlIGJlbmVmaXQgb2YgYWxzbyBtYWtpbmcgdGhlCisgICAgICAgIHN0YWNrdHJh Y2UgZWFzeSB0byByZWFkIGluIHRoZSBjYXNlIHdoZXJlIHRoaXMgYXNzdW1wdGlvbiBkb2VzIG5v dCBob2xkLgorCisgICAgICAgIFRoZSBzb3VyY2Ugb2YgdGhpcyBwYXJ0aWN1bGFyIGJ1ZyB3YXMg dGhhdCBFeGVjdXRpdmUucnVuX2FuZF90aHJvd19pZl9mYWlsKCkgd2lsbAorICAgICAgICB0ZWUg dGhlIG91dHB1dCBvZiB0aGUgc3VicHJvY2VzcywgYW5kIGluIHRoZSBjYXNlIG9mIHJ1bm5pbmcg cHJlcGFyZS1DaGFuZ2VMb2cgdGhpcworICAgICAgICBtaWdodCBwcm9kdWNlIG5vbi1hc2NpaSBv dXRwdXQsIHdoaWNoIGdldHMgd3JpdHRlbiBkaXJlY3RseSB0byBzeXMuc3Rkb3V0IGFzIHJhdwor ICAgICAgICB1dGY4LWVuY29kZWQgc3RyaW5ncy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0LXBhdGNoOgorCiAyMDEyLTA1 LTExICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4KIAogICAg ICAgICBbUXRdIE1ha2Ugc3VyZSBkaWFsb2dzIGhhdmUgdGhlaXIgcGFyZW50IGFuZCBhdHRhY2hl ZCBwcm9wZXJ0aWVzIHNldCBiZWZvcmUgQ29tcG9uZW50Lm9uQ29tcGxldGVkCmRpZmYgLS1naXQg Yy9Ub29scy9TY3JpcHRzL3dlYmtpdC1wYXRjaCB3L1Rvb2xzL1NjcmlwdHMvd2Via2l0LXBhdGNo CmluZGV4IGE4Y2U1MTMwYjRiYzdiMDVjMTkyYWRkZDNhYmQyZGIxNzE3YTQyNjAuLjQyMDkwZDQ5 YWZmMmRjNmZjZjNmZmQzZDU3Mzk3YzE1ZDVjNTMxYzUgMTAwNzU1Ci0tLSBjL1Rvb2xzL1Njcmlw dHMvd2Via2l0LXBhdGNoCisrKyB3L1Rvb2xzL1NjcmlwdHMvd2Via2l0LXBhdGNoCkBAIC00Mywx MiArNDMsMjcgQEAgaW1wb3J0IHdlYmtpdHB5LmNvbW1vbi52ZXJzaW9uX2NoZWNrCiBmcm9tIHdl YmtpdHB5LmNvbW1vbi5zeXN0ZW0ubG9ndXRpbHMgaW1wb3J0IGNvbmZpZ3VyZV9sb2dnaW5nCiBm cm9tIHdlYmtpdHB5LnRvb2wubWFpbiBpbXBvcnQgV2ViS2l0UGF0Y2gKIAorIyBBIFN0cmVhbVdy aXRlciB3aWxsIGJ5IGRlZmF1bHQgdHJ5IHRvIGVuY29kZSBhbGwgb2JqZWN0cyBwYXNzZWQKKyMg dG8gd3JpdGUoKSwgc28gd2hlbiBwYXNzZWQgYSByYXcgc3RyaW5nIGFscmVhZHkgZW5jb2RlZCBh cyB1dGY4LAorIyBpdCB3aWxsIGJsb3cgdXAgd2l0aCBhbiBVbmljb2RlRGVjb2RlRXJyb3IuIFRo aXMgZG9lcyBub3QgbWF0Y2gKKyMgdGhlIGRlZmF1bHQgYmVoYXZpb3VyIG9mIHdyaXRpbmcgdG8g c3lzLnN0ZG91dCwgc28gd2UgaW50ZXJjZXB0CisjIHRoZSBjYXNlIG9mIHdyaXRpbmcgcmF3IHN0 cmluZ3MgYW5kIG1ha2Ugc3VyZSBTdHJlYW1Xcml0ZXIgZ2V0cworIyBpbnB1dCB0aGF0IGl0IGNh biBoYW5kbGUuCitjbGFzcyBGb3JnaXZpbmdVVEY4V3JpdGVyKGNvZGVjcy5sb29rdXAoJ3V0Zi04 JylbLTFdKToKKyAgICBkZWYgd3JpdGUoc2VsZiwgb2JqZWN0KToKKyAgICAgICAgaWYgaXNpbnN0 YW5jZShvYmplY3QsIHN0cik6CisgICAgICAgICAgICAjIEFzc3VtZSByYXcgc3RyaW5ncyBhcmUg dXRmLTggZW5jb2RlZC4gSWYgdGhpcyBsaW5lCisgICAgICAgICAgICAjIGZhaWxzIHdpdGggYW4g VW5pY29kZURlY29kZUVycm9yLCBvdXIgYXNzdW1wdGlvbiB3YXMKKyAgICAgICAgICAgICMgd3Jv bmcsIGFuZCB0aGUgc3RhY2t0cmFjZSBzaG91bGQgc2hvdyB5b3Ugd2VyZSB3ZQorICAgICAgICAg ICAgIyB3cml0ZSBub24tVW5pY29kZS9VVEYtOCBkYXRhICh3aGljaCB3ZSBzaG91bGRuJ3QpLgor ICAgICAgICAgICAgb2JqZWN0ID0gb2JqZWN0LmRlY29kZSgndXRmLTgnKQorICAgICAgICByZXR1 cm4gY29kZWNzLlN0cmVhbVdyaXRlci53cml0ZShzZWxmLCBvYmplY3QpCisKICMgQnkgZGVmYXVs dCwgc3lzLnN0ZG91dCBhc3N1bWVzIGFzY2lpIGVuY29kaW5nLiAgU2luY2Ugb3VyIG1lc3NhZ2Vz IGNhbgogIyBjb250YWluIHVuaWNvZGUgc3RyaW5ncyAoYXMgd2l0aCBzb21lIHBlb3BsZXMnIG5h bWVzKSB3ZSBuZWVkIHRvIGFwcGx5CiAjIHRoZSB1dGYtOCBjb2RlYyB0byBwcmV2ZW50IHRocm93 aW5nIGFuZCBleGNlcHRpb24uCiAjIE5vdCBoYXZpbmcgdGhpcyB3YXMgdGhlIGNhdXNlIG9mIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzQ1Mi4KLXN5cy5zdGRvdXQg PSBjb2RlY3MubG9va3VwKCd1dGYtOCcpWy0xXShzeXMuc3Rkb3V0KQotCitzeXMuc3Rkb3V0ID0g Rm9yZ2l2aW5nVVRGOFdyaXRlcihzeXMuc3Rkb3V0KQogCiBfbG9nID0gbG9nZ2luZy5nZXRMb2dn ZXIoIndlYmtpdC1wYXRjaCIpCiAK