85807 2012-05-07 10:30:42 -0700 Fix containerForRepaint() assumption about non-null enclosingLayer() 2012-05-07 12:35:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne enne simon.fraser webkit.review.bot oldest_to_newest 617689 0 enne 2012-05-07 10:30:42 -0700 Fix containerForRepaint() assumption about non-null enclosingLayer() 617691 1 140545 enne 2012-05-07 10:30:55 -0700 Created attachment 140545 Failing test 617698 2 140547 enne 2012-05-07 10:32:46 -0700 Created attachment 140547 Patch 617710 3 enne 2012-05-07 10:36:06 -0700 smfr: I looked into why https://chromiumcodereview.appspot.com/10342008/ got reverted on the Chromium branch, and it turned out that there was a crash that (mistakenly) looked like it started occurring because of your change. So, it was conservatively reverted on the branch. I've attached the messy autogenerated test that was triggering it. However, that revision range ended up being incorrect and it wasn't due to your patch. This is a pretty obvious fix, so I just went ahead and patched it. 617723 4 140547 webkit.review.bot 2012-05-07 10:57:11 -0700 Comment on attachment 140547 Patch Rejecting attachment 140547 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/RenderObject.cpp Hunk #1 FAILED at 1243. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderObject.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Simon Fras..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12644206 617766 5 140562 enne 2012-05-07 11:29:59 -0700 Created attachment 140562 Rebased for landing 617828 6 140562 webkit.review.bot 2012-05-07 12:35:02 -0700 Comment on attachment 140562 Rebased for landing Clearing flags on attachment: 140562 Committed r116339: <http://trac.webkit.org/changeset/116339> 617829 7 webkit.review.bot 2012-05-07 12:35:12 -0700 All reviewed patches have been landed. Closing bug. 140545 2012-05-07 10:30:55 -0700 2012-05-07 11:29:53 -0700 Failing test bug-85807-20120507103054.patch text/plain 932 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MTgwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb250 YWluZXJGb3JSZXBhaW50Q3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2NvbnRhaW5lckZvclJlcGFp bnRDcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNhYmU1MDQ1NGQzOGM1YTE3OGY3NjE3NGM3YWQ2MjI2 ZmEzZGE1ZTQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jb250YWluZXJGb3JSZXBh aW50Q3Jhc2guaHRtbApAQCAtMCwwICsxLDMyIEBACis8c3R5bGU+CisjaWRfNjEwNiB7Cit9CisK K29iamVjdCB7Cistd2Via2l0LWJhY2tmYWNlLXZpc2liaWxpdHk6aGlkZGVuOworPC9zdHlsZT4K KworPHNjcmlwdD4KKyhfPXdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgJiYgXy53YWl0VW50 aWxEb25lKCk7CisgIHZhciBhZiA9IFtdLCBpID0gMDsKKyAgZnVuY3Rpb24gbWFpbigpe2FmW2kr KyAlIGFmLmxlbmd0aF0oKX0KK2FmLnB1c2goZnVuY3Rpb24gKCl7CisgIGRvY3VtZW50LmRlc2ln bk1vZGU9Im9uIjtkb2N1bWVudC5leGVjQ29tbWFuZCgiU2VsZWN0QWxsIik7ICBkb2N1bWVudC5l eGVjQ29tbWFuZCgiSnVzdGlmeUNlbnRlciIsIGZhbHNlKTsgIH0pCitmdW5jdGlvbiBmXzExKCl7 CisgIH0KKzwvc2NyaXB0PgorCis8c2NyaXB0PgorICBzZXRJbnRlcnZhbChtYWluLCAxMDApOwor PC9zY3JpcHQ+CisKKzxvYmplY3Qgc3ZnOm92ZXJsaW5lLXRoaWNrbmVzcz0ifXsyckAxMworUWot ZmYoK21jXzcJMm80aEkgIjwveG1wPgorPC9vYmplY3Q+Cis8bGlzdGluZyB4bGluazpyb2xlPSdb ciVFW2JoN1sKK0NjZnYrJEtoW3kjI3BMd3xJYVtPdwlaJElpQ2EnCisjQG1cZEVlIj4KKzxydD4K KzxzCX4kJmx0Oz4KKzwvcz4KKwo= 140547 2012-05-07 10:32:46 -0700 2012-05-07 11:29:56 -0700 Patch bug-85807-20120507103245.patch text/plain 1617 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDM5NzMwOWJkZDJjMjY4 OWZmYmYzOTY0OTFkZTM4ZTg4NjEzMGM2MS4uMGZlNTM3ZmUzNjkyOGU3YWIyZTczYTNjZWZmYWM4 Zjk4YjBmNTljYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTA3ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4IGNvbnRhaW5lckZv clJlcGFpbnQoKSBhc3N1bXB0aW9uIGFib3V0IG5vbi1udWxsIGVuY2xvc2luZ0xheWVyKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1ODA3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6Y29udGFp bmVyRm9yUmVwYWludCk6CisKIDIwMTItMDQtMTMgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBs ZS5jb20+CiAKICAgICAgICAgVmlkZW8gYXQgYXBwbGUuY29tIGdldHMgc3RhbmRhcmQgY29udHJv bHMgaW4gYWRkaXRpb24gdG8gY3VzdG9tIGNvbnRyb2xzIGFmdGVyIHJldHVybmluZyBmcm9tIGZ1 bGwgc2NyZWVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCmluZGV4 IDNiZWEzNTM1YWNjZGE3MDk0ZGE3N2E0M2EyN2JkNDVhNTJhMmFlM2EuLmQyYjg4MTczNDgxYjA0 ZDcyNTUzY2RlYTdjZGM1NmRhODk4OGYxNzQgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJPYmplY3QuY3BwCkBAIC0xMjQzLDkgKzEyNDMsMTEgQEAgUmVuZGVyQm94TW9kZWxPYmpl Y3QqIFJlbmRlck9iamVjdDo6Y29udGFpbmVyRm9yUmVwYWludCgpIGNvbnN0CiAKICNpZiBVU0Uo QUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgaWYgKHYtPnVzZXNDb21wb3NpdGluZygpKSB7 Ci0gICAgICAgIFJlbmRlckxheWVyKiBjb21wTGF5ZXIgPSBlbmNsb3NpbmdMYXllcigpLT5lbmNs b3NpbmdDb21wb3NpdGluZ0xheWVyKCk7Ci0gICAgICAgIGlmIChjb21wTGF5ZXIpCi0gICAgICAg ICAgICByZXBhaW50Q29udGFpbmVyID0gY29tcExheWVyLT5yZW5kZXJlcigpOworICAgICAgICBp ZiAoUmVuZGVyTGF5ZXIqIHBhcmVudExheWVyID0gZW5jbG9zaW5nTGF5ZXIoKSkgeworICAgICAg ICAgICAgUmVuZGVyTGF5ZXIqIGNvbXBMYXllciA9IHBhcmVudExheWVyLT5lbmNsb3NpbmdDb21w b3NpdGluZ0xheWVyKCk7CisgICAgICAgICAgICBpZiAoY29tcExheWVyKQorICAgICAgICAgICAg ICAgIHJlcGFpbnRDb250YWluZXIgPSBjb21wTGF5ZXItPnJlbmRlcmVyKCk7CisgICAgICAgIH0K ICAgICB9CiAjZW5kaWYKICAgICAK 140562 2012-05-07 11:29:59 -0700 2012-05-07 12:35:01 -0700 Rebased for landing bug-85807-20120507112958.patch text/plain 1565 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTRmNTRmMDU1YTU4OTU0 YWM2MTg4ZDNkYWJhNmIzYzliMzdlZTc4Ny4uNmMzMWVmZGZmZGNlMmM0ODMxMDQxZjhhZjNlOTBl NjAxNDhjMzdlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTA3ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4IGNvbnRhaW5lckZv clJlcGFpbnQoKSBhc3N1bXB0aW9uIGFib3V0IG5vbi1udWxsIGVuY2xvc2luZ0xheWVyKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1ODA3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OmNvbnRhaW5l ckZvclJlcGFpbnQpOgorCiAyMDEyLTA1LTA0ICBKZWZmcmV5IFBmYXUgIDxqcGZhdUBhcHBsZS5j b20+CiAKICAgICAgICAgUHJldmVudCBlYXJseSBFdmVudExpc3RlbmVyIGRlbGV0aW9uCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCmluZGV4IGNjODBiYWU5YjY1Njhk MTYwNmRmODE4MWI2ZmY3M2FmZjhmMTY3N2EuLmQ2M2QzYzQ1ZmMwMDZiY2EwNTIzNGNkNzAzNWIz NTg0NjBiNjBjNWUgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJP YmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3Bw CkBAIC0xMjU1LDkgKzEyNTUsMTEgQEAgUmVuZGVyQm94TW9kZWxPYmplY3QqIFJlbmRlck9iamVj dDo6Y29udGFpbmVyRm9yUmVwYWludCgpIGNvbnN0CiAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09N UE9TSVRJTkcpCiAgICAgaWYgKHYtPnVzZXNDb21wb3NpdGluZygpKSB7Ci0gICAgICAgIFJlbmRl ckxheWVyKiBjb21wTGF5ZXIgPSBlbmNsb3NpbmdMYXllcigpLT5lbmNsb3NpbmdDb21wb3NpdGlu Z0xheWVyRm9yUmVwYWludCgpOwotICAgICAgICBpZiAoY29tcExheWVyKQotICAgICAgICAgICAg cmVwYWludENvbnRhaW5lciA9IGNvbXBMYXllci0+cmVuZGVyZXIoKTsKKyAgICAgICAgaWYgKFJl bmRlckxheWVyKiBwYXJlbnRMYXllciA9IGVuY2xvc2luZ0xheWVyKCkpIHsKKyAgICAgICAgICAg IFJlbmRlckxheWVyKiBjb21wTGF5ZXIgPSBwYXJlbnRMYXllci0+ZW5jbG9zaW5nQ29tcG9zaXRp bmdMYXllckZvclJlcGFpbnQoKTsKKyAgICAgICAgICAgIGlmIChjb21wTGF5ZXIpCisgICAgICAg ICAgICAgICAgcmVwYWludENvbnRhaW5lciA9IGNvbXBMYXllci0+cmVuZGVyZXIoKTsKKyAgICAg ICAgfQogICAgIH0KICNlbmRpZgogICAgIAo=