85805 2012-05-07 09:31:09 -0700 Shrink SVGInlineTextBox object size 2012-05-07 13:27:05 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rwlbuis rwlbuis eric webkit.review.bot zimmermann oldest_to_newest 617645 0 rwlbuis 2012-05-07 09:31:09 -0700 The way we use bitpacking here is not ideal. 617655 1 140541 rwlbuis 2012-05-07 09:47:05 -0700 Created attachment 140541 Patch 617712 2 140541 darin 2012-05-07 10:37:13 -0700 Comment on attachment 140541 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140541&action=review Where’s the compile-time size assertion for this class? > Source/WebCore/rendering/svg/SVGInlineTextBox.h:86 > + unsigned m_paintingResourceMode : 4; When we add a new mode, what will point someone here to add more bits? I am worried that this mode is defined in another file, and someone modifying it would have no reason to look here. Maybe a comment in the file that defines the enum? 617878 3 rwlbuis 2012-05-07 13:27:05 -0700 (In reply to comment #2) > (From update of attachment 140541 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140541&action=review > > Where’s the compile-time size assertion for this class? > > > Source/WebCore/rendering/svg/SVGInlineTextBox.h:86 > > + unsigned m_paintingResourceMode : 4; > > When we add a new mode, what will point someone here to add more bits? I am worried that this mode is defined in another file, and someone modifying it would have no reason to look here. Maybe a comment in the file that defines the enum? I fixed both before landing it in r116343. Cheers, Rob. 140541 2012-05-07 09:47:05 -0700 2012-05-07 10:37:12 -0700 Patch bug-85805-20120507124731.patch text/plain 1417 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MzEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjg1ZDA0OTNjMzAwMzM3 MTUzOTMxY2E4NjEzZTg1ZWYxMjQ0NzJlMC4uNDAyZTMxOGY5OTE1NzE2MTYwMDNkNzgwNGVjODEx OTk5NGY0MGEzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTA3ICBSb2Ig QnVpcyAgPHJidWlzQHJpbS5jb20+CisKKyAgICAgICAgU2hyaW5rIFNWR0lubGluZVRleHRCb3gg b2JqZWN0IHNpemUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg1ODA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVkdWNlIHRoZSBvYmplY3Qgc2l6ZSBvZiBTVkdJbmxpbmVUZXh0Qm94IGJ5IHVzaW5nIGJp dGZpZWxkcy4gVGhpcworICAgICAgICBzaG91bGQgYmUgNCBieXRlcyBvbiAzMi1iaXRzIGFuZCA4 IGJ5dGVzIG9uIDY0LWJpdHMgc3lzdGVtcy4KKworICAgICAgICAqIHJlbmRlcmluZy9zdmcvU1ZH SW5saW5lVGV4dEJveC5oOgorICAgICAgICAoU1ZHSW5saW5lVGV4dEJveCk6CisKIDIwMTItMDUt MDcgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24uY29tPgogCiAgICAg ICAgIE1lZGlhU3RyZWFtIHNob3VsZCBub3QgYmUgYW4gQWN0aXZlRE9NT2JqZWN0CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR0lubGluZVRleHRCb3guaCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHSW5saW5lVGV4dEJveC5oCmluZGV4IGQzYjlk Nzk5ZDVlZmI5Yjk1YzFmMDQ2Mzg0ZTUwM2ZmOTA0YmJlZGMuLjA3OTYwMWQyY2Y3YzIyYjIxMWUy YzI3ZTQ2ODUzNDE3M2U0NGU4YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9zdmcvU1ZHSW5saW5lVGV4dEJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9z dmcvU1ZHSW5saW5lVGV4dEJveC5oCkBAIC04Myw4ICs4Myw4IEBAIHByaXZhdGU6CiAKIHByaXZh dGU6CiAgICAgZmxvYXQgbV9sb2dpY2FsSGVpZ2h0OwotICAgIGludCBtX3BhaW50aW5nUmVzb3Vy Y2VNb2RlOwotICAgIGJvb2wgbV9zdGFydHNOZXdUZXh0Q2h1bmsgOiAxOworICAgIHVuc2lnbmVk IG1fcGFpbnRpbmdSZXNvdXJjZU1vZGUgOiA0OworICAgIHVuc2lnbmVkIG1fc3RhcnRzTmV3VGV4 dENodW5rIDogMTsKICAgICBSZW5kZXJTVkdSZXNvdXJjZSogbV9wYWludGluZ1Jlc291cmNlOwog ICAgIFZlY3RvcjxTVkdUZXh0RnJhZ21lbnQ+IG1fdGV4dEZyYWdtZW50czsKIH07Cg==