85801 2012-05-07 06:59:51 -0700 [chromium] setContentsMemoryAllocationLimitBytes needs to setNeedsCommit. 2012-05-07 10:24:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmocny mmocny cc-bugs enne jamesr kbr nduca webkit.review.bot oldest_to_newest 617571 0 mmocny 2012-05-07 06:59:51 -0700 [chromium] setContentsMemoryAllocationLimitBytes needs to setNeedsCommit. 617573 1 140523 mmocny 2012-05-07 07:01:35 -0700 Created attachment 140523 Patch 617578 2 140523 mmocny 2012-05-07 07:11:59 -0700 Comment on attachment 140523 Patch This patch fixes: http://code.google.com/p/chromium/issues/detail?id=126079 On pages that did not need to update/draw, we would push a single white frame while our memory allocation was 0, and not push another frame once that memory allocation changed. As well as calling setNeedsCommit, this patch resets the memory allocation to its initial value on visibility if it was purged down to 0. This way, we can push a frame before waiting for a round trip memory allocation adjustments message to arrive. If the message arrives before the next frame, great. If not, at least our allocation is some conservative non 0 value, and also matches our current initialized state behaviour. 617631 3 140523 nduca 2012-05-07 09:05:57 -0700 Comment on attachment 140523 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140523&action=review > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:382 > + // Reset memory allocation to initial value if we have purged down to 0. Why? This feels wrong... you're basically goign to let any newly visible tab ignore the gpu memory manager's recommendation? > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:427 > + setNeedsCommit(); This part LGTM 617634 4 140535 mmocny 2012-05-07 09:15:35 -0700 Created attachment 140535 Patch 617635 5 140523 mmocny 2012-05-07 09:16:59 -0700 Comment on attachment 140523 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140523&action=review >> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:382 >> + // Reset memory allocation to initial value if we have purged down to 0. > > Why? This feels wrong... you're basically goign to let any newly visible tab ignore the gpu memory manager's recommendation? Discussed offline: it should be a separate bug to optimize returning from 0 memory allocation, as there are many possible solutions to this. Removing from this patch for now. 617654 6 140535 enne 2012-05-07 09:47:00 -0700 Comment on attachment 140535 Patch R=me. I agree with the approach of fixing this first and optimizing it later. 617682 7 140535 webkit.review.bot 2012-05-07 10:24:43 -0700 Comment on attachment 140535 Patch Clearing flags on attachment: 140535 Committed r116316: <http://trac.webkit.org/changeset/116316> 617683 8 webkit.review.bot 2012-05-07 10:24:50 -0700 All reviewed patches have been landed. Closing bug. 140523 2012-05-07 07:01:35 -0700 2012-05-07 09:16:59 -0700 Patch bug-85801-20120507100134.patch text/plain 2224 mmocny U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI3MzZkMTEwOWRjNjNh NjlmNzVhYWEwZWVjNjI5YzdkMTFhMDUyMS4uMmMxZjQ1MTE3N2ViNTk4YmNhYWVlMWFjMzhjZTcy M2Y3MDQ1OTE3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTA3ICBNaWNo YWwgTW9jbnkgIDxtbW9jbnlAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIHNldENv bnRlbnRzTWVtb3J5QWxsb2NhdGlvbkxpbWl0Qnl0ZXMgbmVlZHMgdG8gc2V0TmVlZHNDb21taXQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTgwMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENDTGF5ZXJU cmVlSG9zdDo6c2V0Q29udGVudHNNZW1vcnlBbGxvY2F0aW9uTGltaXRCeXRlcyBuZWVkcyB0byBj YWxsIHNldE5lZWRzQ29tbWl0IGFmdGVyIGFkanVzdGluZyBtZW1vcnkKKyAgICAgICAgbGltaXRz LCBzbyB0aGF0IHdlIHB1c2ggYSBuZXcgZnJhbWUuICBJbiBwYXJ0aWN1bGFyLCB3aGVuIHJldHVy bmluZyBmcm9tIG5vbiB2aXNpYmlsZSBzdGF0ZSwgd2UgYWRqdXN0CisgICAgICAgIG1lbW9yeSBh bGxvY2F0aW9uIGZyb20gMCB0byBub24gMCwgYW5kIHdlIG5lZWQgdG8gcHVzaCBhIG5vbiBibGFu ayBmcmFtZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5 ZXJUcmVlSG9zdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ0xheWVyVHJlZUhvc3Q6OnNldFZp c2libGUpOgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0OjpzZXRDb250ZW50c01l bW9yeUFsbG9jYXRpb25MaW1pdEJ5dGVzKToKKwogMjAxMi0wNS0wNyAgQ3NhYmEgT3N6dHJvZ29u w6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1aWxkZml4IGZvciBidWdneSBHQ0MK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2Nj L0NDTGF5ZXJUcmVlSG9zdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwCmluZGV4IDM5ZDJhMTY1OGUwN2YwYmY3MWNh YjY3YTU2NmE3NTUxMmVjZWVjN2QuLjVlZTBiNzY1NTlmZDAwYmE4OTFiNDhiNTZiYzM5Mzc1NDE5 ZWVkNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmNwcApAQCAtMzc5LDYgKzM3OSwx MCBAQCB2b2lkIENDTGF5ZXJUcmVlSG9zdDo6c2V0VmlzaWJsZShib29sIHZpc2libGUpCiAKICAg ICBtX3Zpc2libGUgPSB2aXNpYmxlOwogCisgICAgLy8gUmVzZXQgbWVtb3J5IGFsbG9jYXRpb24g dG8gaW5pdGlhbCB2YWx1ZSBpZiB3ZSBoYXZlIHB1cmdlZCBkb3duIHRvIDAuCisgICAgaWYgKG1f dmlzaWJsZSAmJiAhbV9jb250ZW50c1RleHR1cmVNYW5hZ2VyLT5tYXhNZW1vcnlMaW1pdEJ5dGVz KCkpCisgICAgICBzZXRDb250ZW50c01lbW9yeUFsbG9jYXRpb25MaW1pdEJ5dGVzKFRleHR1cmVN YW5hZ2VyOjpoaWdoTGltaXRCeXRlcyh2aWV3cG9ydFNpemUoKSkpOworCiAgICAgLy8gVGVsbHMg dGhlIHByb3h5IHRoYXQgdmlzaWJpbGl0eSBzdGF0ZSBoYXMgY2hhbmdlZC4gVGhpcyB3aWxsIGlu IHR1cm4gY2FsbAogICAgIC8vIENDTGF5ZXJUcmVlSG9zdDo6ZGlkQmVjb21lSW52aXNpYmxlT25J bXBsVGhyZWFkIG9uIHRoZSBhcHByb3ByaWF0ZSB0aHJlYWQsIGZvcgogICAgIC8vIHRoZSBjYXNl IHdoZXJlICF2aXNpYmxlLgpAQCAtNDIwLDYgKzQyNCw3IEBAIHZvaWQgQ0NMYXllclRyZWVIb3N0 OjpzZXRDb250ZW50c01lbW9yeUFsbG9jYXRpb25MaW1pdEJ5dGVzKHNpemVfdCBieXRlcykKICAg ICAgICAgcmV0dXJuOwogCiAgICAgbV9jb250ZW50c1RleHR1cmVNYW5hZ2VyLT5zZXRNZW1vcnlB bGxvY2F0aW9uTGltaXRCeXRlcyhieXRlcyk7CisgICAgc2V0TmVlZHNDb21taXQoKTsKIH0KIAog Cg== 140535 2012-05-07 09:15:35 -0700 2012-05-07 10:24:43 -0700 Patch bug-85801-20120507121534.patch text/plain 1678 mmocny U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI3MzZkMTEwOWRjNjNh NjlmNzVhYWEwZWVjNjI5YzdkMTFhMDUyMS4uMmMxZjQ1MTE3N2ViNTk4YmNhYWVlMWFjMzhjZTcy M2Y3MDQ1OTE3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTA3ICBNaWNo YWwgTW9jbnkgIDxtbW9jbnlAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIHNldENv bnRlbnRzTWVtb3J5QWxsb2NhdGlvbkxpbWl0Qnl0ZXMgbmVlZHMgdG8gc2V0TmVlZHNDb21taXQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTgwMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENDTGF5ZXJU cmVlSG9zdDo6c2V0Q29udGVudHNNZW1vcnlBbGxvY2F0aW9uTGltaXRCeXRlcyBuZWVkcyB0byBj YWxsIHNldE5lZWRzQ29tbWl0IGFmdGVyIGFkanVzdGluZyBtZW1vcnkKKyAgICAgICAgbGltaXRz LCBzbyB0aGF0IHdlIHB1c2ggYSBuZXcgZnJhbWUuICBJbiBwYXJ0aWN1bGFyLCB3aGVuIHJldHVy bmluZyBmcm9tIG5vbiB2aXNpYmlsZSBzdGF0ZSwgd2UgYWRqdXN0CisgICAgICAgIG1lbW9yeSBh bGxvY2F0aW9uIGZyb20gMCB0byBub24gMCwgYW5kIHdlIG5lZWQgdG8gcHVzaCBhIG5vbiBibGFu ayBmcmFtZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5 ZXJUcmVlSG9zdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ0xheWVyVHJlZUhvc3Q6OnNldFZp c2libGUpOgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0OjpzZXRDb250ZW50c01l bW9yeUFsbG9jYXRpb25MaW1pdEJ5dGVzKToKKwogMjAxMi0wNS0wNyAgQ3NhYmEgT3N6dHJvZ29u w6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1aWxkZml4IGZvciBidWdneSBHQ0MK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2Nj L0NDTGF5ZXJUcmVlSG9zdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwCmluZGV4IDM5ZDJhMTY1OGUwN2YwYmY3MWNh YjY3YTU2NmE3NTUxMmVjZWVjN2QuLjllNTc2YWMzNzk2YjY4YTQzMjg3OTM1YjUzMjY3MTUzYTRj YTgyNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmNwcApAQCAtNDIwLDYgKzQyMCw3 IEBAIHZvaWQgQ0NMYXllclRyZWVIb3N0OjpzZXRDb250ZW50c01lbW9yeUFsbG9jYXRpb25MaW1p dEJ5dGVzKHNpemVfdCBieXRlcykKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9jb250ZW50c1Rl eHR1cmVNYW5hZ2VyLT5zZXRNZW1vcnlBbGxvY2F0aW9uTGltaXRCeXRlcyhieXRlcyk7CisgICAg c2V0TmVlZHNDb21taXQoKTsKIH0KIAogCg==