85791 2012-05-07 04:29:26 -0700 Remove CYGWIN=tty from environment variable as its no longer supported 2012-05-21 14:40:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 vivekgalatage vivekgalatage abarth aroben bfulgham bweinstein rniwa sfalken vivekgalatage webkit.review.bot oldest_to_newest 617516 0 vivekgalatage 2012-05-07 04:29:26 -0700 cygwin throws a warning as: "tty" option detected in CYGWIN environment variable. CYGWIN=tty is no longer supported. Please remove it from your CYGWIN environment variable and use a terminal emulator like mintty, xterm, or rxvt. 617517 1 vivekgalatage 2012-05-07 04:30:19 -0700 This has been mentioned in the changelog: http://cygwin.com/cygwin-ug-net/ov-new1.7.html "The CYGWIN environment variable options "envcache", "strip_title", "title", "tty", and "upcaseenv" have been removed." 617532 2 140511 vivekgalatage 2012-05-07 05:16:14 -0700 Created attachment 140511 Patch 617543 3 aroben 2012-05-07 05:48:03 -0700 What effect will this have for people who haven't yet upgraded to Cygwin 1.7.10? 617549 4 vivekgalatage 2012-05-07 05:55:12 -0700 According to http://cygwin.com/cygwin-ug-net/using-cygwinenv.html, this options will: (no)tty - If set, Cygwin enabled extra support (i.e., termios) for UNIX-like ttys in the Windows console. This option has been removed because it can be easily replaced by using a terminal like mintty, and it does not work well with some Windows programs. As on windows, mintty is default terminal program even for older releases of cygwin, I think there should not be any issue. More info about termios: http://docs.python.org/library/termios.html 617695 5 140511 darin 2012-05-07 10:31:44 -0700 Comment on attachment 140511 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140511&action=review > Tools/ChangeLog:8 > + Cygwin has removed support for the CYGWIN=tty environment variable hence removed it. No need for this for people using older versions of Cygwin? 618257 6 vivekgalatage 2012-05-07 20:35:54 -0700 (In reply to comment #5) > (From update of attachment 140511 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140511&action=review > > > Tools/ChangeLog:8 > > + Cygwin has removed support for the CYGWIN=tty environment variable hence removed it. > > No need for this for people using older versions of Cygwin? The usage of mintty is the default option, so this CYGWIN=tty is obsolete a long time ago. I could dig through a discussion thread at http://www.mail-archive.com/cygwin@cygwin.com/msg116237.html and found it should be ok to remove this option. What would be your opinion? 619411 7 140511 aroben 2012-05-09 05:28:01 -0700 Comment on attachment 140511 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140511&action=review >>> Tools/ChangeLog:8 >>> + Cygwin has removed support for the CYGWIN=tty environment variable hence removed it. >> >> No need for this for people using older versions of Cygwin? > > The usage of mintty is the default option, so this CYGWIN=tty is obsolete a long time ago. > > I could dig through a discussion thread at http://www.mail-archive.com/cygwin@cygwin.com/msg116237.html and found it should be ok to remove this option. > > What would be your opinion? Bug 31228 comment 1 says that CYGWIN=tty is required for emacs to work. If that was ever true, then it seems like this patch will break emacs for people who have an existing Cygwin <1.7.10 install and start working on WebKit for the first time. 619423 8 vivekgalatage 2012-05-09 05:50:25 -0700 (In reply to comment #7) > Bug 31228 comment 1 says that CYGWIN=tty is required for emacs to work. If that was ever true, then it seems like this patch will break emacs for people who have an existing Cygwin <1.7.10 install and start working on WebKit for the first time. Oh yes, I agree that this would break existing cygwin < 1.7.10 and those who are using programs like emacs with cygwin. So shall we leave this variable as it is? Or we take a poll on webkit-dev for how many people use windows with cygwin < 1.7.10 and with emacs. So then based on that number make a decision whether to remove this variable. Your thoughts? 619591 9 aroben 2012-05-09 09:48:09 -0700 (In reply to comment #8) > (In reply to comment #7) > > Bug 31228 comment 1 says that CYGWIN=tty is required for emacs to work. If that was ever true, then it seems like this patch will break emacs for people who have an existing Cygwin <1.7.10 install and start working on WebKit for the first time. > > Oh yes, I agree that this would break existing cygwin < 1.7.10 and those who are using programs like emacs with cygwin. > > So shall we leave this variable as it is? Or we take a poll on webkit-dev for how many people use windows with cygwin < 1.7.10 and with emacs. So then based on that number make a decision whether to remove this variable. > > Your thoughts? This will only affect people who are doing doing WebKit development for the first time. If you're on a brand new computer, you'll have Cygwin >= 1.7.10 so this won't be a problem. It will only be a problem if you have an existing Cygwin install and start working on WebKit for the first time. I doubt there are too many people in that situation. But maybe we can make it work for everyone. Can't we detect the Cygwin version using `uname`? 619596 10 vivekgalatage 2012-05-09 09:56:47 -0700 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > Bug 31228 comment 1 says that CYGWIN=tty is required for emacs to work. If that was ever true, then it seems like this patch will break emacs for people who have an existing Cygwin <1.7.10 install and start working on WebKit for the first time. > > > > Oh yes, I agree that this would break existing cygwin < 1.7.10 and those who are using programs like emacs with cygwin. > > > > So shall we leave this variable as it is? Or we take a poll on webkit-dev for how many people use windows with cygwin < 1.7.10 and with emacs. So then based on that number make a decision whether to remove this variable. > > > > Your thoughts? > > This will only affect people who are doing doing WebKit development for the first time. If you're on a brand new computer, you'll have Cygwin >= 1.7.10 so this won't be a problem. It will only be a problem if you have an existing Cygwin install and start working on WebKit for the first time. I doubt there are too many people in that situation. > > But maybe we can make it work for everyone. Can't we detect the Cygwin version using `uname`? Yes `uname -r` would give which version of cygwin is being used. Something like: $ uname -r 1.7.11(0.260/5/3) So in the python script we can detect this and based on the detected version we may or may not set the env. variable. This way it will work for older versions of cygwin as well. 619725 11 140997 vivekgalatage 2012-05-09 12:24:34 -0700 Created attachment 140997 Patch 619729 12 140997 aroben 2012-05-09 12:28:47 -0700 Comment on attachment 140997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140997&action=review This is looking close! > Tools/ChangeLog:6 > + Added check to support older versions of Cygwin 1.7.9 or lesser This doesn't really describe the entire change; it only describes the differences from the last version of your patch. > Tools/Scripts/webkitdirs.pm:1491 > + # FIXME: The setting CYGWIN=tty is supported only till cygwin version 1.7.9 Why is this a FIXME? I don't think there's anything we need to "fix" here. > Tools/Scripts/webkitdirs.pm:1495 > + my $currentCygwinVersion = version->parse(`uname -r`); > + my $minCygwinVersion = version->parse("1.7.10"); > + if ($currentCygwinVersion < $minCygwinVersion) { I didn't know about the version module! Seems less mysterious than using "v1.7.10" strings. I'd rename $minCygwinVersion to $firstCygwinVersionWithoutTTYVariable for clarity. 619742 13 vivekgalatage 2012-05-09 12:45:33 -0700 (In reply to comment #12) Thank you Adam for your review comments. > (From update of attachment 140997 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140997&action=review > > This is looking close! > > > Tools/ChangeLog:6 > > + Added check to support older versions of Cygwin 1.7.9 or lesser > > This doesn't really describe the entire change; it only describes the differences from the last version of your patch. > I will update the description. > > Tools/Scripts/webkitdirs.pm:1491 > > + # FIXME: The setting CYGWIN=tty is supported only till cygwin version 1.7.9 > > Why is this a FIXME? I don't think there's anything we need to "fix" here. > I thought as we move further, this check wouldn't be necessary so someday in future we can remove this altogether hence added FIXME > > Tools/Scripts/webkitdirs.pm:1495 > > + my $currentCygwinVersion = version->parse(`uname -r`); > > + my $minCygwinVersion = version->parse("1.7.10"); > > + if ($currentCygwinVersion < $minCygwinVersion) { > > I didn't know about the version module! Seems less mysterious than using "v1.7.10" strings. > > I'd rename $minCygwinVersion to $firstCygwinVersionWithoutTTYVariable for clarity. I will update the variable. 619743 14 aroben 2012-05-09 12:46:55 -0700 (In reply to comment #13) > (In reply to comment #12) > > (From update of attachment 140997 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=140997&action=review > > > Tools/Scripts/webkitdirs.pm:1491 > > > + # FIXME: The setting CYGWIN=tty is supported only till cygwin version 1.7.9 > > > > Why is this a FIXME? I don't think there's anything we need to "fix" here. > > > > I thought as we move further, this check wouldn't be necessary so someday in future we can remove this altogether hence added FIXME In that case, I'd phrase it like so: FIXME: We should remove this code entirely once we stop supporting Cygwin 1.7.9. That way it's actually saying what we should fix. 619758 15 141003 vivekgalatage 2012-05-09 13:02:42 -0700 Created attachment 141003 Patch 619759 16 141003 aroben 2012-05-09 13:04:13 -0700 Comment on attachment 141003 Patch Looks great! Thanks for pushing this to its current state. 619760 17 vivekgalatage 2012-05-09 13:05:31 -0700 (In reply to comment #16) > (From update of attachment 141003 [details]) > Looks great! Thanks for pushing this to its current state. Thank you too for your quick reviews, appreciated. 619877 18 141003 webkit.review.bot 2012-05-09 14:55:25 -0700 Comment on attachment 141003 Patch Clearing flags on attachment: 141003 Committed r116559: <http://trac.webkit.org/changeset/116559> 619878 19 webkit.review.bot 2012-05-09 14:55:31 -0700 All reviewed patches have been landed. Closing bug. 629504 20 141003 abarth 2012-05-21 14:33:41 -0700 Comment on attachment 141003 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141003&action=review > Tools/Scripts/webkitdirs.pm:32 > +use version; This line seems to have broken my use of build-webkit: Can't locate version.pm in @INC (@INC contains: /Users/abarth/svn/webkit/Tools/Scripts /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 .) at /Users/abarth/svn/webkit/Tools/Scripts/webkitdirs.pm line 32. Any ideas? 629508 21 abarth 2012-05-21 14:34:09 -0700 Note: I'm using a Lion. 629520 22 abarth 2012-05-21 14:40:13 -0700 I think this is because I'm using a MacPorts version of Perl. Probably means its a problem on my end. Thanks! 140511 2012-05-07 05:16:14 -0700 2012-05-09 12:24:22 -0700 Patch bug-85791-20120507174633.patch text/plain 1553 vivekgalatage SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExNjMwMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTA1LTA3ICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21h aWwuY29tPgorCisgICAgICAgIFJlbW92ZSBDWUdXSU49dHR5IGZyb20gZW52aXJvbm1lbnQgdmFy aWFibGUgYXMgaXRzIG5vIGxvbmdlciBzdXBwb3J0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NzkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ3lnd2luIGhhcyByZW1vdmVkIHN1cHBvcnQgZm9yIHRo ZSBDWUdXSU49dHR5IGVudmlyb25tZW50IHZhcmlhYmxlIGhlbmNlIHJlbW92ZWQgaXQuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChzZXR1cEFwcGxlV2luRW52 KToKKwogMjAxMi0wNS0wNyAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgW1F0XSBBZGQgdGVzdCBzcGVjaWZpYyBwbGF0Zm9ybSBwbHVnaW4gdG8gYWNoaWV2 ZSB1bmlmaWVkIGxheW91dCB0ZXN0IHJlc3VsdHMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0 ZGlycy5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJldmlz aW9uIDExNjI4NikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkod29ya2luZyBjb3B5 KQpAQCAtMTQ4MiwxMCArMTQ4Miw2IEBAIHN1YiBzZXR1cEFwcGxlV2luRW52KCkKICAgICAgICAg bXkgJHJlc3RhcnROZWVkZWQgPSAwOwogICAgICAgICBteSAldmFyaWFibGVzVG9TZXQgPSAoKTsK IAotICAgICAgICAjIFNldHRpbmcgdGhlIGVudmlyb25tZW50IHZhcmlhYmxlICdDWUdXSU4nIHRv ICd0dHknIG1ha2VzIGN5Z3dpbiBlbmFibGUgZXh0cmEgc3VwcG9ydCAoaS5lLiwgdGVybWlvcykK LSAgICAgICAgIyBmb3IgVU5JWC1saWtlIHR0eXMgaW4gdGhlIFdpbmRvd3MgY29uc29sZQotICAg ICAgICAkdmFyaWFibGVzVG9TZXR7Q1lHV0lOfSA9ICJ0dHkiIHVubGVzcyAkRU5We0NZR1dJTn07 Ci0gICAgICAgIAogICAgICAgICAjIFRob3NlIGVudmlyb25tZW50IHZhcmlhYmxlcyBtdXN0IGJl IHNldCB0byBiZSBhYmxlIHRvIGJ1aWxkIGluc2lkZSBWaXN1YWwgU3R1ZGlvLgogICAgICAgICAk dmFyaWFibGVzVG9TZXR7V0VCS0lUTElCUkFSSUVTRElSfSA9IHdpbmRvd3NMaWJyYXJpZXNEaXIo KSB1bmxlc3MgJEVOVntXRUJLSVRMSUJSQVJJRVNESVJ9OwogICAgICAgICAkdmFyaWFibGVzVG9T ZXR7V0VCS0lUT1VUUFVURElSfSA9IHdpbmRvd3NPdXRwdXREaXIoKSB1bmxlc3MgJEVOVntXRUJL SVRPVVRQVVRESVJ9Owo= 140997 2012-05-09 12:24:34 -0700 2012-05-09 13:02:33 -0700 Patch bug-85791-20120510005419.patch text/plain 2179 vivekgalatage SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExNjU0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTA1LTA5ICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21h aWwuY29tPgorCisgICAgICAgIFJlbW92ZSBDWUdXSU49dHR5IGZyb20gZW52aXJvbm1lbnQgdmFy aWFibGUgYXMgaXRzIG5vIGxvbmdlciBzdXBwb3J0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NzkxCisKKyAgICAgICAgQWRkZWQgY2hlY2sgdG8g c3VwcG9ydCBvbGRlciB2ZXJzaW9ucyBvZiBDeWd3aW4gMS43Ljkgb3IgbGVzc2VyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dGRpcnMucG06CisgICAgICAgIChzZXR1cEFwcGxlV2luRW52KToKKwogMjAxMi0wNS0wOSAgQ2hy aXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIFtF RkxdW0RSVF0gRUZMJ3MgRFJUIG5lZWRzIHRvIHN1cHBvcnQgTGF5b3V0VGVzdENvbnRyb2xsZXIu ZHVtcEljb25DaGFuZ2VzKCkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJldmlzaW9uIDExNjM4NykK KysrIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkod29ya2luZyBjb3B5KQpAQCAtMjksNiAr MjksNyBAQAogIyBNb2R1bGUgdG8gc2hhcmUgY29kZSB0byBnZXQgdG8gV2ViS2l0IGRpcmVjdG9y aWVzLgogCiB1c2Ugc3RyaWN0OwordXNlIHZlcnNpb247CiB1c2Ugd2FybmluZ3M7CiB1c2UgQ29u ZmlnOwogdXNlIERpZ2VzdDo6TUQ1IHF3KG1kNV9oZXgpOwpAQCAtMTQ4Nyw5ICsxNDg4LDE1IEBA IHN1YiBzZXR1cEFwcGxlV2luRW52KCkKICAgICAgICAgbXkgJHJlc3RhcnROZWVkZWQgPSAwOwog ICAgICAgICBteSAldmFyaWFibGVzVG9TZXQgPSAoKTsKIAotICAgICAgICAjIFNldHRpbmcgdGhl IGVudmlyb25tZW50IHZhcmlhYmxlICdDWUdXSU4nIHRvICd0dHknIG1ha2VzIGN5Z3dpbiBlbmFi bGUgZXh0cmEgc3VwcG9ydCAoaS5lLiwgdGVybWlvcykKLSAgICAgICAgIyBmb3IgVU5JWC1saWtl IHR0eXMgaW4gdGhlIFdpbmRvd3MgY29uc29sZQotICAgICAgICAkdmFyaWFibGVzVG9TZXR7Q1lH V0lOfSA9ICJ0dHkiIHVubGVzcyAkRU5We0NZR1dJTn07CisgICAgICAgICMgRklYTUU6IFRoZSBz ZXR0aW5nIENZR1dJTj10dHkgaXMgc3VwcG9ydGVkIG9ubHkgdGlsbCBjeWd3aW4gdmVyc2lvbiAx LjcuOQorICAgICAgICAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 NTc5MQorICAgICAgICBteSAkY3VycmVudEN5Z3dpblZlcnNpb24gPSB2ZXJzaW9uLT5wYXJzZShg dW5hbWUgLXJgKTsKKyAgICAgICAgbXkgJG1pbkN5Z3dpblZlcnNpb24gPSB2ZXJzaW9uLT5wYXJz ZSgiMS43LjEwIik7CisgICAgICAgIGlmICgkY3VycmVudEN5Z3dpblZlcnNpb24gPCAkbWluQ3ln d2luVmVyc2lvbikgeworICAgICAgICAgICAgIyBTZXR0aW5nIHRoZSBlbnZpcm9ubWVudCB2YXJp YWJsZSAnQ1lHV0lOJyB0byAndHR5JyBtYWtlcyBjeWd3aW4gZW5hYmxlIGV4dHJhIHN1cHBvcnQg KGkuZS4sIHRlcm1pb3MpCisgICAgICAgICAgICAjIGZvciBVTklYLWxpa2UgdHR5cyBpbiB0aGUg V2luZG93cyBjb25zb2xlCisgICAgICAgICAgICAkdmFyaWFibGVzVG9TZXR7Q1lHV0lOfSA9ICJ0 dHkiIHVubGVzcyAkRU5We0NZR1dJTn07CisgICAgICAgIH0KICAgICAgICAgCiAgICAgICAgICMg VGhvc2UgZW52aXJvbm1lbnQgdmFyaWFibGVzIG11c3QgYmUgc2V0IHRvIGJlIGFibGUgdG8gYnVp bGQgaW5zaWRlIFZpc3VhbCBTdHVkaW8uCiAgICAgICAgICR2YXJpYWJsZXNUb1NldHtXRUJLSVRM SUJSQVJJRVNESVJ9ID0gd2luZG93c0xpYnJhcmllc0RpcigpIHVubGVzcyAkRU5We1dFQktJVExJ QlJBUklFU0RJUn07Cg== 141003 2012-05-09 13:02:42 -0700 2012-05-21 14:33:41 -0700 Patch bug-85791-20120510013227.patch text/plain 2528 vivekgalatage SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExNjU0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDEyLTA1LTA5ICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21h aWwuY29tPgorCisgICAgICAgIFJlbW92ZSBDWUdXSU49dHR5IGZyb20gZW52aXJvbm1lbnQgdmFy aWFibGUgYXMgaXRzIG5vIGxvbmdlciBzdXBwb3J0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NzkxCisKKyAgICAgICAgVGhlIENZR1dJTj10dHkg ZW52aXJvbm1lbnQgdmFyaWFibGUgaXMgbm8gbG9uZ2VyIHN1cHBvcnRlZCBmcm9tIEN5Z3dpbgor ICAgICAgICB2ZXJzaW9uIDEuNy4xMC4gVGhpcyBmaXggYXZvaWRzIGFkZGl0aW9uIG9mIHRoaXMg ZW52aXJvbm1lbnQgdmFyaWFibGUKKyAgICAgICAgZm9yIEN5Z3dpbiB2ZXJzaW9ucyBncmVhdGVy IHRoYW4gMS43LjkuIEZvciBzdXBwb3J0aW5nIG9sZGVyIHZlcnNpb25zCisgICAgICAgIGkuZS4g MS43Ljkgb3Igb2xkZXIsIHRoZSBzY3JpcHQgdGFrZXMgY2FyZSBvZiByZXRhaW5pbmcgdGhlIGVu dmlyb25tZW50CisgICAgICAgIHZhcmlhYmxlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAo c2V0dXBBcHBsZVdpbkVudik6CisKIDIwMTItMDUtMDkgIENocmlzdG9waGUgRHVtZXogIDxjaHJp c3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtEUlRdIEVGTCdzIERSVCBu ZWVkcyB0byBzdXBwb3J0IExheW91dFRlc3RDb250cm9sbGVyLmR1bXBJY29uQ2hhbmdlcygpCklu ZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCShyZXZpc2lvbiAxMTYzODcpCisrKyBUb29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0JKHdvcmtpbmcgY29weSkKQEAgLTI5LDYgKzI5LDcgQEAKICMgTW9kdWxlIHRv IHNoYXJlIGNvZGUgdG8gZ2V0IHRvIFdlYktpdCBkaXJlY3Rvcmllcy4KIAogdXNlIHN0cmljdDsK K3VzZSB2ZXJzaW9uOwogdXNlIHdhcm5pbmdzOwogdXNlIENvbmZpZzsKIHVzZSBEaWdlc3Q6Ok1E NSBxdyhtZDVfaGV4KTsKQEAgLTE0ODcsOSArMTQ4OCwxNSBAQCBzdWIgc2V0dXBBcHBsZVdpbkVu digpCiAgICAgICAgIG15ICRyZXN0YXJ0TmVlZGVkID0gMDsKICAgICAgICAgbXkgJXZhcmlhYmxl c1RvU2V0ID0gKCk7CiAKLSAgICAgICAgIyBTZXR0aW5nIHRoZSBlbnZpcm9ubWVudCB2YXJpYWJs ZSAnQ1lHV0lOJyB0byAndHR5JyBtYWtlcyBjeWd3aW4gZW5hYmxlIGV4dHJhIHN1cHBvcnQgKGku ZS4sIHRlcm1pb3MpCi0gICAgICAgICMgZm9yIFVOSVgtbGlrZSB0dHlzIGluIHRoZSBXaW5kb3dz IGNvbnNvbGUKLSAgICAgICAgJHZhcmlhYmxlc1RvU2V0e0NZR1dJTn0gPSAidHR5IiB1bmxlc3Mg JEVOVntDWUdXSU59OworICAgICAgICAjIEZJWE1FOiBXZSBzaG91bGQgcmVtb3ZlIHRoaXMgZXhw bGljaXQgdmVyc2lvbiBjaGVjayBmb3IgY3lnd2luIG9uY2Ugd2Ugc3RvcCBzdXBwb3J0aW5nIEN5 Z3dpbiAxLjcuOSBvciBvbGRlciB2ZXJzaW9ucy4gCisgICAgICAgICMgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NzkxCisgICAgICAgIG15ICRjdXJyZW50Q3lnd2lu VmVyc2lvbiA9IHZlcnNpb24tPnBhcnNlKGB1bmFtZSAtcmApOworICAgICAgICBteSAkZmlyc3RD eWd3aW5WZXJzaW9uV2l0aG91dFRUWVN1cHBvcnQgPSB2ZXJzaW9uLT5wYXJzZSgiMS43LjEwIik7 CisgICAgICAgIGlmICgkY3VycmVudEN5Z3dpblZlcnNpb24gPCAkZmlyc3RDeWd3aW5WZXJzaW9u V2l0aG91dFRUWVN1cHBvcnQpIHsKKyAgICAgICAgICAgICMgU2V0dGluZyB0aGUgZW52aXJvbm1l bnQgdmFyaWFibGUgJ0NZR1dJTicgdG8gJ3R0eScgbWFrZXMgY3lnd2luIGVuYWJsZSBleHRyYSBz dXBwb3J0IChpLmUuLCB0ZXJtaW9zKQorICAgICAgICAgICAgIyBmb3IgVU5JWC1saWtlIHR0eXMg aW4gdGhlIFdpbmRvd3MgY29uc29sZQorICAgICAgICAgICAgJHZhcmlhYmxlc1RvU2V0e0NZR1dJ Tn0gPSAidHR5IiB1bmxlc3MgJEVOVntDWUdXSU59OworICAgICAgICB9CiAgICAgICAgIAogICAg ICAgICAjIFRob3NlIGVudmlyb25tZW50IHZhcmlhYmxlcyBtdXN0IGJlIHNldCB0byBiZSBhYmxl IHRvIGJ1aWxkIGluc2lkZSBWaXN1YWwgU3R1ZGlvLgogICAgICAgICAkdmFyaWFibGVzVG9TZXR7 V0VCS0lUTElCUkFSSUVTRElSfSA9IHdpbmRvd3NMaWJyYXJpZXNEaXIoKSB1bmxlc3MgJEVOVntX RUJLSVRMSUJSQVJJRVNESVJ9Owo=