85781 2012-05-07 01:39:26 -0700 Buildfix for buggy GCC 2012-05-07 04:42:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 1 ossy ossy eric hausmann kenneth ossy webkit.review.bot oldest_to_newest 617457 0 ossy 2012-05-07 01:39:26 -0700 After http://trac.webkit.org/changeset/116009 build started to fail on Qt Windows and on Qt ARM bots: In file included from ../../../../Source/WebCore/rendering/RenderBlock.cpp:25:0: ../../../../Source/WebCore/rendering/RenderBlock.h: In function 'void WebCore::RenderBlock::MarginInfo::_ZN7WebCore11RenderBlock10MarginInfo11clearMarginEv.clone.244(WebCore::LayoutUnit*, int*)': ../../../../Source/WebCore/rendering/RenderBlock.h:868:69: internal compiler error: in create_tmp_var, at gimplify.c:505 This change is absolutely innocent and it didn't change anything in this file. Unfortunately it is a crazy GCC bug triggered by this patch. 617459 1 140494 ossy 2012-05-07 01:42:58 -0700 Created attachment 140494 Patch 617482 2 140501 ossy 2012-05-07 03:24:25 -0700 Created attachment 140501 Patch 617522 3 140501 webkit.review.bot 2012-05-07 04:42:24 -0700 Comment on attachment 140501 Patch Clearing flags on attachment: 140501 Committed r116298: <http://trac.webkit.org/changeset/116298> 617523 4 webkit.review.bot 2012-05-07 04:42:40 -0700 All reviewed patches have been landed. Closing bug. 140494 2012-05-07 01:42:58 -0700 2012-05-07 03:24:18 -0700 Patch bug-85781-20120507104256.patch text/plain 1515 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Q1MjhkZWU4NjAyNzZk MWVlNTUzYTNiNGQ3NGMyMmJjNTczNzNlOC4uOWI2OWJjMmE4OWJlMzYyMDNhODRlYTQ4YmM2ODZk NDA5MmM2MzE1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTA3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgQnVpbGRmaXggZm9y IGJ1Z2d5IEdDQworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODU3ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5oOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxv Y2s6Ok1hcmdpbkluZm86OmNsZWFyTWFyZ2luKToKKwogMjAxMi0wNS0wNyAgQW50dGkgS29pdmlz dG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTE2MjM1KTogYnJv a2UgYSBsb3Qgb2YgdGVzdHMgb24gYWxsIGNocm9taXVtIGRlYnVnIGJvdHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKaW5kZXggMmY2ZjRiNmRlYjE0Mzk4ZGM4MTRlMmYwNmE0 MjY4NmYwNDJkMTUyZS4uMzBhODQ2NjNjOTRiMTE5ZTVjZWM0MjA5NDYxYzE4YTgwNzAxYjNhZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKQEAgLTg2NSw3ICs4NjUsNyBA QCBwcml2YXRlOgogCiAgICAgICAgIHZvaWQgc2V0QXRCZWZvcmVTaWRlT2ZCbG9jayhib29sIGIp IHsgbV9hdEJlZm9yZVNpZGVPZkJsb2NrID0gYjsgfQogICAgICAgICB2b2lkIHNldEF0QWZ0ZXJT aWRlT2ZCbG9jayhib29sIGIpIHsgbV9hdEFmdGVyU2lkZU9mQmxvY2sgPSBiOyB9Ci0gICAgICAg IHZvaWQgY2xlYXJNYXJnaW4oKSB7IG1fcG9zaXRpdmVNYXJnaW4gPSBtX25lZ2F0aXZlTWFyZ2lu ID0gMDsgfQorICAgICAgICB2b2lkIGNsZWFyTWFyZ2luKCkgeyBtX3Bvc2l0aXZlTWFyZ2luID0g MDsgbV9uZWdhdGl2ZU1hcmdpbiA9IDA7IH0KICAgICAgICAgdm9pZCBzZXRNYXJnaW5CZWZvcmVR dWlyayhib29sIGIpIHsgbV9tYXJnaW5CZWZvcmVRdWlyayA9IGI7IH0KICAgICAgICAgdm9pZCBz ZXRNYXJnaW5BZnRlclF1aXJrKGJvb2wgYikgeyBtX21hcmdpbkFmdGVyUXVpcmsgPSBiOyB9CiAg ICAgICAgIHZvaWQgc2V0RGV0ZXJtaW5lZE1hcmdpbkJlZm9yZVF1aXJrKGJvb2wgYikgeyBtX2Rl dGVybWluZWRNYXJnaW5CZWZvcmVRdWlyayA9IGI7IH0K 140501 2012-05-07 03:24:25 -0700 2012-05-07 04:42:24 -0700 Patch bug-85781-20120507032424.patch text/plain 1512 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODRkN2NlMTdhYjZkZTIx ZWNiYTA2N2JhODI3NDhhM2I1ZGJhMzlkYy4uZTkwOTNmNTdjYjY1Njg3YWRhZGU5ZmU4YWY1MDVl NGQyMTFkNTc2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTA3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgQnVpbGRmaXggZm9y IGJ1Z2d5IEdDQworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODU3ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5oOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxv Y2s6Ok1hcmdpbkluZm86OmNsZWFyTWFyZ2luKToKKwogMjAxMi0wNS0wNyAgQW50dGkgS29pdmlz dG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2ZXJ0IHRoZSBwcmV2aW91cy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKaW5kZXggMmY2ZjRiNmRlYjE0Mzk4ZGM4 MTRlMmYwNmE0MjY4NmYwNDJkMTUyZS4uMzg1OTQ0MmJlYzBmZmI5MDk0Y2E2NTU0MGZmYzZkODg2 NmFlMmMxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKQEAgLTg2NSw3 ICs4NjUsMTEgQEAgcHJpdmF0ZToKIAogICAgICAgICB2b2lkIHNldEF0QmVmb3JlU2lkZU9mQmxv Y2soYm9vbCBiKSB7IG1fYXRCZWZvcmVTaWRlT2ZCbG9jayA9IGI7IH0KICAgICAgICAgdm9pZCBz ZXRBdEFmdGVyU2lkZU9mQmxvY2soYm9vbCBiKSB7IG1fYXRBZnRlclNpZGVPZkJsb2NrID0gYjsg fQotICAgICAgICB2b2lkIGNsZWFyTWFyZ2luKCkgeyBtX3Bvc2l0aXZlTWFyZ2luID0gbV9uZWdh dGl2ZU1hcmdpbiA9IDA7IH0KKyAgICAgICAgdm9pZCBjbGVhck1hcmdpbigpCisgICAgICAgIHsK KyAgICAgICAgICAgIG1fcG9zaXRpdmVNYXJnaW4gPSAwOworICAgICAgICAgICAgbV9uZWdhdGl2 ZU1hcmdpbiA9IDA7CisgICAgICAgIH0KICAgICAgICAgdm9pZCBzZXRNYXJnaW5CZWZvcmVRdWly ayhib29sIGIpIHsgbV9tYXJnaW5CZWZvcmVRdWlyayA9IGI7IH0KICAgICAgICAgdm9pZCBzZXRN YXJnaW5BZnRlclF1aXJrKGJvb2wgYikgeyBtX21hcmdpbkFmdGVyUXVpcmsgPSBiOyB9CiAgICAg ICAgIHZvaWQgc2V0RGV0ZXJtaW5lZE1hcmdpbkJlZm9yZVF1aXJrKGJvb2wgYikgeyBtX2RldGVy bWluZWRNYXJnaW5CZWZvcmVRdWlyayA9IGI7IH0K