85779 2012-05-07 00:50:40 -0700 [CG] ImageBuffer::ImageDataToDataURL: Remove alpha stuffing when encoding to JPEG 2012-05-07 11:33:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noel.gordon noel.gordon eric kbr mitz thorton webkit.review.bot oldest_to_newest 617437 0 noel.gordon 2012-05-07 00:50:40 -0700 [CG] ImageBuffer::ImageDataToDataURL: Remove alpha stuffing when encoding to JPEG 617440 1 140489 noel.gordon 2012-05-07 01:02:26 -0700 Created attachment 140489 Patch 617754 2 140489 eric 2012-05-07 11:23:44 -0700 Comment on attachment 140489 Patch Looks right. 617772 3 140489 webkit.review.bot 2012-05-07 11:33:32 -0700 Comment on attachment 140489 Patch Clearing flags on attachment: 140489 Committed r116330: <http://trac.webkit.org/changeset/116330> 617773 4 webkit.review.bot 2012-05-07 11:33:37 -0700 All reviewed patches have been landed. Closing bug. 140489 2012-05-07 01:02:26 -0700 2012-05-07 11:33:32 -0700 Patch bug-85779-20120507180224.patch text/plain 4146 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2Mjc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmE2N2QxNzlkNTU2MDI5 NGY5YjU3NTI3ODg5MTMzZDI1NzMxZGRlNi4uMzA3OTFkYmE4ZGJmNjk4M2JlMDU1MDQyZjQwM2Fm MWU0NmM3N2RjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTA3ICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBbQ0ddIEltYWdlQnVm ZmVyOjpJbWFnZURhdGFUb0RhdGFVUkw6IFJlbW92ZSBhbHBoYSBzdHVmZmluZyB3aGVuIGVuY29k aW5nIHRvIEpQRUcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg1Nzc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTm8gY2hhbmdlIGluIGJlaGF2aW9yLiBDb3ZlcmVkIGJ5IGZhc3QvY2FudmFzL3dlYmdsL3By ZW11bHRpcGx5YWxwaGEtdGVzdC5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j Zy9JbWFnZUJ1ZmZlckNHLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRGF0YVRvRGF0YVVS TCk6IFJlbW92ZSB0aGUgbmVlZCB0byBzdHVmZiB0aGUgYWxwaGEgY2hhbm5lbCB3aXRoIDI1NS4K KyAgICAgICAgUmVuYW1lIGRhdGFWZWN0b3IgdG8gcHJlbXVsdGlwbGllZERhdGEgYW5kIHZlcmlm eSB0aGF0IGl0cyByZXNpemUoKSB3b3JrZWQuIFJld3JpdGUKKyAgICAgICAgdGhlIHByZW11bHRp cGxpY2F0aW9uIGxvb3Agd2l0aG91dCB0aGUgYWxwaGEgY2hhbm5lbCA9IDI1NSBwYXJ0IGFuZCBh c2sgdGhlIENHIEpQRUcKKyAgICAgICAgZW5jb2RlciB0byBpZ25vcmUgdGhlIGFscGhhIGNoYW5u ZWwgKGtDR0ltYWdlQWxwaGFOb25lU2tpcExhc3QpIGluc3RlYWQuCisKIDIwMTItMDUtMDYgIE1P UklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckNHLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0cuY3BwCmluZGV4IDMwZWNlMWVl MzM1ZTBkNTlhYzBkYmQ1N2NlZDUxNDVhOWE4ZDYzNjEuLjYxZDA0MjIxMDQ4ZjY4ZmM4NjQ5OGQ4 YWRlOTliMjJjZDlkNTllYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0cuY3BwCkBAIC00ODAsMzAgKzQ4MCwzMiBAQCBTdHJp bmcgSW1hZ2VEYXRhVG9EYXRhVVJMKGNvbnN0IEltYWdlRGF0YSYgc291cmNlLCBjb25zdCBTdHJp bmcmIG1pbWVUeXBlLCBjb25zdAogICAgIFJldGFpblB0cjxDRlN0cmluZ1JlZj4gdXRpID0gdXRp RnJvbU1JTUVUeXBlKG1pbWVUeXBlKTsKICAgICBBU1NFUlQodXRpKTsKIAorICAgIENHSW1hZ2VB bHBoYUluZm8gZGF0YUFscGhhSW5mbyA9IGtDR0ltYWdlQWxwaGFMYXN0OwogICAgIHVuc2lnbmVk IGNoYXIqIGRhdGEgPSBzb3VyY2UuZGF0YSgpLT5kYXRhKCk7Ci0gICAgVmVjdG9yPHVpbnQ4X3Q+ IGRhdGFWZWN0b3I7CisgICAgVmVjdG9yPHVpbnQ4X3Q+IHByZW11bHRpcGxpZWREYXRhOwogCiAg ICAgaWYgKENGRXF1YWwodXRpLmdldCgpLCBqcGVnVVRJKCkpKSB7CiAgICAgICAgIC8vIEpQRUdz IGRvbid0IGhhdmUgYW4gYWxwaGEgY2hhbm5lbCwgc28gd2UgaGF2ZSB0byBtYW51YWxseSBjb21w b3NpdGUgb24gdG9wIG9mIGJsYWNrLgotICAgICAgICBkYXRhVmVjdG9yLnJlc2l6ZSg0ICogc291 cmNlLndpZHRoKCkgKiBzb3VyY2UuaGVpZ2h0KCkpOwotICAgICAgICB1bnNpZ25lZCBjaGFyICpv dXQgPSBkYXRhVmVjdG9yLmRhdGEoKTsKLSAgICAgICAgCi0gICAgICAgIGZvciAoaW50IGkgPSAw OyBpIDwgc291cmNlLndpZHRoKCkgKiBzb3VyY2UuaGVpZ2h0KCk7IGkrKykgewotICAgICAgICAg ICAgLy8gTXVsdGlwbHkgY29sb3IgZGF0YSBieSBhbHBoYSwgYW5kIHNldCBhbHBoYSB0byAyNTUu Ci0gICAgICAgICAgICBpbnQgYWxwaGEgPSBkYXRhWzQgKiBpICsgM107CisgICAgICAgIHNpemVf dCBzaXplID0gNCAqIHNvdXJjZS53aWR0aCgpICogc291cmNlLmhlaWdodCgpOworICAgICAgICBp ZiAoIXByZW11bHRpcGxpZWREYXRhLnRyeVJlc2VydmVDYXBhY2l0eShzaXplKSkKKyAgICAgICAg ICAgIHJldHVybiAiZGF0YTosIjsKKworICAgICAgICB1bnNpZ25lZCBjaGFyICpidWZmZXIgPSBw cmVtdWx0aXBsaWVkRGF0YS5kYXRhKCk7CisgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwg c2l6ZTsgaSArPSA0KSB7CisgICAgICAgICAgICB1bnNpZ25lZCBhbHBoYSA9IGRhdGFbaSArIDNd OwogICAgICAgICAgICAgaWYgKGFscGhhICE9IDI1NSkgewotICAgICAgICAgICAgICAgIG91dFs0 ICogaSArIDBdID0gZGF0YVs0ICogaSArIDBdICogYWxwaGEgLyAyNTU7Ci0gICAgICAgICAgICAg ICAgb3V0WzQgKiBpICsgMV0gPSBkYXRhWzQgKiBpICsgMV0gKiBhbHBoYSAvIDI1NTsKLSAgICAg ICAgICAgICAgICBvdXRbNCAqIGkgKyAyXSA9IGRhdGFbNCAqIGkgKyAyXSAqIGFscGhhIC8gMjU1 OworICAgICAgICAgICAgICAgIGJ1ZmZlcltpICsgMF0gPSBkYXRhW2kgKyAwXSAqIGFscGhhIC8g MjU1OworICAgICAgICAgICAgICAgIGJ1ZmZlcltpICsgMV0gPSBkYXRhW2kgKyAxXSAqIGFscGhh IC8gMjU1OworICAgICAgICAgICAgICAgIGJ1ZmZlcltpICsgMl0gPSBkYXRhW2kgKyAyXSAqIGFs cGhhIC8gMjU1OwogICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICBvdXRbNCAq IGkgKyAwXSA9IGRhdGFbNCAqIGkgKyAwXTsKLSAgICAgICAgICAgICAgICBvdXRbNCAqIGkgKyAx XSA9IGRhdGFbNCAqIGkgKyAxXTsKLSAgICAgICAgICAgICAgICBvdXRbNCAqIGkgKyAyXSA9IGRh dGFbNCAqIGkgKyAyXTsKKyAgICAgICAgICAgICAgICBidWZmZXJbaSArIDBdID0gZGF0YVtpICsg MF07CisgICAgICAgICAgICAgICAgYnVmZmVyW2kgKyAxXSA9IGRhdGFbaSArIDFdOworICAgICAg ICAgICAgICAgIGJ1ZmZlcltpICsgMl0gPSBkYXRhW2kgKyAyXTsKICAgICAgICAgICAgIH0KLSAg ICAgICAgICAgIG91dFs0ICogaSArIDNdID0gMjU1OwogICAgICAgICB9CiAKLSAgICAgICAgZGF0 YSA9IG91dDsKKyAgICAgICAgZGF0YUFscGhhSW5mbyA9IGtDR0ltYWdlQWxwaGFOb25lU2tpcExh c3Q7IC8vIElnbm9yZSB0aGUgYWxwaGEgY2hhbm5lbC4KKyAgICAgICAgZGF0YSA9IHByZW11bHRp cGxpZWREYXRhLmRhdGEoKTsKICAgICB9CiAKICAgICBSZXRhaW5QdHI8Q0dEYXRhUHJvdmlkZXJS ZWY+IGRhdGFQcm92aWRlcjsKQEAgLTUxMyw3ICs1MTUsNyBAQCBTdHJpbmcgSW1hZ2VEYXRhVG9E YXRhVVJMKGNvbnN0IEltYWdlRGF0YSYgc291cmNlLCBjb25zdCBTdHJpbmcmIG1pbWVUeXBlLCBj b25zdAogCiAgICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+IGltYWdlOwogICAgIGltYWdlLmFkb3B0 Q0YoQ0dJbWFnZUNyZWF0ZShzb3VyY2Uud2lkdGgoKSwgc291cmNlLmhlaWdodCgpLCA4LCAzMiwg NCAqIHNvdXJjZS53aWR0aCgpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZXZp Y2VSR0JDb2xvclNwYWNlUmVmKCksIGtDR0JpdG1hcEJ5dGVPcmRlckRlZmF1bHQgfCBrQ0dJbWFn ZUFscGhhTGFzdCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGV2aWNlUkdCQ29s b3JTcGFjZVJlZigpLCBrQ0dCaXRtYXBCeXRlT3JkZXJEZWZhdWx0IHwgZGF0YUFscGhhSW5mbywK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGF0YVByb3ZpZGVyLmdldCgpLCAwLCBm YWxzZSwga0NHUmVuZGVyaW5nSW50ZW50RGVmYXVsdCkpOwogCiAgICAgcmV0dXJuIENHSW1hZ2VU b0RhdGFVUkwoaW1hZ2UuZ2V0KCksIG1pbWVUeXBlLCBxdWFsaXR5KTsK