85768 2012-05-06 20:11:58 -0700 [Chromium] Move sharedWorkerRepository to Platform.h 2012-12-11 12:54:47 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 104704 P2 Normal --- 95861 82948 1 pilgrim pilgrim abarth dglazkov fishd haraken jamesr tkent+wkapi webkit.review.bot oldest_to_newest 617322 0 pilgrim 2012-05-06 20:11:58 -0700 [Chromium] Move sharedWorkerRepository to Platform.h 617325 1 140463 pilgrim 2012-05-06 20:12:38 -0700 Created attachment 140463 Patch 617326 2 webkit.review.bot 2012-05-06 20:14:04 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 617342 3 140463 abarth 2012-05-06 20:49:27 -0700 Comment on attachment 140463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140463&action=review > Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:-63 > -class WebSharedWorkerRepository; // FIXME: Does this belong in platform? This one is tricky because WebSharedWorkerRepository depends on WebSharedWorker, which depends on a bunch of "non-platform" concepts (e.g., ScriptExecutionContext, ContentSecurityPolicy). It's likely this will need to move outside of the platform part of the API... We'd need to look more closely at where. 788695 4 pilgrim 2012-12-11 12:54:47 -0800 *** This bug has been marked as a duplicate of bug 104704 *** 140463 2012-05-06 20:12:38 -0700 2012-05-06 20:49:27 -0700 Patch bug-85768-20120506231154.patch text/plain 6698 pilgrim SW5kZXg6IFNvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1Bs YXRmb3JtL0NoYW5nZUxvZwkocmV2aXNpb24gMTE2MjYyKQorKysgU291cmNlL1BsYXRmb3JtL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTA2ICBNYXJr IFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIE1v dmUgc2hhcmVkV29ya2VyUmVwb3NpdG9yeSB0byBQbGF0Zm9ybS5oCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTc2OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhcnQgb2YgYSByZWZhY3RvcmluZyBzZXJp ZXMuIFNlZSB0cmFja2luZyBidWcgODI5NDguCisKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMv UGxhdGZvcm0uaDoKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChQbGF0Zm9ybSk6CisgICAg ICAgIChXZWJLaXQ6OlBsYXRmb3JtOjpzaGFyZWRXb3JrZXJSZXBvc2l0b3J5KToKKwogMjAxMi0w NS0wNCAgVG9tbXkgV2lkZW5mbHljaHQgIDx0b21teXdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBN ZWRpYVN0cmVhbSBBUEk6IE1ha2UgUGVlckNvbm5lY3Rpb24wMCdzIEFQSSBmdWxseSBjb21wbGlh bnQgd2l0aCB0aGUgZHJhZnQKSW5kZXg6IFNvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMv UGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGlj L1BsYXRmb3JtLmgJKHJldmlzaW9uIDExNjI1NSkKKysrIFNvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1 bS9wdWJsaWMvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtNDcsNiArNDcsNyBAQCBjbGFz cyBXZWJQZWVyQ29ubmVjdGlvbjAwSGFuZGxlcjsKIGNsYXNzIFdlYlBlZXJDb25uZWN0aW9uMDBI YW5kbGVyQ2xpZW50OwogY2xhc3MgV2ViUGVlckNvbm5lY3Rpb25IYW5kbGVyOwogY2xhc3MgV2Vi UGVlckNvbm5lY3Rpb25IYW5kbGVyQ2xpZW50OworY2xhc3MgV2ViU2hhcmVkV29ya2VyUmVwb3Np dG9yeTsgLy8gRklYTUU6IERvZXMgdGhpcyBiZWxvbmcgaW4gcGxhdGZvcm0/CiBjbGFzcyBXZWJV Ukw7CiBjbGFzcyBXZWJVUkxMb2FkZXI7CiBjbGFzcyBXZWJTb2NrZXRTdHJlYW1IYW5kbGU7CkBA IC0xMzQsNiArMTM1LDExIEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgY2FjaGVNZXRhZGF0 YShjb25zdCBXZWJVUkwmLCBkb3VibGUgcmVzcG9uc2VUaW1lLCBjb25zdCBjaGFyKiBkYXRhLCBz aXplX3QgZGF0YVNpemUpIHsgfQogCiAKKyAgICAvLyBTaGFyZWQgV29ya2VycyAtLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKworICAgIHZpcnR1 YWwgV2ViU2hhcmVkV29ya2VyUmVwb3NpdG9yeSogc2hhcmVkV29ya2VyUmVwb3NpdG9yeSgpIHsg cmV0dXJuIDA7IH0KKworCiAgICAgLy8gVGhyZWFkcyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKICAgICAvLyBDcmVhdGVzIGFuIGVtYmVk ZGVyLWRlZmluZWQgdGhyZWFkLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlz aW9uIDExNjI2MikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTItMDUtMDYgIE1hcmsgUGlsZ3JpbSAgPHBpbGdy aW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gTW92ZSBzaGFyZWRXb3JrZXJS ZXBvc2l0b3J5IHRvIFBsYXRmb3JtLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg1NzY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUGFydCBvZiBhIHJlZmFjdG9yaW5nIHNlcmllcy4gU2VlIHRyYWNraW5n IGJ1ZyA4Mjk0OC4KKworICAgICAgICAqIHB1YmxpYy9wbGF0Zm9ybS9XZWJLaXRQbGF0Zm9ybVN1 cHBvcnQuaDoKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChXZWJLaXRQbGF0Zm9ybVN1cHBv cnQpOgorICAgICAgICAqIHNyYy9TaGFyZWRXb3JrZXJSZXBvc2l0b3J5LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlNoYXJlZFdvcmtlclJlcG9zaXRvcnk6OmlzQXZhaWxhYmxlKToKKyAgICAgICAg KFdlYkNvcmU6OlNoYXJlZFdvcmtlclJlcG9zaXRvcnk6OmNvbm5lY3QpOgorICAgICAgICAoV2Vi Q29yZTo6U2hhcmVkV29ya2VyUmVwb3NpdG9yeTo6ZG9jdW1lbnREZXRhY2hlZCk6CisgICAgICAg IChXZWJDb3JlOjpTaGFyZWRXb3JrZXJSZXBvc2l0b3J5OjpoYXNTaGFyZWRXb3JrZXJzKToKKwog MjAxMi0wNS0wNiAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAg ICBbY2hyb21pdW1dIEFkZCBXZWJLaXQgQVBJIHRvIGFjY2VzcyBtdWx0aXBsZSBhdHRyaWJ1dGUg b2YgaW5wdXQgZWxlbWVudApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvcGxh dGZvcm0vV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvcGxhdGZvcm0vV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgJKHJldmlz aW9uIDExNjI1NSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL3BsYXRmb3JtL1dl YktpdFBsYXRmb3JtU3VwcG9ydC5oCSh3b3JraW5nIGNvcHkpCkBAIC02MCw3ICs2MCw2IEBAIGNs YXNzIFdlYklEQktleTsgLy8gRklYTUU6IERvZXMgdGhpcyBiZWwKIGNsYXNzIFdlYk1lc3NhZ2VQ b3J0Q2hhbm5lbDsgLy8gRklYTUU6IERvZXMgdGhpcyBiZWxvbmcgaW4gcGxhdGZvcm0/CiBjbGFz cyBXZWJQbHVnaW5MaXN0QnVpbGRlcjsgLy8gRklYTUU6IERvZXMgdGhpcyBiZWxvbmcgaW4gcGxh dGZvcm0/CiBjbGFzcyBXZWJTYW5kYm94U3VwcG9ydDsKLWNsYXNzIFdlYlNoYXJlZFdvcmtlclJl cG9zaXRvcnk7IC8vIEZJWE1FOiBEb2VzIHRoaXMgYmVsb25nIGluIHBsYXRmb3JtPwogY2xhc3Mg V2ViU3RvcmFnZU5hbWVzcGFjZTsgLy8gRklYTUU6IERvZXMgdGhpcyBiZWxvbmcgaW4gcGxhdGZv cm0/CiBjbGFzcyBXZWJUaGVtZUVuZ2luZTsKIGNsYXNzIFdlYldvcmtlclJ1bkxvb3A7CkBAIC0x NTksMTAgKzE1OCw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIFdlYlN0cmluZyBxdWVyeUxvY2Fs aXplZFN0cmluZyhXZWJMb2NhbGl6ZWRTdHJpbmc6Ok5hbWUsIGNvbnN0IFdlYlN0cmluZyYgcGFy YW1ldGVyMSwgY29uc3QgV2ViU3RyaW5nJiBwYXJhbWV0ZXIyKSB7IHJldHVybiBXZWJTdHJpbmco KTsgfQogCiAKLSAgICAvLyBTaGFyZWQgV29ya2VycyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KLQotICAgIHZpcnR1YWwgV2ViU2hhcmVkV29y a2VyUmVwb3NpdG9yeSogc2hhcmVkV29ya2VyUmVwb3NpdG9yeSgpIHsgcmV0dXJuIDA7IH0KLQog ICAgIC8vIEdQVSAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tCiAgICAgLy8KICAgICAvLyBNYXkgcmV0dXJuIG51bGwgaWYgR1BV IGlzIG5vdCBzdXBwb3J0ZWQuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9TaGFy ZWRXb3JrZXJSZXBvc2l0b3J5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9TaGFyZWRXb3JrZXJSZXBvc2l0b3J5LmNwcAkocmV2aXNpb24gMTE2MjU1KQorKysg U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvU2hhcmVkV29ya2VyUmVwb3NpdG9yeS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTUwLDEyICs1MCwxMyBAQAogI2luY2x1ZGUgIldlYk1lc3NhZ2VQb3J0 Q2hhbm5lbC5oIgogI2luY2x1ZGUgIldlYlNoYXJlZFdvcmtlci5oIgogI2luY2x1ZGUgIldlYlNo YXJlZFdvcmtlclJlcG9zaXRvcnkuaCIKLSNpbmNsdWRlICJwbGF0Zm9ybS9XZWJLaXRQbGF0Zm9y bVN1cHBvcnQuaCIKICNpbmNsdWRlICJwbGF0Zm9ybS9XZWJTdHJpbmcuaCIKICNpbmNsdWRlICJw bGF0Zm9ybS9XZWJVUkwuaCIKICNpbmNsdWRlICJXb3JrZXJTY3JpcHRMb2FkZXIuaCIKICNpbmNs dWRlICJXb3JrZXJTY3JpcHRMb2FkZXJDbGllbnQuaCIKIAorI2luY2x1ZGUgPHB1YmxpYy9QbGF0 Zm9ybS5oPgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIERvY3VtZW50OwpAQCAtMTkz LDcgKzE5NCw3IEBAIHZvaWQgU2hhcmVkV29ya2VyU2NyaXB0TG9hZGVyOjpjb25uZWN0ZWQKIGJv b2wgU2hhcmVkV29ya2VyUmVwb3NpdG9yeTo6aXNBdmFpbGFibGUoKQogewogICAgIC8vIEFsbG93 IHRoZSBXZWJLaXRQbGF0Zm9ybVN1cHBvcnQgdG8gZGV0ZXJtaW5lIGlmIFNoYXJlZFdvcmtlcnMg YXJlIGF2YWlsYWJsZS4KLSAgICByZXR1cm4gV2ViS2l0Ojp3ZWJLaXRQbGF0Zm9ybVN1cHBvcnQo KS0+c2hhcmVkV29ya2VyUmVwb3NpdG9yeSgpOworICAgIHJldHVybiBXZWJLaXQ6OlBsYXRmb3Jt OjpjdXJyZW50KCktPnNoYXJlZFdvcmtlclJlcG9zaXRvcnkoKTsKIH0KIAogc3RhdGljIFdlYlNo YXJlZFdvcmtlclJlcG9zaXRvcnk6OkRvY3VtZW50SUQgZ2V0SWQodm9pZCogZG9jdW1lbnQpCkBA IC0yMDYsNyArMjA3LDcgQEAgdm9pZCBTaGFyZWRXb3JrZXJSZXBvc2l0b3J5Ojpjb25uZWN0KFBh cwogewogICAgIC8vIFRoaXMgc2hvdWxkIG5vdCBiZSBjYWxsYWJsZSB1bmxlc3MgdGhlcmUncyBh IFNoYXJlZFdvcmtlclJlcG9zaXRvcnkgZm9yCiAgICAgLy8gdGhpcyBjb250ZXh0IChzaW5jZSBp c0F2YWlsYWJsZSgpIHNob3VsZCBoYXZlIHJldHVybmVkIG51bGwpLgotICAgIEFTU0VSVChXZWJL aXQ6OndlYktpdFBsYXRmb3JtU3VwcG9ydCgpLT5zaGFyZWRXb3JrZXJSZXBvc2l0b3J5KCkpOwor ICAgIEFTU0VSVChXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCktPnNoYXJlZFdvcmtlclJlcG9z aXRvcnkoKSk7CiAKICAgICAvLyBObyBuZXN0ZWQgd29ya2VycyAoZm9yIG5vdykgLSBjb25uZWN0 KCkgc2hvdWxkIG9ubHkgYmUgY2FsbGVkIGZyb20gZG9jdW1lbnQgY29udGV4dC4KICAgICBBU1NF UlQod29ya2VyLT5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCktPmlzRG9jdW1lbnQoKSk7CkBAIC0y MjEsNyArMjIyLDcgQEAgdm9pZCBTaGFyZWRXb3JrZXJSZXBvc2l0b3J5Ojpjb25uZWN0KFBhcwog ICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgV2ViS2l0Ojp3ZWJLaXRQbGF0Zm9ybVN1cHBv cnQoKS0+c2hhcmVkV29ya2VyUmVwb3NpdG9yeSgpLT5hZGRTaGFyZWRXb3JrZXIoCisgICAgV2Vi S2l0OjpQbGF0Zm9ybTo6Y3VycmVudCgpLT5zaGFyZWRXb3JrZXJSZXBvc2l0b3J5KCktPmFkZFNo YXJlZFdvcmtlcigKICAgICAgICAgd2ViV29ya2VyLmdldCgpLCBnZXRJZChkb2N1bWVudCkpOwog CiAgICAgLy8gVGhlIGxvYWRlciBvYmplY3QgbWFuYWdlcyBpdHMgb3duIGxpZmVjeWNsZSAoYW5k IHRoZSBsaWZlY3ljbGVzIG9mIHRoZSB0d28gd29ya2VyIG9iamVjdHMpLgpAQCAtMjMyLDcgKzIz Myw3IEBAIHZvaWQgU2hhcmVkV29ya2VyUmVwb3NpdG9yeTo6Y29ubmVjdChQYXMKIAogdm9pZCBT aGFyZWRXb3JrZXJSZXBvc2l0b3J5Ojpkb2N1bWVudERldGFjaGVkKERvY3VtZW50KiBkb2N1bWVu dCkKIHsKLSAgICBXZWJTaGFyZWRXb3JrZXJSZXBvc2l0b3J5KiByZXBvID0gV2ViS2l0Ojp3ZWJL aXRQbGF0Zm9ybVN1cHBvcnQoKS0+c2hhcmVkV29ya2VyUmVwb3NpdG9yeSgpOworICAgIFdlYlNo YXJlZFdvcmtlclJlcG9zaXRvcnkqIHJlcG8gPSBXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCkt PnNoYXJlZFdvcmtlclJlcG9zaXRvcnkoKTsKICAgICBpZiAocmVwbykKICAgICAgICAgcmVwby0+ ZG9jdW1lbnREZXRhY2hlZChnZXRJZChkb2N1bWVudCkpOwogCkBAIC0yNDMsNyArMjQ0LDcgQEAg dm9pZCBTaGFyZWRXb3JrZXJSZXBvc2l0b3J5Ojpkb2N1bWVudERldAogCiBib29sIFNoYXJlZFdv cmtlclJlcG9zaXRvcnk6Omhhc1NoYXJlZFdvcmtlcnMoRG9jdW1lbnQqIGRvY3VtZW50KQogewot ICAgIFdlYlNoYXJlZFdvcmtlclJlcG9zaXRvcnkqIHJlcG8gPSBXZWJLaXQ6OndlYktpdFBsYXRm b3JtU3VwcG9ydCgpLT5zaGFyZWRXb3JrZXJSZXBvc2l0b3J5KCk7CisgICAgV2ViU2hhcmVkV29y a2VyUmVwb3NpdG9yeSogcmVwbyA9IFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQoKS0+c2hhcmVk V29ya2VyUmVwb3NpdG9yeSgpOwogICAgIHJldHVybiByZXBvICYmIHJlcG8tPmhhc1NoYXJlZFdv cmtlcnMoZ2V0SWQoZG9jdW1lbnQpKTsKIH0KIAo=