85767 2012-05-06 20:03:18 -0700 [Chromium] Move createOffscreenGraphicsContext3D to Platform.h 2012-11-28 10:47:26 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82948 1 pilgrim pilgrim abarth dglazkov fishd haraken jamesr tkent+wkapi webkit.review.bot oldest_to_newest 617315 0 pilgrim 2012-05-06 20:03:18 -0700 [Chromium] Move createOffscreenGraphicsContext3D to Platform.h 617317 1 140461 pilgrim 2012-05-06 20:04:29 -0700 Created attachment 140461 Patch 617319 2 webkit.review.bot 2012-05-06 20:06:41 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 617341 3 140461 abarth 2012-05-06 20:46:13 -0700 Comment on attachment 140461 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140461&action=review > Source/Platform/chromium/public/Platform.h:44 > +class WebGraphicsContext3D; We shouldn't need the forward declaration given that we're including WebGraphicsContext3D.h 617842 4 140461 jamesr 2012-05-07 12:53:07 -0700 Comment on attachment 140461 Patch Nice! Thanks for doing this, Mark. 778057 5 pilgrim 2012-11-28 10:47:14 -0800 Appears to have been fixed in another bug, can't find the reference. 140461 2012-05-06 20:04:29 -0700 2012-11-28 10:47:26 -0800 Patch bug-85767-20120506230345.patch text/plain 5110 pilgrim SW5kZXg6IFNvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1Bs YXRmb3JtL0NoYW5nZUxvZwkocmV2aXNpb24gMTE2MjYyKQorKysgU291cmNlL1BsYXRmb3JtL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTA2ICBNYXJr IFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIE1v dmUgY3JlYXRlT2Zmc2NyZWVuR3JhcGhpY3NDb250ZXh0M0QgdG8gUGxhdGZvcm0uaAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU3NjcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXJ0IG9mIGEgcmVmYWN0 b3Jpbmcgc2VyaWVzLiBTZWUgdHJhY2tpbmcgYnVnIDgyOTQ4LgorCisgICAgICAgICogY2hyb21p dW0vcHVibGljL1BsYXRmb3JtLmg6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAoUGxhdGZv cm0pOgorICAgICAgICAoV2ViS2l0OjpQbGF0Zm9ybTo6Y3JlYXRlT2Zmc2NyZWVuR3JhcGhpY3ND b250ZXh0M0QpOgorCiAyMDEyLTA1LTA0ICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29n bGUuY29tPgogCiAgICAgICAgIE1lZGlhU3RyZWFtIEFQSTogTWFrZSBQZWVyQ29ubmVjdGlvbjAw J3MgQVBJIGZ1bGx5IGNvbXBsaWFudCB3aXRoIHRoZSBkcmFmdApJbmRleDogU291cmNlL1BsYXRm b3JtL2Nocm9taXVtL3B1YmxpYy9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9QbGF0 Zm9ybS9jaHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0uaAkocmV2aXNpb24gMTE2MjU1KQorKysgU291 cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBA IC0zNSwxMSArMzUsMTMgQEAKICNpbmNsdWRlICJXZWJDb21tb24uaCIKICNpbmNsdWRlICJXZWJE YXRhLmgiCiAjaW5jbHVkZSAiV2ViR2FtZXBhZHMuaCIKKyNpbmNsdWRlICJXZWJHcmFwaGljc0Nv bnRleHQzRC5oIgogI2luY2x1ZGUgIldlYlN0cmluZy5oIgogCiBuYW1lc3BhY2UgV2ViS2l0IHsK IAogY2xhc3MgV2ViQXVkaW9CdXM7CitjbGFzcyBXZWJHcmFwaGljc0NvbnRleHQzRDsKIGNsYXNz IFdlYk1lZGlhU3RyZWFtQ2VudGVyOwogY2xhc3MgV2ViTWVkaWFTdHJlYW1DZW50ZXJDbGllbnQ7 CiBjbGFzcyBXZWJNaW1lUmVnaXN0cnk7CkBAIC03NCw2ICs3NiwxMyBAQCBwdWJsaWM6CiAgICAg dmlydHVhbCB2b2lkIHNhbXBsZUdhbWVwYWRzKFdlYkdhbWVwYWRzJiBpbnRvKSB7IGludG8ubGVu Z3RoID0gMDsgfQogCiAKKyAgICAvLyBHUFUgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorICAgIC8vCisgICAgLy8gTWF5IHJl dHVybiBudWxsIGlmIEdQVSBpcyBub3Qgc3VwcG9ydGVkLgorICAgIC8vIFJldHVybnMgbmV3bHkg YWxsb2NhdGVkIGFuZCBpbml0aWFsaXplZCBvZmZzY3JlZW4gV2ViR3JhcGhpY3NDb250ZXh0M0Qg aW5zdGFuY2UuCisgICAgdmlydHVhbCBXZWJHcmFwaGljc0NvbnRleHQzRCogY3JlYXRlT2Zmc2Ny ZWVuR3JhcGhpY3NDb250ZXh0M0QoY29uc3QgV2ViR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0 ZXMmKSB7IHJldHVybiAwOyB9CisKKwogICAgIC8vIEhpc3RvcnkgLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiAgICAgLy8gUmV0 dXJucyB0aGUgaGFzaCBmb3IgdGhlIGdpdmVuIGNhbm9uaWNhbGl6ZWQgVVJMIGZvciB1c2UgaW4g dmlzaXRlZApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNjI2MikK KysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTItMDUtMDYgIE1hcmsgUGlsZ3JpbSAgPHBpbGdyaW1AY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gTW92ZSBjcmVhdGVPZmZzY3JlZW5HcmFwaGljc0Nv bnRleHQzRCB0byBQbGF0Zm9ybS5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04NTc2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFBhcnQgb2YgYSByZWZhY3RvcmluZyBzZXJpZXMuIFNlZSB0cmFja2luZyBi dWcgODI5NDguCisKKyAgICAgICAgKiBwdWJsaWMvcGxhdGZvcm0vV2ViS2l0UGxhdGZvcm1TdXBw b3J0Lmg6CisgICAgICAgIChXZWJLaXRQbGF0Zm9ybVN1cHBvcnQpOgorICAgICAgICAqIHNyYy9H cmFwaGljc0NvbnRleHQzRENocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNz Q29udGV4dDNEOjpjcmVhdGUpOgorCiAyMDEyLTA1LTA2ICBLZWlzaGkgSGF0dG9yaSAgPGtlaXNo aUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQWRkIFdlYktpdCBBUEkgdG8gYWNj ZXNzIG11bHRpcGxlIGF0dHJpYnV0ZSBvZiBpbnB1dCBlbGVtZW50CkluZGV4OiBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9wbGF0Zm9ybS9XZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9wbGF0Zm9ybS9XZWJLaXRQ bGF0Zm9ybVN1cHBvcnQuaAkocmV2aXNpb24gMTE2MjU1KQorKysgU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvcGxhdGZvcm0vV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgJKHdvcmtpbmcgY29w eSkKQEAgLTMzLDcgKzMzLDYgQEAKIAogI2luY2x1ZGUgIi4uL1dlYklEQktleVBhdGguaCIgLy8g RklYTUU6IFJlbW92ZSB3aXRoOiBodHRwOi8vd2Via2l0Lm9yZy9iLzg0MjA3CiAjaW5jbHVkZSAi V2ViQ29tbW9uLmgiCi0jaW5jbHVkZSAiV2ViR3JhcGhpY3NDb250ZXh0M0QuaCIKICNpbmNsdWRl ICJXZWJMb2NhbGl6ZWRTdHJpbmcuaCIKICNpbmNsdWRlICJXZWJTZXJpYWxpemVkU2NyaXB0VmFs dWUuaCIKICNpbmNsdWRlICJXZWJTdHJpbmcuaCIKQEAgLTE2NCwxMCArMTYzLDYgQEAgcHVibGlj OgogICAgIHZpcnR1YWwgV2ViU2hhcmVkV29ya2VyUmVwb3NpdG9yeSogc2hhcmVkV29ya2VyUmVw b3NpdG9yeSgpIHsgcmV0dXJuIDA7IH0KIAogICAgIC8vIEdQVSAtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCi0gICAgLy8KLSAg ICAvLyBNYXkgcmV0dXJuIG51bGwgaWYgR1BVIGlzIG5vdCBzdXBwb3J0ZWQuCi0gICAgLy8gUmV0 dXJucyBuZXdseSBhbGxvY2F0ZWQgYW5kIGluaXRpYWxpemVkIG9mZnNjcmVlbiBXZWJHcmFwaGlj c0NvbnRleHQzRCBpbnN0YW5jZS4KLSAgICB2aXJ0dWFsIFdlYkdyYXBoaWNzQ29udGV4dDNEKiBj cmVhdGVPZmZzY3JlZW5HcmFwaGljc0NvbnRleHQzRChjb25zdCBXZWJHcmFwaGljc0NvbnRleHQz RDo6QXR0cmlidXRlcyYpIHsgcmV0dXJuIDA7IH0KIAogICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB0 aGUgcGxhdGZvcm0gaXMgY2FwYWJsZSBvZiBwcm9kdWNpbmcgYW4gb2Zmc2NyZWVuIGNvbnRleHQg c3VpdGFibGUgZm9yIGFjY2VsZXJhdGluZyAyZCBjYW52YXMuCiAgICAgLy8gVGhpcyB3aWxsIHJl dHVybiBmYWxzZSBpZiB0aGUgcGxhdGZvcm0gY2Fubm90IHByb21pc2UgdGhhdCBjb250ZXh0cyB3 aWxsIGJlIHByZXNlcnZlZCBhY3Jvc3Mgb3BlcmF0aW9ucyBsaWtlCkluZGV4OiBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVtLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVt LmNwcAkocmV2aXNpb24gMTE2MjU1KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvR3Jh cGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDggKzQ5LDgg QEAKICNpbmNsdWRlICJXZWJWaWV3Q2xpZW50LmgiCiAjaW5jbHVkZSAiV2ViVmlld0ltcGwuaCIK ICNpbmNsdWRlICJwbGF0Zm9ybS9XZWJHcmFwaGljc0NvbnRleHQzRC5oIgotI2luY2x1ZGUgInBs YXRmb3JtL1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oIgogCisjaW5jbHVkZSA8cHVibGljL1BsYXRm b3JtLmg+CiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRlIDx3dGYvRmFzdE1hbGxvYy5oPgog I2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KQEAgLTEwNDMsNyArMTA0Myw3IEBAIFBhc3NS ZWZQdHI8R3JhcGhpY3NDb250ZXh0M0Q+IEdyYXBoaWNzQ28KICAgICB3ZWJBdHRyaWJ1dGVzLnNo YXJlUmVzb3VyY2VzID0gYXR0cnMuc2hhcmVSZXNvdXJjZXM7CiAgICAgd2ViQXR0cmlidXRlcy5w cmVmZXJEaXNjcmV0ZUdQVSA9IGF0dHJzLnByZWZlckRpc2NyZXRlR1BVOwogCi0gICAgT3duUHRy PFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0Q+IHdlYkNvbnRleHQgPSBhZG9wdFB0cihXZWJL aXQ6OndlYktpdFBsYXRmb3JtU3VwcG9ydCgpLT5jcmVhdGVPZmZzY3JlZW5HcmFwaGljc0NvbnRl eHQzRCh3ZWJBdHRyaWJ1dGVzKSk7CisgICAgT3duUHRyPFdlYktpdDo6V2ViR3JhcGhpY3NDb250 ZXh0M0Q+IHdlYkNvbnRleHQgPSBhZG9wdFB0cihXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCkt PmNyZWF0ZU9mZnNjcmVlbkdyYXBoaWNzQ29udGV4dDNEKHdlYkF0dHJpYnV0ZXMpKTsKICAgICBp ZiAoIXdlYkNvbnRleHQpCiAgICAgICAgIHJldHVybiAwOwogCg==