85746 2012-05-06 14:19:10 -0700 Add values for all features to Qt's features.pri 2012-05-07 04:12:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85611 85456 1 eric eric ossy vestbo webkit.review.bot oldest_to_newest 617164 0 eric 2012-05-06 14:19:10 -0700 Add values for all features to Qt's features.pri 617165 1 140434 eric 2012-05-06 14:23:03 -0700 Created attachment 140434 Patch 617166 2 eric 2012-05-06 14:24:46 -0700 I would like someone with knowledge of the Qt port to review this and make sure that I'm not disabling any features Qt actually wants on. It's important that we get this list correct, as this is a representation of what will appear in Features.py (and thus be used to generate the defaults for build-webkit --help, etc.) You can see the current Features.py listed here: https://github.com/eseidel/webkit/compare/master...features 617168 3 eric 2012-05-06 14:28:23 -0700 I can also tweak the PRI-generator to not output values for features which are disabled... but I'd rather stick with a full list if that's compatible with how the Qt build system works. This list of enable/disables would ideally be "policy-level" decisions -- features which the "qt port" believes should be on/off. Individual builders of the Qt port can of course modify this list (as presumably folks do), but in my vision this list (as well as the Features.py list) should be the high-level view of what "should be" on vs. off. 617169 4 eric 2012-05-06 14:29:00 -0700 Anyway, I very much welcome your feedback, and do not wish to presume too much about the workings of your build system. Let me know if this can work for you. :) 617493 5 140434 vestbo 2012-05-07 03:56:08 -0700 Comment on attachment 140434 Patch The patch looks good! Having an exhaustive list in features.pri is fine, the way things work right now is that we: 1. Parse command line options (that as passed to qmake from build-webkit, eg --enable-foo turns into DEFINES+=ENABLE_FOO=1 2. Do dynamic feature checking based on optional dependencies (which might add eg, ENABLE_VIDEO=1 to DEFINES, if the right libs are available). 3. Fill in any un-set features from the defaults in features.pri This is a bit reverse, but that' just how it has to be done right now due to qmake weirdness :) So basically, if the dynamic check for eg. video fails, it will then end up using the default in features.pri, which is ENABLE_VIDEO=0, since it's off by default. So for the Qt port (and Chromium) the list in Features.py really is a tri-state (on/off/auto), with off/auto baked into one. I think that's fine as long as the list in Features.py is not be used to say "oh, no port has this feature enabled, we can remove it", since we might actually enable it dynamically. So perhaps the script should have some sort of warning about making decisions solely based on the output of the script? 617502 6 140434 webkit.review.bot 2012-05-07 04:12:25 -0700 Comment on attachment 140434 Patch Clearing flags on attachment: 140434 Committed r116294: <http://trac.webkit.org/changeset/116294> 617503 7 webkit.review.bot 2012-05-07 04:12:37 -0700 All reviewed patches have been landed. Closing bug. 140434 2012-05-06 14:23:03 -0700 2012-05-07 04:12:24 -0700 Patch bug-85746-20120506142302.patch text/plain 3828 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MjM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWY1MDMzNTVmNjhhMjhiYjYzMjUxOTM0MzYyZmZmMDVi Nzk0OWRkNS4uN2JiNzAzZTM4ZGIwZTkxZGE2N2EzYzAxM2Y3Yzk5Y2VmZmUxY2E5YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA1LTA2ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBBZGQgdmFsdWVzIGZvciBhbGwgZmVhdHVyZXMgdG8gUXQncyBmZWF0dXJlcy5wcmkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NzQ2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBnZW5lcmF0ZS1m ZWF0dXJlLWZpbGVzIGdlbmVyYXRlcyBmZWF0dXJlcy5wcmkgaXQgcHJvdmlkZXMgYSB2YWx1ZQor ICAgICAgICBmb3IgZXZlcnkgcG9zc2libGUgRU5BQkxFXy4gIEluIHByZXByYXRpb24gZm9yIGxh bmRpbmcgZ2VuZXJhdGUtZmVhdHVyZS1maWxlcworICAgICAgICBpdCBzZWVtcyBhcHByb3ByaWF0 ZSB0byBhZGQgYSB2YWx1ZSBmb3IgYWxsIHBvc3NpYmxlIEVOQUJMRXMgdG8gdGhlIGV4aXN0aW5n CisgICAgICAgIGZlYXR1cmVzLnByaS4gIFRoaXMgbGV0cyBtZSBtYWtlIHN1cmUgdGhhdCBJJ20g Z2V0dGluZyB0aGVtIGFsbCByaWdodCEKKworICAgICAgICAqIHFtYWtlL21rc3BlY3MvZmVhdHVy ZXMvZmVhdHVyZXMucHJpOgorCiAyMDEyLTA1LTAyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0 Lm9yZz4KIAogICAgICAgICBXZWJLaXQgc2hvdWxkIGhhdmUgYW4gZWFzeSB3YXkgdG8gYWRkL3Jl bW92ZSBGRUFUVVJFX0RFRklORVMgZm9yIGFsbCBwb3J0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvcW1h a2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmkgYi9Ub29scy9xbWFrZS9ta3NwZWNzL2Zl YXR1cmVzL2ZlYXR1cmVzLnByaQppbmRleCAwMGFkODI5MzA0YmEwNDZjMjQ0Y2QzMmM3N2YyNDdj Yzk2OGVmYTJjLi5mNTgxYTBjNjVmN2NlYTcwNTg3MjVlY2U4OGU3Njk2MTYzN2NiNmE2IDEwMDY0 NAotLS0gYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2ZlYXR1cmVzLnByaQorKysgYi9U b29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2ZlYXR1cmVzLnByaQpAQCAtMTQsMTQgKzE0LDI0 IEBACiAKIEZFQVRVUkVfREVGQVVMVFMgPSBcCiAgICAgRU5BQkxFXzNEX1JFTkRFUklORz0xIFwK KyAgICBFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTPTAgXAogICAgIEVOQUJMRV9BTklNQVRJ T05fQVBJPTAgXAorICAgIEVOQUJMRV9CQVRURVJZX1NUQVRVUz0wIFwKICAgICBFTkFCTEVfQkxP Qj0xIFwKICAgICBFTkFCTEVfQ0hBTk5FTF9NRVNTQUdJTkc9MSBcCisgICAgRU5BQkxFX0NTU19F WENMVVNJT05TPTAgXAogICAgIEVOQUJMRV9DU1NfRklMVEVSUz0xIFwKKyAgICBFTkFCTEVfQ1NT X0dSSURfTEFZT1VUPTAgXAorICAgIEVOQUJMRV9DU1NfUkVHSU9OUz0wIFwKKyAgICBFTkFCTEVf Q1NTX1NIQURFUlM9MCBcCiAgICAgRU5BQkxFX0RBU0hCT0FSRF9TVVBQT1JUPTAgXAorICAgIEVO QUJMRV9EQVRBR1JJRD0wIFwKICAgICBFTkFCTEVfREFUQUxJU1Q9MSBcCisgICAgRU5BQkxFX0RB VEFfVFJBTlNGRVJfSVRFTVM9MCBcCiAgICAgRU5BQkxFX0RFVEFJTFM9MSBcCisgICAgRU5BQkxF X0RFVklDRV9PUklFTlRBVElPTj0wIFwKICAgICBFTkFCTEVfRElSRUNUT1JZX1VQTE9BRD0wIFwK KyAgICBFTkFCTEVfRE9XTkxPQURfQVRUUklCVVRFPTAgXAogICAgIEVOQUJMRV9GQVNUX01PQklM RV9TQ1JPTExJTkc9MSBcCiAgICAgRU5BQkxFX0ZJTEVfU1lTVEVNPTAgXAogICAgIEVOQUJMRV9G SUxURVJTPTEgXApAQCAtMzAsMzQgKzQwLDU0IEBAIEZFQVRVUkVfREVGQVVMVFMgPSBcCiAgICAg RU5BQkxFX0dBTUVQQUQ9MCBcCiAgICAgRU5BQkxFX0dFT0xPQ0FUSU9OPTAgXAogICAgIEVOQUJM RV9HRVNUVVJFX0VWRU5UUz0xIFwKKyAgICBFTkFCTEVfSElHSF9EUElfQ0FOVkFTPTAgXAogICAg IEVOQUJMRV9JQ09OREFUQUJBU0U9MSBcCisgICAgRU5BQkxFX0lOREVYRURfREFUQUJBU0U9MCBc CiAgICAgRU5BQkxFX0lOUFVUX1NQRUVDSD0wIFwKICAgICBFTkFCTEVfSU5QVVRfVFlQRV9DT0xP Uj0wIFwKKyAgICBFTkFCTEVfSU5QVVRfVFlQRV9EQVRFPTAgXAorICAgIEVOQUJMRV9JTlBVVF9U WVBFX0RBVEVUSU1FPTAgXAorICAgIEVOQUJMRV9JTlBVVF9UWVBFX0RBVEVUSU1FTE9DQUw9MCBc CisgICAgRU5BQkxFX0lOUFVUX1RZUEVfTU9OVEg9MCBcCisgICAgRU5BQkxFX0lOUFVUX1RZUEVf VElNRT0wIFwKKyAgICBFTkFCTEVfSU5QVVRfVFlQRV9XRUVLPTAgXAogICAgIEVOQUJMRV9JTlNQ RUNUT1I9MSBcCiAgICAgRU5BQkxFX0pBVkFTQ1JJUFRfREVCVUdHRVI9MSBcCisgICAgRU5BQkxF X0xFR0FDWV9DU1NfVkVORE9SX1BSRUZJWEVTPTAgXAogICAgIEVOQUJMRV9MRUdBQ1lfTk9USUZJ Q0FUSU9OUz0xIFwKICAgICBFTkFCTEVfTEVHQUNZX1dFQktJVF9CTE9CX0JVSUxERVI9MSBcCisg ICAgRU5BQkxFX0xJTktfUFJFRkVUQ0g9MCBcCisgICAgRU5BQkxFX0xJTktfUFJFUkVOREVSPTAg XAorICAgIEVOQUJMRV9NQVRITUw9MCBcCiAgICAgRU5BQkxFX01FRElBX1NPVVJDRT0wIFwKICAg ICBFTkFCTEVfTUVESUFfU1RBVElTVElDUz0wIFwKICAgICBFTkFCTEVfTUVESUFfU1RSRUFNPTAg XAogICAgIEVOQUJMRV9NRVRFUl9UQUc9MSBcCiAgICAgRU5BQkxFX01IVE1MPTAgXAogICAgIEVO QUJMRV9NSUNST0RBVEE9MCBcCisgICAgRU5BQkxFX01VVEFUSU9OX09CU0VSVkVSUz0wIFwKICAg ICBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQST0wIFwKKyAgICBFTkFCTEVfTkVUV09SS19JTkZP PTAgXAogICAgIEVOQUJMRV9OT1RJRklDQVRJT05TPTEgXAorICAgIEVOQUJMRV9PUklFTlRBVElP Tl9FVkVOVFM9MCBcCiAgICAgRU5BQkxFX1BBR0VfVklTSUJJTElUWV9BUEk9MSBcCiAgICAgRU5B QkxFX1BST0dSRVNTX1RBRz0xIFwKICAgICBFTkFCTEVfUVVPVEE9MCBcCisgICAgRU5BQkxFX1JF R0lTVEVSX1BST1RPQ09MX0hBTkRMRVI9MCBcCiAgICAgRU5BQkxFX1JFUVVFU1RfQU5JTUFUSU9O X0ZSQU1FPTEgXAogICAgIEVOQUJMRV9TQ1JJUFRFRF9TUEVFQ0g9MCBcCiAgICAgRU5BQkxFX1NI QURPV19ET009MCBcCiAgICAgRU5BQkxFX1NIQVJFRF9XT1JLRVJTPTEgXAogICAgIEVOQUJMRV9T UUxfREFUQUJBU0U9MSBcCisgICAgRU5BQkxFX1NUWUxFX1NDT1BFRD0wIFwKICAgICBFTkFCTEVf U1ZHPTEgXAorICAgIEVOQUJMRV9TVkdfRE9NX09CSkNfQklORElOR1M9MCBcCiAgICAgRU5BQkxF X1NWR19GT05UUz0wIFwKKyAgICBFTkFCTEVfVEVYVF9OT1RJRklDQVRJT05TX09OTFk9MCBcCiAg ICAgRU5BQkxFX1RPVUNIX0FESlVTVE1FTlQ9MSBcCiAgICAgRU5BQkxFX1RPVUNIX0VWRU5UUz0x IFwKICAgICBFTkFCTEVfVE9VQ0hfSUNPTl9MT0FESU5HPTAgXAorICAgIEVOQUJMRV9WSUJSQVRJ T049MCBcCiAgICAgRU5BQkxFX1ZJREVPPTAgXAogICAgIEVOQUJMRV9WSURFT19UUkFDSz0wIFwK ICAgICBFTkFCTEVfV0VCR0w9MCBcCkBAIC02NSw0ICs5NSw0IEBAIEZFQVRVUkVfREVGQVVMVFMg PSBcCiAgICAgRU5BQkxFX1dFQl9TT0NLRVRTPTEgXAogICAgIEVOQUJMRV9XRUJfVElNSU5HPTEg XAogICAgIEVOQUJMRV9XT1JLRVJTPTEgXAotICAgIEVOQUJMRV9YU0xUPTAKKyAgICBFTkFCTEVf WFNMVD0wIFwK