85720 2012-05-05 14:08:14 -0700 [webkitpy] FileSystem should have a pathsep abstraction 2012-05-07 12:08:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 rakuco webkit-unassigned dpranke eric oldest_to_newest 617040 0 rakuco 2012-05-05 14:08:14 -0700 As discussed in https://bugs.webkit.org/show_bug.cgi?id=85697#c2 , since we already have a `sep' abstraction in the FileSystem class, it would also be good to have one for os.pathsep so that we're able to unittest changes such as the one in <http://trac.webkit.org/changeset/116229> 617058 1 dpranke 2012-05-05 17:13:29 -0700 My initial leaning is to put this elsewhere, since it's (IMO) more path of the environment than part of the filesystem. We don't really have a good abstraction for the environment, though, or a more general place to stuff system-specific things. I suppose you could just make it be a field on SystemHost. Or maybe Executive? That said, I don't feel strongly about it one way or another. 617061 2 eric 2012-05-05 17:20:47 -0700 I made an Environment abstraction. Did I never land it? 617300 3 rakuco 2012-05-06 19:35:29 -0700 (In reply to comment #2) > I made an Environment abstraction. Did I never land it? You did, but it doesn't seem to have many features. Should we move sep from FileSystem to Environment and add pathsep to it? We may be talking about different kinds of environment abstractions, though -- to me, Environment is about environment variables and things we can change, whereas information such as pathsep and sep never changes in a system. 617805 4 dpranke 2012-05-07 12:08:35 -0700 (In reply to comment #3) > (In reply to comment #2) > > I made an Environment abstraction. Did I never land it? > > You did, but it doesn't seem to have many features. Should we move sep from FileSystem to Environment and add pathsep to it? > > We may be talking about different kinds of environment abstractions, though -- to me, Environment is about environment variables and things we can change, whereas information such as pathsep and sep never changes in a system. 'sep' is clearly a filesystem-related concept, since it is used by things like filesystem.join(). 'pathsep' is less clear to me; nothing in a filesystem actually uses or requires path separators. The only thing that does are things in the environment.