85699 2012-05-05 00:15:24 -0700 [Gtk] GtkDriver is not required anymore after r116134 2012-05-05 00:34:02 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan abarth dpranke ojan ossy pnormand webkit.review.bot oldest_to_newest 616909 0 zan 2012-05-05 00:15:24 -0700 In r116134, a XvfbDriver was introduced that is shared by both Qt and Gtk ports. This makes GtkDriver redundant, so it should be removed. 616912 1 140383 zan 2012-05-05 00:27:34 -0700 Created attachment 140383 Patch 616913 2 140383 ossy 2012-05-05 00:30:19 -0700 Comment on attachment 140383 Patch r=me 616914 3 140383 zan 2012-05-05 00:33:54 -0700 Comment on attachment 140383 Patch Clearing flags on attachment: 140383 Committed r116212: <http://trac.webkit.org/changeset/116212> 616915 4 zan 2012-05-05 00:34:02 -0700 All reviewed patches have been landed. Closing bug. 140383 2012-05-05 00:27:34 -0700 2012-05-05 00:33:53 -0700 Patch bug-85699-20120505092732.patch text/plain 3141 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MjEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjA5Y2ViMmIyYjQzNDQ2ZTk5ZGI4MmY2MjllZTY0MDFm NjU1M2M5Ny4uZmVmYzY2ZDcxNzMxMGJiYWQ2YjU5MzFhZDBjNWVkYWExNjgwMTg3ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA1LTA1ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgW0d0a10gR3RrRHJpdmVyIGlzIG5vdCByZXF1aXJlZCBhbnltb3JlIGFmdGVyIHIx MTYxMzQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1 Njk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVt b3ZlIEd0a0RyaXZlciBhcyBpdCB3YXMgcmVwbGFjZWQgYnkgdGhlIFh2ZmJEcml2ZXIgYW5kIGlz CisgICAgICAgIG5vIGxvbmdlciBuZWVkZWQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weToKKwogMjAxMi0wNS0wNCAgUmFwaGFlbCBLdWJvIGRh IENvc3RhICA8cmFrdWNvQHdlYmtpdC5vcmc+CiAKICAgICAgICAgd2Via2l0cHk6IFByZXNlcnZl IFhER19EQVRBX0RJUlMgaW4gdGhlIGVudmlyb25tZW50IHBhc3NlZCB0byBTZXJ2ZXJQcm9jZXNz LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9n dGsucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weQpp bmRleCAzMmI3ZjU0Y2Q2ZjM5MWU0NzhiMTY2Mzg2NTJmNzdhMjM5ZmRkN2IzLi41ZTRlMWEyZWFm ZWYxZDNkZmZhMTljMjg4OWIyNDg4NTZjMDJjYWQ4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weQpAQCAtMzgsNDMgKzM4LDYgQEAgZnJvbSB3 ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydC5wdWxzZWF1ZGlvX3Nhbml0aXplciBpbXBvcnQgUHVs c2VBdWRpb1Nhbml0aXplcgogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydC54dmZiZHJp dmVyIGltcG9ydCBYdmZiRHJpdmVyCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0 aXZlIGltcG9ydCBFeGVjdXRpdmUKIAotCi1jbGFzcyBHdGtEcml2ZXIoV2ViS2l0RHJpdmVyKToK LSAgICBkZWYgX3N0YXJ0KHNlbGYsIHBpeGVsX3Rlc3RzLCBwZXJfdGVzdF9hcmdzKToKLQotICAg ICAgICAjIENvbGxlY3QgdGhlIG51bWJlciBvZiBYIHNlcnZlcnMgcnVubmluZyBhbHJlYWR5IGFu ZCBtYWtlCi0gICAgICAgICMgc3VyZSBvdXIgWHZmYiBwcm9jZXNzIGRvZXNuJ3QgY2xhc2ggd2l0 aCBhbnkgb2YgdGhlbS4KLSAgICAgICAgZGVmIHhfZmlsdGVyKHByb2Nlc3NfbmFtZSk6Ci0gICAg ICAgICAgICByZXR1cm4gcHJvY2Vzc19uYW1lLmZpbmQoIlhvcmciKSA+IC0xCi0KLSAgICAgICAg cnVubmluZ19kaXNwbGF5cyA9IGxlbihFeGVjdXRpdmUoKS5ydW5uaW5nX3BpZHMoeF9maWx0ZXIp KQotCi0gICAgICAgICMgVXNlIGV2ZW4gZGlzcGxheXMgZm9yIHBpeGVsIHRlc3RzIGFuZCBvZGQg b25lcyBvdGhlcndpc2UuIFdoZW4gcGl4ZWwgdGVzdHMgYXJlIGRpc2FibGVkLAotICAgICAgICAj IERyaXZlclByb3h5IGNyZWF0ZXMgdHdvIGRyaXZlcnMsIG9uZSBmb3Igbm9ybWFsIGFuZCB0aGUg b3RoZXIgZm9yIHJlZiB0ZXN0cy4gQm90aCBoYXZlCi0gICAgICAgICMgdGhlIHNhbWUgd29ya2Vy IG51bWJlciwgc28gdGhpcyBwcmV2ZW50cyB0aGVtIGZyb20gdXNpbmcgdGhlIHNhbWUgWHZmYiBp bnN0YW5jZS4KLSAgICAgICAgZGlzcGxheV9pZCA9IHNlbGYuX3dvcmtlcl9udW1iZXIgKiAyICsg cnVubmluZ19kaXNwbGF5cwotICAgICAgICBpZiBwaXhlbF90ZXN0czoKLSAgICAgICAgICAgIGRp c3BsYXlfaWQgKz0gMQotICAgICAgICBydW5feHZmYiA9IFsiWHZmYiIsICI6JWQiICUgKGRpc3Bs YXlfaWQpLCAiLXNjcmVlbiIsICAiMCIsICI4MDB4NjAweDI0IiwgIi1ub2xpc3RlbiIsICJ0Y3Ai XQotICAgICAgICB3aXRoIG9wZW4ob3MuZGV2bnVsbCwgJ3cnKSBhcyBkZXZudWxsOgotICAgICAg ICAgICAgc2VsZi5feHZmYl9wcm9jZXNzID0gc3VicHJvY2Vzcy5Qb3BlbihydW5feHZmYiwgc3Rk ZXJyPWRldm51bGwpCi0gICAgICAgIHNlcnZlcl9uYW1lID0gc2VsZi5fcG9ydC5kcml2ZXJfbmFt ZSgpCi0gICAgICAgIGVudmlyb25tZW50ID0gc2VsZi5fcG9ydC5zZXR1cF9lbnZpcm9uX2Zvcl9z ZXJ2ZXIoc2VydmVyX25hbWUpCi0gICAgICAgICMgV2UgbXVzdCBkbyB0aGlzIGhlcmUgYmVjYXVz ZSB0aGUgRElTUExBWSBudW1iZXIgZGVwZW5kcyBvbiBfd29ya2VyX251bWJlcgotICAgICAgICBl bnZpcm9ubWVudFsnRElTUExBWSddID0gIjolZCIgJSAoZGlzcGxheV9pZCkKLSAgICAgICAgc2Vs Zi5fY3Jhc2hlZF9wcm9jZXNzX25hbWUgPSBOb25lCi0gICAgICAgIHNlbGYuX2NyYXNoZWRfcGlk ID0gTm9uZQotICAgICAgICBzZWxmLl9zZXJ2ZXJfcHJvY2VzcyA9IFNlcnZlclByb2Nlc3Moc2Vs Zi5fcG9ydCwgc2VydmVyX25hbWUsIHNlbGYuY21kX2xpbmUocGl4ZWxfdGVzdHMsIHBlcl90ZXN0 X2FyZ3MpLCBlbnZpcm9ubWVudCkKLQotICAgIGRlZiBzdG9wKHNlbGYpOgotICAgICAgICBXZWJL aXREcml2ZXIuc3RvcChzZWxmKQotICAgICAgICBpZiBnZXRhdHRyKHNlbGYsICdfeHZmYl9wcm9j ZXNzJywgTm9uZSk6Ci0gICAgICAgICAgICAjIEZJWE1FOiBUaGlzIHNob3VsZCB1c2UgRXhlY3V0 aXZlLmtpbGxfcHJvY2VzcwotICAgICAgICAgICAgb3Mua2lsbChzZWxmLl94dmZiX3Byb2Nlc3Mu cGlkLCBzaWduYWwuU0lHVEVSTSkKLSAgICAgICAgICAgIHNlbGYuX3h2ZmJfcHJvY2Vzcy53YWl0 KCkKLSAgICAgICAgICAgIHNlbGYuX3h2ZmJfcHJvY2VzcyA9IE5vbmUKLQotCiBjbGFzcyBHdGtQ b3J0KFdlYktpdFBvcnQsIFB1bHNlQXVkaW9TYW5pdGl6ZXIpOgogICAgIHBvcnRfbmFtZSA9ICJn dGsiCiAK