85697 2012-05-04 22:41:22 -0700 webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT. 2012-05-05 14:09:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco dpranke eric oldest_to_newest 616900 0 rakuco 2012-05-04 22:41:22 -0700 webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT. 616901 1 140381 rakuco 2012-05-04 22:43:01 -0700 Created attachment 140381 Patch 617031 2 140381 eric 2012-05-05 10:56:04 -0700 Comment on attachment 140381 Patch Yay! Except we really should have an os abstraction if this were unittested code (which some day it should be). I believe FileSystem has .sep, so presumably eventually our FileSystem class will have pathsep. Since this is not currently really unittestable code, I won't make you move it. But some day we should. :) 617039 3 rakuco 2012-05-05 14:08:12 -0700 Committed r116229: <http://trac.webkit.org/changeset/116229> 617041 4 rakuco 2012-05-05 14:09:11 -0700 (In reply to comment #2) > (From update of attachment 140381 [details]) > Yay! Except we really should have an os abstraction if this were unittested code (which some day it should be). I believe FileSystem has .sep, so presumably eventually our FileSystem class will have pathsep. > > Since this is not currently really unittestable code, I won't make you move it. But some day we should. :) I've filed https://bugs.webkit.org/show_bug.cgi?id=85720 for that :-) 140381 2012-05-04 22:43:01 -0700 2012-05-05 10:56:04 -0700 Patch bug-85697-20120505024257.patch text/plain 1754 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MjA4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGI3NTA1NjQ4MWFmZmU2MjRjZTBhNzk3MmFlOTY5NmNh NzI2NTJjYy4uODNhMDI1YTA4MDkzODVjMDkzOWYxZjQzMjliOTA4Y2EyZjViMDZjZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA1LTA0ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29Ad2Via2l0Lm9y Zz4KKworICAgICAgICB3ZWJraXRweTogVXNlIG9zLnBhdGhzZXAgaW5zdGVhZCBvZiBtYW51YWxs eSBmaW5kaW5nIG91dCB0aGUgcGF0aCBzZXBhcmF0b3IgaW4gTlJXVC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1Njk3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL25ldy1ydW4td2Via2l0 LXRlc3RzOiBJbnN0ZWFkIG9mIG1hbnVhbGx5IGRldGVjdGluZyB3aGV0aGVyCisgICAgICAgIHRo ZSBwYXRoIHNlcGFyYXRvciBzaG91bGQgYmUgJzonIG9yICc7JyBieSBjaGVja2luZyBzeXMucGxh dGZvcm0sIHJlbHkKKyAgICAgICAgb24gb3MucGF0aHNlcCB3aGljaCBoYXMgZXhhY3RseSB0aGUg c2FtZSBpbmZvcm1hdGlvbiAob3MucGF0aHNlcCBpcworICAgICAgICAnOicgZm9yIEN5Z3dpbiwg ZnJvbSB3aGF0IEkgY291bGQgY2hlY2sgaW4gUHl0aG9uJ3Mgc291cmNlcykuCisKIDIwMTItMDUt MDQgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgW0dU S10gU2ltcGxpZnkgaG93IGxpYldlYkNvcmVNb2R1bGVzIGlzIGxpbmtlZCBpbiwgYW5kIGZpeCBX ZWJLaXQyIGJ1aWxkCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0LXRl c3RzIGIvVG9vbHMvU2NyaXB0cy9uZXctcnVuLXdlYmtpdC10ZXN0cwppbmRleCBiMDNkNmI5ZWI1 ZDZhYjU4ZDhiMzFhYzVlZTNmODJjZGJlZTc4N2Q3Li4xYzNkM2IxNTkzOThmYTFiZDkwYmI5OGIw YzQxN2NiNWI4YjEzZDhlIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0 LXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvbmV3LXJ1bi13ZWJraXQtdGVzdHMKQEAgLTQ0LDEw ICs0NCw3IEBAIGlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6CiAgICAgZW52ID0gb3MuZW52aXJv bgogICAgIGlmIGVudi5oYXNfa2V5KCdQWVRIT05QQVRIJyk6CiAgICAgICAgIGlmIHNjcmlwdF9k aXIgbm90IGluIGVudlsnUFlUSE9OUEFUSCddOgotICAgICAgICAgICAgZW52X3NlcGFyYXRvciA9 ICc6JwotICAgICAgICAgICAgaWYgc3lzLnBsYXRmb3JtID09ICd3aW4zMic6Ci0gICAgICAgICAg ICAgICAgZW52X3NlcGFyYXRvciA9ICc7JwotICAgICAgICAgICAgZW52WydQWVRIT05QQVRIJ10g PSBlbnZbJ1BZVEhPTlBBVEgnXSArIGVudl9zZXBhcmF0b3IgKyBzY3JpcHRfZGlyCisgICAgICAg ICAgICBlbnZbJ1BZVEhPTlBBVEgnXSA9IGVudlsnUFlUSE9OUEFUSCddICsgb3MucGF0aHNlcCAr IHNjcmlwdF9kaXIKICAgICBlbHNlOgogICAgICAgICBlbnZbJ1BZVEhPTlBBVEgnXSA9IHNjcmlw dF9kaXIKICAgICBtb2R1bGVfcGF0aCA9IG9zLnBhdGguam9pbihzY3JpcHRfZGlyLCAnd2Via2l0 cHknLCAnbGF5b3V0X3Rlc3RzJywgJ3J1bl93ZWJraXRfdGVzdHMucHknKQo=