<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>85661</bug_id>
          
          <creation_ts>2012-05-04 13:46:42 -0700</creation_ts>
          <short_desc>[BlackBerry] Add methods need by client side</short_desc>
          <delta_ts>2012-05-07 10:31:47 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit BlackBerry</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Crystal Zhang">haizhang</reporter>
          <assigned_to name="Crystal Zhang">haizhang</assigned_to>
          <cc>rwlbuis</cc>
    
    <cc>staikos</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>616601</commentid>
    <comment_count>0</comment_count>
      <attachid>140314</attachid>
    <who name="Crystal Zhang">haizhang</who>
    <bug_when>2012-05-04 13:46:42 -0700</bug_when>
    <thetext>Created attachment 140314
patch

The two APIs needed by client side.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>616604</commentid>
    <comment_count>1</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-04 13:51:59 -0700</bug_when>
    <thetext>Attachment 140314 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebKit/blackberry/Api/WebPageClient...&quot; exit_code: 1
Source/WebKit/blackberry/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/blackberry/Api/WebPageClient.h:254:  The parameter name &quot;rect&quot; adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>616623</commentid>
    <comment_count>2</comment_count>
      <attachid>140318</attachid>
    <who name="Crystal Zhang">haizhang</who>
    <bug_when>2012-05-04 14:05:36 -0700</bug_when>
    <thetext>Created attachment 140318
updated patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>616644</commentid>
    <comment_count>3</comment_count>
      <attachid>140318</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-05-04 14:16:40 -0700</bug_when>
    <thetext>Comment on attachment 140318
updated patch

Looks good.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>616659</commentid>
    <comment_count>4</comment_count>
      <attachid>140318</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-04 14:21:13 -0700</bug_when>
    <thetext>Comment on attachment 140318
updated patch

Rejecting attachment 140318 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 1

Last 500 characters of output:
ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py&quot;, line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File &quot;/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py&quot;, line 64, in _run
    step(tool, options).run(state)
  File &quot;/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py&quot;, line 50, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: &apos;NoneType&apos; object has no attribute &apos;has_valid_reviewer&apos;

Full output: http://queues.webkit.org/results/12543443</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>616670</commentid>
    <comment_count>5</comment_count>
      <attachid>140329</attachid>
    <who name="Crystal Zhang">haizhang</who>
    <bug_when>2012-05-04 14:29:20 -0700</bug_when>
    <thetext>Created attachment 140329
fix commit error</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>616677</commentid>
    <comment_count>6</comment_count>
      <attachid>140329</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-05-04 14:33:07 -0700</bug_when>
    <thetext>Comment on attachment 140329
fix commit error

Second attempt.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>616687</commentid>
    <comment_count>7</comment_count>
      <attachid>140329</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-04 14:41:27 -0700</bug_when>
    <thetext>Comment on attachment 140329
fix commit error

Rejecting attachment 140329 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 1

Last 500 characters of output:
ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py&quot;, line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File &quot;/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py&quot;, line 64, in _run
    step(tool, options).run(state)
  File &quot;/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py&quot;, line 50, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: &apos;NoneType&apos; object has no attribute &apos;has_valid_reviewer&apos;

Full output: http://queues.webkit.org/results/12543452</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>616744</commentid>
    <comment_count>8</comment_count>
      <attachid>140345</attachid>
    <who name="Crystal Zhang">haizhang</who>
    <bug_when>2012-05-04 15:45:57 -0700</bug_when>
    <thetext>Created attachment 140345
patch4</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>616827</commentid>
    <comment_count>9</comment_count>
      <attachid>140345</attachid>
    <who name="George Staikos">staikos</who>
    <bug_when>2012-05-04 17:33:20 -0700</bug_when>
    <thetext>Comment on attachment 140345
patch4

Why is this not passing IntRect by const&amp;?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>616860</commentid>
    <comment_count>10</comment_count>
      <attachid>140345</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2012-05-04 19:12:48 -0700</bug_when>
    <thetext>Comment on attachment 140345
patch4

View in context: https://bugs.webkit.org/attachment.cgi?id=140345&amp;action=review

patches does not apply against ToT!

&gt; Source/WebKit/blackberry/Api/WebPageClient.h:254
&gt; +    virtual void createPopupWebView(Platform::IntRect) = 0;

const Platform::IntRect&amp; and please name the parameter, if it has a meaningful name.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>616861</commentid>
    <comment_count>11</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2012-05-04 19:13:09 -0700</bug_when>
    <thetext>
&gt; patches does not apply against ToT!

err, patch*</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>617589</commentid>
    <comment_count>12</comment_count>
      <attachid>140526</attachid>
    <who name="Crystal Zhang">haizhang</who>
    <bug_when>2012-05-07 07:43:23 -0700</bug_when>
    <thetext>Created attachment 140526
patch5</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>617606</commentid>
    <comment_count>13</comment_count>
      <attachid>140526</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2012-05-07 08:08:42 -0700</bug_when>
    <thetext>Comment on attachment 140526
patch5

View in context: https://bugs.webkit.org/attachment.cgi?id=140526&amp;action=review

&gt; Source/WebKit/blackberry/Api/WebPageClient.h:255
&gt; +    virtual void createPopupWebView(Platform::IntRect) = 0;
&gt; +    virtual void closePopupWebView() = 0;

could you pass a &apos;const Platform::IntRect&amp;&apos; here, or you want a copy? Also please name the parameter as it is unclear what it is about.

&gt; Source/WebKit/blackberry/ChangeLog:8
&gt; +        Add methods need by client side when create and close HTML popup dialogs.

typo: needed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>617610</commentid>
    <comment_count>14</comment_count>
      <attachid>140529</attachid>
    <who name="Crystal Zhang">haizhang</who>
    <bug_when>2012-05-07 08:19:20 -0700</bug_when>
    <thetext>Created attachment 140529
patch6</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>617694</commentid>
    <comment_count>15</comment_count>
      <attachid>140529</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-07 10:31:42 -0700</bug_when>
    <thetext>Comment on attachment 140529
patch6

Clearing flags on attachment: 140529

Committed r116318: &lt;http://trac.webkit.org/changeset/116318&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>617696</commentid>
    <comment_count>16</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-07 10:31:47 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>140314</attachid>
            <date>2012-05-04 13:46:42 -0700</date>
            <delta_ts>2012-05-04 14:05:36 -0700</delta_ts>
            <desc>patch</desc>
            <filename>0001-2012-05-03-Crystal-Zhang-haizhang-rim.com.patch</filename>
            <type>text/plain</type>
            <size>1624</size>
            <attacher name="Crystal Zhang">haizhang</attacher>
            
              <data encoding="base64">RnJvbSA1NjE0MTIxNjg4NjM1MWUxZTA1YmEwMDllMjQzMjE4ZjNlMDE2ZjY3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBDcnlzdGFsIFpoYW5nIDxoYWl6aGFuZ0ByaW0uY29tPgpEYXRl
OiBUaHUsIDMgTWF5IDIwMTIgMTU6MzQ6MDUgLTA0MDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA1
LTAzICBDcnlzdGFsIFpoYW5nICA8aGFpemhhbmdAcmltLmNvbT4KCiAgICAgICAgQ3JlYXRlIFBv
cHVwV2ViVmlldyBmb3IgSFRNTCBjb250cm9scyBpbiBsaWJ3ZWJ2aWV3LCBhZGQgbWV0aG9kcyBu
ZWVkIGJ5IGxpYndlYnZpZXcuCgogICAgICAgIFBSIDE1NDM2MAoKICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgKiBBcGkvV2ViUGFnZUNsaWVudC5oOgotLS0KIFNv
dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oIHwgICAgMiArKwogU291
cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgfCAgIDEwICsrKysrKysr
KysKIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaCBi
L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oCmluZGV4IGUxMjM1
NjguLjIwYmJmMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi
UGFnZUNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNs
aWVudC5oCkBAIC0yNTEsNiArMjUxLDggQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBjbGVh
ckNhY2hlKCkgPSAwOwogCiAgICAgdmlydHVhbCBib29sIGhhc0tleWJvYXJkRm9jdXMoKSA9IDA7
CisgICAgdmlydHVhbCB2b2lkIGNyZWF0ZVBvcHVwV2ViVmlldyhQbGF0Zm9ybTo6SW50UmVjdCBy
ZWN0KSA9IDA7CisgICAgdmlydHVhbCB2b2lkIGNsb3NlUG9wdXBXZWJWaWV3KCkgPSAwOwogfTsK
IH0gLy8gbmFtZXNwYWNlIFdlYktpdAogfSAvLyBuYW1lc3BhY2UgQmxhY2tCZXJyeQpkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv
YmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggMjdmNjM1Yi4uNTA2MzNlMSAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Js
YWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKyAgICAyMDEyLTA1LTAzICBDcnlz
dGFsIFpoYW5nICA8aGFpemhhbmdAcmltLmNvbT4KKworICAgIENyZWF0ZSBQb3B1cFdlYlZpZXcg
Zm9yIEhUTUwgY29udHJvbHMgaW4gbGlid2VidmlldywgYWRkIG1ldGhvZHMgbmVlZCBieSBsaWJ3
ZWJ2aWV3LgorCisgICAgUFIgMTU0MzYwCisKKyAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICogQXBpL1dlYlBhZ2VDbGllbnQuaDoKKwogMjAxMi0wNS0wMyAgQ3J5c3RhbCBa
aGFuZyAgPGhhaXpoYW5nQHJpbS5jb20+CiAKICAgICAgICAgQWRkIGh0bWxTb3VyY2UoKSBpbiBQ
YWdlUG9wdXBDbGllbnQKLS0gCjEuNy40LjEKCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>140318</attachid>
            <date>2012-05-04 14:05:36 -0700</date>
            <delta_ts>2012-05-04 14:29:20 -0700</delta_ts>
            <desc>updated patch</desc>
            <filename>0001-2012-05-03-Crystal-Zhang-haizhang-rim.com.patch</filename>
            <type>text/plain</type>
            <size>1814</size>
            <attacher name="Crystal Zhang">haizhang</attacher>
            
              <data encoding="base64">RnJvbSAzMWQ5Yzc1MTdjMmYxNDE3NDY5YzhkMDFmNjA4ZjcwZDMyNGFiMTdiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBDcnlzdGFsIFpoYW5nIDxoYWl6aGFuZ0ByaW0uY29tPgpEYXRl
OiBUaHUsIDMgTWF5IDIwMTIgMTU6MzQ6MDUgLTA0MDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA1
LTAzICBDcnlzdGFsIFpoYW5nICA8aGFpemhhbmdAcmltLmNvbT4KCiAgICAgICAgW0JsYWNrQmVy
cnldIEFkZCBtZXRob2RzIG5lZWQgYnkgY2xpZW50IHNpZGUuCiAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NjYxCgogICAgICAgIEFkZCBtZXRob2RzIG5l
ZWQgYnkgY2xpZW50IHNpZGUgd2hlbiBjcmVhdGUgYW5kIGNsb3NlIEhUTUwgcG9wdXAgZGlhbG9n
cy4KICAgICAgICBQUiAxNTQzNjAKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CgogICAgICAgICogQXBpL1dlYlBhZ2VDbGllbnQuaDoKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNr
YmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaCB8ICAgIDIgKysKIFNvdXJjZS9XZWJLaXQvYmxhY2ti
ZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAyIGZpbGVzIGNo
YW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0
L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaAppbmRleCBlMTIzNTY4Li5lZGUxYzE0IDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaAor
KysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaApAQCAtMjUx
LDYgKzI1MSw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgY2xlYXJDYWNoZSgpID0gMDsK
IAogICAgIHZpcnR1YWwgYm9vbCBoYXNLZXlib2FyZEZvY3VzKCkgPSAwOworICAgIHZpcnR1YWwg
dm9pZCBjcmVhdGVQb3B1cFdlYlZpZXcoUGxhdGZvcm06OkludFJlY3QpID0gMDsKKyAgICB2aXJ0
dWFsIHZvaWQgY2xvc2VQb3B1cFdlYlZpZXcoKSA9IDA7CiB9OwogfSAvLyBuYW1lc3BhY2UgV2Vi
S2l0CiB9IC8vIG5hbWVzcGFjZSBCbGFja0JlcnJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxv
ZwppbmRleCAyN2Y2MzViLi40MjVkMjU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNr
YmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cK
QEAgLTEsMyArMSwxNiBAQAorICAgIDIwMTItMDUtMDMgIENyeXN0YWwgWmhhbmcgIDxoYWl6aGFu
Z0ByaW0uY29tPgorCisgICAgW0JsYWNrQmVycnldIEFkZCBtZXRob2RzIG5lZWQgYnkgY2xpZW50
IHNpZGUuCisgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NjYx
CisgIAorICAgIEFkZCBtZXRob2RzIG5lZWQgYnkgY2xpZW50IHNpZGUgd2hlbiBjcmVhdGUgYW5k
IGNsb3NlIEhUTUwgcG9wdXAgZGlhbG9ncy4KKworICAgIFBSIDE1NDM2MAorCisgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAqIEFwaS9XZWJQYWdlQ2xpZW50Lmg6CisKIDIw
MTItMDUtMDMgIENyeXN0YWwgWmhhbmcgIDxoYWl6aGFuZ0ByaW0uY29tPgogCiAgICAgICAgIEFk
ZCBodG1sU291cmNlKCkgaW4gUGFnZVBvcHVwQ2xpZW50Ci0tIAoxLjcuNC4xCgo=
</data>
<flag name="review"
          id="146138"
          type_id="1"
          status="+"
          setter="rwlbuis"
    />
    <flag name="commit-queue"
          id="146139"
          type_id="3"
          status="-"
          setter="webkit.review.bot"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>140329</attachid>
            <date>2012-05-04 14:29:20 -0700</date>
            <delta_ts>2012-05-04 15:45:57 -0700</delta_ts>
            <desc>fix commit error</desc>
            <filename>0001-2012-05-03-Crystal-Zhang-haizhang-rim.com.patch</filename>
            <type>text/plain</type>
            <size>1814</size>
            <attacher name="Crystal Zhang">haizhang</attacher>
            
              <data encoding="base64">RnJvbSAzMWQ5Yzc1MTdjMmYxNDE3NDY5YzhkMDFmNjA4ZjcwZDMyNGFiMTdiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBDcnlzdGFsIFpoYW5nIDxoYWl6aGFuZ0ByaW0uY29tPgpEYXRl
OiBUaHUsIDMgTWF5IDIwMTIgMTU6MzQ6MDUgLTA0MDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA1
LTAzICBDcnlzdGFsIFpoYW5nICA8aGFpemhhbmdAcmltLmNvbT4KCiAgICAgICAgW0JsYWNrQmVy
cnldIEFkZCBtZXRob2RzIG5lZWQgYnkgY2xpZW50IHNpZGUuCiAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NjYxCgogICAgICAgIEFkZCBtZXRob2RzIG5l
ZWQgYnkgY2xpZW50IHNpZGUgd2hlbiBjcmVhdGUgYW5kIGNsb3NlIEhUTUwgcG9wdXAgZGlhbG9n
cy4KICAgICAgICBQUiAxNTQzNjAKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CgogICAgICAgICogQXBpL1dlYlBhZ2VDbGllbnQuaDoKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNr
YmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaCB8ICAgIDIgKysKIFNvdXJjZS9XZWJLaXQvYmxhY2ti
ZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAyIGZpbGVzIGNo
YW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0
L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaAppbmRleCBlMTIzNTY4Li5lZGUxYzE0IDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaAor
KysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaApAQCAtMjUx
LDYgKzI1MSw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgY2xlYXJDYWNoZSgpID0gMDsK
IAogICAgIHZpcnR1YWwgYm9vbCBoYXNLZXlib2FyZEZvY3VzKCkgPSAwOworICAgIHZpcnR1YWwg
dm9pZCBjcmVhdGVQb3B1cFdlYlZpZXcoUGxhdGZvcm06OkludFJlY3QpID0gMDsKKyAgICB2aXJ0
dWFsIHZvaWQgY2xvc2VQb3B1cFdlYlZpZXcoKSA9IDA7CiB9OwogfSAvLyBuYW1lc3BhY2UgV2Vi
S2l0CiB9IC8vIG5hbWVzcGFjZSBCbGFja0JlcnJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxv
ZwppbmRleCAyN2Y2MzViLi40MjVkMjU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNr
YmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cK
QEAgLTEsMyArMSwxNiBAQAorICAgIDIwMTItMDUtMDMgIENyeXN0YWwgWmhhbmcgIDxoYWl6aGFu
Z0ByaW0uY29tPgorCisgICAgW0JsYWNrQmVycnldIEFkZCBtZXRob2RzIG5lZWQgYnkgY2xpZW50
IHNpZGUuCisgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NjYx
CisgIAorICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgQWRkIG1ldGhvZHMg
bmVlZCBieSBjbGllbnQgc2lkZSB3aGVuIGNyZWF0ZSBhbmQgY2xvc2UgSFRNTCBwb3B1cCBkaWFs
b2dzLgorCisgICAgUFIgMTU0MzYwCisKKyAgICAqIEFwaS9XZWJQYWdlQ2xpZW50Lmg6CisKIDIw
MTItMDUtMDMgIENyeXN0YWwgWmhhbmcgIDxoYWl6aGFuZ0ByaW0uY29tPgogCiAgICAgICAgIEFk
ZCBodG1sU291cmNlKCkgaW4gUGFnZVBvcHVwQ2xpZW50Ci0tIAoxLjcuNC4xCgo=
</data>
<flag name="review"
          id="146150"
          type_id="1"
          status="+"
          setter="rwlbuis"
    />
    <flag name="commit-queue"
          id="146151"
          type_id="3"
          status="-"
          setter="webkit.review.bot"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>140345</attachid>
            <date>2012-05-04 15:45:57 -0700</date>
            <delta_ts>2012-05-07 07:43:23 -0700</delta_ts>
            <desc>patch4</desc>
            <filename>0001-2012-05-04-Crystal-Zhang-haizhang-rim.com.patch</filename>
            <type>text/plain</type>
            <size>1686</size>
            <attacher name="Crystal Zhang">haizhang</attacher>
            
              <data encoding="base64">RnJvbSBkNWI3NDdlYmQzYzIzMjg1YmM1OWEyZjI2NWIxOTg4NzcxOWM0YmMyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBDcnlzdGFsIFpoYW5nIDxibHVlYmVsbHpoeUBnbWFpbC5jb20+
CkRhdGU6IEZyaSwgNCBNYXkgMjAxMiAxODo0MjowMSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIw
MTItMDUtMDQgIENyeXN0YWwgWmhhbmcgIDxoYWl6aGFuZ0ByaW0uY29tPgoKICAgICAgICBbQmxh
Y2tCZXJyeV0gQWRkIG1ldGhvZHMgbmVlZCBieSBjbGllbnQgc2lkZQogICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTY2MQoKICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgKiBBcGkvV2ViUGFnZUNsaWVudC5oOgotLS0KIFNv
dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oIHwgICAgMiArKwogU291
cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgfCAgICA5ICsrKysrKysr
KwogMiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Js
YWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaAppbmRleCAzMjk2NjA5Li42Yzk4YWFlIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaAorKysg
Yi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaApAQCAtMjUxLDYg
KzI1MSw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgY2xlYXJDYWNoZSgpID0gMDsKIAog
ICAgIHZpcnR1YWwgYm9vbCBoYXNLZXlib2FyZEZvY3VzKCkgPSAwOworICAgIHZpcnR1YWwgdm9p
ZCBjcmVhdGVQb3B1cFdlYlZpZXcoUGxhdGZvcm06OkludFJlY3QpID0gMDsKKyAgICB2aXJ0dWFs
IHZvaWQgY2xvc2VQb3B1cFdlYlZpZXcoKSA9IDA7CiB9OwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0
CiB9IC8vIG5hbWVzcGFjZSBCbGFja0JlcnJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js
YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp
bmRleCBiNjNiYTMyLi5jMDQ1NmMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy
cnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAg
LTEsNSArMSwxNCBAQAogMjAxMi0wNS0wNCAgQ3J5c3RhbCBaaGFuZyAgPGhhaXpoYW5nQHJpbS5j
b20+CiAKKyAgICAgICAgW0JsYWNrQmVycnldIEFkZCBtZXRob2RzIG5lZWQgYnkgY2xpZW50IHNp
ZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NjYx
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBBcGkv
V2ViUGFnZUNsaWVudC5oOgorCisyMDEyLTA1LTA0ICBDcnlzdGFsIFpoYW5nICA8aGFpemhhbmdA
cmltLmNvbT4KKwogICAgICAgICBbQmxhY2tCZXJyeV0gSW1wbGVtZW50IGEgcG9wdXAgY2xpZW50
IGZvciBIVE1MIGNvbnRyb2xzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD04NTY3MAogCi0tIAoxLjcuMTAuMQoK
</data>
<flag name="review"
          id="146172"
          type_id="1"
          status="-"
          setter="tonikitoo"
    />
    <flag name="commit-queue"
          id="146173"
          type_id="3"
          status="-"
          setter="tonikitoo"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>140526</attachid>
            <date>2012-05-07 07:43:23 -0700</date>
            <delta_ts>2012-05-07 08:19:20 -0700</delta_ts>
            <desc>patch5</desc>
            <filename>0001-2012-05-07-Crystal-Zhang-haizhang-rim.com.patch</filename>
            <type>text/plain</type>
            <size>1832</size>
            <attacher name="Crystal Zhang">haizhang</attacher>
            
              <data encoding="base64">RnJvbSAzY2Y3ZjhmYzI5Nzg0YjQ5ZDUwOTgwMWI2YzExZGY5MTM1ZTA0OTZlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBDcnlzdGFsIFpoYW5nIDxibHVlYmVsbHpoeUBnbWFpbC5jb20+
CkRhdGU6IE1vbiwgNyBNYXkgMjAxMiAxMDo0MjowNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIw
MTItMDUtMDcgIENyeXN0YWwgWmhhbmcgIDxoYWl6aGFuZ0ByaW0uY29tPgoKICAgICAgICBbQmxh
Y2tCZXJyeV0gQWRkIG1ldGhvZHMgbmVlZCBieSBjbGllbnQgc2lkZQogICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTY2MQoKICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgQWRkIG1ldGhvZHMgbmVlZCBieSBjbGllbnQgc2lk
ZSB3aGVuIGNyZWF0ZSBhbmQgY2xvc2UgSFRNTCBwb3B1cCBkaWFsb2dzLgogICAgICAgIFBSIDE1
NDM2MAoKICAgICAgICAqIEFwaS9XZWJQYWdlQ2xpZW50Lmg6Ci0tLQogU291cmNlL1dlYktpdC9i
bGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmggfCAgICAyICsrCiBTb3VyY2UvV2ViS2l0L2Js
YWNrYmVycnkvQ2hhbmdlTG9nICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiAyIGZpbGVz
IGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js
YWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9B
cGkvV2ViUGFnZUNsaWVudC5oCmluZGV4IDMyOTY2MDkuLjZjOThhYWUgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oCisrKyBiL1NvdXJjZS9X
ZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oCkBAIC0yNTEsNiArMjUxLDggQEAg
cHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBjbGVhckNhY2hlKCkgPSAwOwogCiAgICAgdmlydHVh
bCBib29sIGhhc0tleWJvYXJkRm9jdXMoKSA9IDA7CisgICAgdmlydHVhbCB2b2lkIGNyZWF0ZVBv
cHVwV2ViVmlldyhQbGF0Zm9ybTo6SW50UmVjdCkgPSAwOworICAgIHZpcnR1YWwgdm9pZCBjbG9z
ZVBvcHVwV2ViVmlldygpID0gMDsKIH07CiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIH0gLy8gbmFt
ZXNwYWNlIEJsYWNrQmVycnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDQ5ZjZk
MDkuLjEwZmJhZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM
b2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1
IEBACisyMDEyLTA1LTA3ICBDcnlzdGFsIFpoYW5nICA8aGFpemhhbmdAcmltLmNvbT4KKworICAg
ICAgICBbQmxhY2tCZXJyeV0gQWRkIG1ldGhvZHMgbmVlZCBieSBjbGllbnQgc2lkZQorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU2NjEKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbWV0aG9kcyBuZWVk
IGJ5IGNsaWVudCBzaWRlIHdoZW4gY3JlYXRlIGFuZCBjbG9zZSBIVE1MIHBvcHVwIGRpYWxvZ3Mu
CisgICAgICAgIFBSIDE1NDM2MAorCisgICAgICAgICogQXBpL1dlYlBhZ2VDbGllbnQuaDoKKwog
MjAxMi0wNS0wNiAgTWFyeSBXdSAgPG1hcnkud3VAdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAg
ICAgIFtCbGFja0JlcnJ5XSBTdXBwb3J0IGh0bWw1IGRvd25sb2FkIGF0dHJpYnV0ZS4KLS0gCjEu
Ny4xMC4xCgo=
</data>
<flag name="commit-queue"
          id="146422"
          type_id="3"
          status="-"
          setter="tonikitoo"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>140529</attachid>
            <date>2012-05-07 08:19:20 -0700</date>
            <delta_ts>2012-05-07 10:31:41 -0700</delta_ts>
            <desc>patch6</desc>
            <filename>0001-2012-05-07-Crystal-Zhang-haizhang-rim.com.patch</filename>
            <type>text/plain</type>
            <size>1855</size>
            <attacher name="Crystal Zhang">haizhang</attacher>
            
              <data encoding="base64">RnJvbSA1NzgzOWI0ZmRiOGM5NzBkMGQ2MDg4YTZjODY1NzhlMzRmNTAyMGZmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBDcnlzdGFsIFpoYW5nIDxibHVlYmVsbHpoeUBnbWFpbC5jb20+
CkRhdGU6IE1vbiwgNyBNYXkgMjAxMiAxMDo0MjowNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIw
MTItMDUtMDcgIENyeXN0YWwgWmhhbmcgIDxoYWl6aGFuZ0ByaW0uY29tPgoKICAgICAgICBbQmxh
Y2tCZXJyeV0gQWRkIG1ldGhvZHMgbmVlZCBieSBjbGllbnQgc2lkZQogICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTY2MQoKICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgQWRkIG1ldGhvZHMgbmVlZGVkIGJ5IGNsaWVudCBz
aWRlIHdoZW4gY3JlYXRlIGFuZCBjbG9zZSBIVE1MIHBvcHVwIGRpYWxvZ3MuCiAgICAgICAgUFIg
MTU0MzYwCgogICAgICAgICogQXBpL1dlYlBhZ2VDbGllbnQuaDoKLS0tCiBTb3VyY2UvV2ViS2l0
L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaCB8ICAgIDIgKysKIFNvdXJjZS9XZWJLaXQv
YmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIDIgZmls
ZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv
YmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5
L0FwaS9XZWJQYWdlQ2xpZW50LmgKaW5kZXggMzI5NjYwOS4uNGFlNGViNCAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmgKKysrIGIvU291cmNl
L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmgKQEAgLTI1MSw2ICsyNTEsOCBA
QCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGNsZWFyQ2FjaGUoKSA9IDA7CiAKICAgICB2aXJ0
dWFsIGJvb2wgaGFzS2V5Ym9hcmRGb2N1cygpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgY3JlYXRl
UG9wdXBXZWJWaWV3KGNvbnN0IFBsYXRmb3JtOjpJbnRSZWN0JiB3ZWJWaWV3UmVjdCkgPSAwOwor
ICAgIHZpcnR1YWwgdm9pZCBjbG9zZVBvcHVwV2ViVmlldygpID0gMDsKIH07CiB9IC8vIG5hbWVz
cGFjZSBXZWJLaXQKIH0gLy8gbmFtZXNwYWNlIEJsYWNrQmVycnkKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv
Q2hhbmdlTG9nCmluZGV4IDQ5ZjZkMDkuLjcyY2Q0ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL
aXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0No
YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTA3ICBDcnlzdGFsIFpoYW5nICA8aGFp
emhhbmdAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQWRkIG1ldGhvZHMgbmVlZCBi
eSBjbGllbnQgc2lkZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9ODU2NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBBZGQgbWV0aG9kcyBuZWVkZWQgYnkgY2xpZW50IHNpZGUgd2hlbiBjcmVhdGUgYW5kIGNs
b3NlIEhUTUwgcG9wdXAgZGlhbG9ncy4KKyAgICAgICAgUFIgMTU0MzYwCisKKyAgICAgICAgKiBB
cGkvV2ViUGFnZUNsaWVudC5oOgorCiAyMDEyLTA1LTA2ICBNYXJ5IFd1ICA8bWFyeS53dUB0b3Jj
aG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFN1cHBvcnQgaHRtbDUgZG93
bmxvYWQgYXR0cmlidXRlLgotLSAKMS43LjEwLjEKCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>