85654 2012-05-04 12:52:51 -0700 REGRESSION(r116134): It made 3 inspector tests fail 2012-10-09 01:14:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 77335 79666 1 ossy vsevik apavlov kkristof loislo ossy pfeldman vsevik yurys oldest_to_newest 616544 0 ossy 2012-05-04 12:52:51 -0700 I have no idea how is it possible, but r116134 made 3 inspector tests fail on Qt with NRWT: --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/scripts-panel-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/scripts-panel-actual.txt @@ -2,13 +2,13 @@ Running: testInitialLoad +Source requested for baz.js Dumping ScriptsNavigator 'Scripts' tab: bar.js baz.js foo.js foobar.js Dumping ScriptsNavigator 'Content scripts' tab: -Source requested for baz.js Running: testReset Source requested for baz.js --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/snippets-model-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/snippets-model-actual.txt @@ -5,21 +5,66 @@ Running: testCreateRenameEditDelete Dumping saved snippets: Dumping model snippets: + Snippet: id = 1, name = 'Snippet1', content = '// This snippet does nothing. +var i = 2+2; +'. + Snippet: id = 2, name = 'Snippet2', content = '// This snippet creates a function that does nothing. +function doesNothing() +{ + var i = 2+2; +} +'. Snippet created. Dumping saved snippets: Snippet: id = 1, name = 'Snippet #1', content = ''. + Snippet: id = 2, name = 'Snippet2', content = '// This snippet creates a function that does nothing. +function doesNothing() +{ + var i = 2+2; +} +'. Dumping model snippets: Snippet: id = 1, name = 'Snippet #1', content = ''. + Snippet: id = 2, name = 'Snippet2', content = '// This snippet creates a function that does nothing. +function doesNothing() +{ + var i = 2+2; +} +'. Snippet renamed. Dumping saved snippets: Snippet: id = 1, name = 'New snippet name', content = ''. + Snippet: id = 2, name = 'Snippet2', content = '// This snippet creates a function that does nothing. +function doesNothing() +{ + var i = 2+2; +} +'. Dumping model snippets: Snippet: id = 1, name = 'New snippet name', content = ''. + Snippet: id = 2, name = 'Snippet2', content = '// This snippet creates a function that does nothing. +function doesNothing() +{ + var i = 2+2; +} +'. Snippet content changed. Dumping saved snippets: Snippet: id = 1, name = 'New snippet name', content = 'New snippet content'. + Snippet: id = 2, name = 'Snippet2', content = '// This snippet creates a function that does nothing. +function doesNothing() +{ + var i = 2+2; +} +'. Dumping model snippets: Snippet: id = 1, name = 'New snippet name', content = 'New snippet content'. + Snippet: id = 2, name = 'Snippet2', content = '// This snippet creates a function that does nothing. +function doesNothing() +{ + var i = 2+2; +} +'. Another snippet created. Dumping saved snippets: Snippet: id = 1, name = 'New snippet name', content = 'New snippet content'. --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/source-frame-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/source-frame-actual.txt @@ -1,17 +1,8 @@ -CONSOLE MESSAGE: line 10: test error message +FAIL: Timed out waiting for notifyDone to be called Tests that it's possible to set breakpoint in source frame, and that source frame displays breakpoints and console errors. Debugger was enabled. Running: testSetBreakpoint Script source was shown. -Breakpoint added to source frame at line 14 -Running: testConsoleMessage -Script source was shown. -Message added to source frame: test error message -Messages cleared in source frame. - -Running: testShowResource -Debugger was disabled. - 616549 1 ossy 2012-05-04 12:54:11 -0700 You can easily reproduce these fails with "NRWT inspector/debugger". They pass if you revert r116134 or use ORWT instead of NRWT. 616551 2 ossy 2012-05-04 12:55:49 -0700 cc inspector guys, maybe you have any idea how is it possible. 616573 3 ossy 2012-05-04 13:20:32 -0700 I skipped them until proper fix - r116159 737514 4 ossy 2012-10-09 01:14:50 -0700 They aren't in the skipped list now.