85614 2012-05-04 06:37:42 -0700 [Qt] Build fix when using libpng version > 1.2. 2012-05-09 02:07:03 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 menard menard webkit.review.bot zoltan oldest_to_newest 616146 0 menard 2012-05-04 06:37:42 -0700 [Qt[D[3~d[D[D] Build fix for ver[D[D[D[D[D[D[D[Dwhen using libpng version > 1.2. 616150 1 140213 menard 2012-05-04 06:39:40 -0700 Created attachment 140213 Patch 616151 2 menard 2012-05-04 06:39:59 -0700 (In reply to comment #1) > Created an attachment (id=140213) [details] > Patch Let see what EWS say. 616160 3 menard 2012-05-04 06:50:11 -0700 Committed r116091: <http://trac.webkit.org/changeset/116091> 618492 4 zoltan 2012-05-08 07:01:32 -0700 This patch has been rollouted, it's safe to check it in, so we will avoid problems later. 618495 5 140712 zoltan 2012-05-08 07:02:22 -0700 Created attachment 140712 Patch 618830 6 140712 rafael.lobo 2012-05-08 14:50:18 -0700 Comment on attachment 140712 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140712&action=review I don't understand, the first patch was rolled out? If so, why this change won't get rolled out? I don't see much difference from the previous one. > Source/WebCore/ChangeLog:1 > +2012-05-08 Zoltan Horvath <zoltan@webkit.org> Maybe you should use Alexis name instead. 618848 7 140712 eric 2012-05-08 15:06:25 -0700 Comment on attachment 140712 Patch rs=me. 618851 8 140712 eric 2012-05-08 15:07:24 -0700 Comment on attachment 140712 Patch What's going on with this patch? It was rolled out? Is it ready to roll in again? 619263 9 zoltan 2012-05-09 01:17:45 -0700 (In reply to comment #8) > (From update of attachment 140712 [details]) > What's going on with this patch? It was rolled out? Is it ready to roll in again? It was a build fix for some systems, after landing the webcore imagedecoder patch from bug #80400 we rollouted it in one cup the patch and its buildfixes to decrease the mass-up. ...I didn't want to leave a build fix in the trunk for a rollouted revision. :) This way is more consistent I think, and it makes sense to push in. Thanks for the review. 619289 10 140712 webkit.review.bot 2012-05-09 02:06:58 -0700 Comment on attachment 140712 Patch Clearing flags on attachment: 140712 Committed r116507: <http://trac.webkit.org/changeset/116507> 619290 11 webkit.review.bot 2012-05-09 02:07:03 -0700 All reviewed patches have been landed. Closing bug. 140213 2012-05-04 06:39:40 -0700 2012-05-08 07:02:10 -0700 Patch bug-85614-20120504103922.patch text/plain 1189 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTRjNjZlMmYxYjljZDU4 Yjc3ODhhNjVjYzI3YjE4YTBlNWFjMGZjMC4uNmU1NjhiOGJjODhiNjk0OWEyYjA1ZmQ5MTgxNDZm NjQ1YWMxMDQ0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTA0ICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtRdF0g QnVpbGQgZml4IHdoZW4gdXNpbmcgbGlicG5nIHZlcnNpb24gPiAxLjIuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTYxNAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IGVuZm9yY2UgdGhlIHZlcnNp b24gb2YgbGlicG5nIHdoZW4gcGFzc2luZyB0aGUgb3B0aW9uIHRvIHRoZSBsaW5rZXIuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIDogYnVpbGQgZml4LgorCisgICAgICAgICogV2ViQ29yZS5wcmk6 CisKIDIwMTItMDUtMDQgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29t PgogCiAgICAgICAgIFtRdF0gSW1hZ2VzIGFyZSBzY2FsZWQgYmFkbHkgaW4gV2ViS2l0MgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkgYi9Tb3VyY2UvV2ViQ29yZS9XZWJD b3JlLnByaQppbmRleCBjYTdlNjgzYzY1NTcyNGZjNzAwMzg0MjgwZGM2YTQ4OTVjMDkzNDFiLi5j YmEzZDQ3OWJkMTRiNjFiNjVkZGJiZGQ0OTNjOTgzYTA3YTQxN2JmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLnByaQorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaQpA QCAtMjM4LDcgKzIzOCw3IEBAIGhhdmVRdCg1KSB7CiAgICAgIWNvbnRhaW5zKGNvbmZpZ190ZXN0 X2xpYnBuZywgeWVzKTogZXJyb3IoIlBORyAxLjIgbGlicmFyeSBub3QgZm91bmQhIikKIH0KIAot TElCUyArPSAtbGpwZWcgLWxwbmcxMgorTElCUyArPSAtbGpwZWcgLWxwbmcKIAogd2luMzItKnx3 aW5jZSogewogICAgIERMTERFU1RESVIgPSAkJHtST09UX0JVSUxEX0RJUn0vYmluCg== 140712 2012-05-08 07:02:22 -0700 2012-05-09 02:06:57 -0700 Patch bug-85614-20120508160219.patch text/plain 1575 zoltan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDA0ZjI0YTI3N2U5OTUx Zjc0YmU4ZWEwOTBiYzE0ZDQ1MTQ0Yjk4Yy4uMjNjYTM5YmEzZTBmOTM1MDE4ZTk4ZjU1MDE5NGQw Mjk1NWFlMDVjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTA4ICBab2x0 YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF0gQnVpbGQgZml4 IHdoZW4gdXNpbmcgbGlicG5nIHZlcnNpb24gIT0gMS4yCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTYxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IGVuZm9yY2UgdGhlIHZlcnNpb24gb2YgbGli cG5nIHdoZW4gcGFzc2luZyB0aGUgb3B0aW9uIHRvIHRoZSBsaW5rZXIuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLCBubyBpbnRlbmRlZCBmdW5jdGlvbmFsaXR5IGNoYW5nZS4KKworICAgICAgICAq IFdlYkNvcmUucHJpOgorCiAyMDEyLTA1LTAzICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgRXh0cmEgbGluZS1icmVha3MgYWRkZWQgd2hlbiBjb3B5 aW5nIGZyb20gc291cmNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkg Yi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaQppbmRleCAyY2E1OTkzY2NmZjhhZGRiYTg3NGFh OWY4ZTBlZjEwZTUzYWRiMjA2Li5lOGI4NmM4NTA2MTg2OGQwMzg3ODI0NWRjZWU0OWVlYzdhMGYz MjRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaQorKysgYi9Tb3VyY2Uv V2ViQ29yZS9XZWJDb3JlLnByaQpAQCAtMjMzLDEwICsyMzMsMTAgQEAgY29udGFpbnMoREVGSU5F UywgV1RGX1VTRV9RVF9JTUFHRV9ERUNPREVSPTApIHsKICAgICBoYXZlUXQoNSkgewogICAgICAg ICAjIFF0NSBhbGxvd3MgdXMgdG8gdXNlIGNvbmZpZyB0ZXN0cyB0byBjaGVjayBmb3IgdGhlIHBy ZXNlbmNlIG9mIHRoZXNlIGxpYnJhcmllcwogICAgICAgICAhY29udGFpbnMoY29uZmlnX3Rlc3Rf bGlianBlZywgeWVzKTogZXJyb3IoIkpQRUcgbGlicmFyeSBub3QgZm91bmQhIikKLSAgICAgICAg IWNvbnRhaW5zKGNvbmZpZ190ZXN0X2xpYnBuZywgeWVzKTogZXJyb3IoIlBORyAxLjIgbGlicmFy eSBub3QgZm91bmQhIikKKyAgICAgICAgIWNvbnRhaW5zKGNvbmZpZ190ZXN0X2xpYnBuZywgeWVz KTogZXJyb3IoIlBORyBsaWJyYXJ5IG5vdCBmb3VuZCEiKQogICAgIH0KIAotICAgIExJQlMgKz0g LWxqcGVnIC1scG5nMTIKKyAgICBMSUJTICs9IC1sanBlZyAtbHBuZwogCiAgICAgY29udGFpbnMo REVGSU5FUywgV1RGX1VTRV9XRUJQPTEpIHsKICAgICAgICAgSU5DTFVERVBBVEggKz0gJCRTT1VS Q0VfRElSL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAK