85572 2012-05-03 19:54:46 -0700 [BlackBerry] Enable credential persistance and auto fill 2012-05-06 15:05:01 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jonathan.dong.webkit webkit-unassigned charles.wei leo.yang mstaikos rakuco rwlbuis staikos tonikitoo webkit.review.bot zimmermann oldest_to_newest 615914 0 jonathan.dong.webkit 2012-05-03 19:54:46 -0700 enable credential persistance and auto fill feature in build system 615931 1 140153 jonathan.dong.webkit 2012-05-03 20:45:23 -0700 Created attachment 140153 Patch 616180 2 140153 rwlbuis 2012-05-04 07:18:08 -0700 Comment on attachment 140153 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140153&action=review Looks good, wondering about the minor fix line? > Source/WebKit/blackberry/ChangeLog:10 > + This is a minor fix by the way. I dont get this line? Better clear it up before landing. 616202 3 140153 jonathan.dong.webkit 2012-05-04 07:42:05 -0700 Comment on attachment 140153 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140153&action=review >> Source/WebKit/blackberry/ChangeLog:10 >> + This is a minor fix by the way. > > I dont get this line? Better clear it up before landing. Thanks Rob, calling setAutofilled() on the input element will get it painted with yellow background which can notify user this input is auto filled by browser. I forget to add this in the former patches. will explain this in changelog with my next patch. 616218 4 140225 jonathan.dong.webkit 2012-05-04 07:56:13 -0700 Created attachment 140225 Patch 616230 5 140225 rwlbuis 2012-05-04 08:07:12 -0700 Comment on attachment 140225 Patch Looks good, I hope Leo, Charles or Mary can help with landing. 617095 6 jonathan.dong.webkit 2012-05-06 03:27:46 -0700 hi Rob, do you know what's wrong with it? Charles has helped on cq+ this patch in the early morning this Saturday, but it hasn't get landed yet until now, and there's no status update. Do I need to re-submit it? and we are not able to see the build status here in china, :( 617111 7 rwlbuis 2012-05-06 09:23:42 -0700 Hi Jonathan, (In reply to comment #6) > hi Rob, do you know what's wrong with it? Charles has helped on cq+ this patch in the early morning this Saturday, but it hasn't get landed yet until now, and there's no status update. Do I need to re-submit it? > > and we are not able to see the build status here in china, :( Maybe the queue is stuck, I'll keep an eye on it. 617181 8 140225 webkit.review.bot 2012-05-06 15:04:54 -0700 Comment on attachment 140225 Patch Clearing flags on attachment: 140225 Committed r116241: <http://trac.webkit.org/changeset/116241> 617182 9 webkit.review.bot 2012-05-06 15:05:01 -0700 All reviewed patches have been landed. Closing bug. 140153 2012-05-03 20:45:23 -0700 2012-05-04 07:55:54 -0700 Patch bug-85572-20120504114520.patch text/plain 3225 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBmMzJhYWYxNjIyNmU3NGVhOGZjMTU4NTRhZTE3N2RhZWEwODU2ODM2Li5lNDRhZTBmYzdj N2M2ZTc0MjhkM2E4ZWUxYzlmMTU0YzAyMzRhNDliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0wNS0wMyAgSm9uYXRoYW4gRG9uZyAgPGpvbmF0 aGFuLmRvbmdAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBFbmFi bGUgY3JlZGVudGlhbCBwZXJzaXN0YW5jZSBhbmQgYXV0byBmaWxsCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTU3MgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNldCBhdXRvZmlsbGVkIHN0YXR1cyBvZiBj cmVkZW50aWFsIGlucHV0IGZpZWxkcyB3aGVuIGNyZWRlbnRpYWwKKyAgICAgICAgaW5mb3JtYXRp b24gaXMgYXV0byBmaWxsZWQgYnkgQ3JlZGVudGlhbE1hbmFnZXIuCisgICAgICAgIFRoaXMgaXMg YSBtaW5vciBmaXggYnkgdGhlIHdheS4KKworICAgICAgICBObyBiZWhhdmlvciBjaGFuZ2VzLCBz byBubyBuZXcgdGVzdC4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0NyZWRlbnRpYWxUcmFu c2Zvcm1EYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNyZWRlbnRpYWxUcmFuc2Zvcm1EYXRh OjpzZXRDcmVkZW50aWFsKToKKwogMjAxMi0wNS0wMyAgRmFkeSBTYW11ZWwgIDxmc2FtdWVsQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmluZyBsaW5lIGluIGNvbXB1dGVWaWV3cG9ydEF0 dHJpYnV0ZXMgdGhhdCBlbmZvcmNlcyBhIG1pbmltdW0gc2NhbGUgZmFjdG9yIHRvIG5ldmVyIGFs bG93IHpvb21pbmcgb3V0IG1vcmUgdGhhbiB2aWV3cG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0NyZWRlbnRpYWxUcmFuc2Zvcm1EYXRhLmNw cCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DcmVkZW50aWFsVHJh bnNmb3JtRGF0YS5jcHAKaW5kZXggOGMyMmFlMmEyMjg5YTAxMzFkN2YwOTVjMjk5MTdiYjc2MDVi MmVkNi4uMGQwNWE3NTQzMzIzZGMxMzNiNmE4MWY2MDY2ZTllNDgxZDkzOGMyZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0NyZWRlbnRpYWxUcmFu c2Zvcm1EYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBv cnQvQ3JlZGVudGlhbFRyYW5zZm9ybURhdGEuY3BwCkBAIC0xNzAsNyArMTcwLDkgQEAgdm9pZCBD cmVkZW50aWFsVHJhbnNmb3JtRGF0YTo6c2V0Q3JlZGVudGlhbChjb25zdCBDcmVkZW50aWFsJiBj cmVkZW50aWFsKQogCiAgICAgbV9jcmVkZW50aWFsID0gY3JlZGVudGlhbDsKICAgICBtX3VzZXJO YW1lRWxlbWVudC0+c2V0VmFsdWUoY3JlZGVudGlhbC51c2VyKCkpOworICAgIG1fdXNlck5hbWVF bGVtZW50LT5zZXRBdXRvZmlsbGVkKCk7CiAgICAgbV9wYXNzd29yZEVsZW1lbnQtPnNldFZhbHVl KGNyZWRlbnRpYWwucGFzc3dvcmQoKSk7CisgICAgbV9wYXNzd29yZEVsZW1lbnQtPnNldEF1dG9m aWxsZWQoKTsKIH0KIAogYm9vbCBDcmVkZW50aWFsVHJhbnNmb3JtRGF0YTo6ZmluZFBhc3N3b3Jk Rm9ybUZpZWxkcyhIVE1MRm9ybUVsZW1lbnQqIGZvcm0pCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21h a2UvT3B0aW9uc0JsYWNrQmVycnkuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0JsYWNrQmVy cnkuY21ha2UKaW5kZXggMjYxNDRjZmQ3MjllODY1ODg1ZWE4YzA3MmMwMTM0NjAwZTdkMmEyMC4u ZDdjZjk0OWNlY2E3OGVlOTgxZThlMGVkNDUwNGEyZWYyZWY0MDM1NiAxMDA2NDQKLS0tIGEvU291 cmNlL2NtYWtlL09wdGlvbnNCbGFja0JlcnJ5LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRp b25zQmxhY2tCZXJyeS5jbWFrZQpAQCAtMTczLDYgKzE3Myw4IEBAIEVORElGICgpCiAKIFdFQktJ VF9PUFRJT05fRU5EKCkKIAorQUREX0RFRklOSVRJT05TKC1ERU5BQkxFX0JMQUNLQkVSUllfQ1JF REVOVElBTF9QRVJTSVNUPTEpCisKICMgU29tZSBvZiBvdXIgZmlsZXMsIHN1Y2ggYXMgcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vQ29tcGxleFRleHRDb250cm9sbGVyTGludXguY3BwLCByZXF1 aXJlIGEKICMgbmV3ZXIgSUNVIHZlcnNpb24gdGhhbiB0aGUgdmVyc2lvbiBhc3NvY2lhdGVkIHdp dGggdGhlIGhlYWRlcnMgaW4ge1dlYkNvcmUsIEphdmFTY3JpcHRDb3JlfS9pY3UuCiAjIEJlY2F1 c2Ugb2YgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDkxMz4gd2Ug Y2FuJ3QgZGlyZWN0bHkgcmVmZXJlbmNlIHRoZXNlIG5ld2VyCmRpZmYgLS1naXQgYS9DaGFuZ2VM b2cgYi9DaGFuZ2VMb2cKaW5kZXggMGUwNDA5OTllMjk5OTUzZGY2MTAyMWEzNWEwZmQ0NzlmM2Zi NDdjYi4uNDRjNGVkMGEzNDNmNGUyZjhhNGZlODMzNWVhM2VmZmY5NzQwODE5NyAxMDA2NDQKLS0t IGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTAz ICBKb25hdGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAg ICAgICAgW0JsYWNrQmVycnldIEVuYWJsZSBjcmVkZW50aWFsIHBlcnNpc3RhbmNlIGFuZCBhdXRv IGZpbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1 NTcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5h YmxlIGNyZWRlbnRpYWwgcGVyc2lzdGFuY2UgYW5kIGF1dG8gZmlsbCBmZWF0dXJlIGJ5IGFkZGlu ZworICAgICAgICBFTkFCTEVfQkxBQ0tCRVJSWV9DUkVERU5USUFMX1BFUlNJU1Q9MS4KKworICAg ICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQmxhY2tCZXJyeS5jbWFrZToKKwogMjAxMi0wNS0w MyAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8cmFrdWNvQHdlYmtpdC5vcmc+CiAKICAgICAgICAg W0NNYWtlXSBSZXdyaXRlIEZpbmRDYWlyby5jbWFrZS4K 140225 2012-05-04 07:56:13 -0700 2012-05-06 15:04:53 -0700 Patch bug-85572-20120504225610.patch text/plain 3282 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyYjJlNmVjYzA4NjVjMmVjMjZhMGE1NjQ3MTA2NGYzNzllZWYxZWRjLi40N2EyYWFkYmQz N2ZjZmIzMGZmN2ZlOGMyMzE1ZTM2YWFjMDIyOGE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0wNS0wNCAgSm9uYXRoYW4gRG9uZyAgPGpvbmF0 aGFuLmRvbmdAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBFbmFi bGUgY3JlZGVudGlhbCBwZXJzaXN0YW5jZSBhbmQgYXV0byBmaWxsCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTU3MgorCisgICAgICAgIFJldmlld2Vk IGJ5IFJvYiBCdWlzLgorCisgICAgICAgIFNldCBhdXRvZmlsbGVkIHN0YXR1cyBvZiBjcmVkZW50 aWFsIGlucHV0IGZpZWxkcyB3aGVuIGNyZWRlbnRpYWwKKyAgICAgICAgaW5mb3JtYXRpb24gaXMg YXV0byBmaWxsZWQgYnkgQ3JlZGVudGlhbE1hbmFnZXIuCisgICAgICAgIEJ5IGRvaW5nIHRoaXMg dGhlIGlucHV0IGVsZW1lbnQgd2lsbCBnZXQgcGFpbnRlZCB3aXRoIHllbGxvdyBiYWNrZ3JvdW5k CisgICAgICAgIHdoaWNoIGNhbiBub3RpZnkgdXNlciB0aGlzIGlucHV0IGZpZWxkIGlzIGF1dG8g ZmlsbGVkIGJ5IHRoZSBicm93c2VyLgorCisgICAgICAgIE5vIGJlaGF2aW9yIGNoYW5nZXMsIHNv IG5vIG5ldyB0ZXN0LgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ3JlZGVudGlhbFRyYW5z Zm9ybURhdGEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q3JlZGVudGlhbFRyYW5zZm9ybURhdGE6 OnNldENyZWRlbnRpYWwpOgorCiAyMDEyLTA1LTA0ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gU2V0IFdlYkNvcmUgaW1hZ2VkZWNvZGVycyBhcyBk ZWZhdWx0IGFuZCBhZGQgZmFsbGJhY2sgdG8gUUltYWdlRGVjb2RlcgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0NyZWRlbnRpYWxUcmFuc2Zvcm1E YXRhLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DcmVkZW50 aWFsVHJhbnNmb3JtRGF0YS5jcHAKaW5kZXggOGMyMmFlMmEyMjg5YTAxMzFkN2YwOTVjMjk5MTdi Yjc2MDViMmVkNi4uMGQwNWE3NTQzMzIzZGMxMzNiNmE4MWY2MDY2ZTllNDgxZDkzOGMyZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0NyZWRlbnRp YWxUcmFuc2Zvcm1EYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29y ZVN1cHBvcnQvQ3JlZGVudGlhbFRyYW5zZm9ybURhdGEuY3BwCkBAIC0xNzAsNyArMTcwLDkgQEAg dm9pZCBDcmVkZW50aWFsVHJhbnNmb3JtRGF0YTo6c2V0Q3JlZGVudGlhbChjb25zdCBDcmVkZW50 aWFsJiBjcmVkZW50aWFsKQogCiAgICAgbV9jcmVkZW50aWFsID0gY3JlZGVudGlhbDsKICAgICBt X3VzZXJOYW1lRWxlbWVudC0+c2V0VmFsdWUoY3JlZGVudGlhbC51c2VyKCkpOworICAgIG1fdXNl ck5hbWVFbGVtZW50LT5zZXRBdXRvZmlsbGVkKCk7CiAgICAgbV9wYXNzd29yZEVsZW1lbnQtPnNl dFZhbHVlKGNyZWRlbnRpYWwucGFzc3dvcmQoKSk7CisgICAgbV9wYXNzd29yZEVsZW1lbnQtPnNl dEF1dG9maWxsZWQoKTsKIH0KIAogYm9vbCBDcmVkZW50aWFsVHJhbnNmb3JtRGF0YTo6ZmluZFBh c3N3b3JkRm9ybUZpZWxkcyhIVE1MRm9ybUVsZW1lbnQqIGZvcm0pCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvY21ha2UvT3B0aW9uc0JsYWNrQmVycnkuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0Js YWNrQmVycnkuY21ha2UKaW5kZXggMjYxNDRjZmQ3MjllODY1ODg1ZWE4YzA3MmMwMTM0NjAwZTdk MmEyMC4uZDdjZjk0OWNlY2E3OGVlOTgxZThlMGVkNDUwNGEyZWYyZWY0MDM1NiAxMDA2NDQKLS0t IGEvU291cmNlL2NtYWtlL09wdGlvbnNCbGFja0JlcnJ5LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFr ZS9PcHRpb25zQmxhY2tCZXJyeS5jbWFrZQpAQCAtMTczLDYgKzE3Myw4IEBAIEVORElGICgpCiAK IFdFQktJVF9PUFRJT05fRU5EKCkKIAorQUREX0RFRklOSVRJT05TKC1ERU5BQkxFX0JMQUNLQkVS UllfQ1JFREVOVElBTF9QRVJTSVNUPTEpCisKICMgU29tZSBvZiBvdXIgZmlsZXMsIHN1Y2ggYXMg cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ29tcGxleFRleHRDb250cm9sbGVyTGludXguY3Bw LCByZXF1aXJlIGEKICMgbmV3ZXIgSUNVIHZlcnNpb24gdGhhbiB0aGUgdmVyc2lvbiBhc3NvY2lh dGVkIHdpdGggdGhlIGhlYWRlcnMgaW4ge1dlYkNvcmUsIEphdmFTY3JpcHRDb3JlfS9pY3UuCiAj IEJlY2F1c2Ugb2YgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDkx Mz4gd2UgY2FuJ3QgZGlyZWN0bHkgcmVmZXJlbmNlIHRoZXNlIG5ld2VyCmRpZmYgLS1naXQgYS9D aGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNGI5YTRmNDJiYWU4YjVlZjE5MTk0OWY1NGYyMjY0 OWQzNDIwNGNhZi4uNjA2YWY4NzkzMDU5MTAyOTY1NjlkZTM4NmNlYmJkMmMzMjVmZTVmYSAxMDA2 NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEy LTA1LTA0ICBKb25hdGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+ CisKKyAgICAgICAgW0JsYWNrQmVycnldIEVuYWJsZSBjcmVkZW50aWFsIHBlcnNpc3RhbmNlIGFu ZCBhdXRvIGZpbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg1NTcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUm9iIEJ1aXMuCisKKyAgICAgICAgRW5h YmxlIGNyZWRlbnRpYWwgcGVyc2lzdGFuY2UgYW5kIGF1dG8gZmlsbCBmZWF0dXJlIGJ5IGFkZGlu ZworICAgICAgICBFTkFCTEVfQkxBQ0tCRVJSWV9DUkVERU5USUFMX1BFUlNJU1Q9MS4KKworICAg ICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQmxhY2tCZXJyeS5jbWFrZToKKwogMjAxMi0wNS0w NCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjExNjA3NS4K