85566 2012-05-03 18:30:17 -0700 Improve UI for garden-o-matic examine view when there are fewer than 5 tests. 2012-05-03 18:56:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth adamk dglazkov webkit.review.bot oldest_to_newest 615868 0 ojan 2012-05-03 18:30:17 -0700 Improve UI for garden-o-matic examine view when there are fewer than 5 tests. 615869 1 140142 ojan 2012-05-03 18:30:38 -0700 Created attachment 140142 Patch 615871 2 ojan 2012-05-03 18:31:21 -0700 This way, we don't use 100px minHeight if there is less than 100px of content. 615875 3 abarth 2012-05-03 18:36:47 -0700 resize-handle. Interesting. :) 615876 4 ojan 2012-05-03 18:41:04 -0700 (In reply to comment #3) > resize-handle. Interesting. :) This was put there in response to aklein's criticism the the panel UI makes it hard to jump to a specific test in a long list compared to the accordion UI which showed you more tests at a time. 615877 5 abarth 2012-05-03 18:43:14 -0700 I should boot up garden-o-matic to see what amazingness you've brought to the tool. Thanks for improving it. :) 615888 6 140142 webkit.review.bot 2012-05-03 18:56:36 -0700 Comment on attachment 140142 Patch Clearing flags on attachment: 140142 Committed r116062: <http://trac.webkit.org/changeset/116062> 615889 7 webkit.review.bot 2012-05-03 18:56:42 -0700 All reviewed patches have been landed. Closing bug. 140142 2012-05-03 18:30:38 -0700 2012-05-03 18:56:36 -0700 Patch bug-85566-20120503183037.patch text/plain 5927 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MDQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjgxM2MzMGY2ODg1MmE1YTdhODQ1ZjZmZjg5NWM5YTJl ZWNhNWNmNy4uMzdmNDAxNDdjZWI1Y2ExNTE3NzdlNDM1NDg3YTFiN2FmZjU1OGYwZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDEyLTA1LTAzICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAg ICAgSW1wcm92ZSBVSSBmb3IgZ2FyZGVuLW8tbWF0aWMgZXhhbWluZSB2aWV3IHdoZW4gdGhlcmUg YXJlIGZld2VyIHRoYW4gNSB0ZXN0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg1NTY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9yZXN1bHRzLmpzOgorICAgICAg ICAoLik6CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvcmVzdWx0c191bml0dGVzdHMu anM6CisgICAgICAgICguKToKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc3R5bGVzL3Jlc3VsdHMuY3Nz OgorCisyMDEyLTA1LTAzICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKICAgICAg ICAgRml4IG1vZGlmaWVyIGFuZCBidWcgc29ydGluZyBvbiB0aGUgZmxha2luZXNzIGRhc2hib2Fy ZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU1NTQK IApkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvcmVzdWx0cy5qcyBiL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpL3Jlc3VsdHMuanMKaW5kZXggNzI1YWIwMzc3NzhmODIw M2E5YTFlNmZmMDk1YjU5M2JkZjE3ZDA5Zi4uYjFmN2U4NGU4Mjk5OWUwM2MwNDg2YTRlMThhMzYz YjM2ZGU4ZDdkMiAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Vi a2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvcmVzdWx0 cy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9yZXN1bHRzLmpzCkBAIC0yNDAs NyArMjQwLDggQEAgdWkucmVzdWx0cy5UZXN0U2VsZWN0b3IgPSBiYXNlLmV4dGVuZHMoJ2Rpdics IHsKICAgICAgICAgdGhpcy5fZmxha2luZXNzRGF0YSA9IG5ldyB1aS5yZXN1bHRzLkZsYWtpbmVz c0RhdGEoKTsKICAgICAgICAgdGhpcy5hcHBlbmRDaGlsZCh0aGlzLl9mbGFraW5lc3NEYXRhKTsK IAotICAgICAgICBPYmplY3Qua2V5cyhyZXN1bHRzQnlUZXN0KS5zb3J0KCkuZm9yRWFjaChmdW5j dGlvbih0ZXN0TmFtZSkgeworICAgICAgICB2YXIgdGVzdE5hbWVzID0gT2JqZWN0LmtleXMocmVz dWx0c0J5VGVzdCk7CisgICAgICAgIHRlc3ROYW1lcy5zb3J0KCkuZm9yRWFjaChmdW5jdGlvbih0 ZXN0TmFtZSkgewogICAgICAgICAgICAgdmFyIG5vbkxpbmtUaXRsZSA9IGRvY3VtZW50LmNyZWF0 ZUVsZW1lbnQoJ2EnKTsKICAgICAgICAgICAgIG5vbkxpbmtUaXRsZS5jbGFzc0xpc3QuYWRkKCdu b24tbGluay10aXRsZScpOwogICAgICAgICAgICAgbm9uTGlua1RpdGxlLnRleHRDb250ZW50ID0g dGVzdE5hbWU7CkBAIC0yNTYsNiArMjU3LDE0IEBAIHVpLnJlc3VsdHMuVGVzdFNlbGVjdG9yID0g YmFzZS5leHRlbmRzKCdkaXYnLCB7CiAgICAgICAgICAgICBoZWFkZXIuYWRkRXZlbnRMaXN0ZW5l cignY2xpY2snLCB0aGlzLl9zaG93UmVzdWx0cy5iaW5kKHRoaXMsIGhlYWRlcikpOwogICAgICAg ICAgICAgdG9wUGFuZWwuYXBwZW5kQ2hpbGQoaGVhZGVyKTsKICAgICAgICAgfSwgdGhpcyk7CisK KyAgICAgICAgLy8gSWYgd2UgaGF2ZSBhIHNtYWxsIGFtb3VudCBvZiBjb250ZW50LCBkb24ndCBz aG93IHRoZSByZXNpemUgaGFuZGxlci4KKyAgICAgICAgLy8gT3RoZXJ3aXNlLCBzZXQgdGhlIG1p bkhlaWdodCBzbyB0aGF0IHRoZSBwZXJjZW50YWdlIGhlaWdodCBvZiB0aGUgCisgICAgICAgIC8v IHRvcFBhbmVsIGlzIG5vdCB0b28gc21hbGwuCisgICAgICAgIGlmICh0ZXN0TmFtZXMubGVuZ3Ro IDw9IDQpCisgICAgICAgICAgICB0aGlzLnJlbW92ZUNoaWxkKHRoaXMucXVlcnlTZWxlY3Rvcign LnJlc2l6ZS1oYW5kbGUnKSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHRvcFBhbmVsLnN0 eWxlLm1pbkhlaWdodCA9ICcxMDBweCc7CiAgICAgfSwKICAgICBfYXBwZW5kUmVzaXplSGFuZGxl OiBmdW5jdGlvbigpCiAgICAgewpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMv dWkvcmVzdWx0c191bml0dGVzdHMuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9yZXN1 bHRzX3VuaXR0ZXN0cy5qcwppbmRleCBiZGM4OWE1Mzk4M2FmODU2NWU5MzAwNWRiMjFkMmQ1MDc0 MTVhYWExLi4xYTRkNTUwODBjZDZjYjZmZWVkYjU0ZTc2YTcyNmQzMDAwZDJiOWQ3IDEwMDY0NAot LS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9yZXN1bHRzX3VuaXR0ZXN0cy5qcworKysg Yi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNf aHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9yZXN1bHRzX3VuaXR0ZXN0cy5qcwpAQCAtODks NyArODksNDAgQEAgdmFyIGtFeGFtcGxlUmVzdWx0c1dpdGhUaW1lb3V0QnlUZXN0ID0gewogICAg IH0KIH07CiAKLXRlc3QoJ1ZpZXcnLCAxNiwgZnVuY3Rpb24oKSB7Cit2YXIga0V4YW1wbGVHcmVh dGVyVGhhbkZvdXJSZXN1bHRzQnlUZXN0ID0geworICAgICJzY3JvbGxiYXJzL2N1c3RvbS1zY3Jv bGxiYXItd2l0aC1pbmNvbXBsZXRlLXN0eWxlLmh0bWwiOiB7CisgICAgICAgICJNb2NrIExpbnV4 IjogeworICAgICAgICAgICAgImV4cGVjdGVkIjogIlRFWFQiLAorICAgICAgICAgICAgImFjdHVh bCI6ICJDUkFTSCIKKyAgICAgICAgfQorICAgIH0sCisgICAgInNjcm9sbGJhcnMvMS5odG1sIjog eworICAgICAgICAiTW9jayBMaW51eCI6IHsKKyAgICAgICAgICAgICJleHBlY3RlZCI6ICJURVhU IiwKKyAgICAgICAgICAgICJhY3R1YWwiOiAiQ1JBU0giCisgICAgICAgIH0KKyAgICB9LAorICAg ICJzY3JvbGxiYXJzLzIuaHRtbCI6IHsKKyAgICAgICAgIk1vY2sgTGludXgiOiB7CisgICAgICAg ICAgICAiZXhwZWN0ZWQiOiAiVEVYVCIsCisgICAgICAgICAgICAiYWN0dWFsIjogIkNSQVNIIgor ICAgICAgICB9CisgICAgfSwKKyAgICAic2Nyb2xsYmFycy8zLmh0bWwiOiB7CisgICAgICAgICJN b2NrIExpbnV4IjogeworICAgICAgICAgICAgImV4cGVjdGVkIjogIlRFWFQiLAorICAgICAgICAg ICAgImFjdHVhbCI6ICJDUkFTSCIKKyAgICAgICAgfQorICAgIH0sCisgICAgInVzZXJzY3JpcHRz L2Fub3RoZXItdGVzdC5odG1sIjogeworICAgICAgICAiTW9jayBCdWlsZGVyIjogeworICAgICAg ICAgICAgImV4cGVjdGVkIjogIlBBU1MiLAorICAgICAgICAgICAgImFjdHVhbCI6ICJURVhUIgor ICAgICAgICB9CisgICAgfQorfTsKKwordGVzdCgnVmlldycsIDE4LCBmdW5jdGlvbigpIHsKICAg ICB2YXIgZGVsZWdhdGUgPSB7CiAgICAgICAgIGZldGNoUmVzdWx0c1VSTHM6IGZ1bmN0aW9uKGZh aWx1cmVJbmZvLCBjYWxsYmFjaykgeyByZXR1cm47IH0KICAgICB9OwpAQCAtMTI2LDkgKzE1OSwy NyBAQCB0ZXN0KCdWaWV3JywgMTYsIGZ1bmN0aW9uKCkgewogICAgIGVxdWFscyh0b3BQYW5lbC5j aGlsZE5vZGVzWzBdLCB0b3BQYW5lbC5xdWVyeVNlbGVjdG9yKCcuYWN0aXZlJykpOzsKICAgICBl cXVhbHMoJCgkKCcuYnVpbGRlci1zZWxlY3RvcicsIHZpZXcpWzBdKS50YWJzKCdvcHRpb24nLCAn c2VsZWN0ZWQnKSwgMSk7CiAgICAgZXF1YWxzKHZpZXcuY3VycmVudFRlc3ROYW1lKCksICdzY3Jv bGxiYXJzL2N1c3RvbS1zY3JvbGxiYXItd2l0aC1pbmNvbXBsZXRlLXN0eWxlLmh0bWwnKTsKKwor ICAgIG9rKCF0ZXN0U2VsZWN0b3IucXVlcnlTZWxlY3RvcignLnJlc2l6ZS1oYW5kbGUnKSk7Cisg ICAgZXF1YWxzKHRvcFBhbmVsLnN0eWxlLm1pbkhlaWdodCwgJycpOworfSk7CisKK3Rlc3QoJ1Zp ZXcgd2l0aCBtb3JlIHRoYW4gZm91ciB0ZXN0cycsIDIsIGZ1bmN0aW9uKCkgeworICAgIHZhciBk ZWxlZ2F0ZSA9IHsKKyAgICAgICAgZmV0Y2hSZXN1bHRzVVJMczogZnVuY3Rpb24oZmFpbHVyZUlu Zm8sIGNhbGxiYWNrKSB7IHJldHVybjsgfQorICAgIH07CisKKyAgICB2YXIgdmlldyA9IG5ldyB1 aS5yZXN1bHRzLlZpZXcoZGVsZWdhdGUpOworICAgIHZpZXcuc2V0UmVzdWx0c0J5VGVzdChrRXhh bXBsZUdyZWF0ZXJUaGFuRm91clJlc3VsdHNCeVRlc3QpOworCisgICAgdmFyIHRlc3RTZWxlY3Rv ciA9IHZpZXcucXVlcnlTZWxlY3RvcignLnRlc3Qtc2VsZWN0b3InKTsKKyAgICB2YXIgdG9wUGFu ZWwgPSB0ZXN0U2VsZWN0b3IucXVlcnlTZWxlY3RvcignLnRvcC1wYW5lbCcpOworCisgICAgb2so dGVzdFNlbGVjdG9yLnF1ZXJ5U2VsZWN0b3IoJy5yZXNpemUtaGFuZGxlJykpOworICAgIGVxdWFs cyh0b3BQYW5lbC5zdHlsZS5taW5IZWlnaHQsICcxMDBweCcpOwogfSk7CiAKLXRlc3QoJ1ZpZXcn LCAyLCBmdW5jdGlvbigpIHsKK3Rlc3QoJ1ZpZXcgd2l0aCByZWZ0ZXN0cycsIDIsIGZ1bmN0aW9u KCkgewogICAgIHZhciBkZWxlZ2F0ZSA9IHsKICAgICAgICAgZmV0Y2hSZXN1bHRzVVJMczogZnVu Y3Rpb24oZmFpbHVyZUluZm8sIGNhbGxiYWNrKSB7IHJldHVybjsgfQogICAgIH07CmRpZmYgLS1n aXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9UZXN0RmFpbHVyZXMvc3R5bGVzL3Jlc3VsdHMuY3NzIGIvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVz L3N0eWxlcy9yZXN1bHRzLmNzcwppbmRleCAwZjE3ODQ4Mzc3YzVhMDE4MTAyYWQ2Mjg2MTU5NmNj Nzg1NmZhM2ZiLi44NjljYTY0YTc3ZjI3M2MxNWYyNjNhZTcyODVmM2U4YTFlYjE0OWJkIDEwMDY0 NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc3R5bGVzL3Jlc3VsdHMuY3NzCisrKyBiL1Rvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RG YWlsdXJlcy9zdHlsZXMvcmVzdWx0cy5jc3MKQEAgLTkyLDcgKzkyLDYgQEAKIH0KIAogLnJlc3Vs dHMtdmlldyAudG9wLXBhbmVsIHsKLSAgICBtaW4taGVpZ2h0OiAxMDBweDsKICAgICBtYXgtaGVp Z2h0OiAyMCU7CiAgICAgb3ZlcmZsb3c6IGF1dG87CiAgICAgcG9zaXRpb246IHJlbGF0aXZlOwo=