85549 2012-05-03 15:20:21 -0700 webkitpy: Use PlatformInfo wherever possible in the User class. 2012-05-03 16:44:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco abarth dpranke eric ojan webkit.review.bot oldest_to_newest 615690 0 rakuco 2012-05-03 15:20:21 -0700 webkitpy: Use PlatformInfo wherever possible in the User class. 615693 1 140110 rakuco 2012-05-03 15:23:08 -0700 Created attachment 140110 Patch 615703 2 140110 dpranke 2012-05-03 15:35:24 -0700 Comment on attachment 140110 Patch looks fine. Can you add a FIXME: to go find all of the callers of User() and update them? 615788 3 rakuco 2012-05-03 16:44:47 -0700 Committed r116042: <http://trac.webkit.org/changeset/116042> 140110 2012-05-03 15:23:08 -0700 2012-05-03 15:35:23 -0700 Patch bug-85549-20120503192308.patch text/plain 2518 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MDIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjFlODllNmIzZWZjMDdkZmZiYmNhNTg1MGM4MmFmNWMy Nzc4MWQwOC4uZDM2YmEzYTQ2NWYyODFjNDY4ZGU0NDkxZTAxN2ZlMjQ0NzQ0YmIyZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDEyLTA1LTAzICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29Ad2Via2l0Lm9y Zz4KIAorICAgICAgICB3ZWJraXRweTogVXNlIFBsYXRmb3JtSW5mbyB3aGVyZXZlciBwb3NzaWJs ZSBpbiB0aGUgVXNlciBjbGFzcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg1NTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSW5zdGVhZCBvZiByZWx5aW5nIG9uIHN5cy5wbGF0Zm9ybSB0byBkZXRlY3Qg d2hldGhlciB0aGUgY3VycmVudAorICAgICAgICBwbGF0Zm9ybSBpcyBhIE1hYywgdXNlIHRoZSBQ bGF0Zm9ybUluZm8gY2xhc3MgaW5zdGVhZC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv Y29tbW9uL3N5c3RlbS91c2VyLnB5OgorICAgICAgICAoVXNlci5fX2luaXRfXyk6CisgICAgICAg IChVc2VyLmVkaXRfY2hhbmdlbG9nKToKKworMjAxMi0wNS0wMyAgUmFwaGFlbCBLdWJvIGRhIENv c3RhICA8cmFrdWNvQHdlYmtpdC5vcmc+CisKICAgICAgICAgd2Via2l0cHk6IFJlbW92ZSBjaGVj ayBmb3IgcmVhZGxpbmUgb24gTWFjLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODU1NDcKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vc3lzdGVtL3VzZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9z eXN0ZW0vdXNlci5weQppbmRleCBmYWM0NmQ0MGFkNThmODcxY2MxOTBhNmJjYzE4YWQ3MjM1YWM5 ZDRmLi5lMjA0MDU5MTI4ZGE0MmQ4MzA4YWI2MGRjZTRjNTA5MTAwYzEzZTc1IDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vdXNlci5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vdXNlci5weQpAQCAtMjksMTIgKzI5LDE2 IEBACiBpbXBvcnQgZ2V0cGFzcwogaW1wb3J0IGxvZ2dpbmcKIGltcG9ydCBvcworaW1wb3J0IHBs YXRmb3JtCiBpbXBvcnQgcmUKIGltcG9ydCBzaGxleAogaW1wb3J0IHN1YnByb2Nlc3MKIGltcG9y dCBzeXMKIGltcG9ydCB3ZWJicm93c2VyCiAKK2Zyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5l eGVjdXRpdmUgaW1wb3J0IEV4ZWN1dGl2ZQorZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLnBs YXRmb3JtaW5mbyBpbXBvcnQgUGxhdGZvcm1JbmZvCisKIAogX2xvZyA9IGxvZ2dpbmcuZ2V0TG9n Z2VyKF9fbmFtZV9fKQogCkBAIC01MSw2ICs1NSwxMSBAQCBjbGFzcyBVc2VyKG9iamVjdCk6CiAg ICAgREVGQVVMVF9OTyA9ICduJwogICAgIERFRkFVTFRfWUVTID0gJ3knCiAKKyAgICBkZWYgX19p bml0X18oc2VsZiwgcGxhdGZvcm1pbmZvPU5vbmUpOgorICAgICAgICAjIFdlIGNhbm5vdCBnZXQg dGhlIFBsYXRmb3JtSW5mbyBvYmplY3QgZnJvbSBhIFN5c3RlbUhvc3QgYmVjYXVzZQorICAgICAg ICAjIFVzZXIgaXMgcGFydCBvZiBTeXN0ZW1Ib3N0IGl0c2VsZi4KKyAgICAgICAgc2VsZi5fcGxh dGZvcm1pbmZvID0gcGxhdGZvcm1pbmZvIG9yIFBsYXRmb3JtSW5mbyhzeXMsIHBsYXRmb3JtLCBF eGVjdXRpdmUoKSkKKwogICAgICMgRklYTUU6IFRoZXNlIGFyZSBAY2xhc3NtZXRob2RzIGJlY2F1 c2UgYnVnemlsbGEucHkgZG9lc24ndCBoYXZlIGEgVG9vbCBvYmplY3QgKHRodXMgbm8gVXNlciBp bnN0YW5jZSkuCiAgICAgQGNsYXNzbWV0aG9kCiAgICAgZGVmIHByb21wdChjbHMsIG1lc3NhZ2Us IHJlcGVhdD0xLCByYXdfaW5wdXQ9cmF3X2lucHV0KToKQEAgLTEwMiw3ICsxMTEsNyBAQCBjbGFz cyBVc2VyKG9iamVjdCk6CiAKICAgICBkZWYgZWRpdF9jaGFuZ2Vsb2coc2VsZiwgZmlsZXMpOgog ICAgICAgICBlZGl0X2FwcGxpY2F0aW9uID0gb3MuZW52aXJvbi5nZXQoIkNIQU5HRV9MT0dfRURJ VF9BUFBMSUNBVElPTiIpCi0gICAgICAgIGlmIGVkaXRfYXBwbGljYXRpb24gYW5kIHN5cy5wbGF0 Zm9ybSA9PSAiZGFyd2luIjoKKyAgICAgICAgaWYgZWRpdF9hcHBsaWNhdGlvbiBhbmQgc2VsZi5f cGxhdGZvcm1pbmZvLmlzX21hYygpOgogICAgICAgICAgICAgIyBPbiBNYWMgd2Ugc3VwcG9ydCBl ZGl0aW5nIENoYW5nZUxvZ3MgdXNpbmcgYW4gYXBwbGljYXRpb24uCiAgICAgICAgICAgICBhcmdz ID0gc2hsZXguc3BsaXQoZWRpdF9hcHBsaWNhdGlvbikKICAgICAgICAgICAgIHByaW50ICJVc2lu ZyBlZGl0b3IgaW4gdGhlIENIQU5HRV9MT0dfRURJVF9BUFBMSUNBVElPTiBlbnZpcm9ubWVudCB2 YXJpYWJsZS4iCg==