85530 2012-05-03 12:02:20 -0700 [chromium] Revise touchpad fling curve to use exponential curve, to improve feel and small fling performance. 2012-05-03 14:16:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wjmaclean wjmaclean rjkroege webkit.review.bot oldest_to_newest 615473 0 wjmaclean 2012-05-03 12:02:20 -0700 [chromium] Revise touchpad fling curve to use exponential curve, to improve feel and small fling performance. 615483 1 140064 wjmaclean 2012-05-03 12:10:35 -0700 Created attachment 140064 Patch 615493 2 140064 kbr 2012-05-03 12:30:33 -0700 Comment on attachment 140064 Patch The new magic constants look as good to me as the old magic constants, assuming they've been tested. r=me 615497 3 wjmaclean 2012-05-03 12:34:34 -0700 (In reply to comment #2) > (From update of attachment 140064 [details]) > The new magic constants look as good to me as the old magic constants, assuming they've been tested. r=me These will shortly be replaced by configurable parameters plumbed through from elsewhere :-) 615607 4 rjkroege 2012-05-03 14:07:30 -0700 FWIW: https://bugs.webkit.org/show_bug.cgi?id=81663 plumbs parameters to permit altering the magic constants. And the changes look good to me. 615617 5 140064 webkit.review.bot 2012-05-03 14:16:30 -0700 Comment on attachment 140064 Patch Clearing flags on attachment: 140064 Committed r116011: <http://trac.webkit.org/changeset/116011> 615618 6 webkit.review.bot 2012-05-03 14:16:34 -0700 All reviewed patches have been landed. Closing bug. 140064 2012-05-03 12:10:35 -0700 2012-05-03 14:16:30 -0700 Patch bug-85530-20120503151033.patch text/plain 5992 wjmaclean U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1ODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI3N2UzZWNkMmMzZTU3 NGI3OTQ1NzgxNzcxMWQ3OWQ5MzU3YjA1NC4uOTAwY2U0Nzg1ZGNjNzY1YzZhNzRmOTU5NDFkMGE3 MjE0MWZiYzlkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA1LTAzICBXLiBK YW1lcyBNYWNMZWFuICA8d2ptYWNsZWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21p dW1dIFJldmlzZSB0b3VjaHBhZCBmbGluZyBjdXJ2ZSB0byB1c2UgZXhwb25lbnRpYWwgY3VydmUs IHRvIGltcHJvdmUgZmVlbCBhbmQgc21hbGwgZmxpbmcgcGVyZm9ybWFuY2UuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTUzMAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4aXN0aW5nIHVuaXQgdGVzdHMg dXBkYXRlZCBmb3IgbmV3IGN1cnZlLgorCisgICAgICAgIE1vZGlmaWVzIFRvdWNocGFkRkxpbmdH ZXN0dXJlQ3VydmUgdG8gdXNlIGFuIGV4cG9uZW50aWFsLCByYXRoZXIgdGhhbiBwb2x5bm9taWFs LCBjdXJ2ZS4KKyAgICAgICAgVGhpcyBjaGFuZ2UgYXBwZWFycyB0byBpbXByb3ZlIHRoZSBvdmVy YWxsIGZlZWwgb2YgdG91Y2hwYWQgZmxpbmcsIGFuZCBzdWJzdGFudGlhbGx5CisgICAgICAgIGlt cHJvdmVzIHNtYWxsLWZsaW5nIHBlcmZvcm1hbmNlLgorCisgICAgICAgICogcGxhdGZvcm0vVG91 Y2hwYWRGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRv dWNocGFkRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZTo6Y3JlYXRlKToKKyAgICAgICAgKFdlYkNv cmUpOgorICAgICAgICAoV2ViQ29yZTo6cG9zaXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6dmVs b2NpdHkpOgorICAgICAgICAoV2ViQ29yZTo6VG91Y2hwYWRGbGluZ1BsYXRmb3JtR2VzdHVyZUN1 cnZlOjpUb3VjaHBhZEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmUpOgorCiAyMDEyLTA1LTAyICBQ YXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IENhbm5vdCByZWFkIHByb3BlcnR5ICdsZW5ndGgnIG9mIHVuZGVmaW5lZCBUZXh0RWRp dG9yTW9kZWwuanM6NDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDUxOGE5MGIyNWEy OTJjZDRjMmU2ODk2ZTRmYjAwZjk3MjE5MDVkYjguLjE0OTgzNWU0MGI5MWJlZmIyMWVhYmRlYTdh MWI1YmNkM2UyMTA2MGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTItMDUtMDMgIFcuIEphbWVzIE1hY0xlYW4gIDx3am1hY2xlYW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtjaHJvbWl1bV0gUmV2aXNlIHRvdWNocGFkIGZsaW5nIGN1cnZlIHRvIHVz ZSBleHBvbmVudGlhbCBjdXJ2ZSwgdG8gaW1wcm92ZSBmZWVsIGFuZCBzbWFsbCBmbGluZyBwZXJm b3JtYW5jZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg1NTMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiB0ZXN0cy9QbGF0Zm9ybUdlc3R1cmVDdXJ2ZVRlc3QuY3BwOgorCiAyMDEyLTA1LTAyICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIE1lZGlhU3RyZWFt IEFQSTogQ2hhbmdpbmcgd2Via2l0R2V0VXNlck1lZGlhIHRvIHRha2UgYW4gb2JqZWN0IGluc3Rl YWQgb2YgYSBzdHJpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1RvdWNo cGFkRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9Ub3VjaHBhZEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmUuY3BwCmluZGV4IDVmOWJhY2RhMmZj MDFkMjcyNWQxOTg0Y2UxZDc2YzgyZTFlZjI2ZmIuLjA5ZjE4NWE5ZjE0NmU1NDE3OGI1ZjQ3NmUw Y2Q0Mzc1NDdhYzJkYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1RvdWNo cGFkRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vVG91Y2hwYWRGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlLmNwcApAQCAtNTYsOSArNTYs MTEgQEAgY29uc3QgaW50IFRvdWNocGFkRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZTo6bV9tYXhT ZWFyY2hJdGVyYXRpb25zID0gMjA7CiBQYXNzT3duUHRyPFBsYXRmb3JtR2VzdHVyZUN1cnZlPiBU b3VjaHBhZEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmU6OmNyZWF0ZShjb25zdCBGbG9hdFBvaW50 JiB2ZWxvY2l0eSwgSW50UG9pbnQgY3VtdWxhdGl2ZVNjcm9sbCkKIHsKICAgICAvLyBUaGUgZGVm YXVsdCBwYXJhbWV0ZXJzIGxpc3RlZCBiZWxvdyBhcmUgYSBtYXRjaGVkIHNldCwgYW5kIHNob3Vs ZCBub3QgYmUgY2hhbmdlZCBpbmRlcGVuZGVudGx5IG9mIG9uZSBhbm90aGVyLgotICAgIHJldHVy biBjcmVhdGUodmVsb2NpdHksIDEuNTM5NWUrMDEsIDIuMDQ2NmUrMDQsIC0yLjk4OTllKzA0LCAy LjA1NzdlKzA0LCAtNS40OTY2ZSswMywgMS4xMjg0NDUsIGN1bXVsYXRpdmVTY3JvbGwpOworICAg IHJldHVybiBjcmVhdGUodmVsb2NpdHksIC01LjcwNzYyZSswMywgMS43MmUrMDIsIDMuN2UrMDAs IDAsIDAsIDEuMywgY3VtdWxhdGl2ZVNjcm9sbCk7CiB9CiAKKy8vIEZJWE1FOiBuZWVkIHRvIHJl bW92ZSBwMywgcDQgaGVyZSBhbmQgYmVsb3cgYXMgdGhleSBhcmUgbm90IHVzZWQgaW4gdGhlIGV4 cG9uZW50aWFsIGN1cnZlLCBidXQgbGVhdmUgaW4gZm9yIG5vdyB0byBmYWNpbGl0YXRlCisvLyB0 aGUgaW4tZmxpZ2h0IHBhdGNoIGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODE2NjMgLgogUGFzc093blB0cjxQbGF0Zm9ybUdlc3R1cmVDdXJ2ZT4gVG91Y2hwYWRG bGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlOjpjcmVhdGUoY29uc3QgRmxvYXRQb2ludCYgdmVsb2Np dHksIGZsb2F0IHAwLCBmbG9hdCBwMSwgZmxvYXQgcDIsIGZsb2F0IHAzLCBmbG9hdCBwNCwgZmxv YXQgY3VydmVEdXJhdGlvbiwgSW50UG9pbnQgY3VtdWxhdGl2ZVNjcm9sbCkKIHsKICAgICByZXR1 cm4gYWRvcHRQdHIobmV3IFRvdWNocGFkRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZSh2ZWxvY2l0 eSwgcDAsIHAxLCBwMiwgcDMsIHA0LCBjdXJ2ZUR1cmF0aW9uLCBjdW11bGF0aXZlU2Nyb2xsKSk7 CkBAIC02NiwxMiArNjgsMTIgQEAgUGFzc093blB0cjxQbGF0Zm9ybUdlc3R1cmVDdXJ2ZT4gVG91 Y2hwYWRGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlOjpjcmVhdGUoY29uc3QKIAogaW5saW5lIGRv dWJsZSBwb3NpdGlvbihkb3VibGUgdCwgZmxvYXQqIHApCiB7Ci0gICAgcmV0dXJuIHBbMF0gKyB0 ICogKHBbMV0gKyB0ICogKHBbMl0gKyB0ICogKHBbM10gKyB0ICogcFs0XSkpKTsKKyAgICByZXR1 cm4gcFswXSAqIGV4cCgtcFsyXSAqIHQpIC0gcFsxXSAqIHQgLSBwWzBdOwogfQogCiBpbmxpbmUg ZG91YmxlIHZlbG9jaXR5KGRvdWJsZSB0LCBmbG9hdCogcCkKIHsKLSAgICByZXR1cm4gcFsxXSAr IHQgKiAoMiAqIHBbMl0gKyB0ICogKDMgKiBwWzNdICsgdCAqIDQgKiBwWzRdKSk7CisgICAgcmV0 dXJuIC1wWzBdICogcFsyXSAqIGV4cCgtcFsyXSAqIHQpIC0gcFsxXTsKIH0KIAogVG91Y2hwYWRG bGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlOjpUb3VjaHBhZEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3Vy dmUoY29uc3QgRmxvYXRQb2ludCYgaW5pdGlhbFZlbG9jaXR5LCBmbG9hdCBwMCwgZmxvYXQgcDEs IGZsb2F0IHAyLCBmbG9hdCBwMywgZmxvYXQgcDQsIGZsb2F0IGN1cnZlRHVyYXRpb24sIGNvbnN0 IEludFBvaW50JiBjdW11bGF0aXZlU2Nyb2xsKQpAQCAtNzksMTkgKzgxLDIwIEBAIFRvdWNocGFk RmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZTo6VG91Y2hwYWRGbGluZ1BsYXRmb3JtR2VzdHVyZUN1 cnZlKGNvbnN0IEZsb2F0CiAgICAgLCBtX2N1cnZlRHVyYXRpb24oY3VydmVEdXJhdGlvbikKIHsK ICAgICBBU1NFUlQoaW5pdGlhbFZlbG9jaXR5ICE9IEZsb2F0UG9pbnQ6Onplcm8oKSk7Ci0gICAg bV9jb2VmZnNbMF0gPSBwMDsKLSAgICBtX2NvZWZmc1sxXSA9IHAxOwotICAgIG1fY29lZmZzWzJd ID0gcDI7Ci0gICAgbV9jb2VmZnNbM10gPSBwMzsKLSAgICBtX2NvZWZmc1s0XSA9IHA0OworCisg ICAgbV9jb2VmZnNbMF0gPSBwMDsgLy8gYWxwaGEKKyAgICBtX2NvZWZmc1sxXSA9IHAxOyAvLyBi ZXRhCisgICAgbV9jb2VmZnNbMl0gPSBwMjsgLy8gZ2FtbWEKKyAgICBtX2NvZWZmc1szXSA9IHAz OyAvLyBub3QgdXNlZAorICAgIG1fY29lZmZzWzRdID0gcDQ7IC8vIG5vdCB1c2VkCiAKICAgICBm bG9hdCBtYXhJbml0aWFsVmVsb2NpdHkgPSBtYXgoZmFicyhpbml0aWFsVmVsb2NpdHkueCgpKSwg ZmFicyhpbml0aWFsVmVsb2NpdHkueSgpKSk7CiAKICAgICAvLyBGb3JjZSBtYXhJbml0aWFsVmVs b2NpdHkgdG8gbGllIGluIHRoZSByYW5nZSB2KDApIHRvIHYoY3VydmVEdXJhdGlvbiksIGFuZCBh c3N1bWUgdGhhdAogICAgIC8vIHRoZSBjdXJ2ZSBwYXJhbWV0ZXJzIGRlZmluZSBhIG1vbm90b25p Y2FsbHkgZGVjcmVhc2luZyB2ZWxvY2l0eSwgb3IgZWxzZSBiaXNlY3Rpb24gc2VhcmNoIG1heQog ICAgIC8vIGZhaWwuCi0gICAgaWYgKG1heEluaXRpYWxWZWxvY2l0eSA+IG1fY29lZmZzWzFdKQot ICAgICAgICBtYXhJbml0aWFsVmVsb2NpdHkgPSBtX2NvZWZmc1sxXTsKKyAgICBpZiAobWF4SW5p dGlhbFZlbG9jaXR5ID4gdmVsb2NpdHkoMCwgbV9jb2VmZnMpKQorICAgICAgICBtYXhJbml0aWFs VmVsb2NpdHkgPSB2ZWxvY2l0eSgwLCBtX2NvZWZmcyk7CiAKICAgICBpZiAobWF4SW5pdGlhbFZl bG9jaXR5IDwgdmVsb2NpdHkobV9jdXJ2ZUR1cmF0aW9uLCBtX2NvZWZmcykpCiAgICAgICAgIG1h eEluaXRpYWxWZWxvY2l0eSA9IHZlbG9jaXR5KG1fY3VydmVEdXJhdGlvbiwgbV9jb2VmZnMpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9QbGF0Zm9ybUdlc3R1cmVD dXJ2ZVRlc3QuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9QbGF0Zm9ybUdlc3R1 cmVDdXJ2ZVRlc3QuY3BwCmluZGV4IGE1ZDcwNDMxYmM1NDE3Y2IzYjgwZjZhM2EzNTY0NDAyZTU2 NTE1M2MuLjM2MjcyN2MwNDQxZGM5OWYxNGEyZjdmYTk5MDBjMzViMWY0YzUyMDUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvUGxhdGZvcm1HZXN0dXJlQ3VydmVUZXN0 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1BsYXRmb3JtR2VzdHVyZUN1 cnZlVGVzdC5jcHAKQEAgLTExMCw3ICsxMTAsNyBAQCBURVNUKFBsYXRmb3JtR2VzdHVyZUN1cnZl LCBmbGluZ0N1cnZlVG91Y2gpCiAgICAgRVhQRUNUX1RSVUUoYW5pbWF0aW9uLT5hbmltYXRlKDAu NDUpKTsgLy8gVXNlIG5vbi11bmlmb3JtIHRpY2sgc3BhY2luZy4KICAgICBFWFBFQ1RfVFJVRShh bmltYXRpb24tPmFuaW1hdGUoMSkpOwogICAgIEVYUEVDVF9GQUxTRShhbmltYXRpb24tPmFuaW1h dGUoMS41KSk7Ci0gICAgRVhQRUNUX05FQVIodGFyZ2V0LmN1bXVsYXRpdmVEZWx0YSgpLngoKSwg MTA5NCwgMSk7CisgICAgRVhQRUNUX05FQVIodGFyZ2V0LmN1bXVsYXRpdmVEZWx0YSgpLngoKSwg MTE5MywgMSk7CiAgICAgRVhQRUNUX0VRKHRhcmdldC5jdW11bGF0aXZlRGVsdGEoKS55KCksIDAp OwogfQogCg==