85504 2012-05-03 08:52:47 -0700 webkitpy: Style checker broken when committing a PNG 2012-05-03 10:06:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tmpsantos tmpsantos abarth dpranke levin ojan webkit.review.bot oldest_to_newest 615306 0 tmpsantos 2012-05-03 08:52:47 -0700 $ ./Tools/Scripts/check-webkit-style -g HEAD Traceback (most recent call last): File "./Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check self._text_file_reader.process_file(file_path=path, line_numbers=None) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file self._processor.process(lines, file_path, **kwargs) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/checker.py", line 844, in process min_confidence) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/checker.py", line 619, in dispatch min_confidence) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/checker.py", line 593, in _create_checker checker = PNGChecker(file_path, handle_style_error) File "/opt/tmpsantos/projects/webkit-efl/Tools/Scripts/webkitpy/style/checkers/png.py", line 43, in __init__ self._fs = host.filesystem AttributeError: 'NoneType' object has no attribute 'filesystem' 615313 1 140026 tmpsantos 2012-05-03 08:57:03 -0700 Created attachment 140026 Patch 615319 2 140026 dpranke 2012-05-03 09:01:59 -0700 Comment on attachment 140026 Patch thanks for looking at this, but I'm pretty sure that would assign self._fs to host if host is non-null. Just change host to self._host on line 43. 615321 3 tmpsantos 2012-05-03 09:03:17 -0700 (In reply to comment #2) > (From update of attachment 140026 [details]) > thanks for looking at this, but I'm pretty sure that would assign self._fs to host if host is non-null. Just change host to self._host on line 43. Yeah, I noticed that when running the utests here. 615330 4 140032 tmpsantos 2012-05-03 09:15:16 -0700 Created attachment 140032 patch Fixes previous patch 615331 5 140032 dpranke 2012-05-03 09:16:03 -0700 Comment on attachment 140032 patch thanks! 615370 6 140032 webkit.review.bot 2012-05-03 10:06:34 -0700 Comment on attachment 140032 patch Clearing flags on attachment: 140032 Committed r115986: <http://trac.webkit.org/changeset/115986> 615372 7 webkit.review.bot 2012-05-03 10:06:46 -0700 All reviewed patches have been landed. Closing bug. 140026 2012-05-03 08:57:03 -0700 2012-05-03 09:15:16 -0700 Patch bug-85504-20120503185805.patch text/plain 1377 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1OTcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjE2YTk4NTQ2YzY3NzU2YWU4ZGRjN2E4OTdjMjQ0MWNm NWQ4ZDFjZC4uMDhkMGY0ZWJiYTlmMWNlOTI0YTZmZjY5Zjc2MTY0ODUzZjI5YWU3NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTA1LTAzICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgorCisgICAgICAgIHdlYmtpdHB5OiBTdHlsZSBjaGVja2VyIGJyb2tlbiB3aGVu IGNvbW1pdHRpbmcgYSBQTkcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg1NTA0CisKKyAgICAgICAgVW5yZXZpZXdlZCBicm9rZW4gdG9vbCBmaXguCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL3BuZy5weToKKyAgICAg ICAgKFBOR0NoZWNrZXIuX19pbml0X18pOgorCiAyMDEyLTA1LTAzICBaYW4gRG9iZXJzZWsgIDx6 YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgW0d0a10gSW1hZ2VEaWZmIGNyYXNoZXMg d2hlbiBpdCBjYW4ndCBvcGVuIGEgZGlzcGxheQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9wbmcucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL3BuZy5weQppbmRleCA4NWIxODk1ODNkNWFiNjNjNWNhOTA3ZjBkNjcxMjFh OTQ3OTk4YWM4Li4xZjJlNjhjMmRiNjMzN2YyNjMxY2QyNDYwNTM0ODNlYTc0OGRiN2E2IDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL3BuZy5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL3BuZy5weQpAQCAtNDAsNyAr NDAsNyBAQCBjbGFzcyBQTkdDaGVja2VyKG9iamVjdCk6CiAgICAgICAgIHNlbGYuX2ZpbGVfcGF0 aCA9IGZpbGVfcGF0aAogICAgICAgICBzZWxmLl9oYW5kbGVfc3R5bGVfZXJyb3IgPSBoYW5kbGVf c3R5bGVfZXJyb3IKICAgICAgICAgc2VsZi5faG9zdCA9IGhvc3Qgb3IgU3lzdGVtSG9zdCgpCi0g ICAgICAgIHNlbGYuX2ZzID0gaG9zdC5maWxlc3lzdGVtCisgICAgICAgIHNlbGYuX2ZzID0gaG9z dCBvciBTeXN0ZW1Ib3N0KCkuZmlsZXN5c3RlbQogICAgICAgICBzZWxmLl9kZXRlY3RvciA9IHNj bSBvciBTQ01EZXRlY3RvcihzZWxmLl9mcywgc2VsZi5faG9zdC5leGVjdXRpdmUpLmRldGVjdF9z Y21fc3lzdGVtKHNlbGYuX2ZzLmdldGN3ZCgpKQogCiAgICAgZGVmIGNoZWNrKHNlbGYsIGlubGlu ZT1Ob25lKToK 140032 2012-05-03 09:15:16 -0700 2012-05-03 10:06:33 -0700 patch png.patch text/plain 1207 tmpsantos ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyMTZh OTg1Li5hYTFlOTA2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDUtMDMgIFRoaWFnbyBNYXJjb3MgUC4gU2Fu dG9zICA8dGhpYWdvLnNhbnRvc0BpbnRlbC5jb20+CisKKyAgICAgICAgd2Via2l0cHk6IFN0eWxl IGNoZWNrZXIgYnJva2VuIHdoZW4gY29tbWl0dGluZyBhIFBORworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU1MDQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvcG5nLnB5OgorICAgICAgICAoUE5HQ2hlY2tlci5fX2luaXRfXyk6CisKIDIwMTItMDUt MDMgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAgICAgICBbR3Rr XSBJbWFnZURpZmYgY3Jhc2hlcyB3aGVuIGl0IGNhbid0IG9wZW4gYSBkaXNwbGF5CmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL3BuZy5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvcG5nLnB5CmluZGV4IDg1YjE4OTUuLmUw Yjc5ZTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv cG5nLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvcG5nLnB5 CkBAIC00MCw3ICs0MCw3IEBAIGNsYXNzIFBOR0NoZWNrZXIob2JqZWN0KToKICAgICAgICAgc2Vs Zi5fZmlsZV9wYXRoID0gZmlsZV9wYXRoCiAgICAgICAgIHNlbGYuX2hhbmRsZV9zdHlsZV9lcnJv ciA9IGhhbmRsZV9zdHlsZV9lcnJvcgogICAgICAgICBzZWxmLl9ob3N0ID0gaG9zdCBvciBTeXN0 ZW1Ib3N0KCkKLSAgICAgICAgc2VsZi5fZnMgPSBob3N0LmZpbGVzeXN0ZW0KKyAgICAgICAgc2Vs Zi5fZnMgPSBzZWxmLl9ob3N0LmZpbGVzeXN0ZW0KICAgICAgICAgc2VsZi5fZGV0ZWN0b3IgPSBz Y20gb3IgU0NNRGV0ZWN0b3Ioc2VsZi5fZnMsIHNlbGYuX2hvc3QuZXhlY3V0aXZlKS5kZXRlY3Rf c2NtX3N5c3RlbShzZWxmLl9mcy5nZXRjd2QoKSkKIAogICAgIGRlZiBjaGVjayhzZWxmLCBpbmxp bmU9Tm9uZSk6Cg==