85499 2012-05-03 07:57:08 -0700 [EFL] CSS tests needs gardening 2012-05-03 10:12:44 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tmpsantos tmpsantos gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 615276 0 tmpsantos 2012-05-03 07:57:08 -0700 What I'm doing now: - Rebaselining of all failing CSS tests. - Moving all CSS tests from Skipped list to test_expectations.txt and creating the appropriated bug. 615337 1 140034 tmpsantos 2012-05-03 09:26:20 -0700 Created attachment 140034 patch 615343 2 webkit.review.bot 2012-05-03 09:32:26 -0700 Attachment 140034 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check self._text_file_reader.process_file(file_path=path, line_numbers=None) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file self._processor.process(lines, file_path, **kwargs) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 844, in process min_confidence) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 619, in dispatch min_confidence) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 593, in _create_checker checker = PNGChecker(file_path, handle_style_error) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checkers/png.py", line 43, in __init__ self._fs = host.filesystem AttributeError: 'NoneType' object has no attribute 'filesystem' If any of these errors are false positives, please file a bug against check-webkit-style. 615345 3 tmpsantos 2012-05-03 09:35:04 -0700 (In reply to comment #2) > Attachment 140034 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 > Traceback (most recent call last): > File "Tools/Scripts/check-webkit-style", line 48, in <module> > sys.exit(CheckWebKitStyle().main()) > File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/main.py", line 154, in main > patch_checker.check(patch) > File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check > self._text_file_reader.process_file(file_path=path, line_numbers=None) > File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file > self._processor.process(lines, file_path, **kwargs) > File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 844, in process > min_confidence) > File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 619, in dispatch > min_confidence) > File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 593, in _create_checker > checker = PNGChecker(file_path, handle_style_error) > File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checkers/png.py", line 43, in __init__ > self._fs = host.filesystem > AttributeError: 'NoneType' object has no attribute 'filesystem' > > > If any of these errors are false positives, please file a bug against check-webkit-style. Thanks bot, but this was an issue (bug 85504) on the style checker that I already fixed but was not landed yet. :-P 615377 4 140034 webkit.review.bot 2012-05-03 10:12:33 -0700 Comment on attachment 140034 patch Clearing flags on attachment: 140034 Committed r115987: <http://trac.webkit.org/changeset/115987> 615378 5 webkit.review.bot 2012-05-03 10:12:44 -0700 All reviewed patches have been landed. Closing bug. 140034 2012-05-03 09:26:20 -0700 2012-05-03 10:12:33 -0700 patch css.patch text/plain 0 tmpsantos