85480 2012-05-03 05:24:22 -0700 Remove extra checks for empty string when parsing CSS value 2012-05-03 08:10:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cmarcelo cmarcelo koivisto macpherson menard webkit.review.bot oldest_to_newest 615181 0 cmarcelo 2012-05-03 05:24:22 -0700 Remove extra checks for empty string when parsing CSS value 615237 1 140002 cmarcelo 2012-05-03 06:38:57 -0700 Created attachment 140002 Patch 615285 2 140002 webkit.review.bot 2012-05-03 08:10:43 -0700 Comment on attachment 140002 Patch Clearing flags on attachment: 140002 Committed r115972: <http://trac.webkit.org/changeset/115972> 615286 3 webkit.review.bot 2012-05-03 08:10:47 -0700 All reviewed patches have been landed. Closing bug. 140002 2012-05-03 06:38:57 -0700 2012-05-03 08:10:42 -0700 Patch bug-85480-20120503103854.patch text/plain 6948 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1OTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjZmZGVkZWFjOWMwMjY4 NDNhMjYyMTE1NzUwZjA1OGIwNmM2ZTVkNS4uNjQ5Nzk3N2E4M2Y3ODE4OWY2Y2Y0NTJlZWQ5YTJm MGZmZmJjZDZmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA1LTAzICBDYWlv IE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+ CisKKyAgICAgICAgUmVtb3ZlIGV4dHJhIGNoZWNrcyBmb3IgZW1wdHkgc3RyaW5nIHdoZW4gcGFy c2luZyBDU1MgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg1NDgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRWFjaCBwYXJzZSB2YWx1ZSBoZWxwZXIgZnVuY3Rpb24gd2FzIGNoZWNraW5nIHdoZXRo ZXIgdGhlIHZhbHVlIHN0cmluZyB3YXMgZW1wdHkuIEZvciB0aGUKKyAgICAgICAgY29tbW9uIGNh c2UgdGhpcyBjaGVjayBpcyBhbHJlYWR5IGRvbmUgYnkgU3R5bGVQcm9wZXJ0eVNldDo6c2V0UHJv cGVydHkoKS4gU28gdGhpcyBwYXRjaAorICAgICAgICBtYWtlIENTU1BhcnNlcjo6cGFyc2VWYWx1 ZSgpIGFzc3VtZSB0aGUgdmFsdWUgc3RyaW5nIGlzIG5vdCBlbXB0eSwgYW5kIGZpeCB0aGUgb3Ro ZXIgdHdvCisgICAgICAgIGNsaWVudHMuCisKKyAgICAgICAgVGVzdDogZmFzdC9odG1sL2ZvbnQt ZmFjZS1lbXB0eS1zaG91bGQtbm90LWNyYXNoLmh0bWwKKworICAgICAgICAqIGNzcy9DU1NQYXJz ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFyc2VDb2xvclZhbHVlKTogUmVwbGFjZSB0aGUg c3RyaW5nIGVtcHR5IGNoZWNrIGJ5IGFuIEFTU0VSVCgpIHRvIGRvY3VtZW50CisgICAgICAgIGZ1 bmN0aW9uJ3MgZXhwZWN0YXRpb25zLgorICAgICAgICAoV2ViQ29yZTo6cGFyc2VTaW1wbGVMZW5n dGhWYWx1ZSk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6cGFyc2VLZXl3b3JkVmFsdWUpOiBE aXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VGb250RmFjZVZhbHVlKTog VGhpcyB3aWxsIGJlIGNvdmVyZWQgYnkgdGhlIGFkZGVkIHRlc3QuCisgICAgICAgIChXZWJDb3Jl OjpDU1NQYXJzZXI6OnBhcnNlVmFsdWUpOgorICAgICAgICAqIGNzcy9XZWJLaXRDU1NNYXRyaXgu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViS2l0Q1NTTWF0cml4OjpzZXRNYXRyaXhWYWx1ZSk6 IFRoaXMgaXMgYWxyZWFkeSBjb3ZlcmVkIGJ5CisgICAgICAgIHRyYW5zZm9ybXMvY3NzbWF0cml4 LTJkLWludGVyZmFjZS54aHRtbC4KKwogMjAxMi0wNS0wMyAgQW5kcmV5IEtvc3lha292ICA8Y2Fz ZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYXR0ZW1wIHRvIGZpeCBjaHJv bWl1bSB3aW4gYnVpbGQgYnJva2VuIGF0IHIxMTU5NDMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3Bw CmluZGV4IDA1YTM2MWFjYTQyNGY1M2ZhOGJkYjZiMGRiMTI2ZmY1ZDA5MTAwYzIuLmU2Y2Q3ODg2 NjkzNmU0MWM2YzViZjdiZjQxZTE0NjU5OTg5NWViYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCkBAIC0zNjIsOSArMzYyLDggQEAgc3RhdGljIGlubGluZSBib29sIGlzQ29sb3JQcm9wZXJ0 eUlEKENTU1Byb3BlcnR5SUQgcHJvcGVydHlJZCkKIAogc3RhdGljIGJvb2wgcGFyc2VDb2xvclZh bHVlKFN0eWxlUHJvcGVydHlTZXQqIGRlY2xhcmF0aW9uLCBDU1NQcm9wZXJ0eUlEIHByb3BlcnR5 SWQsIGNvbnN0IFN0cmluZyYgc3RyaW5nLCBib29sIGltcG9ydGFudCwgQ1NTUGFyc2VyTW9kZSBj c3NQYXJzZXJNb2RlKQogeworICAgIEFTU0VSVCghc3RyaW5nLmlzRW1wdHkoKSk7CiAgICAgYm9v bCBzdHJpY3QgPSBpc1N0cmljdFBhcnNlck1vZGUoY3NzUGFyc2VyTW9kZSk7Ci0gICAgaWYgKCFz dHJpbmcubGVuZ3RoKCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoIWlzQ29sb3JQ cm9wZXJ0eUlEKHByb3BlcnR5SWQpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgQ1NTUGFy c2VyU3RyaW5nIGNzc1N0cmluZzsKQEAgLTQ0MiwxMyArNDQxLDExIEBAIHN0YXRpYyBpbmxpbmUg Ym9vbCBpc1NpbXBsZUxlbmd0aFByb3BlcnR5SUQoQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eUlkLCBi b29sJiBhY2NlCiAKIHN0YXRpYyBib29sIHBhcnNlU2ltcGxlTGVuZ3RoVmFsdWUoU3R5bGVQcm9w ZXJ0eVNldCogZGVjbGFyYXRpb24sIENTU1Byb3BlcnR5SUQgcHJvcGVydHlJZCwgY29uc3QgU3Ry aW5nJiBzdHJpbmcsIGJvb2wgaW1wb3J0YW50LCBDU1NQYXJzZXJNb2RlIGNzc1BhcnNlck1vZGUp CiB7CisgICAgQVNTRVJUKCFzdHJpbmcuaXNFbXB0eSgpKTsKICAgICBib29sIGFjY2VwdHNOZWdh dGl2ZU51bWJlcnM7CiAgICAgYm9vbCBzdHJpY3QgPSBpc1N0cmljdFBhcnNlck1vZGUoY3NzUGFy c2VyTW9kZSk7CiAgICAgdW5zaWduZWQgbGVuZ3RoID0gc3RyaW5nLmxlbmd0aCgpOwogCi0gICAg aWYgKCFsZW5ndGgpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQogICAgIGRvdWJsZSBudW1iZXI7 CiAgICAgYm9vbCBvazsKICAgICBDU1NQcmltaXRpdmVWYWx1ZTo6VW5pdFR5cGVzIHVuaXQgPSBD U1NQcmltaXRpdmVWYWx1ZTo6Q1NTX05VTUJFUjsKQEAgLTkzMyw4ICs5MzAsNyBAQCBzdGF0aWMg aW5saW5lIGJvb2wgaXNLZXl3b3JkUHJvcGVydHlJRChDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SWQp CiAKIHN0YXRpYyBib29sIHBhcnNlS2V5d29yZFZhbHVlKFN0eWxlUHJvcGVydHlTZXQqIGRlY2xh cmF0aW9uLCBDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SWQsIGNvbnN0IFN0cmluZyYgc3RyaW5nLCBi b29sIGltcG9ydGFudCkKIHsKLSAgICBpZiAoc3RyaW5nLmlzRW1wdHkoKSkKLSAgICAgICAgcmV0 dXJuIGZhbHNlOworICAgIEFTU0VSVCghc3RyaW5nLmlzRW1wdHkoKSk7CiAKICAgICBpZiAoIWlz S2V5d29yZFByb3BlcnR5SUQocHJvcGVydHlJZCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKQEAg LTk2Myw2ICs5NTksOCBAQCBzdGF0aWMgYm9vbCBwYXJzZUtleXdvcmRWYWx1ZShTdHlsZVByb3Bl cnR5U2V0KiBkZWNsYXJhdGlvbiwgQ1NTUHJvcGVydHlJRCBwcm9wZQogCiBQYXNzUmVmUHRyPENT U1ZhbHVlTGlzdD4gQ1NTUGFyc2VyOjpwYXJzZUZvbnRGYWNlVmFsdWUoY29uc3QgQXRvbWljU3Ry aW5nJiBzdHJpbmcpCiB7CisgICAgaWYgKHN0cmluZy5pc0VtcHR5KCkpCisgICAgICAgIHJldHVy biAwOwogICAgIFJlZlB0cjxTdHlsZVByb3BlcnR5U2V0PiBkdW1teVN0eWxlID0gU3R5bGVQcm9w ZXJ0eVNldDo6Y3JlYXRlKCk7CiAgICAgaWYgKCFwYXJzZVZhbHVlKGR1bW15U3R5bGUuZ2V0KCks IENTU1Byb3BlcnR5Rm9udEZhbWlseSwgc3RyaW5nLCBmYWxzZSwgQ1NTUXVpcmtzTW9kZSwgMCkp CiAgICAgICAgIHJldHVybiAwOwpAQCAtOTcxLDYgKzk2OSw3IEBAIFBhc3NSZWZQdHI8Q1NTVmFs dWVMaXN0PiBDU1NQYXJzZXI6OnBhcnNlRm9udEZhY2VWYWx1ZShjb25zdCBBdG9taWNTdHJpbmcm IHN0cmluCiAKIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZVZhbHVlKFN0eWxlUHJvcGVydHlTZXQqIGRl Y2xhcmF0aW9uLCBDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SUQsIGNvbnN0IFN0cmluZyYgc3RyaW5n LCBib29sIGltcG9ydGFudCwgQ1NTUGFyc2VyTW9kZSBjc3NQYXJzZXJNb2RlLCBTdHlsZVNoZWV0 SW50ZXJuYWwqIGNvbnRleHRTdHlsZVNoZWV0KQogeworICAgIEFTU0VSVCghc3RyaW5nLmlzRW1w dHkoKSk7CiAgICAgaWYgKHBhcnNlU2ltcGxlTGVuZ3RoVmFsdWUoZGVjbGFyYXRpb24sIHByb3Bl cnR5SUQsIHN0cmluZywgaW1wb3J0YW50LCBjc3NQYXJzZXJNb2RlKSkKICAgICAgICAgcmV0dXJu IHRydWU7CiAgICAgaWYgKHBhcnNlQ29sb3JWYWx1ZShkZWNsYXJhdGlvbiwgcHJvcGVydHlJRCwg c3RyaW5nLCBpbXBvcnRhbnQsIGNzc1BhcnNlck1vZGUpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL1dlYktpdENTU01hdHJpeC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0 Q1NTTWF0cml4LmNwcAppbmRleCBkYzk1Mjk0ZDg0NGQ0ZGRlNWQxMzYwZjIxY2I2YTRjYzk2OWIw ODJjLi45MmJmY2UzNTQ4MjEyYTk0MWE4MjgzOWFlYmI4YWJlMTE5YTNiOTYzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTTWF0cml4LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvV2ViS2l0Q1NTTWF0cml4LmNwcApAQCAtNTIsNiArNTIsOSBAQCBXZWJLaXRDU1NN YXRyaXg6On5XZWJLaXRDU1NNYXRyaXgoKQogCiB2b2lkIFdlYktpdENTU01hdHJpeDo6c2V0TWF0 cml4VmFsdWUoY29uc3QgU3RyaW5nJiBzdHJpbmcsIEV4Y2VwdGlvbkNvZGUmIGVjKQogeworICAg IGlmIChzdHJpbmcuaXNFbXB0eSgpKQorICAgICAgICByZXR1cm47CisKICAgICBSZWZQdHI8U3R5 bGVQcm9wZXJ0eVNldD4gc3R5bGVEZWNsYXJhdGlvbiA9IFN0eWxlUHJvcGVydHlTZXQ6OmNyZWF0 ZSgpOwogICAgIGlmIChDU1NQYXJzZXI6OnBhcnNlVmFsdWUoc3R5bGVEZWNsYXJhdGlvbi5nZXQo KSwgQ1NTUHJvcGVydHlXZWJraXRUcmFuc2Zvcm0sIHN0cmluZywgdHJ1ZSwgQ1NTU3RyaWN0TW9k ZSwgMCkpIHsKICAgICAgICAgLy8gQ29udmVydCB0byBUcmFuc2Zvcm1PcGVyYXRpb25zLiBUaGlz IGNhbiBmYWlsIGlmIGEgcHJvcGVydHkKQEAgLTgwLDcgKzgzLDcgQEAgdm9pZCBXZWJLaXRDU1NN YXRyaXg6OnNldE1hdHJpeFZhbHVlKGNvbnN0IFN0cmluZyYgc3RyaW5nLCBFeGNlcHRpb25Db2Rl JiBlYykKIAogICAgICAgICAvLyBzZXQgdGhlIG1hdHJpeAogICAgICAgICBtX21hdHJpeCA9IHQ7 Ci0gICAgfSBlbHNlIGlmICghc3RyaW5nLmlzRW1wdHkoKSkgLy8gVGhlcmUgaXMgc29tZXRoaW5n IHRoZXJlIGJ1dCBwYXJzaW5nIGZhaWxlZAorICAgIH0gZWxzZSAvLyBUaGVyZSBpcyBzb21ldGhp bmcgdGhlcmUgYnV0IHBhcnNpbmcgZmFpbGVkLgogICAgICAgICBlYyA9IFNZTlRBWF9FUlI7CiB9 CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCAzMDA2YjRlOGFhNzE1YmIwNmE1NzIyZTNmYTYzNjA3MTgwYzcxNDdiLi42OTBl NGU3NjcyOTA3N2E4NGUyMmNhYWE0OWFiMTA3M2Q2NzRmZDFlIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTItMDUtMDMgIENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xp dmVpcmFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBSZW1vdmUgZXh0cmEgY2hlY2tzIGZvciBl bXB0eSBzdHJpbmcgd2hlbiBwYXJzaW5nIENTUyB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU0ODAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvaHRtbC9mb250LWZhY2UtZW1wdHktc2hv dWxkLW5vdC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvaHRtbC9m b250LWZhY2UtZW1wdHktc2hvdWxkLW5vdC1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxMi0wNS0w MyAgVWRheSBLaXJhbiAgPHVkYXlraXJhbkBtb3Rvcm9sYS5jb20+CiAKICAgICAgICAgQ1NTIGNs aXA6IGF1dG8gY2xpcHMgdG8gYm94IGJvcmRlcnMgaW5zdGVhZCBvZiByZW1vdmluZyBjbGlwcGlu ZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9odG1sL2ZvbnQtZmFjZS1lbXB0eS1zaG91 bGQtbm90LWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvaHRtbC9mb250LWZh Y2UtZW1wdHktc2hvdWxkLW5vdC1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMDM4MzE2 MjBmNjQ4MDQ1MzhlMjBlOTZhMTEzM2JhZTkxZDZiNGNlZAotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvaHRtbC9mb250LWZhY2UtZW1wdHktc2hvdWxkLW5vdC1jcmFzaC1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSBAQAorVGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2gu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2h0bWwvZm9udC1mYWNlLWVtcHR5LXNob3Vs ZC1ub3QtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvaHRtbC9mb250LWZhY2UtZW1wdHkt c2hvdWxkLW5vdC1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjM5ODMxOTA2MjIxNTM2MmM0MWYzNDc2 OWRmMjMxODMzM2YwYmMxZjMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2h0 bWwvZm9udC1mYWNlLWVtcHR5LXNob3VsZC1ub3QtY3Jhc2guaHRtbApAQCAtMCwwICsxLDEzIEBA Cis8IWRvY3R5cGUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0 KCk7Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorVGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBu b3QgY3Jhc2guCis8Zm9udCBmYWNlPSIiPjwvZm9udD4KKzwvYm9keT4KKzwvaHRtbD4K