85479 2012-05-03 05:20:52 -0700 [EFL] Handling of numeric-pad keys in EFL's PlatformKeyboardEvent 2012-05-22 11:14:06 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85369 0 mikhail.pozdnyakov mikhail.pozdnyakov gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 615179 0 mikhail.pozdnyakov 2012-05-03 05:20:52 -0700 EFL's PlatformKeyboardEvent::isKeypad() should be implemented and codes for numeric-pad ("KP..") keys should be returned appropriately in order to unskip: fast/events/keydown-numpad-keys.html 615204 1 139994 mikhail.pozdnyakov 2012-05-03 05:43:56 -0700 Created attachment 139994 Handling of numeric-pad keys in EFL's PlatformKeyboardEvent 615287 2 139994 rakuco 2012-05-03 08:11:19 -0700 Comment on attachment 139994 Handling of numeric-pad keys in EFL's PlatformKeyboardEvent Looks OK. 618736 3 139994 gustavo 2012-05-08 13:07:12 -0700 Comment on attachment 139994 Handling of numeric-pad keys in EFL's PlatformKeyboardEvent OK. Now just the numpad keys missing? =) 618749 4 139994 webkit.review.bot 2012-05-08 13:24:07 -0700 Comment on attachment 139994 Handling of numeric-pad keys in EFL's PlatformKeyboardEvent Clearing flags on attachment: 139994 Committed r116452: <http://trac.webkit.org/changeset/116452> 618750 5 webkit.review.bot 2012-05-08 13:24:12 -0700 All reviewed patches have been landed. Closing bug. 139994 2012-05-03 05:43:56 -0700 2012-05-08 13:24:07 -0700 Handling of numeric-pad keys in EFL's PlatformKeyboardEvent bug85479 text/plain 4782 mikhail.pozdnyakov Y29tbWl0IGYyMTE1MzQ5NWJhYWY1MGMxZTdlYWRkY2JkYjNjZmE1ZTYxYzE2OGMKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg VGh1IE1heSAzIDE1OjQyOjIyIDIwMTIgKzAzMDAKCiAgICBidWc4NTQ3OQoKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5YWZi NzBkLi5hNjM4NWYyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDUtMDMgIE1pa2hhaWwg UG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CisKKyAgICAgICAgW0VG TF0gSGFuZGxpbmcgb2YgbnVtZXJpYy1wYWQga2V5cyBpbiBFRkwncyBQbGF0Zm9ybUtleWJvYXJk RXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1 NDc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5z a2lwcGVkIGZhc3QvZXZlbnRzL2tleWRvd24tbnVtcGFkLWtleXMuaHRtbC4KKworICAgICAgICAq IHBsYXRmb3JtL2VmbC9Ta2lwcGVkOgorCiAyMDEyLTA1LTAyICBEb25nd29vIEltICA8ZHcuaW1A c2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gSW1wbGVtZW50IHRoZSBXZWIgQXVkaW8gQVBJ IGZlYXR1cmUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZCBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCmluZGV4IDg5Y2ZiYjguLmZhMzA0YzYg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCisrKyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCkBAIC0xMDM4LDcgKzEwMzgsNiBAQCBmYXN0L2V2 ZW50cy9kcmFnLXBhcmVudC1ub2RlLmh0bWwKIGZhc3QvZXZlbnRzL2pzLWtleWJvYXJkLWV2ZW50 LWNyZWF0aW9uLmh0bWwKIGZhc3QvZXZlbnRzL2tleS1ldmVudHMtaW4taW5wdXQtYnV0dG9uLmh0 bWwKIGZhc3QvZXZlbnRzL2tleS1ldmVudHMtaW4taW5wdXQtdGV4dC5odG1sCi1mYXN0L2V2ZW50 cy9rZXlkb3duLW51bXBhZC1rZXlzLmh0bWwKIGZhc3QvZXZlbnRzL29wdGlvbi10YWIuaHRtbAog ZmFzdC9ldmVudHMvc3BlY2lhbC1rZXktZXZlbnRzLWluLWlucHV0LXRleHQuaHRtbAogZmFzdC9m b3Jtcy9lbnRlci1jbGlja3MtYnV0dG9ucy5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzVmOTA3OS4uODJh ZjkwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA1LTAzICBNaWtoYWlsIFBv emRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxd IEhhbmRsaW5nIG9mIG51bWVyaWMtcGFkIGtleXMgaW4gRUZMJ3MgUGxhdGZvcm1LZXlib2FyZEV2 ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTQ3 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVGTCdz IFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6aXNLZXlwYWQoKSBub3cgcmV0dXJucyBtZWFuaW5nZnVs IHZhbHVlLgorICAgICAgICBBZGRlZCBudW1lcmljLXBhZCBrZXlzIHRvIHRoZSBLZXkgTWFwIGFu ZCBXaW5kb3dzIEtleSBNYXAuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICog cGxhdGZvcm0vZWZsL0VmbEtleWJvYXJkVXRpbGl0aWVzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmNyZWF0ZUtleU1hcCk6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVXaW5kb3dzS2V5TWFwKToK KyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvUGxhdGZvcm1LZXlib2FyZEV2ZW50RWZsLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6UGxhdGZvcm1LZXlib2FyZEV2 ZW50KToKKwogMjAxMi0wNS0wMiAgRG9uZ3dvbyBJbSAgPGR3LmltQHNhbXN1bmcuY29tPgogCiAg ICAgICAgIFtFRkxdIEltcGxlbWVudCB0aGUgV2ViIEF1ZGlvIEFQSSBmZWF0dXJlLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0VmbEtleWJvYXJkVXRpbGl0aWVzLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9FZmxLZXlib2FyZFV0aWxpdGllcy5jcHAK aW5kZXggYWExYjVlOC4uOWU4ZWIxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZWZsL0VmbEtleWJvYXJkVXRpbGl0aWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvRWZsS2V5Ym9hcmRVdGlsaXRpZXMuY3BwCkBAIC03OCw2ICs3OCwxNyBAQCBzdGF0 aWMgdm9pZCBjcmVhdGVLZXlNYXAoKQogICAgIGtleU1hcCgpLnNldCgiSVNPX0xlZnRfVGFiIiwg IlUrMDAwOSIpOwogICAgIGtleU1hcCgpLnNldCgiQmFja1NwYWNlIiwgIlUrMDAwOCIpOwogICAg IGtleU1hcCgpLnNldCgic3BhY2UiLCAiVSswMDIwIik7CisgICAgLy8gS2V5cGFkIGxvY2F0aW9u CisgICAga2V5TWFwKCkuc2V0KCJLUF9MZWZ0IiwgIkxlZnQiKTsKKyAgICBrZXlNYXAoKS5zZXQo IktQX1JpZ2h0IiwgIlJpZ2h0Iik7CisgICAga2V5TWFwKCkuc2V0KCJLUF9VcCIsICJVcCIpOwor ICAgIGtleU1hcCgpLnNldCgiS1BfRG93biIsICJEb3duIik7CisgICAga2V5TWFwKCkuc2V0KCJL UF9QcmlvciIsICJQYWdlVXAiKTsKKyAgICBrZXlNYXAoKS5zZXQoIktQX05leHQiLCAiUGFnZURv d24iKTsKKyAgICBrZXlNYXAoKS5zZXQoIktQX0hvbWUiLCAiSG9tZSIpOworICAgIGtleU1hcCgp LnNldCgiS1BfRW5kIiwgIkVuZCIpOworICAgIGtleU1hcCgpLnNldCgiS1BfSW5zZXJ0IiwgIklu c2VydCIpOworICAgIGtleU1hcCgpLnNldCgiS1BfRGVsZXRlIiwgIlUrMDA3RiIpOwogfQogCiBz dGF0aWMgdm9pZCBjcmVhdGVXaW5kb3dzS2V5TWFwKCkKQEAgLTEzMSw2ICsxNDIsMTcgQEAgc3Rh dGljIHZvaWQgY3JlYXRlV2luZG93c0tleU1hcCgpCiAgICAgd2luZG93c0tleU1hcCgpLnNldCgi YnJhY2VyaWdodCIsIFZLX09FTV82KTsKICAgICB3aW5kb3dzS2V5TWFwKCkuc2V0KCJhcG9zdHJv cGhlIiwgVktfT0VNXzcpOwogICAgIHdpbmRvd3NLZXlNYXAoKS5zZXQoInF1b3RlZGJsIiwgVktf T0VNXzcpOworICAgIC8vIEtleXBhZCBsb2NhdGlvbgorICAgIHdpbmRvd3NLZXlNYXAoKS5zZXQo IktQX0xlZnQiLCBWS19MRUZUKTsKKyAgICB3aW5kb3dzS2V5TWFwKCkuc2V0KCJLUF9SaWdodCIs IFZLX1JJR0hUKTsKKyAgICB3aW5kb3dzS2V5TWFwKCkuc2V0KCJLUF9VcCIsIFZLX1VQKTsKKyAg ICB3aW5kb3dzS2V5TWFwKCkuc2V0KCJLUF9Eb3duIiwgVktfRE9XTik7CisgICAgd2luZG93c0tl eU1hcCgpLnNldCgiS1BfUHJpb3IiLCBWS19QUklPUik7CisgICAgd2luZG93c0tleU1hcCgpLnNl dCgiS1BfTmV4dCIsIFZLX05FWFQpOworICAgIHdpbmRvd3NLZXlNYXAoKS5zZXQoIktQX0hvbWUi LCBWS19IT01FKTsKKyAgICB3aW5kb3dzS2V5TWFwKCkuc2V0KCJLUF9FbmQiLCBWS19FTkQpOwor ICAgIHdpbmRvd3NLZXlNYXAoKS5zZXQoIktQX0luc2VydCIsIFZLX0lOU0VSVCk7CisgICAgd2lu ZG93c0tleU1hcCgpLnNldCgiS1BfRGVsZXRlIiwgVktfREVMRVRFKTsKIAogICAgIC8vIFNldCBh bHBoYWJldCB0byB0aGUgd2luZG93c0tleU1hcC4KICAgICBjb25zdCBjaGFyKiBhbHBoYWJldCA9 ICJhYmNkZWZnaGlqa2xtbm9wcXJzdHV2d3h5eiI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9lZmwvUGxhdGZvcm1LZXlib2FyZEV2ZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2VmbC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRFZmwuY3BwCmluZGV4IDY1NjU2 NGQuLjc0ODc5NDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9QbGF0 Zm9ybUtleWJvYXJkRXZlbnRFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm bC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRFZmwuY3BwCkBAIC00OSw3ICs0OSw3IEBAIFBsYXRmb3Jt S2V5Ym9hcmRFdmVudDo6UGxhdGZvcm1LZXlib2FyZEV2ZW50KGNvbnN0IEV2YXNfRXZlbnRfS2V5 X0Rvd24qIGV2ZW50KQogICAgICwgbV9uYXRpdmVWaXJ0dWFsS2V5Q29kZSgwKQogICAgICwgbV9t YWNDaGFyQ29kZSgwKQogICAgICwgbV9hdXRvUmVwZWF0KGZhbHNlKQotICAgICwgbV9pc0tleXBh ZChmYWxzZSkKKyAgICAsIG1faXNLZXlwYWQoU3RyaW5nKGV2ZW50LT5rZXkpLnN0YXJ0c1dpdGgo IktQXyIpKQogICAgICwgbV9pc1N5c3RlbUtleShmYWxzZSkKIHsKIH0KQEAgLTYzLDcgKzYzLDcg QEAgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpQbGF0Zm9ybUtleWJvYXJkRXZlbnQoY29uc3QgRXZh c19FdmVudF9LZXlfVXAqIGV2ZW50KQogICAgICwgbV9uYXRpdmVWaXJ0dWFsS2V5Q29kZSgwKQog ICAgICwgbV9tYWNDaGFyQ29kZSgwKQogICAgICwgbV9hdXRvUmVwZWF0KGZhbHNlKQotICAgICwg bV9pc0tleXBhZChmYWxzZSkKKyAgICAsIG1faXNLZXlwYWQoU3RyaW5nKGV2ZW50LT5rZXkpLnN0 YXJ0c1dpdGgoIktQXyIpKQogICAgICwgbV9pc1N5c3RlbUtleShmYWxzZSkKIHsKIH0K