85476 2012-05-03 05:00:57 -0700 [Gtk] ImageDiff crashes when it can't open a display 2012-05-03 06:15:24 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan mrobinson pnormand oldest_to_newest 615167 0 zan 2012-05-03 05:00:57 -0700 This happens regularly on the GTK 64-bit Debug builder. Here's stderr output: (ImageDiff:14017): Gdk-WARNING **: cannot open display 615168 1 zan 2012-05-03 05:03:40 -0700 The problem originates from the gdk_init function call[1]. It turns out GdkPixbufLoader doesn't actually require gdk_init() to be called, meaning this should be replaced by only calling g_type_init() and the crashes should go away. [1] http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/gtk/ImageDiff.cpp#L181 615180 2 139986 zan 2012-05-03 05:22:51 -0700 Created attachment 139986 Patch 615219 3 139986 zan 2012-05-03 06:15:09 -0700 Comment on attachment 139986 Patch Clearing flags on attachment: 139986 Committed r115967: <http://trac.webkit.org/changeset/115967> 615220 4 zan 2012-05-03 06:15:24 -0700 All reviewed patches have been landed. Closing bug. 139986 2012-05-03 05:22:51 -0700 2012-05-03 06:15:09 -0700 Patch bug-85476-20120503142249.patch text/plain 1427 zan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExNTk2MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDEyLTA1LTAzICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5j b20+CisKKyAgICAgICAgW0d0a10gSW1hZ2VEaWZmIGNyYXNoZXMgd2hlbiBpdCBjYW4ndCBvcGVu IGEgZGlzcGxheQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODU0NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZXBsYWNlIGdka19pbml0KCkgaW5pdGlhbGl6YXRpb24gY2FsbCB3aXRoIHRoZSBnX3R5cGVf aW5pdCgpCisgICAgICAgIGNhbGwuIEdka1BpeGJ1ZkxvYWRlciBkb2Vzbid0IGFjdHVhbGx5IG5l ZWQgdGhlIGN1cnJlbnQgY2FsbCB0byBiZQorICAgICAgICBtYWRlIGFuZCB0aGlzIGNoYW5nZSB3 aWxsIGFsc28gcmVtb3ZlIGNyYXNoZXMgd2hlbiBJbWFnZURpZmYKKyAgICAgICAgaXMgc3RhcnRl ZCBpbiBhbiBlbnZpcm9ubWVudCB3aXRob3V0IGEgRElTUExBWSBlbnYuCisKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS9ndGsvSW1hZ2VEaWZmLmNwcDoKKyAgICAgICAgKG1haW4pOgorCiAyMDEy LTA1LTAzICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAg SW1hZ2VEaWZmIHNob3VsZCBiZSBydW4gaW5zaWRlIGEgcHJvcGVybHkgZXN0YWJsaXNoZWQgZW52 aXJvbm1lbnQKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9JbWFnZURpZmYuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9JbWFnZURpZmYuY3BwCShyZXZp c2lvbiAxMTU5NjIpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvSW1hZ2VEaWZmLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTc4LDcgKzE3OCw3IEBAIHZvaWQgcHJpbnRJbWFnZURpZmZlcmVu Y2VzKEdka1BpeGJ1ZiogYmEKIAogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKIHsK LSAgICBnZGtfaW5pdCgmYXJnYywgJmFyZ3YpOworICAgIGdfdHlwZV9pbml0KCk7CiAKICAgICBH RXJyb3IqIGVycm9yID0gMDsKICAgICBHT3B0aW9uQ29udGV4dCogY29udGV4dCA9IGdfb3B0aW9u X2NvbnRleHRfbmV3KCItIGNvbXBhcmUgdHdvIGltYWdlIGZpbGVzLCBwcmludGluZyB0aGVpciBw ZXJjZW50YWdlIGRpZmZlcmVuY2UgYW5kIHRoZSBkaWZmZXJlbmNlIGltYWdlIHRvIHN0ZG91dCIp Owo=