85475 2012-05-03 04:31:44 -0700 run-qtwebkit-tests hangs with -j1 2012-06-06 06:09:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Major --- 1 ossy webkit-unassigned galpeter jbadics jesus kadam ossy webkit.review.bot oldest_to_newest 615161 0 ossy 2012-05-03 04:31:44 -0700 Tool/Scripts/run-qtwebkit-tests hangs after it ran all Qt API tests with -j1 (run only one job) It should be fixed. 618421 1 kadam 2012-05-08 01:46:36 -0700 I'm going to check what causes this problem. 641314 2 145726 jbadics 2012-06-05 01:48:55 -0700 Created attachment 145726 Proposed patch It's likely that this could be solved by canceling the timer of process_killer when results of tests are returned. 641336 3 galpeter 2012-06-05 02:07:36 -0700 View in context: https://bugs.webkit.org/attachment.cgi?id=145726&action=review > Tools/Scripts/run-qtwebkit-tests:158 > log.info("Finished %s", test_suite.test_file_name()) > + timer.cancel() > return test_suite This is not in the correct place. If timeout is not set the 'timer' will be a "None" value, calling cancel() on that will result an AttributeError. You should check if the timer is set to a valid object. So I would give an r- for now (sadly I can't set that flag). 641354 4 145738 jbadics 2012-06-05 02:44:52 -0700 Created attachment 145738 proposed patch 641358 5 galpeter 2012-06-05 02:50:02 -0700 View in context: https://bugs.webkit.org/attachment.cgi?id=145738&action=review > Tools/Scripts/run-qtwebkit-tests:158 > + if timeout: > + timer.cancel() Now it looks a lot better. I'll give it a non-reviewer r+ :) 641385 6 jbadics 2012-06-05 03:46:41 -0700 (In reply to comment #5) > View in context: https://bugs.webkit.org/attachment.cgi?id=145738&action=review > Now it looks a lot better. I'll give it a non-reviewer r+ :) Thank you. : ) 642402 7 145738 ossy 2012-06-06 05:48:16 -0700 Comment on attachment 145738 proposed patch r=me. Thanks for the fix. 642404 8 145738 webkit.review.bot 2012-06-06 06:09:22 -0700 Comment on attachment 145738 proposed patch Clearing flags on attachment: 145738 Committed r119588: <http://trac.webkit.org/changeset/119588> 642405 9 webkit.review.bot 2012-06-06 06:09:27 -0700 All reviewed patches have been landed. Closing bug. 145726 2012-06-05 01:48:55 -0700 2012-06-05 02:44:52 -0700 Proposed patch rqtwt_j1_wk2_1.patch text/plain 1227 jbadics ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYzdk NGVmLi5hMGZiMTU5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMDUgIErDoW5vcyBCYWRpY3MgIDxqYmFk aWNzQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBbUXRdIHJ1bi1xdHdlYmtpdC10ZXN0cyBo YW5ncyB3aXRoIC1qMQorICAgICAgICBydW4tcXR3ZWJraXQtdGVzdHMgdXNlZCB0byBoYW5nIHdo ZW4gd2syIEFQSSB0ZXN0cyB3ZXJlIHJ1biB3aXRoIC1qMSBhbmQgLS10aW1lb3V0LgorICAgICAg ICBUaGlzIGNvdWxkIGhhcHBlbiBkdWUgdG8gYW4gdW5jYW5jZWxsZWQgdGltZXIgYWZ0ZXIgcmVz dWx0cyB3ZXJlIHJldHVybmVkLiBUaGlzIHRpbWVyIHdhcworICAgICAgICBzdGFydGVkIG9ubHkg aWYgLS10aW1lb3V0IHdhcyBzZXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04NTQ3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy9ydW4tcXR3ZWJraXQtdGVzdHM6CisgICAgICAgIChydW5f dGVzdCk6CisKIDIwMTItMDUtMzEgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9A bm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gU2ltcGxpZnkgUVRfVkVSU0lPTl9DSEVDS1MgZm9y IFF0NSBieSBpbnRyb2R1Y2luZyBIQVZFKFFUNSkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv cnVuLXF0d2Via2l0LXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tcXR3ZWJraXQtdGVzdHMKaW5k ZXggMjg4YmQ1Ny4uZjEwM2U0OSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tcXR3ZWJr aXQtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tcXR3ZWJraXQtdGVzdHMKQEAgLTE1NCw2 ICsxNTQsNyBAQCBkZWYgcnVuX3Rlc3QoYXJncyk6CiAgICAgZWxzZToKICAgICAgICAgdGVzdF9z dWl0ZS5zZXRfb3V0cHV0KHRzdC5jb21tdW5pY2F0ZSgpWzBdKSAgIyB0YWtlcyBzdGRvdXQgb25s eSwgaW4gZGV2ZWxvcGVyIG1vZGUgaXQgd291bGQgYmUgTm9uZS4KICAgICBsb2cuaW5mbygiRmlu aXNoZWQgJXMiLCB0ZXN0X3N1aXRlLnRlc3RfZmlsZV9uYW1lKCkpCisgICAgdGltZXIuY2FuY2Vs KCkKICAgICByZXR1cm4gdGVzdF9zdWl0ZQogCiAK 145738 2012-06-05 02:44:52 -0700 2012-06-06 06:09:22 -0700 proposed patch rqtwt_j1_wk2_2.patch text/plain 1248 jbadics ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYzdk NGVmLi5hMGZiMTU5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMDUgIErDoW5vcyBCYWRpY3MgIDxqYmFk aWNzQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBbUXRdIHJ1bi1xdHdlYmtpdC10ZXN0cyBo YW5ncyB3aXRoIC1qMQorICAgICAgICBydW4tcXR3ZWJraXQtdGVzdHMgdXNlZCB0byBoYW5nIHdo ZW4gd2syIEFQSSB0ZXN0cyB3ZXJlIHJ1biB3aXRoIC1qMSBhbmQgLS10aW1lb3V0LgorICAgICAg ICBUaGlzIGNvdWxkIGhhcHBlbiBkdWUgdG8gYW4gdW5jYW5jZWxsZWQgdGltZXIgYWZ0ZXIgcmVz dWx0cyB3ZXJlIHJldHVybmVkLiBUaGlzIHRpbWVyIHdhcworICAgICAgICBzdGFydGVkIG9ubHkg aWYgLS10aW1lb3V0IHdhcyBzZXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04NTQ3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy9ydW4tcXR3ZWJraXQtdGVzdHM6CisgICAgICAgIChydW5f dGVzdCk6CisKIDIwMTItMDUtMzEgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9A bm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gU2ltcGxpZnkgUVRfVkVSU0lPTl9DSEVDS1MgZm9y IFF0NSBieSBpbnRyb2R1Y2luZyBIQVZFKFFUNSkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv cnVuLXF0d2Via2l0LXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tcXR3ZWJraXQtdGVzdHMKaW5k ZXggMjg4YmQ1Ny4uZGVkODdjNSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tcXR3ZWJr aXQtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tcXR3ZWJraXQtdGVzdHMKQEAgLTE1NCw2 ICsxNTQsOCBAQCBkZWYgcnVuX3Rlc3QoYXJncyk6CiAgICAgZWxzZToKICAgICAgICAgdGVzdF9z dWl0ZS5zZXRfb3V0cHV0KHRzdC5jb21tdW5pY2F0ZSgpWzBdKSAgIyB0YWtlcyBzdGRvdXQgb25s eSwgaW4gZGV2ZWxvcGVyIG1vZGUgaXQgd291bGQgYmUgTm9uZS4KICAgICBsb2cuaW5mbygiRmlu aXNoZWQgJXMiLCB0ZXN0X3N1aXRlLnRlc3RfZmlsZV9uYW1lKCkpCisgICAgaWYgdGltZW91dDoK KyAgICAgICAgdGltZXIuY2FuY2VsKCkKICAgICByZXR1cm4gdGVzdF9zdWl0ZQogCiAK