85467 2012-05-03 01:59:53 -0700 Linker warnings due to duplicate symbols for SimplifyMarkupCommand.cpp on Windows 2012-05-03 03:38:05 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 1 vivekgalatage vivekgalatage rniwa vivekgalatage webkit.review.bot oldest_to_newest 615101 0 vivekgalatage 2012-05-03 01:59:53 -0700 While building Debug/Debug_All/Release builds for windows while linking WebCore.lib following warnings are issued: Performing Pre-Link Event... Creating library... EditingAllInOne.obj : warning LNK4006: "private: __thiscall WebCore::SimplifyMarkupCommand::SimplifyMarkupCommand(class WebCore::Document *,class WebCore::Node *,class WebCore::Node *)" (??0SimplifyMarkupCommand@WebCore@@AAE@PAVDocument@1@PAVNode@1@1@Z) already defined in SimplifyMarkupCommand.obj; second definition ignored EditingAllInOne.obj : warning LNK4006: "private: virtual void __thiscall WebCore::SimplifyMarkupCommand::doApply(void)" (?doApply@SimplifyMarkupCommand@WebCore@@EAEXXZ) already defined in SimplifyMarkupCommand.obj; second definition ignored Performing Post-Build Event... 615102 1 vivekgalatage 2012-05-03 02:01:27 -0700 The file has been included multiple times both in EditingAllInOne.cpp as well as its not excluded from build in the WebCore.vcproj Hence while linking this error is thrown. The file has to be excluded as this is included in AllInOne.cpp. Patch to follow. 615110 2 139974 vivekgalatage 2012-05-03 02:14:59 -0700 Created attachment 139974 Patch 615115 3 139974 rniwa 2012-05-03 02:24:54 -0700 Comment on attachment 139974 Patch Looks sane. Please update the bug title. 615118 4 139976 vivekgalatage 2012-05-03 02:37:58 -0700 Created attachment 139976 Patch 615141 5 139976 webkit.review.bot 2012-05-03 03:38:01 -0700 Comment on attachment 139976 Patch Clearing flags on attachment: 139976 Committed r115956: <http://trac.webkit.org/changeset/115956> 615142 6 webkit.review.bot 2012-05-03 03:38:05 -0700 All reviewed patches have been landed. Closing bug. 139974 2012-05-03 02:14:59 -0700 2012-05-03 02:37:51 -0700 Patch bug-85467-20120503144444.patch text/plain 1867 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTk1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTAzICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFdlYkNvcmUgbXVs dGlwbHkgZGVmaW5lZCBzeW1ib2xzIGZvciBmaWxlIFNpbXBsaWZ5TWFya3VwQ29tbWFuZC5jcHAg b24gV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODU0NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmVkIHRoZSBtdWx0aXBsZSBpbmNsdXNpb24gb2YgdGhlIGZpbGUgU2ltcGxpZnlNYXJr dXBDb21tYW5kLmNwcCAKKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAg ICogV2ViQ29yZS52Y3Byb2ovV2ViQ29yZS52Y3Byb2o6CisKIDIwMTItMDUtMDMgIE5pa29sYXMg WmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAgQWNjdW11bGF0aW9u IGZvciB2YWx1ZXMtYW5pbWF0aW9uIGlzIGJyb2tlbgpJbmRleDogU291cmNlL1dlYkNvcmUvV2Vi Q29yZS52Y3Byb2ovV2ViQ29yZS52Y3Byb2oKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv V2ViQ29yZS52Y3Byb2ovV2ViQ29yZS52Y3Byb2oJKHJldmlzaW9uIDExNTI4NikKKysrIFNvdXJj ZS9XZWJDb3JlL1dlYkNvcmUudmNwcm9qL1dlYkNvcmUudmNwcm9qCSh3b3JraW5nIGNvcHkpCkBA IC01NjU0Niw3ICs1NjU0Niw3IEBACiAJCQkJPgogCQkJCTxGaWxlQ29uZmlndXJhdGlvbgogCQkJ CQlOYW1lPSJEZWJ1Z3xXaW4zMiIKLQkJCQkJRXhjbHVkZWRGcm9tQnVpbGQ9ImZhbHNlIgorCQkJ CQlFeGNsdWRlZEZyb21CdWlsZD0idHJ1ZSIKIAkJCQkJPgogCQkJCQk8VG9vbAogICAgICAgICAg ICAgICAgICAgICBOYW1lPSJWQ0NMQ29tcGlsZXJUb29sIgpAQCAtNTY1NTQsNyArNTY1NTQsNyBA QAogCQkJCTwvRmlsZUNvbmZpZ3VyYXRpb24+CiAJCQkJPEZpbGVDb25maWd1cmF0aW9uCiAJCQkJ CU5hbWU9IlJlbGVhc2V8V2luMzIiCi0JCQkJCUV4Y2x1ZGVkRnJvbUJ1aWxkPSJmYWxzZSIKKwkJ CQkJRXhjbHVkZWRGcm9tQnVpbGQ9InRydWUiCiAJCQkJCT4KIAkJCQkJPFRvb2wKICAgICAgICAg ICAgICAgICAgICAgTmFtZT0iVkNDTENvbXBpbGVyVG9vbCIKQEAgLTU2NTc4LDcgKzU2NTc4LDcg QEAKIAkJCQk8L0ZpbGVDb25maWd1cmF0aW9uPgogCQkJCTxGaWxlQ29uZmlndXJhdGlvbgogCQkJ CQlOYW1lPSJEZWJ1Z19BbGx8V2luMzIiCi0JCQkJCUV4Y2x1ZGVkRnJvbUJ1aWxkPSJmYWxzZSIK KwkJCQkJRXhjbHVkZWRGcm9tQnVpbGQ9InRydWUiCiAJCQkJCT4KIAkJCQkJPFRvb2wKICAgICAg ICAgICAgICAgICAgICAgTmFtZT0iVkNDTENvbXBpbGVyVG9vbCIKQEAgLTU2NTg2LDcgKzU2NTg2 LDcgQEAKIAkJCQk8L0ZpbGVDb25maWd1cmF0aW9uPgogCQkJCTxGaWxlQ29uZmlndXJhdGlvbgog CQkJCQlOYW1lPSJQcm9kdWN0aW9ufFdpbjMyIgotCQkJCQlFeGNsdWRlZEZyb21CdWlsZD0iZmFs c2UiCisJCQkJCUV4Y2x1ZGVkRnJvbUJ1aWxkPSJ0cnVlIgogCQkJCQk+CiAJCQkJCTxUb29sCiAg ICAgICAgICAgICAgICAgICAgIE5hbWU9IlZDQ0xDb21waWxlclRvb2wiCg== 139976 2012-05-03 02:37:58 -0700 2012-05-03 03:38:00 -0700 Patch bug-85467-20120503150742.patch text/plain 1872 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTk1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTAzICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIExpbmtlciB3YXJu aW5ncyBkdWUgdG8gZHVwbGljYXRlIHN5bWJvbHMgZm9yIFNpbXBsaWZ5TWFya3VwQ29tbWFuZC5j cHAgb24gV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODU0NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBSZW1vdmVkIHRoZSBtdWx0aXBsZSBpbmNsdXNpb24gb2YgdGhlIGZpbGUgU2ltcGxpZnlN YXJrdXBDb21tYW5kLmNwcCAKKworICAgICAgICBObyBuZXcgdGVzdHMgcmVxdWlyZWQuCisKKyAg ICAgICAgKiBXZWJDb3JlLnZjcHJvai9XZWJDb3JlLnZjcHJvajoKKwogMjAxMi0wNS0wMyAgTmlr b2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBBY2N1bXVs YXRpb24gZm9yIHZhbHVlcy1hbmltYXRpb24gaXMgYnJva2VuCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9XZWJDb3JlLnZjcHJvai9XZWJDb3JlLnZjcHJvago9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9XZWJDb3JlLnZjcHJvai9XZWJDb3JlLnZjcHJvagkocmV2aXNpb24gMTE1Mjg2KQorKysg U291cmNlL1dlYkNvcmUvV2ViQ29yZS52Y3Byb2ovV2ViQ29yZS52Y3Byb2oJKHdvcmtpbmcgY29w eSkKQEAgLTU2NTQ2LDcgKzU2NTQ2LDcgQEAKIAkJCQk+CiAJCQkJPEZpbGVDb25maWd1cmF0aW9u CiAJCQkJCU5hbWU9IkRlYnVnfFdpbjMyIgotCQkJCQlFeGNsdWRlZEZyb21CdWlsZD0iZmFsc2Ui CisJCQkJCUV4Y2x1ZGVkRnJvbUJ1aWxkPSJ0cnVlIgogCQkJCQk+CiAJCQkJCTxUb29sCiAgICAg ICAgICAgICAgICAgICAgIE5hbWU9IlZDQ0xDb21waWxlclRvb2wiCkBAIC01NjU1NCw3ICs1NjU1 NCw3IEBACiAJCQkJPC9GaWxlQ29uZmlndXJhdGlvbj4KIAkJCQk8RmlsZUNvbmZpZ3VyYXRpb24K IAkJCQkJTmFtZT0iUmVsZWFzZXxXaW4zMiIKLQkJCQkJRXhjbHVkZWRGcm9tQnVpbGQ9ImZhbHNl IgorCQkJCQlFeGNsdWRlZEZyb21CdWlsZD0idHJ1ZSIKIAkJCQkJPgogCQkJCQk8VG9vbAogICAg ICAgICAgICAgICAgICAgICBOYW1lPSJWQ0NMQ29tcGlsZXJUb29sIgpAQCAtNTY1NzgsNyArNTY1 NzgsNyBAQAogCQkJCTwvRmlsZUNvbmZpZ3VyYXRpb24+CiAJCQkJPEZpbGVDb25maWd1cmF0aW9u CiAJCQkJCU5hbWU9IkRlYnVnX0FsbHxXaW4zMiIKLQkJCQkJRXhjbHVkZWRGcm9tQnVpbGQ9ImZh bHNlIgorCQkJCQlFeGNsdWRlZEZyb21CdWlsZD0idHJ1ZSIKIAkJCQkJPgogCQkJCQk8VG9vbAog ICAgICAgICAgICAgICAgICAgICBOYW1lPSJWQ0NMQ29tcGlsZXJUb29sIgpAQCAtNTY1ODYsNyAr NTY1ODYsNyBAQAogCQkJCTwvRmlsZUNvbmZpZ3VyYXRpb24+CiAJCQkJPEZpbGVDb25maWd1cmF0 aW9uCiAJCQkJCU5hbWU9IlByb2R1Y3Rpb258V2luMzIiCi0JCQkJCUV4Y2x1ZGVkRnJvbUJ1aWxk PSJmYWxzZSIKKwkJCQkJRXhjbHVkZWRGcm9tQnVpbGQ9InRydWUiCiAJCQkJCT4KIAkJCQkJPFRv b2wKICAgICAgICAgICAgICAgICAgICAgTmFtZT0iVkNDTENvbXBpbGVyVG9vbCIK