85462 2012-05-02 23:36:58 -0700 Web Inspector: compile time ambiguity happens when I try to assign a TypeBuilder object to an out argument 2012-05-03 05:38:49 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 615048 0 loislo 2012-05-02 23:36:58 -0700 It happens because we have type casting operators for both types RefPtr<*Type*> and PassRefPtr<*Type*>. I think we can drop PassRefPtr type casting operator and use a named function 'release'. 615051 1 139964 loislo 2012-05-02 23:40:12 -0700 Created attachment 139964 Patch 615194 2 139964 loislo 2012-05-03 05:38:42 -0700 Comment on attachment 139964 Patch Clearing flags on attachment: 139964 Committed r115965: <http://trac.webkit.org/changeset/115965> 615195 3 loislo 2012-05-03 05:38:49 -0700 All reviewed patches have been landed. Closing bug. 139964 2012-05-02 23:40:12 -0700 2012-05-03 05:38:42 -0700 Patch bug-85462-20120503104010.patch text/plain 7073 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1OTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjgwMDJjMDQ4OWY3Yjc3 MjRkYTdiYWM0ZDE3MGQwZDNjOWY5NjAwZC4uYWJhYWY1ZWFjOWU2ZTI1OTY1NTE2MDcxMjhmNmNl ZWE0MzRkYTliMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA1LTAyICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBjb21waWxlIHRpbWUgYW1iaWd1aXR5IGhhcHBlbnMgd2hlbiBJIHRyeSB0byBhc3NpZ24g YSBUeXBlQnVpbGRlciBvYmplY3QgdG8gYW4gb3V0IGFyZ3VtZW50LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU0NjIKKworICAgICAgICBJdCBoYXBw ZW5zIGJlY2F1c2Ugd2UgaGF2ZSB0eXBlIGNhc3Rpbmcgb3BlcmF0b3JzIGZvciBib3RoIHR5cGVz IFJlZlB0cjwqVHlwZSo+IGFuZCBQYXNzUmVmUHRyPCpUeXBlKj4uCisgICAgICAgIEkgdGhpbmsg d2UgY2FuIGRyb3AgUGFzc1JlZlB0ciB0eXBlIGNhc3Rpbmcgb3BlcmF0b3IgYW5kIHVzZSBhIG5h bWVkIGZ1bmN0aW9uICdyZWxlYXNlJy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5Ogor ICAgICAgICAqIGluc3BlY3Rvci9Db250ZW50U2VhcmNoVXRpbHMuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q29udGVudFNlYXJjaFV0aWxzOjpidWlsZE9iamVjdEZvclNlYXJjaE1hdGNoKToKKyAg ICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQXBwbGljYXRpb25DYWNoZUFnZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckFwcGxpY2F0aW9uQ2FjaGVBZ2VudDo6YnVpbGRPYmpl Y3RGb3JBcHBsaWNhdGlvbkNhY2hlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yUGFn ZUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkT2JqZWN0Rm9yQ29va2llKToKKyAg ICAgICAgKFdlYkNvcmU6OmJ1aWxkT2JqZWN0Rm9yU2VhcmNoUmVzdWx0KToKKyAgICAgICAgKiBp bnNwZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2VBZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpi dWlsZE9iamVjdEZvclRpbWluZyk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JSZXNvdXJj ZUFnZW50OjpidWlsZEluaXRpYXRvck9iamVjdCk6CisgICAgICAgICogaW5zcGVjdG9yL1Njcmlw dENhbGxGcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRDYWxsRnJhbWU6OmJ1aWxk SW5zcGVjdG9yT2JqZWN0KToKKwogMjAxMi0wNS0wMiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2 aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEx NTkwNy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9Db2RlR2VuZXJhdG9y SW5zcGVjdG9yLnB5IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNw ZWN0b3IucHkKaW5kZXggNWE1YWZmZDRiZTUyZGI5ZmIwMzExNTE5NzI1N2JkMzcwYmVhYjA1OS4u ZDYyOWNhZmViMzM3MmZmOTAyMTRjMzg0YzE1ZGU5M2ZmYzI3OTI5YyAxMDA3NTUKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucHkKKysrIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucHkKQEAgLTEyNDIs OSArMTI0Miw5IEBAIGNsYXNzIFR5cGVCaW5kaW5nczoKICAgICAgICAgICAgIHJldHVybiAqcmVp bnRlcnByZXRfY2FzdDxSZWZQdHI8JXM+Kj4oJm1fcmVzdWx0KTsKICAgICAgICAgfQogCi0gICAg ICAgIG9wZXJhdG9yIFBhc3NSZWZQdHI8JXM+ICgpCisgICAgICAgIFBhc3NSZWZQdHI8JXM+IHJl bGVhc2UoKQogICAgICAgICB7Ci0gICAgICAgICAgICByZXR1cm4gUmVmUHRyPCVzPigqdGhpcyk7 CisgICAgICAgICAgICByZXR1cm4gUmVmUHRyPCVzPigqdGhpcykucmVsZWFzZSgpOwogICAgICAg ICB9CiAgICAgfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvbnRl bnRTZWFyY2hVdGlscy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29udGVudFNlYXJj aFV0aWxzLmNwcAppbmRleCBiOTRiM2JiMmM1MDliMTQ3MTI3ZmU5N2FjOTMyNDhiM2FjYTdkYTJk Li4wNTRkYTM0OGZlNjNhZTk2NjFkMzA2ZjhiMjE2NDM0YzBmNjliNjZiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29udGVudFNlYXJjaFV0aWxzLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29udGVudFNlYXJjaFV0aWxzLmNwcApAQCAtOTgsNyArOTgs OCBAQCBzdGF0aWMgUGFzc1JlZlB0cjxUeXBlQnVpbGRlcjo6UGFnZTo6U2VhcmNoTWF0Y2g+IGJ1 aWxkT2JqZWN0Rm9yU2VhcmNoTWF0Y2goaW50CiB7CiAgICAgcmV0dXJuIFR5cGVCdWlsZGVyOjpQ YWdlOjpTZWFyY2hNYXRjaDo6Y3JlYXRlKCkKICAgICAgICAgLnNldExpbmVOdW1iZXIobGluZU51 bWJlcikKLSAgICAgICAgLnNldExpbmVDb250ZW50KGxpbmVDb250ZW50KTsKKyAgICAgICAgLnNl dExpbmVDb250ZW50KGxpbmVDb250ZW50KQorICAgICAgICAucmVsZWFzZSgpOwogfQogCiBSZWd1 bGFyRXhwcmVzc2lvbiBjcmVhdGVTZWFyY2hSZWdleChjb25zdCBTdHJpbmcmIHF1ZXJ5LCBib29s IGNhc2VTZW5zaXRpdmUsIGJvb2wgaXNSZWdleCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JBcHBsaWNhdGlvbkNhY2hlQWdlbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckFwcGxpY2F0aW9uQ2FjaGVBZ2VudC5jcHAKaW5kZXgg Y2VkMWQ3NmUxMzE1ZjI3M2FlZDkzZDNiMjg2NzY2NGFlNzY5YzQ1NS4uZjcwNTM1ZmM4ZWE0OTlj NDFmNmMyMzljNmI3YWMxZmI3OWRhYWM1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvckFwcGxpY2F0aW9uQ2FjaGVBZ2VudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckFwcGxpY2F0aW9uQ2FjaGVBZ2VudC5jcHAKQEAgLTE2 OCw3ICsxNjgsOCBAQCBQYXNzUmVmUHRyPFR5cGVCdWlsZGVyOjpBcHBsaWNhdGlvbkNhY2hlOjpB cHBsaWNhdGlvbkNhY2hlPiBJbnNwZWN0b3JBcHBsaWNhdGlvbgogICAgICAgICAuc2V0U2l6ZShh cHBsaWNhdGlvbkNhY2hlSW5mby5tX3NpemUpCiAgICAgICAgIC5zZXRDcmVhdGlvblRpbWUoYXBw bGljYXRpb25DYWNoZUluZm8ubV9jcmVhdGlvblRpbWUpCiAgICAgICAgIC5zZXRVcGRhdGVUaW1l KGFwcGxpY2F0aW9uQ2FjaGVJbmZvLm1fdXBkYXRlVGltZSkKLSAgICAgICAgLnNldFJlc291cmNl cyhidWlsZEFycmF5Rm9yQXBwbGljYXRpb25DYWNoZVJlc291cmNlcyhhcHBsaWNhdGlvbkNhY2hl UmVzb3VyY2VzKSk7CisgICAgICAgIC5zZXRSZXNvdXJjZXMoYnVpbGRBcnJheUZvckFwcGxpY2F0 aW9uQ2FjaGVSZXNvdXJjZXMoYXBwbGljYXRpb25DYWNoZVJlc291cmNlcykpCisgICAgICAgIC5y ZWxlYXNlKCk7CiB9CiAKIFBhc3NSZWZQdHI8VHlwZUJ1aWxkZXI6OkFycmF5PFR5cGVCdWlsZGVy OjpBcHBsaWNhdGlvbkNhY2hlOjpBcHBsaWNhdGlvbkNhY2hlUmVzb3VyY2U+ID4gSW5zcGVjdG9y QXBwbGljYXRpb25DYWNoZUFnZW50OjpidWlsZEFycmF5Rm9yQXBwbGljYXRpb25DYWNoZVJlc291 cmNlcyhjb25zdCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6UmVzb3VyY2VJbmZvTGlzdCYgYXBwbGlj YXRpb25DYWNoZVJlc291cmNlcykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvclBhZ2VBZ2VudC5jcHAKaW5kZXggMGM2OWVkZjRmYmVkOGNiNzVkODk3NWFhODI1YTI2MmRk YjVmYjQzMC4uNjFmZTBhN2U4ZDBhM2IzYmJmODAwOGUyZGMzMDZhOWNhOWJmMjg1ZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclBhZ2VBZ2VudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclBhZ2VBZ2VudC5jcHAKQEAgLTQx OCw3ICs0MTgsOCBAQCBzdGF0aWMgUGFzc1JlZlB0cjxUeXBlQnVpbGRlcjo6UGFnZTo6Q29va2ll PiBidWlsZE9iamVjdEZvckNvb2tpZShjb25zdCBDb29raWUmCiAgICAgICAgIC5zZXRTaXplKChj b29raWUubmFtZS5sZW5ndGgoKSArIGNvb2tpZS52YWx1ZS5sZW5ndGgoKSkpCiAgICAgICAgIC5z ZXRIdHRwT25seShjb29raWUuaHR0cE9ubHkpCiAgICAgICAgIC5zZXRTZWN1cmUoY29va2llLnNl Y3VyZSkKLSAgICAgICAgLnNldFNlc3Npb24oY29va2llLnNlc3Npb24pOworICAgICAgICAuc2V0 U2Vzc2lvbihjb29raWUuc2Vzc2lvbikKKyAgICAgICAgLnJlbGVhc2UoKTsKIH0KIAogc3RhdGlj IFBhc3NSZWZQdHI8VHlwZUJ1aWxkZXI6OkFycmF5PFR5cGVCdWlsZGVyOjpQYWdlOjpDb29raWU+ ID4gYnVpbGRBcnJheUZvckNvb2tpZXMoTGlzdEhhc2hTZXQ8Q29va2llPiYgY29va2llc0xpc3Qp CkBAIC02MDAsNyArNjAxLDggQEAgc3RhdGljIFBhc3NSZWZQdHI8VHlwZUJ1aWxkZXI6OlBhZ2U6 OlNlYXJjaFJlc3VsdD4gYnVpbGRPYmplY3RGb3JTZWFyY2hSZXN1bHQoY28KICAgICByZXR1cm4g VHlwZUJ1aWxkZXI6OlBhZ2U6OlNlYXJjaFJlc3VsdDo6Y3JlYXRlKCkKICAgICAgICAgLnNldFVy bCh1cmwpCiAgICAgICAgIC5zZXRGcmFtZUlkKGZyYW1lSWQpCi0gICAgICAgIC5zZXRNYXRjaGVz Q291bnQobWF0Y2hlc0NvdW50KTsKKyAgICAgICAgLnNldE1hdGNoZXNDb3VudChtYXRjaGVzQ291 bnQpCisgICAgICAgIC5yZWxlYXNlKCk7CiB9CiAKIHZvaWQgSW5zcGVjdG9yUGFnZUFnZW50Ojpz ZWFyY2hJblJlc291cmNlcyhFcnJvclN0cmluZyosIGNvbnN0IFN0cmluZyYgdGV4dCwgY29uc3Qg Ym9vbCogY29uc3Qgb3B0aW9uYWxDYXNlU2Vuc2l0aXZlLCBjb25zdCBib29sKiBjb25zdCBvcHRp b25hbElzUmVnZXgsIFJlZlB0cjxUeXBlQnVpbGRlcjo6QXJyYXk8VHlwZUJ1aWxkZXI6OlBhZ2U6 OlNlYXJjaFJlc3VsdD4gPiYgcmVzdWx0cykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JSZXNvdXJjZUFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JSZXNvdXJjZUFnZW50LmNwcAppbmRleCBjNjg0NTQ1NzQ0ZDgyNjkyNzBm OTBmMjJlYjcxZDNlZjQyYTJhNjVkLi45YTZmMTljYmI1YWU0ODJhY2M0Y2VkNGMxYmVlYTQ5ODRj NDg5N2E2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUmVz b3VyY2VBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJl c291cmNlQWdlbnQuY3BwCkBAIC0xMTksNyArMTE5LDggQEAgc3RhdGljIFBhc3NSZWZQdHI8VHlw ZUJ1aWxkZXI6Ok5ldHdvcms6OlJlc291cmNlVGltaW5nPiBidWlsZE9iamVjdEZvclRpbWluZyhj b24KICAgICAgICAgLnNldFNzbEVuZCh0aW1pbmcuc3NsRW5kKQogICAgICAgICAuc2V0U2VuZFN0 YXJ0KHRpbWluZy5zZW5kU3RhcnQpCiAgICAgICAgIC5zZXRTZW5kRW5kKHRpbWluZy5zZW5kRW5k KQotICAgICAgICAuc2V0UmVjZWl2ZUhlYWRlcnNFbmQodGltaW5nLnJlY2VpdmVIZWFkZXJzRW5k KTsKKyAgICAgICAgLnNldFJlY2VpdmVIZWFkZXJzRW5kKHRpbWluZy5yZWNlaXZlSGVhZGVyc0Vu ZCkKKyAgICAgICAgLnJlbGVhc2UoKTsKIH0KIAogc3RhdGljIFBhc3NSZWZQdHI8VHlwZUJ1aWxk ZXI6Ok5ldHdvcms6OlJlcXVlc3Q+IGJ1aWxkT2JqZWN0Rm9yUmVzb3VyY2VSZXF1ZXN0KGNvbnN0 IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkKQEAgLTQwOSw3ICs0MTAsOCBAQCBQYXNzUmVmUHRy PFR5cGVCdWlsZGVyOjpOZXR3b3JrOjpJbml0aWF0b3I+IEluc3BlY3RvclJlc291cmNlQWdlbnQ6 OmJ1aWxkSW5pdGlhdAogICAgICAgICByZXR1cm4gbV9zdHlsZVJlY2FsY3VsYXRpb25Jbml0aWF0 b3I7CiAKICAgICByZXR1cm4gVHlwZUJ1aWxkZXI6Ok5ldHdvcms6OkluaXRpYXRvcjo6Y3JlYXRl KCkKLSAgICAgICAgLnNldFR5cGUoVHlwZUJ1aWxkZXI6Ok5ldHdvcms6OkluaXRpYXRvcjo6VHlw ZTo6T3RoZXIpOworICAgICAgICAuc2V0VHlwZShUeXBlQnVpbGRlcjo6TmV0d29yazo6SW5pdGlh dG9yOjpUeXBlOjpPdGhlcikKKyAgICAgICAgLnJlbGVhc2UoKTsKIH0KIAogI2lmIEVOQUJMRShX RUJfU09DS0VUUykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9TY3JpcHRD YWxsRnJhbWUuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1NjcmlwdENhbGxGcmFtZS5j cHAKaW5kZXggM2Y5Njc0YWVlZTQxMjcxYzNmZWEzZDEwMTQ1MjA0ZjhkZmIxZDlhMS4uMTE0YzI0 ZDkzMzAwNWEwN2QyOTk4OTZlM2MyNGVhZmJmNjgyNDRjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL1NjcmlwdENhbGxGcmFtZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL1NjcmlwdENhbGxGcmFtZS5jcHAKQEAgLTYzLDcgKzYzLDggQEAgUGFzc1JlZlB0 cjxUeXBlQnVpbGRlcjo6Q29uc29sZTo6Q2FsbEZyYW1lPiBTY3JpcHRDYWxsRnJhbWU6OmJ1aWxk SW5zcGVjdG9yT2JqZWMKICAgICAgICAgLnNldEZ1bmN0aW9uTmFtZShtX2Z1bmN0aW9uTmFtZSkK ICAgICAgICAgLnNldFVybChtX3NjcmlwdE5hbWUpCiAgICAgICAgIC5zZXRMaW5lTnVtYmVyKG1f bGluZU51bWJlcikKLSAgICAgICAgLnNldENvbHVtbk51bWJlcihtX2NvbHVtbik7CisgICAgICAg IC5zZXRDb2x1bW5OdW1iZXIobV9jb2x1bW4pCisgICAgICAgIC5yZWxlYXNlKCk7CiB9CiAjZW5k aWYKIAo=