85445 2012-05-02 18:32:05 -0700 Fix tabs vs. space formating in FeatureDefines.vsprops and fix alphabetical sorting 2012-05-03 14:16:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85456 1 eric eric abarth jberlin lforschler sfalken webkit.review.bot oldest_to_newest 614906 0 eric 2012-05-02 18:32:05 -0700 Fix tabs vs. space formating in FeatureDefines.vsprops and fix alphabetical sorting 614908 1 139934 eric 2012-05-02 18:32:55 -0700 Created attachment 139934 Patch 614909 2 eric 2012-05-02 18:34:13 -0700 I very intentionally did not change any functionality here. I did not add or remove any ENABLE macros, just sorting. I'll come back and sort the PreprocessorDefinitions="...." line at a later time (it's also only mostly alphabetical), since it's very long and hard to see in the diff. 614910 3 eric 2012-05-02 18:35:12 -0700 I noticed that this file is set to eol=native. I spoke with Lucas over IRC, and was told that should be correct. With luck this diff will apply, land and be checked-out with the proper line endings. :) 614911 4 eric 2012-05-02 18:35:28 -0700 Note to reviewers: the win-ews should turn green before this lands. 614920 5 eric 2012-05-02 18:40:44 -0700 bug 85433 is the equivalent re-sort for the Mac/IOS port. 614960 6 139934 webkit.review.bot 2012-05-02 20:32:56 -0700 Comment on attachment 139934 Patch Clearing flags on attachment: 139934 Committed r115934: <http://trac.webkit.org/changeset/115934> 614961 7 webkit.review.bot 2012-05-02 20:33:01 -0700 All reviewed patches have been landed. Closing bug. 139934 2012-05-02 18:32:55 -0700 2012-05-02 20:32:56 -0700 Patch bug-85445-20120502183254.patch text/plain 6557 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NzgzCmRpZmYgLS1naXQgYS9XZWJLaXRMaWJyYXJpZXMv Q2hhbmdlTG9nIGIvV2ViS2l0TGlicmFyaWVzL0NoYW5nZUxvZwppbmRleCA0ZGEwMTVhOTYyMWZm MjBmMjU5MzdiZTY3YWE0NzI2YTU5N2EyZjUyLi42ZGRiNjRlN2I2ZTI1MmJmNmY3MTA0MzkyODEw ZjMzYWE5ZDM4MGNkIDEwMDY0NAotLS0gYS9XZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCisrKyBi L1dlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNS0wMiAg RXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRhYnMgdnMuIHNw YWNlIGZvcm1hdGluZyBpbiBGZWF0dXJlRGVmaW5lcy52c3Byb3BzIGFuZCBmaXggYWxwaGFiZXRp Y2FsIHNvcnRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg1NDQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSSBub3RpY2VkIHRoaXMgd2hlbiBjb21wYXJpbmcgbXkgYXV0by1nZW5lcmF0ZWQgb3V0cHV0 IGZvciB0aGlzIGZpbGUgdnMuIHRoZSBvbmUKKyAgICAgICAgd2UgaGF2ZSBjaGVja2VkIGluLiAg U2VlbXMgd2UgbWlnaHQgYXMgd2VsbCBmaXggdGhlIGNoZWNrZWQgaW4gZmlsZSB0byBiZQorICAg ICAgICBjb25zaXN0ZW50IGluIHN0eWxlIHdpdGggaXRzZWxmLiA6KQorCisgICAgICAgICogd2lu L3Rvb2xzL3ZzcHJvcHMvRmVhdHVyZURlZmluZXMudnNwcm9wczoKKwogMjAxMi0wNC0yNyAgR2F2 aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgbmV3IEVOQUJM RV9MSU5LX1BSRVJFTkRFUiBkZWZpbmUgdG8gY29udHJvbCB0aGUgUHJlcmVuZGVyaW5nIEFQSQpk aWZmIC0tZ2l0IGEvV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL0ZlYXR1cmVEZWZp bmVzLnZzcHJvcHMgYi9XZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvRmVhdHVyZURl ZmluZXMudnNwcm9wcwppbmRleCBlMWVkN2U4OThlNTRlODM5YmExNTk3ZTI3MGM3ZTU4MWJjMDYx MWNlLi4zNDQzYjlhMDg1NTJiYzdiMDIzNmNiYjg5M2M4YzI4NjQ2YzFiNzljIDEwMDY0NAotLS0g YS9XZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvRmVhdHVyZURlZmluZXMudnNwcm9w cworKysgYi9XZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvRmVhdHVyZURlZmluZXMu dnNwcm9wcwpAQCAtMTIsMTEgKzEyLDYgQEAKIAkJUHJlcHJvY2Vzc29yRGVmaW5pdGlvbnM9IiQo RU5BQkxFX1JFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FKTskKEVOQUJMRV8zRF9DQU5WQVMpOyQoRU5B QkxFXzNEX1JFTkRFUklORyk7JChFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTKTskKEVOQUJM RV9CTE9CKTskKEVOQUJMRV9DSEFOTkVMX01FU1NBR0lORyk7JChFTkFCTEVfQ1NTX0ZJTFRFUlMp OyQoRU5BQkxFX0NTU19HUklEX0xBWU9VVCk7JChFTkFCTEVfQ1NTX1NIQURFUlMpOyQoRU5BQkxF X0NTU19SRUdJT05TKTskKEVOQUJMRV9DU1NfRVhDTFVTSU9OUyk7JChFTkFCTEVfU1FMX0RBVEFC QVNFKTskKEVOQUJMRV9EQVRBR1JJRCk7JChFTkFCTEVfREFUQUxJU1QpOyQoRU5BQkxFX0RBVEFf VFJBTlNGRVJfSVRFTVMpOyQoRU5BQkxFX0RFVEFJTFMpOyQoRU5BQkxFX0RFVklDRV9PUklFTlRB VElPTik7JChFTkFCTEVfRElSRUNUT1JZX1VQTE9BRCk7JChFTkFCTEVfRklMVEVSUyk7JChFTkFC TEVfRklMRV9TWVNURU0pOyQoRU5BQkxFX0ZVTExTQ1JFRU5fQVBJKTskKEVOQUJMRV9HQU1FUEFE KTskKEVOQUJMRV9HRU9MT0NBVElPTik7JChFTkFCTEVfSElHSF9EUElfQ0FOVkFTKTskKEVOQUJM RV9JQ09OREFUQUJBU0UpOyQoRU5BQkxFX0lOREVYRURfREFUQUJBU0UpOyQoRU5BQkxFX0lOUFVU X1RZUEVfQ09MT1IpOyQoRU5BQkxFX0lOUFVUX1NQRUVDSCk7JChFTkFCTEVfSU5QVVRfVFlQRV9E QVRFKTskKEVOQUJMRV9JTlBVVF9UWVBFX0RBVEVUSU1FKTskKEVOQUJMRV9JTlBVVF9UWVBFX0RB VEVUSU1FTE9DQUwpOyQoRU5BQkxFX0lOUFVUX1RZUEVfTU9OVEgpOyQoRU5BQkxFX0lOUFVUX1RZ UEVfVElNRSk7JChFTkFCTEVfSU5QVVRfVFlQRV9XRUVLKTskKEVOQUJMRV9KQVZBU0NSSVBUX0RF QlVHR0VSKTskKEVOQUJMRV9MRUdBQ1lfQ1NTX1ZFTkRPUl9QUkVGSVhFUyk7JChFTkFCTEVfTEVH QUNZX05PVElGSUNBVElPTlMpOyQoRU5BQkxFX0xJTktfUFJFRkVUQ0gpOyQoRU5BQkxFX0xJTktf UFJFUkVOREVSKTskKEVOQUJMRV9NQVRITUwpOyQoRU5BQkxFX01FVEVSX1RBRyk7JChFTkFCTEVf TUlDUk9EQVRBKTskKEVOQUJMRV9NVVRBVElPTl9PQlNFUlZFUlMpOyQoRU5BQkxFX05PVElGSUNB VElPTlMpOyQoRU5BQkxFX1BBR0VfVklTSUJJTElUWV9BUEkpOyQoRU5BQkxFX1BST0dSRVNTX1RB Ryk7JChFTkFCTEVfUVVPVEEpOyQoRU5BQkxFX1JFR0lTVEVSX1BST1RPQ09MX0hBTkRMRVIpOyQo RU5BQkxFX1NDUklQVEVEX1NQRUVDSCk7JChFTkFCTEVfU0hBRE9XX0RPTSk7JChFTkFCTEVfU0hB UkVEX1dPUktFUlMpOyQoRU5BQkxFX1NUWUxFX1NDT1BFRCk7JChFTkFCTEVfU1ZHKTskKEVOQUJM RV9TVkdfRE9NX09CSkNfQklORElOR1MpOyQoRU5BQkxFX1NWR19GT05UUyk7JChFTkFCTEVfVklE RU8pOyQoRU5BQkxFX01FRElBX1NPVVJDRSk7JChFTkFCTEVfTUVESUFfU1RBVElTVElDUyk7JChF TkFCTEVfV0VCX1NPQ0tFVFMpOyQoRU5BQkxFX1dFQl9USU1JTkcpOyQoRU5BQkxFX1dPUktFUlMp OyQoRU5BQkxFX1hTTFQpIgogCS8+CiAgIDxVc2VyTWFjcm8KLQkJTmFtZT0iRU5BQkxFX1JFUVVF U1RfQU5JTUFUSU9OX0ZSQU1FIgotCQlWYWx1ZT0iRU5BQkxFX1JFUVVFU1RfQU5JTUFUSU9OX0ZS QU1FIgotCQlQZXJmb3JtRW52aXJvbm1lbnRTZXQ9InRydWUiCi0JLz4KLSAgICA8VXNlck1hY3Jv CiAJCU5hbWU9IkVOQUJMRV8zRF9DQU5WQVMiCiAJCVZhbHVlPSIiCiAJCVBlcmZvcm1FbnZpcm9u bWVudFNldD0idHJ1ZSIKQEAgLTQyLDE3ICszNywxNyBAQAogCQlQZXJmb3JtRW52aXJvbm1lbnRT ZXQ9InRydWUiCiAJLz4KICAgPFVzZXJNYWNybwotCQlOYW1lPSJFTkFCTEVfQ1NTX0ZJTFRFUlMi Ci0JCVZhbHVlPSJFTkFCTEVfQ1NTX0ZJTFRFUlMiCisJCU5hbWU9IkVOQUJMRV9DU1NfRVhDTFVT SU9OUyIKKwkJVmFsdWU9IiIKIAkJUGVyZm9ybUVudmlyb25tZW50U2V0PSJ0cnVlIgogCS8+CiAg IDxVc2VyTWFjcm8KLQkJTmFtZT0iRU5BQkxFX0NTU19HUklEX0xBWU9VVCIKLQkJVmFsdWU9IiIK KwkJTmFtZT0iRU5BQkxFX0NTU19GSUxURVJTIgorCQlWYWx1ZT0iRU5BQkxFX0NTU19GSUxURVJT IgogCQlQZXJmb3JtRW52aXJvbm1lbnRTZXQ9InRydWUiCiAJLz4KICAgPFVzZXJNYWNybwotCQlO YW1lPSJFTkFCTEVfQ1NTX1NIQURFUlMiCisJCU5hbWU9IkVOQUJMRV9DU1NfR1JJRF9MQVlPVVQi CiAJCVZhbHVlPSIiCiAJCVBlcmZvcm1FbnZpcm9ubWVudFNldD0idHJ1ZSIKIAkvPgpAQCAtNjIs MTYgKzU3LDExIEBACiAJCVBlcmZvcm1FbnZpcm9ubWVudFNldD0idHJ1ZSIKIAkvPgogICA8VXNl ck1hY3JvCi0JCU5hbWU9IkVOQUJMRV9DU1NfRVhDTFVTSU9OUyIKKwkJTmFtZT0iRU5BQkxFX0NT U19TSEFERVJTIgogCQlWYWx1ZT0iIgogCQlQZXJmb3JtRW52aXJvbm1lbnRTZXQ9InRydWUiCiAJ Lz4KICAgPFVzZXJNYWNybwotCQlOYW1lPSJFTkFCTEVfU1FMX0RBVEFCQVNFIgotCQlWYWx1ZT0i RU5BQkxFX1NRTF9EQVRBQkFTRSIKLQkJUGVyZm9ybUVudmlyb25tZW50U2V0PSJ0cnVlIgotCS8+ Ci0gIDxVc2VyTWFjcm8KIAkJTmFtZT0iRU5BQkxFX0RBVEFHUklEIgogCQlWYWx1ZT0iIgogCQlQ ZXJmb3JtRW52aXJvbm1lbnRTZXQ9InRydWUiCkBAIC05NywxMyArODcsOCBAQAogCQlQZXJmb3Jt RW52aXJvbm1lbnRTZXQ9InRydWUiCiAJLz4KICAgPFVzZXJNYWNybwotICAgICAgICBOYW1lPSJF TkFCTEVfRElSRUNUT1JZX1VQTE9BRCIKLSAgICAgICAgVmFsdWU9IiIKLSAgICAgICAgUGVyZm9y bUVudmlyb25tZW50U2V0PSJ0cnVlIgotICAgIC8+Ci0gIDxVc2VyTWFjcm8KLQkJTmFtZT0iRU5B QkxFX0ZJTFRFUlMiCi0JCVZhbHVlPSJFTkFCTEVfRklMVEVSUyIKKwkJTmFtZT0iRU5BQkxFX0RJ UkVDVE9SWV9VUExPQUQiCisJCVZhbHVlPSIiCiAJCVBlcmZvcm1FbnZpcm9ubWVudFNldD0idHJ1 ZSIKIAkvPgogICA8VXNlck1hY3JvCkBAIC0xMTIsNiArOTcsMTEgQEAKIAkJUGVyZm9ybUVudmly b25tZW50U2V0PSJ0cnVlIgogCS8+CiAgIDxVc2VyTWFjcm8KKwkJTmFtZT0iRU5BQkxFX0ZJTFRF UlMiCisJCVZhbHVlPSJFTkFCTEVfRklMVEVSUyIKKwkJUGVyZm9ybUVudmlyb25tZW50U2V0PSJ0 cnVlIgorCS8+CisgIDxVc2VyTWFjcm8KIAkJTmFtZT0iRU5BQkxFX0ZVTExTQ1JFRU5fQVBJIgog CQlWYWx1ZT0iRU5BQkxFX0ZVTExTQ1JFRU5fQVBJIgogCQlQZXJmb3JtRW52aXJvbm1lbnRTZXQ9 InRydWUiCkBAIC0xNDIsMTIgKzEzMiwxMiBAQAogCQlQZXJmb3JtRW52aXJvbm1lbnRTZXQ9InRy dWUiCiAJLz4KICAgPFVzZXJNYWNybwotCQlOYW1lPSJFTkFCTEVfSU5QVVRfVFlQRV9DT0xPUiIK KwkJTmFtZT0iRU5BQkxFX0lOUFVUX1NQRUVDSCIKIAkJVmFsdWU9IiIKIAkJUGVyZm9ybUVudmly b25tZW50U2V0PSJ0cnVlIgogCS8+CiAgIDxVc2VyTWFjcm8KLQkJTmFtZT0iRU5BQkxFX0lOUFVU X1NQRUVDSCIKKwkJTmFtZT0iRU5BQkxFX0lOUFVUX1RZUEVfQ09MT1IiCiAJCVZhbHVlPSIiCiAJ CVBlcmZvcm1FbnZpcm9ubWVudFNldD0idHJ1ZSIKIAkvPgpAQCAtMTg2LDE2ICsxNzYsMTYgQEAK IAkJVmFsdWU9IkVOQUJMRV9KQVZBU0NSSVBUX0RFQlVHR0VSIgogCQlQZXJmb3JtRW52aXJvbm1l bnRTZXQ9InRydWUiCiAJLz4KLTxVc2VyTWFjcm8KKyAgPFVzZXJNYWNybwogCQlOYW1lPSJFTkFC TEVfTEVHQUNZX0NTU19WRU5ET1JfUFJFRklYRVMiCiAJCVZhbHVlPSJFTkFCTEVfTEVHQUNZX0NT U19WRU5ET1JfUFJFRklYRVMiCiAJCVBlcmZvcm1FbnZpcm9ubWVudFNldD0idHJ1ZSIKLS8+Ci08 VXNlck1hY3JvCisJLz4KKyAgPFVzZXJNYWNybwogCQlOYW1lPSJFTkFCTEVfTEVHQUNZX05PVElG SUNBVElPTlMiCiAJCVZhbHVlPSIiCiAJCVBlcmZvcm1FbnZpcm9ubWVudFNldD0idHJ1ZSIKLS8+ CisJLz4KICAgPFVzZXJNYWNybwogCQlOYW1lPSJFTkFCTEVfTElOS19QUkVGRVRDSCIKIAkJVmFs dWU9IiIKQEAgLTIxMiw2ICsyMDIsMTYgQEAKIAkJUGVyZm9ybUVudmlyb25tZW50U2V0PSJ0cnVl IgogCS8+CiAgIDxVc2VyTWFjcm8KKwkJTmFtZT0iRU5BQkxFX01FRElBX1NPVVJDRSIKKwkJVmFs dWU9IkVOQUJMRV9NRURJQV9TT1VSQ0UiCisJCVBlcmZvcm1FbnZpcm9ubWVudFNldD0idHJ1ZSIK KwkvPgorICA8VXNlck1hY3JvCisJCU5hbWU9IkVOQUJMRV9NRURJQV9TVEFUSVNUSUNTIgorCQlW YWx1ZT0iRU5BQkxFX01FRElBX1NUQVRJU1RJQ1MiCisJCVBlcmZvcm1FbnZpcm9ubWVudFNldD0i dHJ1ZSIKKwkvPgorICA8VXNlck1hY3JvCiAJCU5hbWU9IkVOQUJMRV9NRVRFUl9UQUciCiAJCVZh bHVlPSJFTkFCTEVfTUVURVJfVEFHIgogCQlQZXJmb3JtRW52aXJvbm1lbnRTZXQ9InRydWUiCkBA IC0yNTIsNiArMjUyLDExIEBACiAJCVBlcmZvcm1FbnZpcm9ubWVudFNldD0idHJ1ZSIKIAkvPgog ICA8VXNlck1hY3JvCisJCU5hbWU9IkVOQUJMRV9SRVFVRVNUX0FOSU1BVElPTl9GUkFNRSIKKwkJ VmFsdWU9IkVOQUJMRV9SRVFVRVNUX0FOSU1BVElPTl9GUkFNRSIKKwkJUGVyZm9ybUVudmlyb25t ZW50U2V0PSJ0cnVlIgorCS8+CisgIDxVc2VyTWFjcm8KIAkJTmFtZT0iRU5BQkxFX1NDUklQVEVE X1NQRUVDSCIKIAkJVmFsdWU9IiIKIAkJUGVyZm9ybUVudmlyb25tZW50U2V0PSJ0cnVlIgpAQCAt MjY3LDYgKzI3MiwxMSBAQAogCQlQZXJmb3JtRW52aXJvbm1lbnRTZXQ9InRydWUiCiAJLz4KICAg PFVzZXJNYWNybworCQlOYW1lPSJFTkFCTEVfU1FMX0RBVEFCQVNFIgorCQlWYWx1ZT0iRU5BQkxF X1NRTF9EQVRBQkFTRSIKKwkJUGVyZm9ybUVudmlyb25tZW50U2V0PSJ0cnVlIgorCS8+CisgIDxV c2VyTWFjcm8KIAkJTmFtZT0iRU5BQkxFX1NUWUxFX1NDT1BFRCIKIAkJVmFsdWU9IiIKIAkJUGVy Zm9ybUVudmlyb25tZW50U2V0PSJ0cnVlIgpAQCAtMjkyLDE2ICszMDIsNiBAQAogCQlQZXJmb3Jt RW52aXJvbm1lbnRTZXQ9InRydWUiCiAJLz4KICAgPFVzZXJNYWNybwotCQlOYW1lPSJFTkFCTEVf TUVESUFfU09VUkNFIgotCQlWYWx1ZT0iRU5BQkxFX01FRElBX1NPVVJDRSIKLQkJUGVyZm9ybUVu dmlyb25tZW50U2V0PSJ0cnVlIgotCS8+Ci0gIDxVc2VyTWFjcm8KLQkJTmFtZT0iRU5BQkxFX01F RElBX1NUQVRJU1RJQ1MiCi0JCVZhbHVlPSJFTkFCTEVfTUVESUFfU1RBVElTVElDUyIKLQkJUGVy Zm9ybUVudmlyb25tZW50U2V0PSJ0cnVlIgotCS8+Ci0gIDxVc2VyTWFjcm8KIAkJTmFtZT0iRU5B QkxFX1dFQl9BVURJTyIKIAkJVmFsdWU9IiIKIAkJUGVyZm9ybUVudmlyb25tZW50U2V0PSJ0cnVl Igo=