85444 2012-05-02 18:31:43 -0700 Crash in webkitAddKey() when key parameter is null 2012-07-23 17:37:59 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 82968 1 ddorwin ddorwin eric.carlson feature-media-reviews haraken webkit.review.bot oldest_to_newest 614905 0 ddorwin 2012-05-02 18:31:43 -0700 The following results in a crash video.webkitAddKey("foo", null); The IDL ensures that there is a second parameter but not that it isn't null. We need to check this in the code and return an appropriate error. The algorithm in the proposal also needs to be updated to to handle this. 671421 1 152791 ddorwin 2012-07-17 11:16:37 -0700 Created attachment 152791 Patch 672108 2 152791 haraken 2012-07-18 01:14:03 -0700 Comment on attachment 152791 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152791&action=review > Source/WebCore/ChangeLog:7 > + Would you add the link to the spec that supports your change? The change looks good but I am not sure if SYNTAX_ERR is the expected error. 674006 3 ddorwin 2012-07-19 15:55:25 -0700 (In reply to comment #2) > (From update of attachment 152791 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152791&action=review > > > Source/WebCore/ChangeLog:7 > > + > > Would you add the link to the spec that supports your change? The change looks good but I am not sure if SYNTAX_ERR is the expected error. http://dvcs.w3.org/hg/html-media/raw-file/a70cac1c6d77/encrypted-media/encrypted-media.html#dom-addkey step 1. I had to update it to handle the second argument, but the first argument has always been a SYNTAX_ERR. If there is a better or more appropriate way of handling these cases, I can update this patch and the spec. 674224 4 152791 haraken 2012-07-19 23:30:22 -0700 Comment on attachment 152791 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152791&action=review >>> Source/WebCore/ChangeLog:7 >>> + >> >> Would you add the link to the spec that supports your change? The change looks good but I am not sure if SYNTAX_ERR is the expected error. > > http://dvcs.w3.org/hg/html-media/raw-file/a70cac1c6d77/encrypted-media/encrypted-media.html#dom-addkey step 1. I had to update it to handle the second argument, but the first argument has always been a SYNTAX_ERR. If there is a better or more appropriate way of handling these cases, I can update this patch and the spec. Thanks. Looks OK. Please describe the link and the explanation you described in bugzilla to this ChangeLog. 674226 5 haraken 2012-07-19 23:31:10 -0700 (In reply to comment #3) > I had to update it to handle the second argument OK, let's fix it in a separate patch. 676150 6 153893 ddorwin 2012-07-23 16:29:17 -0700 Created attachment 153893 Patch 676151 7 ddorwin 2012-07-23 16:31:18 -0700 Added (newer) link to the ChangeLogs. The code is the same. CQ? Thanks. 676227 8 153893 webkit.review.bot 2012-07-23 17:37:55 -0700 Comment on attachment 153893 Patch Clearing flags on attachment: 153893 Committed r123409: <http://trac.webkit.org/changeset/123409> 676228 9 webkit.review.bot 2012-07-23 17:37:59 -0700 All reviewed patches have been landed. Closing bug. 152791 2012-07-17 11:16:37 -0700 2012-07-23 16:29:14 -0700 Patch bug-85444-20120717111637.patch text/plain 4934 ddorwin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTFjMzNhZjAyNzQ3ODdk NGJiMzJjZWM1YWQ1OTExMDdhNTY1NmNhMS4uZTdlMmMzZjBjNjFhMTk0M2I3ZjM1NWUyNDBlYzRk OTUwZDliY2M2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTE3ICBEYXZp ZCBEb3J3aW4gIDxkZG9yd2luQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXhlZCBjcmFzaCBp biB3ZWJraXRBZGRLZXkoKSB3aGVuIGtleSBwYXJhbWV0ZXIgaXMgbnVsbC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NDQ0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHM6IG1lZGlhL2VuY3J5cHRl ZC1tZWRpYS9lbmNyeXB0ZWQtbWVkaWEtc3ludGF4Lmh0bWwgCisKKyAgICAgICAgKiBodG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6 d2Via2l0QWRkS2V5KToKKwogMjAxMi0wNy0xNyAgS3dhbmcgWXVsIFNlbyAgPHNreXVsQGNvbXBh bnkxMDAubmV0PgogCiAgICAgICAgICJpbiBib2R5IiBpbnNlcnRpb24gbW9kZSwgImFueSBvdGhl ciBlbmQgdGFnIiBzdGVwIDIuMSBpcyB1cGRhdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVk aWFFbGVtZW50LmNwcAppbmRleCA3MDVhMDVjNWY4ZGI1MTZjNjhiODUwODVhN2IzYjUwNzg2NmZk NjEwLi4xNDhkZjgxMzRiOWJjZWY2ZGRjZmU3MmJlZjdlZDc2Mjk5NWMwNzIxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTI1NjMsNiArMjU2MywxMSBAQCB2 b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OndlYmtpdEFkZEtleShjb25zdCBTdHJpbmcmIGtleVN5c3Rl bSwgUGFzc1JlZlB0cjxVaW50OEFycgogICAgICAgICByZXR1cm47CiAgICAgfQogCisgICAgaWYg KCFrZXkpIHsKKyAgICAgICAgZWMgPSBTWU5UQVhfRVJSOworICAgICAgICByZXR1cm47CisgICAg fQorCiAgICAgaWYgKCFrZXktPmxlbmd0aCgpKSB7CiAgICAgICAgIGVjID0gVFlQRV9NSVNNQVRD SF9FUlI7CiAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwNzk0YzljZTgwOTA1ZmE2ZDVmNmEwNWFm MWZiN2VjNTI3ZWIwYTk3Li5mZTU4NjdiOGYzMzQ5M2U2MzA5NmU5MmM5MDRmNDE0N2M3NTE1NmUw IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDctMTcgIERhdmlkIERvcndpbiAgPGRkb3J3 aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeGVkIGNyYXNoIGluIHdlYmtpdEFkZEtleSgp IHdoZW4ga2V5IHBhcmFtZXRlciBpcyBudWxsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU0NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIG1lZGlhL2VuY3J5cHRlZC1tZWRpYS9lbmNyeXB0ZWQtbWVk aWEtc3ludGF4LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBtZWRpYS9lbmNyeXB0ZWQtbWVkaWEv ZW5jcnlwdGVkLW1lZGlhLXN5bnRheC5odG1sOgorCiAyMDEyLTA3LTE2ICDDgWTDoW0gS2FsbGFp ICA8a2FkYW1AaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFtRdF0gcGxhdGZyb20vcXQvZWRp dGluZy9pbnNlcnRpbmcgdGVzdHMgbmVlZHMgdXBkYXRlIGFmdGVyIHRlc3QgZm9udCBjaGFuZ2Uu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9lbmNyeXB0ZWQtbWVkaWEvZW5jcnlwdGVk LW1lZGlhLXN5bnRheC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS9lbmNyeXB0ZWQt bWVkaWEvZW5jcnlwdGVkLW1lZGlhLXN5bnRheC1leHBlY3RlZC50eHQKaW5kZXggZWE5NzZhMDhm OGNkNmU2MTM5MjczYzAwMWM0MDBhOTkwZWU0OWJmOC4uZmIyNDc4N2QxZWJhZjM5MzUwODIyMGE2 Y2ZlMDA5ODliMWNkOTQ3NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvZW5jcnlwdGVk LW1lZGlhL2VuY3J5cHRlZC1tZWRpYS1zeW50YXgtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRl c3RzL21lZGlhL2VuY3J5cHRlZC1tZWRpYS9lbmNyeXB0ZWQtbWVkaWEtc3ludGF4LWV4cGVjdGVk LnR4dApAQCAtMTksNiArMTksMTEgQEAgVEVTVCh2aWRlby53ZWJraXRDYW5jZWxLZXlSZXF1ZXN0 KCcnKSkgVEhST1dTKERPTUV4Y2VwdGlvbi5TWU5UQVhfRVJSKSBPSwogVEVTVCh2aWRlby53ZWJr aXRDYW5jZWxLZXlSZXF1ZXN0KG51bGwpKSBUSFJPV1MoRE9NRXhjZXB0aW9uLlNZTlRBWF9FUlIp IE9LCiBURVNUKHZpZGVvLndlYmtpdENhbmNlbEtleVJlcXVlc3QodW5kZWZpbmVkKSkgVEhST1dT KERPTUV4Y2VwdGlvbi5TWU5UQVhfRVJSKSBPSwogCitudWxsIGtleSBpcyBjYXVnaHQgYmVmb3Jl IGxvYWQgc3RhdGUgaXMgY2hlY2tlZC4KK1RFU1QodmlkZW8ud2Via2l0QWRkS2V5KCd3ZWJraXQt b3JnLnczLmNsZWFya2V5JywgJycpKSBUSFJPV1MoRE9NRXhjZXB0aW9uLlNZTlRBWF9FUlIpIE9L CitURVNUKHZpZGVvLndlYmtpdEFkZEtleSgnd2Via2l0LW9yZy53My5jbGVhcmtleScsIG51bGwp KSBUSFJPV1MoRE9NRXhjZXB0aW9uLlNZTlRBWF9FUlIpIE9LCitURVNUKHZpZGVvLndlYmtpdEFk ZEtleSgnd2Via2l0LW9yZy53My5jbGVhcmtleScsIHVuZGVmaW5lZCkpIFRIUk9XUyhET01FeGNl cHRpb24uU1lOVEFYX0VSUikgT0sKKwogMC1sZW5ndGgga2V5IGlzIGNhdWdodCBiZWZvcmUgbG9h ZCBzdGF0ZSBpcyBjaGVja2VkLgogVEVTVCh2aWRlby53ZWJraXRBZGRLZXkoJ3dlYmtpdC1vcmcu dzMuY2xlYXJrZXknLCBuZXcgVWludDhBcnJheSgpKSkgVEhST1dTKERPTUV4Y2VwdGlvbi5UWVBF X01JU01BVENIX0VSUikgT0sKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvZW5jcnlw dGVkLW1lZGlhL2VuY3J5cHRlZC1tZWRpYS1zeW50YXguaHRtbCBiL0xheW91dFRlc3RzL21lZGlh L2VuY3J5cHRlZC1tZWRpYS9lbmNyeXB0ZWQtbWVkaWEtc3ludGF4Lmh0bWwKaW5kZXggNjJlMWFm YWM2ZTNjMDg2YThjMTYyNzBhMWUxOGM4NzYyMDE3ODRhMS4uMzc2NDgzMzliYzQxZWIyZWNmNDZk ODdhYmI1ZGYwMGQ5YTA3ZTk4NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvZW5jcnlw dGVkLW1lZGlhL2VuY3J5cHRlZC1tZWRpYS1zeW50YXguaHRtbAorKysgYi9MYXlvdXRUZXN0cy9t ZWRpYS9lbmNyeXB0ZWQtbWVkaWEvZW5jcnlwdGVkLW1lZGlhLXN5bnRheC5odG1sCkBAIC00Miw2 ICs0Miw3IEBACiAKICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiPGJyPlZlcmlmeSBpbnZhbGlk IGtleSBzeXN0ZW0gcGFyYW1ldGVyIGlzIGNhdWdodCBiZWZvcmUgY2hlY2tpbmcgd2hldGhlciBs b2FkaW5nIGhhcyBzdGFydGVkLiIpOwogICAgICAgICAgICAgLy8gSWYgdGhlIGFib3ZlIHdhcyBu b3QgdGhlIGNhc2UsIGFsbCBvZiB0aGVzZSB3b3VsZCBiZSBJTlZBTElEX1NUQVRFX0VSUi4KKyAg ICAgICAgICAgIC8vIEFsc28gdGVzdHMgIm51bGwiIGNhc2UgZm9yIGZpcnN0IHBhcmFtZXRlci4K ICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8ubmV0d29ya1N0YXRlIiwgdmlkZW8uTkVU V09SS19FTVBUWSk7CiAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInZpZGVvLmN1cnJlbnRTcmMi LCAiIik7CiAgICAgICAgICAgICB0ZXN0RXhjZXB0aW9uKCJ2aWRlby53ZWJraXRHZW5lcmF0ZUtl eVJlcXVlc3QoJycpIiwgIkRPTUV4Y2VwdGlvbi5TWU5UQVhfRVJSIik7CkBAIC01NCw2ICs1NSwx MSBAQAogICAgICAgICAgICAgdGVzdEV4Y2VwdGlvbigidmlkZW8ud2Via2l0Q2FuY2VsS2V5UmVx dWVzdChudWxsKSIsICJET01FeGNlcHRpb24uU1lOVEFYX0VSUiIpOwogICAgICAgICAgICAgdGVz dEV4Y2VwdGlvbigidmlkZW8ud2Via2l0Q2FuY2VsS2V5UmVxdWVzdCh1bmRlZmluZWQpIiwgIkRP TUV4Y2VwdGlvbi5TWU5UQVhfRVJSIik7CiAKKyAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiPGJy Pm51bGwga2V5IGlzIGNhdWdodCBiZWZvcmUgbG9hZCBzdGF0ZSBpcyBjaGVja2VkLiIpOworICAg ICAgICAgICAgdGVzdEV4Y2VwdGlvbigidmlkZW8ud2Via2l0QWRkS2V5KCd3ZWJraXQtb3JnLncz LmNsZWFya2V5JywgJycpIiwgIkRPTUV4Y2VwdGlvbi5TWU5UQVhfRVJSIik7CisgICAgICAgICAg ICB0ZXN0RXhjZXB0aW9uKCJ2aWRlby53ZWJraXRBZGRLZXkoJ3dlYmtpdC1vcmcudzMuY2xlYXJr ZXknLCBudWxsKSIsICJET01FeGNlcHRpb24uU1lOVEFYX0VSUiIpOworICAgICAgICAgICAgdGVz dEV4Y2VwdGlvbigidmlkZW8ud2Via2l0QWRkS2V5KCd3ZWJraXQtb3JnLnczLmNsZWFya2V5Jywg dW5kZWZpbmVkKSIsICJET01FeGNlcHRpb24uU1lOVEFYX0VSUiIpOworCiAgICAgICAgICAgICBj b25zb2xlV3JpdGUoIjxicj4wLWxlbmd0aCBrZXkgaXMgY2F1Z2h0IGJlZm9yZSBsb2FkIHN0YXRl IGlzIGNoZWNrZWQuIik7CiAgICAgICAgICAgICB0ZXN0RXhjZXB0aW9uKCJ2aWRlby53ZWJraXRB ZGRLZXkoJ3dlYmtpdC1vcmcudzMuY2xlYXJrZXknLCBuZXcgVWludDhBcnJheSgpKSIsICJET01F eGNlcHRpb24uVFlQRV9NSVNNQVRDSF9FUlIiKTsKIAo= 153893 2012-07-23 16:29:17 -0700 2012-07-23 17:37:55 -0700 Patch bug-85444-20120723162909.patch text/plain 5204 ddorwin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTFjMzNhZjAyNzQ3ODdk NGJiMzJjZWM1YWQ1OTExMDdhNTY1NmNhMS4uNmQzMjdkNzEyODJkZjQzM2VmZjcyOGYxNTYxNTgx MTg0MWVjYTFiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTE3ICBEYXZp ZCBEb3J3aW4gIDxkZG9yd2luQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXhlZCBjcmFzaCBp biB3ZWJraXRBZGRLZXkoKSB3aGVuIGtleSBwYXJhbWV0ZXIgaXMgbnVsbC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NDQ0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVmZXJlbmNlOiBTdGVwIDEgb2Yg aHR0cDovL2R2Y3MudzMub3JnL2hnL2h0bWwtbWVkaWEvcmF3LWZpbGUvNWY3NmEwYjQzODM2L2Vu Y3J5cHRlZC1tZWRpYS9lbmNyeXB0ZWQtbWVkaWEuaHRtbCNkb20tYWRka2V5CisKKyAgICAgICAg VGVzdHM6IG1lZGlhL2VuY3J5cHRlZC1tZWRpYS9lbmNyeXB0ZWQtbWVkaWEtc3ludGF4Lmh0bWwg CisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SFRNTE1lZGlhRWxlbWVudDo6d2Via2l0QWRkS2V5KToKKwogMjAxMi0wNy0xNyAgS3dhbmcg WXVsIFNlbyAgPHNreXVsQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgICJpbiBib2R5IiBpbnNl cnRpb24gbW9kZSwgImFueSBvdGhlciBlbmQgdGFnIiBzdGVwIDIuMSBpcyB1cGRhdGVkCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCA3MDVhMDVjNWY4ZGI1MTZj NjhiODUwODVhN2IzYjUwNzg2NmZkNjEwLi4xNDhkZjgxMzRiOWJjZWY2ZGRjZmU3MmJlZjdlZDc2 Mjk5NWMwNzIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAg LTI1NjMsNiArMjU2MywxMSBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OndlYmtpdEFkZEtleShj b25zdCBTdHJpbmcmIGtleVN5c3RlbSwgUGFzc1JlZlB0cjxVaW50OEFycgogICAgICAgICByZXR1 cm47CiAgICAgfQogCisgICAgaWYgKCFrZXkpIHsKKyAgICAgICAgZWMgPSBTWU5UQVhfRVJSOwor ICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgaWYgKCFrZXktPmxlbmd0aCgpKSB7CiAgICAg ICAgIGVjID0gVFlQRV9NSVNNQVRDSF9FUlI7CiAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwNzk0 YzljZTgwOTA1ZmE2ZDVmNmEwNWFmMWZiN2VjNTI3ZWIwYTk3Li5kZGUwYzg0MWM1NTM3ZmEzZGRk Njc3ZjgzZWE0YmFlN2I5MzFlNjc3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDctMTcg IERhdmlkIERvcndpbiAgPGRkb3J3aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeGVkIGNy YXNoIGluIHdlYmtpdEFkZEtleSgpIHdoZW4ga2V5IHBhcmFtZXRlciBpcyBudWxsLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU0NDQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWZlcmVuY2U6IFN0ZXAg MSBvZiBodHRwOi8vZHZjcy53My5vcmcvaGcvaHRtbC1tZWRpYS9yYXctZmlsZS81Zjc2YTBiNDM4 MzYvZW5jcnlwdGVkLW1lZGlhL2VuY3J5cHRlZC1tZWRpYS5odG1sI2RvbS1hZGRrZXkKKworICAg ICAgICAqIG1lZGlhL2VuY3J5cHRlZC1tZWRpYS9lbmNyeXB0ZWQtbWVkaWEtc3ludGF4LWV4cGVj dGVkLnR4dDoKKyAgICAgICAgKiBtZWRpYS9lbmNyeXB0ZWQtbWVkaWEvZW5jcnlwdGVkLW1lZGlh LXN5bnRheC5odG1sOgorCiAyMDEyLTA3LTE2ICDDgWTDoW0gS2FsbGFpICA8a2FkYW1AaW5mLnUt c3plZ2VkLmh1PgogCiAgICAgICAgIFtRdF0gcGxhdGZyb20vcXQvZWRpdGluZy9pbnNlcnRpbmcg dGVzdHMgbmVlZHMgdXBkYXRlIGFmdGVyIHRlc3QgZm9udCBjaGFuZ2UuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9tZWRpYS9lbmNyeXB0ZWQtbWVkaWEvZW5jcnlwdGVkLW1lZGlhLXN5bnRheC1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS9lbmNyeXB0ZWQtbWVkaWEvZW5jcnlwdGVk LW1lZGlhLXN5bnRheC1leHBlY3RlZC50eHQKaW5kZXggZWE5NzZhMDhmOGNkNmU2MTM5MjczYzAw MWM0MDBhOTkwZWU0OWJmOC4uZmIyNDc4N2QxZWJhZjM5MzUwODIyMGE2Y2ZlMDA5ODliMWNkOTQ3 NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvZW5jcnlwdGVkLW1lZGlhL2VuY3J5cHRl ZC1tZWRpYS1zeW50YXgtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL21lZGlhL2VuY3J5 cHRlZC1tZWRpYS9lbmNyeXB0ZWQtbWVkaWEtc3ludGF4LWV4cGVjdGVkLnR4dApAQCAtMTksNiAr MTksMTEgQEAgVEVTVCh2aWRlby53ZWJraXRDYW5jZWxLZXlSZXF1ZXN0KCcnKSkgVEhST1dTKERP TUV4Y2VwdGlvbi5TWU5UQVhfRVJSKSBPSwogVEVTVCh2aWRlby53ZWJraXRDYW5jZWxLZXlSZXF1 ZXN0KG51bGwpKSBUSFJPV1MoRE9NRXhjZXB0aW9uLlNZTlRBWF9FUlIpIE9LCiBURVNUKHZpZGVv LndlYmtpdENhbmNlbEtleVJlcXVlc3QodW5kZWZpbmVkKSkgVEhST1dTKERPTUV4Y2VwdGlvbi5T WU5UQVhfRVJSKSBPSwogCitudWxsIGtleSBpcyBjYXVnaHQgYmVmb3JlIGxvYWQgc3RhdGUgaXMg Y2hlY2tlZC4KK1RFU1QodmlkZW8ud2Via2l0QWRkS2V5KCd3ZWJraXQtb3JnLnczLmNsZWFya2V5 JywgJycpKSBUSFJPV1MoRE9NRXhjZXB0aW9uLlNZTlRBWF9FUlIpIE9LCitURVNUKHZpZGVvLndl YmtpdEFkZEtleSgnd2Via2l0LW9yZy53My5jbGVhcmtleScsIG51bGwpKSBUSFJPV1MoRE9NRXhj ZXB0aW9uLlNZTlRBWF9FUlIpIE9LCitURVNUKHZpZGVvLndlYmtpdEFkZEtleSgnd2Via2l0LW9y Zy53My5jbGVhcmtleScsIHVuZGVmaW5lZCkpIFRIUk9XUyhET01FeGNlcHRpb24uU1lOVEFYX0VS UikgT0sKKwogMC1sZW5ndGgga2V5IGlzIGNhdWdodCBiZWZvcmUgbG9hZCBzdGF0ZSBpcyBjaGVj a2VkLgogVEVTVCh2aWRlby53ZWJraXRBZGRLZXkoJ3dlYmtpdC1vcmcudzMuY2xlYXJrZXknLCBu ZXcgVWludDhBcnJheSgpKSkgVEhST1dTKERPTUV4Y2VwdGlvbi5UWVBFX01JU01BVENIX0VSUikg T0sKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvZW5jcnlwdGVkLW1lZGlhL2VuY3J5 cHRlZC1tZWRpYS1zeW50YXguaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL2VuY3J5cHRlZC1tZWRp YS9lbmNyeXB0ZWQtbWVkaWEtc3ludGF4Lmh0bWwKaW5kZXggNjJlMWFmYWM2ZTNjMDg2YThjMTYy NzBhMWUxOGM4NzYyMDE3ODRhMS4uMzc2NDgzMzliYzQxZWIyZWNmNDZkODdhYmI1ZGYwMGQ5YTA3 ZTk4NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvZW5jcnlwdGVkLW1lZGlhL2VuY3J5 cHRlZC1tZWRpYS1zeW50YXguaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9lbmNyeXB0ZWQt bWVkaWEvZW5jcnlwdGVkLW1lZGlhLXN5bnRheC5odG1sCkBAIC00Miw2ICs0Miw3IEBACiAKICAg ICAgICAgICAgIGNvbnNvbGVXcml0ZSgiPGJyPlZlcmlmeSBpbnZhbGlkIGtleSBzeXN0ZW0gcGFy YW1ldGVyIGlzIGNhdWdodCBiZWZvcmUgY2hlY2tpbmcgd2hldGhlciBsb2FkaW5nIGhhcyBzdGFy dGVkLiIpOwogICAgICAgICAgICAgLy8gSWYgdGhlIGFib3ZlIHdhcyBub3QgdGhlIGNhc2UsIGFs bCBvZiB0aGVzZSB3b3VsZCBiZSBJTlZBTElEX1NUQVRFX0VSUi4KKyAgICAgICAgICAgIC8vIEFs c28gdGVzdHMgIm51bGwiIGNhc2UgZm9yIGZpcnN0IHBhcmFtZXRlci4KICAgICAgICAgICAgIHRl c3RFeHBlY3RlZCgidmlkZW8ubmV0d29ya1N0YXRlIiwgdmlkZW8uTkVUV09SS19FTVBUWSk7CiAg ICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInZpZGVvLmN1cnJlbnRTcmMiLCAiIik7CiAgICAgICAg ICAgICB0ZXN0RXhjZXB0aW9uKCJ2aWRlby53ZWJraXRHZW5lcmF0ZUtleVJlcXVlc3QoJycpIiwg IkRPTUV4Y2VwdGlvbi5TWU5UQVhfRVJSIik7CkBAIC01NCw2ICs1NSwxMSBAQAogICAgICAgICAg ICAgdGVzdEV4Y2VwdGlvbigidmlkZW8ud2Via2l0Q2FuY2VsS2V5UmVxdWVzdChudWxsKSIsICJE T01FeGNlcHRpb24uU1lOVEFYX0VSUiIpOwogICAgICAgICAgICAgdGVzdEV4Y2VwdGlvbigidmlk ZW8ud2Via2l0Q2FuY2VsS2V5UmVxdWVzdCh1bmRlZmluZWQpIiwgIkRPTUV4Y2VwdGlvbi5TWU5U QVhfRVJSIik7CiAKKyAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiPGJyPm51bGwga2V5IGlzIGNh dWdodCBiZWZvcmUgbG9hZCBzdGF0ZSBpcyBjaGVja2VkLiIpOworICAgICAgICAgICAgdGVzdEV4 Y2VwdGlvbigidmlkZW8ud2Via2l0QWRkS2V5KCd3ZWJraXQtb3JnLnczLmNsZWFya2V5JywgJycp IiwgIkRPTUV4Y2VwdGlvbi5TWU5UQVhfRVJSIik7CisgICAgICAgICAgICB0ZXN0RXhjZXB0aW9u KCJ2aWRlby53ZWJraXRBZGRLZXkoJ3dlYmtpdC1vcmcudzMuY2xlYXJrZXknLCBudWxsKSIsICJE T01FeGNlcHRpb24uU1lOVEFYX0VSUiIpOworICAgICAgICAgICAgdGVzdEV4Y2VwdGlvbigidmlk ZW8ud2Via2l0QWRkS2V5KCd3ZWJraXQtb3JnLnczLmNsZWFya2V5JywgdW5kZWZpbmVkKSIsICJE T01FeGNlcHRpb24uU1lOVEFYX0VSUiIpOworCiAgICAgICAgICAgICBjb25zb2xlV3JpdGUoIjxi cj4wLWxlbmd0aCBrZXkgaXMgY2F1Z2h0IGJlZm9yZSBsb2FkIHN0YXRlIGlzIGNoZWNrZWQuIik7 CiAgICAgICAgICAgICB0ZXN0RXhjZXB0aW9uKCJ2aWRlby53ZWJraXRBZGRLZXkoJ3dlYmtpdC1v cmcudzMuY2xlYXJrZXknLCBuZXcgVWludDhBcnJheSgpKSIsICJET01FeGNlcHRpb24uVFlQRV9N SVNNQVRDSF9FUlIiKTsKIAo=