85438 2012-05-02 17:28:51 -0700 Flash of white when exiting full screen HTML5 video 2012-05-04 16:30:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 jer.noble jer.noble oldest_to_newest 614851 0 jer.noble 2012-05-02 17:28:51 -0700 Flash of white when exiting full screen HTML5 video 614853 1 139923 jer.noble 2012-05-02 17:31:51 -0700 Created attachment 139923 Patch 614854 2 jer.noble 2012-05-02 17:32:02 -0700 <rdar://problem/11364210> 615041 3 139923 mjs 2012-05-02 23:30:05 -0700 Comment on attachment 139923 Patch r=me Is it possible to make a test for this? 615326 4 jer.noble 2012-05-03 09:10:54 -0700 We could make a manual test. But there's no way to write a DRT or WKRT automated test for this. 616607 5 jer.noble 2012-05-04 13:55:42 -0700 After making a test case for this patch, i see that the flash is still occurring. (though less often, & with a shorter flash.) Pulling this patch and investigating further. 616646 6 jer.noble 2012-05-04 14:17:25 -0700 This looks like a problem with the TiledCoreAnimationDrawingAreaProxy. When attempting to sync up drawing between the UIProcess and the WebProcess, this patch calls WebPageProxy::forceRepaint(), which in turn calls m_drawingArea->waitForBackingStoreUpdateOnNextPaint(); The drawing area in question is a TiledCoreAnimationDrawingAreaProxy, and it doesn't implement waitForBackingStoreUpdateOnNextPaint(), it gets effectively ignored. 616665 7 jer.noble 2012-05-04 14:23:12 -0700 Indeed, if I disable tiled drawing and full page acceleration, the flashing problem disappears. 616795 8 140359 jer.noble 2012-05-04 16:24:55 -0700 Created attachment 140359 Patch 616801 9 jer.noble 2012-05-04 16:30:24 -0700 Committed r116188: <http://trac.webkit.org/changeset/116188> 139923 2012-05-02 17:31:51 -0700 2012-05-04 16:24:52 -0700 Patch bug-85438-20120502173150.patch text/plain 3024 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1ODQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWE5MDEzMDBhMzE1ZDNh MDhlNmRmNWQ4M2E1MTJiODAxYzA4ZGUxOC4uZmM0OTZjMThlODgzZWY3NTgzMDcxNzg3NWQ0MjMw ZGZiYmEwNjkxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTA1LTAyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIEZsYXNoIG9mIHdoaXRlIHdo ZW4gZXhpdGluZyBmdWxsIHNjcmVlbiBIVE1MNSB2aWRlbworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU0MzgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3JjZSBhIHJlcGFpbnQgYmVmb3JlIGRpc3BsYXlp bmcgdGhlIG5ld2x5IGV4aXRlZCBXZWJWaWV3IHdpbmRvdy4gIFRoaXMgZ2l2ZXMgdGhlIHdpbmRv dworICAgICAgICBhIGNoYW5jZSB0byBzZWFtbGVzc2x5IHJlcGFpbnQgYmVmb3JlIGVuYWJsaW5n IHNjcmVlbiB1cGRhdGVzLgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5X aW5kb3dDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9s bGVyIGZpbmlzaGVkRXhpdEZ1bGxTY3JlZW5BbmltYXRpb246XSk6CisgICAgICAgICgtW1dLRnVs bFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgY29tcGxldGVGaW5pc2hFeGl0RnVsbFNjcmVlbkFuaW1h dGlvbkFmdGVyUmVwYWludF0pOgorICAgICAgICAoY29tcGxldGVGaW5pc2hFeGl0RnVsbFNjcmVl bkFuaW1hdGlvbkFmdGVyUmVwYWludCk6CisKKzIwMTItMDUtMDIgIEplciBOb2JsZSAgPGplci5u b2JsZUBhcHBsZS5jb20+CisKICAgICAgICAgVGFraW5nIGEgdmlzaWJpbGl0eTpoaWRkZW4gZWxl bWVudCBmdWxsIHNjcmVlbiBjYXVzZXMgZnVsbCBzY3JlZW4gd2luZG93IHRvIGRpc2FwcGVhci4K ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1NDMyCiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2lu ZG93Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2Ny ZWVuV2luZG93Q29udHJvbGxlci5tbQppbmRleCBmODZkYmY4YjRhZTU0YjM4ZmYzM2JkMGFhNmM5 OTBhZTkwOWI1NWE5Li44YWVhMjU4Njc2YzM2ZGQzN2MwOTMyZjUxNGE1NDczMDRlNjAzYWQ1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRv d0NvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxT Y3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCkBAIC0zMzgsNiArMzM4LDggQEAgc3RhdGljIGNvbnN0 IE5TVGltZUludGVydmFsIERlZmF1bHRXYXRjaGRvZ1RpbWVySW50ZXJ2YWwgPSAxOwogICAgIFtz ZWxmIF9zdGFydEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uV2l0aER1cmF0aW9uOmRlZmF1bHRBbmlt YXRpb25EdXJhdGlvbl07CiB9CiAKK3N0YXRpYyB2b2lkIGNvbXBsZXRlRmluaXNoRXhpdEZ1bGxT Y3JlZW5BbmltYXRpb25BZnRlclJlcGFpbnQoV0tFcnJvclJlZiwgdm9pZCopOworCiAtICh2b2lk KWZpbmlzaGVkRXhpdEZ1bGxTY3JlZW5BbmltYXRpb246KGJvb2wpY29tcGxldGVkCiB7CiAgICAg aWYgKCFfaXNFeGl0aW5nRnVsbFNjcmVlbikKQEAgLTM0Niw4ICszNDgsOSBAQCBzdGF0aWMgY29u c3QgTlNUaW1lSW50ZXJ2YWwgRGVmYXVsdFdhdGNoZG9nVGltZXJJbnRlcnZhbCA9IDE7CiAKICAg ICBbc2VsZiBfdXBkYXRlTWVudUFuZERvY2tGb3JGdWxsU2NyZWVuXTsKIAotICAgIC8vIFNjcmVl biB1cGRhdGVzIHRvIGJlIHJlLWVuYWJsZWQgdGEgdGhlIGVuZCBvZiB0aGUgY3VycmVudCBmdW5j dGlvbi4KKyAgICAvLyBTY3JlZW4gdXBkYXRlcyB0byBiZSByZS1lbmFibGVkIGluIGNvbXBsZXRl RmluaXNoRXhpdEZ1bGxTY3JlZW5BbmltYXRpb25BZnRlclJlcGFpbnQuCiAgICAgTlNEaXNhYmxl U2NyZWVuVXBkYXRlcygpOworICAgIFtbX3dlYlZpZXdQbGFjZWhvbGRlci5nZXQoKSB3aW5kb3dd IHNldEF1dG9kaXNwbGF5Ok5PXTsKIAogICAgIFtzZWxmIF9tYW5hZ2VyXS0+ZGlkRXhpdEZ1bGxT Y3JlZW4oKTsKICAgICBbc2VsZiBfbWFuYWdlcl0tPnNldEFuaW1hdGluZ0Z1bGxTY3JlZW4oZmFs c2UpOwpAQCAtMzcyLDkgKzM3NSwyMCBAQCBzdGF0aWMgY29uc3QgTlNUaW1lSW50ZXJ2YWwgRGVm YXVsdFdhdGNoZG9nVGltZXJJbnRlcnZhbCA9IDE7CiAKICAgICBbW193ZWJWaWV3IHdpbmRvd10g bWFrZUtleUFuZE9yZGVyRnJvbnQ6c2VsZl07CiAKKyAgICBbc2VsZiBfcGFnZV0tPmZvcmNlUmVw YWludChWb2lkQ2FsbGJhY2s6OmNyZWF0ZShzZWxmLCBjb21wbGV0ZUZpbmlzaEV4aXRGdWxsU2Ny ZWVuQW5pbWF0aW9uQWZ0ZXJSZXBhaW50KSk7Cit9CisKKy0gKHZvaWQpY29tcGxldGVGaW5pc2hF eGl0RnVsbFNjcmVlbkFuaW1hdGlvbkFmdGVyUmVwYWludAoreworICAgIFtbX3dlYlZpZXcgd2lu ZG93XSBzZXRBdXRvZGlzcGxheTpZRVNdOwogICAgIE5TRW5hYmxlU2NyZWVuVXBkYXRlcygpOwog fQogCitzdGF0aWMgdm9pZCBjb21wbGV0ZUZpbmlzaEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uQWZ0 ZXJSZXBhaW50KFdLRXJyb3JSZWYsIHZvaWQqIF9zZWxmKQoreworICAgIFsoV0tGdWxsU2NyZWVu V2luZG93Q29udHJvbGxlciopX3NlbGYgY29tcGxldGVGaW5pc2hFeGl0RnVsbFNjcmVlbkFuaW1h dGlvbkFmdGVyUmVwYWludF07Cit9CisKIC0gKHZvaWQpY2xvc2UKIHsKICAgICAvLyBXZSBhcmUg YmVpbmcgYXNrZWQgdG8gY2xvc2UgcmFwaWRseSwgbW9zdCBsaWtlbHkgYmVjYXVzZSB0aGUgcGFn ZSAK 140359 2012-05-04 16:24:55 -0700 2012-05-04 16:26:12 -0700 Patch bug-85438-20120504162454.patch text/plain 3521 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWYzOGZmY2Y2MjViY2My MWI0ZmMxOWJhOGQyYTE3MTYyOTk1NGY1Zi4uZjE5Y2YwNTQxOTYwM2U2Y2ExZTZmMzc3YzQxMjVj YTZiYTJhZGZlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA1LTAyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEZsYXNoIG9mIHdoaXRlIHdo ZW4gZXhpdGluZyBmdWxsIHNjcmVlbiBIVE1MNSB2aWRlbworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU0MzgKKworICAgICAgICBSZXZpZXdlZCBieSBN YWNpZWogU3RhY2hvd2lhay4KKworICAgICAgICBGb3JjZSBhIHJlcGFpbnQgYmVmb3JlIGRpc3Bs YXlpbmcgdGhlIG5ld2x5IGV4aXRlZCBXZWJWaWV3IHdpbmRvdy4gIFRoaXMgZ2l2ZXMgdGhlIHdp bmRvdworICAgICAgICBhIGNoYW5jZSB0byBzZWFtbGVzc2x5IHJlcGFpbnQgYmVmb3JlIGVuYWJs aW5nIHNjcmVlbiB1cGRhdGVzLgorCisgICAgICAgIEFsc28sIHNlbmQgdGhlIFdlYlByb2Nlc3Mg dGhlIGRpZEV4aXRGdWxsU2NyZWVuIGFuZCBzZXRBbmltYXRpbmdGdWxsU2NyZWVuKGZhbHNlKSBt ZXNzYWdlcworICAgICAgICBhZnRlciBzd2FwcGluZyB0aGUgV2ViVmlldyBiYWNrIGludG8gaXRz IG9yaWdpbmFsIHdpbmRvdy4gRG9pbmcgb3RoZXJ3aXNlIHNlZW1zIHRvIGNhdXNlCisgICAgICAg IGZvcmNlUmVwYWludCB0byBwYWludCBhIHdoaXRlIGZyYW1lLgorCisgICAgICAgICogVUlQcm9j ZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtXS0Z1 bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIGZpbmlzaGVkRXhpdEZ1bGxTY3JlZW5BbmltYXRpb246 XSk6CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgY29tcGxldGVGaW5p c2hFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbkFmdGVyUmVwYWludF0pOgorICAgICAgICAoY29tcGxl dGVGaW5pc2hFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbkFmdGVyUmVwYWludCk6CisKIDIwMTItMDUt MDQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBTZXQg dGhlIHJpZ2h0IGRldmljZSBzY2FsZSBmYWN0b3Igd2hlbiBjcmVhdGluZyB0aGUgd2ViIHBhZ2UK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2lu ZG93Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2Ny ZWVuV2luZG93Q29udHJvbGxlci5tbQppbmRleCBjMjgyYzlkM2I4MDc1YTMyNWE1Y2UzNjNhZGQ0 YzMyMzY3MjFhYjZmLi45YjNjMTE0MjI0MjMxZWIwN2Q3OTllZGQ1NjBiMjllMGQxNGFhMTA5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRv d0NvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxT Y3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCkBAIC0zMzgsNiArMzM4LDggQEAgc3RhdGljIGNvbnN0 IE5TVGltZUludGVydmFsIERlZmF1bHRXYXRjaGRvZ1RpbWVySW50ZXJ2YWwgPSAxOwogICAgIFtz ZWxmIF9zdGFydEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uV2l0aER1cmF0aW9uOmRlZmF1bHRBbmlt YXRpb25EdXJhdGlvbl07CiB9CiAKK3N0YXRpYyB2b2lkIGNvbXBsZXRlRmluaXNoRXhpdEZ1bGxT Y3JlZW5BbmltYXRpb25BZnRlclJlcGFpbnQoV0tFcnJvclJlZiwgdm9pZCopOworCiAtICh2b2lk KWZpbmlzaGVkRXhpdEZ1bGxTY3JlZW5BbmltYXRpb246KGJvb2wpY29tcGxldGVkCiB7CiAgICAg aWYgKCFfaXNFeGl0aW5nRnVsbFNjcmVlbikKQEAgLTM0NiwxMSArMzQ4LDkgQEAgc3RhdGljIGNv bnN0IE5TVGltZUludGVydmFsIERlZmF1bHRXYXRjaGRvZ1RpbWVySW50ZXJ2YWwgPSAxOwogCiAg ICAgW3NlbGYgX3VwZGF0ZU1lbnVBbmREb2NrRm9yRnVsbFNjcmVlbl07CiAKLSAgICAvLyBTY3Jl ZW4gdXBkYXRlcyB0byBiZSByZS1lbmFibGVkIHRhIHRoZSBlbmQgb2YgdGhlIGN1cnJlbnQgZnVu Y3Rpb24uCisgICAgLy8gU2NyZWVuIHVwZGF0ZXMgdG8gYmUgcmUtZW5hYmxlZCBpbiBjb21wbGV0 ZUZpbmlzaEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uQWZ0ZXJSZXBhaW50LgogICAgIE5TRGlzYWJs ZVNjcmVlblVwZGF0ZXMoKTsKLQotICAgIFtzZWxmIF9tYW5hZ2VyXS0+ZGlkRXhpdEZ1bGxTY3Jl ZW4oKTsKLSAgICBbc2VsZiBfbWFuYWdlcl0tPnNldEFuaW1hdGluZ0Z1bGxTY3JlZW4oZmFsc2Up OworICAgIFtbX3dlYlZpZXdQbGFjZWhvbGRlci5nZXQoKSB3aW5kb3ddIHNldEF1dG9kaXNwbGF5 Ok5PXTsKIAogICAgIE5TUmVzcG9uZGVyICpmaXJzdFJlc3BvbmRlciA9IFtbc2VsZiB3aW5kb3dd IGZpcnN0UmVzcG9uZGVyXTsKICAgICBbc2VsZiBfc3dhcFZpZXc6X3dlYlZpZXdQbGFjZWhvbGRl ci5nZXQoKSB3aXRoOl93ZWJWaWV3XTsKQEAgLTM3Miw5ICszNzIsMjQgQEAgc3RhdGljIGNvbnN0 IE5TVGltZUludGVydmFsIERlZmF1bHRXYXRjaGRvZ1RpbWVySW50ZXJ2YWwgPSAxOwogCiAgICAg W1tfd2ViVmlldyB3aW5kb3ddIG1ha2VLZXlBbmRPcmRlckZyb250OnNlbGZdOwogCisgICAgLy8g VGhlc2UgbWVzc2FnZXMgbXVzdCBiZSBzZW50IGFmdGVyIHRoZSBzd2FwIG9yIGZsYXNoaW5nIHdp bGwgb2NjdXIgZHVyaW5nIGZvcmNlUmVwYWludDoKKyAgICBbc2VsZiBfbWFuYWdlcl0tPmRpZEV4 aXRGdWxsU2NyZWVuKCk7CisgICAgW3NlbGYgX21hbmFnZXJdLT5zZXRBbmltYXRpbmdGdWxsU2Ny ZWVuKGZhbHNlKTsKKworICAgIFtzZWxmIF9wYWdlXS0+Zm9yY2VSZXBhaW50KFZvaWRDYWxsYmFj azo6Y3JlYXRlKHNlbGYsIGNvbXBsZXRlRmluaXNoRXhpdEZ1bGxTY3JlZW5BbmltYXRpb25BZnRl clJlcGFpbnQpKTsKK30KKworLSAodm9pZCljb21wbGV0ZUZpbmlzaEV4aXRGdWxsU2NyZWVuQW5p bWF0aW9uQWZ0ZXJSZXBhaW50Cit7CisgICAgW1tfd2ViVmlldyB3aW5kb3ddIHNldEF1dG9kaXNw bGF5OllFU107CiAgICAgTlNFbmFibGVTY3JlZW5VcGRhdGVzKCk7CiB9CiAKK3N0YXRpYyB2b2lk IGNvbXBsZXRlRmluaXNoRXhpdEZ1bGxTY3JlZW5BbmltYXRpb25BZnRlclJlcGFpbnQoV0tFcnJv clJlZiwgdm9pZCogX3NlbGYpCit7CisgICAgWyhXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVy Kilfc2VsZiBjb21wbGV0ZUZpbmlzaEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uQWZ0ZXJSZXBhaW50 XTsKK30KKwogLSAodm9pZCljbG9zZQogewogICAgIC8vIFdlIGFyZSBiZWluZyBhc2tlZCB0byBj bG9zZSByYXBpZGx5LCBtb3N0IGxpa2VseSBiZWNhdXNlIHRoZSBwYWdlIAo=