85431 2012-05-02 16:37:01 -0700 webkitpy: Special-case win32 calls in file_lock and executive. 2012-05-02 16:47:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco abarth dpranke eric ojan tony webkit.review.bot oldest_to_newest 614795 0 rakuco 2012-05-02 16:37:01 -0700 webkitpy: Special-case win32 calls in file_lock and executive. 614797 1 139910 rakuco 2012-05-02 16:38:09 -0700 Created attachment 139910 Patch 614807 2 139910 dpranke 2012-05-02 16:42:51 -0700 Comment on attachment 139910 Patch have you added a platforminfo.is_win32() yet? 614814 3 rakuco 2012-05-02 16:44:28 -0700 (In reply to comment #2) > (From update of attachment 139910 [details]) > have you added a platforminfo.is_win32() yet? Nope, I'm sort of normalizing accesses to sys.platform first. 614817 4 rakuco 2012-05-02 16:47:39 -0700 Committed r115912: <http://trac.webkit.org/changeset/115912> 139910 2012-05-02 16:38:09 -0700 2012-05-02 16:42:51 -0700 Patch bug-85431-20120502203808.patch text/plain 3670 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1OTAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjMwM2I0ZWE1NTFiMzZmMDdjZjgxOWQyZTUzMmU4Yzcw MWFmYjcwNy4uN2VmOTdlYmNlNWNhMDc1ZDhmYzIwMTlkZDkzZTNhNjA5OTlhZTJmNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIx IEBACiAyMDEyLTA1LTAyICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29Ad2Via2l0Lm9y Zz4KIAorICAgICAgICB3ZWJraXRweTogU3BlY2lhbC1jYXNlIHdpbjMyIGNhbGxzIGluIGZpbGVf bG9jayBhbmQgZXhlY3V0aXZlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODU0MzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTaW1wbGlmeSBhY2Nlc3NlcyB0byBzeXMucGxhdGZvcm0gYnkgb25seSBjaGVj a2luZyBpZiBzeXMucGxhdGZvcm0KKyAgICAgICAgaXMgIndpbjMyIiBhbmQgcmVtb3ZpbmcgZXhw bGljaXQgY2hlY2tzIGZvciB0aGUgZWxzZSBjYXNlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weToKKyAgICAgICAgKEV4ZWN1dGl2ZS5jaGVj a19ydW5uaW5nX3BpZCk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVt L2ZpbGVfbG9jay5weToKKyAgICAgICAgKEZpbGVMb2NrLl9jcmVhdGVfbG9jayk6CisgICAgICAg IChGaWxlTG9jay5fcmVtb3ZlX2xvY2spOgorCisyMDEyLTA1LTAyICBSYXBoYWVsIEt1Ym8gZGEg Q29zdGEgIDxyYWt1Y29Ad2Via2l0Lm9yZz4KKwogICAgICAgICB3ZWJraXRweTogVXNlIGEgU3lz dGVtSG9zdCBpbnN0ZWFkIG9mIFBsYXRmb3JtSW5mbyBpbiB0aGUgUE5HIGNoZWNrZXIuCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTQyNgogCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQppbmRl eCBlNWE5Y2ZiOWM0MjY2MGNlMjg2YTFkY2M4MWJkNGM1N2Y2Y2MzMDBkLi40M2RjYmNhMWIzOGNi MjE4MmNiNzkwNTFmZDFmNWRjZWY2MDc1YTE3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkKQEAgLTI1NCwxNiArMjU0LDE0IEBAIGNs YXNzIEV4ZWN1dGl2ZShvYmplY3QpOgogCiAgICAgZGVmIGNoZWNrX3J1bm5pbmdfcGlkKHNlbGYs IHBpZCk6CiAgICAgICAgICIiIlJldHVybiBUcnVlIGlmIHBpZCBpcyBhbGl2ZSwgb3RoZXJ3aXNl IHJldHVybiBGYWxzZS4iIiIKLSAgICAgICAgaWYgc3lzLnBsYXRmb3JtLnN0YXJ0c3dpdGgoJ2xp bnV4Jykgb3Igc3lzLnBsYXRmb3JtIGluICgnZGFyd2luJywgJ2N5Z3dpbicpOgotICAgICAgICAg ICAgdHJ5OgotICAgICAgICAgICAgICAgIG9zLmtpbGwocGlkLCAwKQotICAgICAgICAgICAgICAg IHJldHVybiBUcnVlCi0gICAgICAgICAgICBleGNlcHQgT1NFcnJvcjoKLSAgICAgICAgICAgICAg ICByZXR1cm4gRmFsc2UKLSAgICAgICAgZWxpZiBzeXMucGxhdGZvcm0gPT0gJ3dpbjMyJzoKKyAg ICAgICAgaWYgc3lzLnBsYXRmb3JtID09ICd3aW4zMic6CiAgICAgICAgICAgICByZXR1cm4gc2Vs Zi5fd2luMzJfY2hlY2tfcnVubmluZ19waWQocGlkKQogCi0gICAgICAgIGFzc2VydChGYWxzZSkK KyAgICAgICAgdHJ5OgorICAgICAgICAgICAgb3Mua2lsbChwaWQsIDApCisgICAgICAgICAgICBy ZXR1cm4gVHJ1ZQorICAgICAgICBleGNlcHQgT1NFcnJvcjoKKyAgICAgICAgICAgIHJldHVybiBG YWxzZQogCiAgICAgZGVmIHJ1bm5pbmdfcGlkcyhzZWxmLCBwcm9jZXNzX25hbWVfZmlsdGVyPU5v bmUpOgogICAgICAgICBpZiBub3QgcHJvY2Vzc19uYW1lX2ZpbHRlcjoKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9maWxlX2xvY2sucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZV9sb2NrLnB5CmluZGV4IGI0YmZmZmM0 MGM3NWNlNTIzNTk3NjZmOGJiYjU2ZWEwNzc4MDMwNGYuLmM1NDI3NzdmMmU3YWU2NzQ4MDU0YzQw YWY0NDVkN2U0NzIxYWExMWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL3N5c3RlbS9maWxlX2xvY2sucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vc3lzdGVtL2ZpbGVfbG9jay5weQpAQCAtNDMsMjAgKzQzLDIwIEBAIGNsYXNzIEZpbGVMb2Nr KG9iamVjdCk6CiAgICAgICAgIHNlbGYuX21heF93YWl0X3RpbWVfc2VjID0gbWF4X3dhaXRfdGlt ZV9zZWMKIAogICAgIGRlZiBfY3JlYXRlX2xvY2soc2VsZik6Ci0gICAgICAgIGlmIHN5cy5wbGF0 Zm9ybS5zdGFydHN3aXRoKCdsaW51eCcpIG9yIHN5cy5wbGF0Zm9ybSBpbiAoJ2RhcndpbicsICdj eWd3aW4nKToKLSAgICAgICAgICAgIGltcG9ydCBmY250bAotICAgICAgICAgICAgZmNudGwuZmxv Y2soc2VsZi5fbG9ja19maWxlX2Rlc2NyaXB0b3IsIGZjbnRsLkxPQ0tfRVggfCBmY250bC5MT0NL X05CKQotICAgICAgICBlbGlmIHN5cy5wbGF0Zm9ybSA9PSAnd2luMzInOgorICAgICAgICBpZiBz eXMucGxhdGZvcm0gPT0gJ3dpbjMyJzoKICAgICAgICAgICAgIGltcG9ydCBtc3ZjcnQKICAgICAg ICAgICAgIG1zdmNydC5sb2NraW5nKHNlbGYuX2xvY2tfZmlsZV9kZXNjcmlwdG9yLCBtc3ZjcnQu TEtfTkJMQ0ssIDMyKQorICAgICAgICBlbHNlOgorICAgICAgICAgICAgaW1wb3J0IGZjbnRsCisg ICAgICAgICAgICBmY250bC5mbG9jayhzZWxmLl9sb2NrX2ZpbGVfZGVzY3JpcHRvciwgZmNudGwu TE9DS19FWCB8IGZjbnRsLkxPQ0tfTkIpCiAKICAgICBkZWYgX3JlbW92ZV9sb2NrKHNlbGYpOgot ICAgICAgICBpZiBzeXMucGxhdGZvcm0uc3RhcnRzd2l0aCgnbGludXgnKSBvciBzeXMucGxhdGZv cm0gaW4gKCdkYXJ3aW4nLCAnY3lnd2luJyk6Ci0gICAgICAgICAgICBpbXBvcnQgZmNudGwKLSAg ICAgICAgICAgIGZjbnRsLmZsb2NrKHNlbGYuX2xvY2tfZmlsZV9kZXNjcmlwdG9yLCBmY250bC5M T0NLX1VOKQotICAgICAgICBlbGlmIHN5cy5wbGF0Zm9ybSA9PSAnd2luMzInOgorICAgICAgICBp ZiBzeXMucGxhdGZvcm0gPT0gJ3dpbjMyJzoKICAgICAgICAgICAgIGltcG9ydCBtc3ZjcnQKICAg ICAgICAgICAgIG1zdmNydC5sb2NraW5nKHNlbGYuX2xvY2tfZmlsZV9kZXNjcmlwdG9yLCBtc3Zj cnQuTEtfVU5MQ0ssIDMyKQorICAgICAgICBlbHNlOgorICAgICAgICAgICAgaW1wb3J0IGZjbnRs CisgICAgICAgICAgICBmY250bC5mbG9jayhzZWxmLl9sb2NrX2ZpbGVfZGVzY3JpcHRvciwgZmNu dGwuTE9DS19VTikKIAogICAgIGRlZiBhY3F1aXJlX2xvY2soc2VsZik6CiAgICAgICAgIHNlbGYu X2xvY2tfZmlsZV9kZXNjcmlwdG9yID0gb3Mub3BlbihzZWxmLl9sb2NrX2ZpbGVfcGF0aCwgb3Mu T19UUlVOQyB8IG9zLk9fQ1JFQVQpCg==