85388 2012-05-02 10:46:40 -0700 Bugs in WebFullScreenController 2012-05-03 15:54:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 83931 84916 0 tobias.netzel webkit-unassigned ap jer.noble webkit.review.bot oldest_to_newest 614423 0 tobias.netzel 2012-05-02 10:46:40 -0700 I run a project to maintain WebKit compatible with OS X 10.5 PowerPC (http://code.google.com/p/leopard-webkit). While fixing the W3C fullscreen API support to work on said target platform I found out that actually there are some bugs in WebFullScreenController that actually happen to not affect more recent versions of Mac OS X. Nevertheless I'm quite sure they are coding errors. The first difference in the attached patch file should only affect 10.5 but I included it because it improves consistency with other parts of WebFullScreenController. The second one also affects 10.5 only but is an error that should be corrected (probably WebFullScreenController has never been tested on 10.5). The last difference is the most important one as in my opinion the original source code is clearly buggy here but nevertheless seems to work on recent versions of OS X. I would be glad if someone could take the patch through the reviewing process into the repository. 614425 1 139839 tobias.netzel 2012-05-02 10:47:32 -0700 Created attachment 139839 Patch against Source/WebKit/mac/WebView/WebFullScreenController.mm 614867 2 ap 2012-05-02 17:46:40 -0700 Would you be willing to work on updating the patch to WebKit contributing requirements <http://www.webkit.org/coding/contributing.html>? Also, it needs to be marked r? to be in review queue (but without a ChangeLog an regression tests, it will be rejected). 615032 3 tobias.netzel 2012-05-02 23:12:14 -0700 Well I would like to do it. But honestly I don't want to find out how much time it takes to run the webkit tests on my own Mac. Apart from that I don't have any Mac that could run OS X 10.6 or 10.7 so I don't think that I could run the tests locally as it won't even build without all the other little patches I did to make it work on 10.5 . So if I could use a buildbot to run the tests I'll work on the patch. Also I don't know if I could provide a testcase since the current code doesn't cause any exceptions. It does cause an exception on 10.5 with the last difference of my patch applied and the first one not applied. And I actually wonder how WebFullScreenController can work as it is - and I can't find out as I don't have access to any machine with 10.6 or 10.7 . I actually think there is some additional work required by someone else who can test and verify this on 10.6 or 10.7 . 615305 4 139839 jer.noble 2012-05-03 08:47:45 -0700 Comment on attachment 139839 Patch against Source/WebKit/mac/WebView/WebFullScreenController.mm View in context: https://bugs.webkit.org/attachment.cgi?id=139839&action=review > tags/Safari-536.9/Source/WebKit/mac/WebView/WebFullScreenController.mm:375 > // If the user has moved the fullScreen window into a new space, temporarily change > // the collectionBehavior of the webView's window so that it is pulled into the active space: > - if (![webWindow isOnActiveSpace]) { > + if (!([webWindow respondsToSelector:@selector(isOnActiveSpace)] ? [webWindow isOnActiveSpace] : YES)) { > NSWindowCollectionBehavior behavior = [webWindow collectionBehavior]; > [webWindow setCollectionBehavior:NSWindowCollectionBehaviorCanJoinAllSpaces]; > [webWindow orderWindow:NSWindowBelow relativeTo:[[self window] windowNumber]]; This looks good. > tags/Safari-536.9/Source/WebKit/mac/WebView/WebFullScreenController.mm:477 > - SetSystemUIMode(_isFullScreen ? kUIModeNormal : kUIModeAllHidden, 0); > + SetSystemUIMode(_isFullScreen ? kUIModeAllHidden : kUIModeNormal, 0); Whoops. Good catch here too. > tags/Safari-536.9/Source/WebKit/mac/WebView/WebFullScreenController.mm:496 > - [[view superview] addSubview:otherView positioned:NSWindowAbove relativeTo:otherView]; > - [otherView removeFromSuperview]; > + [[view superview] addSubview:otherView positioned:NSWindowAbove relativeTo:view]; > + [view removeFromSuperview]; This got fixed in http://trac.webkit.org/changeset/115368 and http://trac.webkit.org/changeset/115324. It would be pretty simple to write up a ChangeLog entry for these two changes. I don't believe you will need a test case, as DumpRenderTree and WebKitTestRunner never hit this code; (they do their own pseudo-full screen). 615359 5 tobias.netzel 2012-05-03 09:53:52 -0700 Too bad I didn't check the trunk for a fix - that would have saved me some hours. I only ever update my sources for every Safari version tag. For the remaining changes I wouldn't have considered filing a bug report here as they are needed for 10.5 compatibility only. And there are already other API calls in WebFullScreenController that don't build as is on 10.5 . But well, lets get it into the trunk anyway. 615423 6 140053 tobias.netzel 2012-05-03 11:11:44 -0700 Created attachment 140053 revised patch, containing ChangeLog entries So, here my first attempt to get a patch reviewed successfully. 615438 7 jer.noble 2012-05-03 11:30:06 -0700 (In reply to comment #6) > Created an attachment (id=140053) [details] > revised patch, containing ChangeLog entries > > So, here my first attempt to get a patch reviewed successfully. FYI, generally you set new patches to r?, indicating you'd like a reviewer to review the patch (which they will then set to r+). 615439 8 140053 jer.noble 2012-05-03 11:31:07 -0700 Comment on attachment 140053 revised patch, containing ChangeLog entries Unofficial r+ from me. Need an actual reviewer to give an official r+. 615463 9 140053 ap 2012-05-03 11:56:50 -0700 Comment on attachment 140053 revised patch, containing ChangeLog entries View in context: https://bugs.webkit.org/attachment.cgi?id=140053&action=review > Source/WebKit2/ChangeLog:10 > + Leopard specific fixes: > + NSWindow doesn't respond to isOnActiveSpace so find out first. > + Values passed to SetSystemUIMode were swapped. I'm confused. Are these only for Leopard? From the above comments, it seemed to me that you found bugs that still apply to newer OS X versions. I don't know if we want to take Leopard fixes at this point. 615503 10 jer.noble 2012-05-03 12:37:35 -0700 (In reply to comment #9) > (From update of attachment 140053 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140053&action=review > > > Source/WebKit2/ChangeLog:10 > > + Leopard specific fixes: > > + NSWindow doesn't respond to isOnActiveSpace so find out first. > > + Values passed to SetSystemUIMode were swapped. > > I'm confused. Are these only for Leopard? From the above comments, it seemed to me that you found bugs that still apply to newer OS X versions. I think he found the bugs fixed by http://trac.webkit.org/changeset/115368 and http://trac.webkit.org/changeset/115324. 615504 11 tobias.netzel 2012-05-03 12:40:34 -0700 Yes, you're right. (In reply to comment #10) 615511 12 tobias.netzel 2012-05-03 12:55:27 -0700 So, I'll mark this as a duplicate or close it. Is that OK for you? 615602 13 tobias.netzel 2012-05-03 14:06:26 -0700 The only relevant parts of this have already been fixed in bugs 83931 and 84916. The remaining parts target OS X 10.5 which isn't supported anymore. 615652 14 140053 ap 2012-05-03 14:46:55 -0700 Comment on attachment 140053 revised patch, containing ChangeLog entries Jer suggests that we get this landed, and it's fine with me. 615668 15 jer.noble 2012-05-03 14:59:11 -0700 At this point Tobias, you should set the commit-queue flag on your patch to "?", and someone with commit privileges (i.e., me) will flip the flag to "+", and the commit bot will land your patch. 615670 16 140053 tobias.netzel 2012-05-03 15:01:09 -0700 Comment on attachment 140053 revised patch, containing ChangeLog entries Now, how will the reviewer's name get into the ChangeLog patches? 615686 17 140053 jer.noble 2012-05-03 15:16:43 -0700 Comment on attachment 140053 revised patch, containing ChangeLog entries The commit bot is smart enough to figure that out. ;) 615710 18 ap 2012-05-03 15:39:01 -0700 Re-opening, so that the commit bot can do its work. 615722 19 140053 webkit.review.bot 2012-05-03 15:47:52 -0700 Comment on attachment 140053 revised patch, containing ChangeLog entries Clearing flags on attachment: 140053 Committed r116031: <http://trac.webkit.org/changeset/116031> 615723 20 webkit.review.bot 2012-05-03 15:47:58 -0700 All reviewed patches have been landed. Closing bug. 615729 21 tobias.netzel 2012-05-03 15:54:05 -0700 Nicely done, thank you! 139839 2012-05-02 10:47:32 -0700 2012-05-03 11:11:44 -0700 Patch against Source/WebKit/mac/WebView/WebFullScreenController.mm WebFullScreenController.patch text/plain 1784 tobias.netzel SW5kZXg6IFdlYkZ1bGxTY3JlZW5Db250cm9sbGVyLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KZGlmZiAtLWdpdCBh L3RhZ3MvU2FmYXJpLTUzNi45L1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnVsbFNjcmVl bkNvbnRyb2xsZXIubW0gYi90YWdzL1NhZmFyaS01MzYuOS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJW aWV3L1dlYkZ1bGxTY3JlZW5Db250cm9sbGVyLm1tCi0tLSBhL3RhZ3MvU2FmYXJpLTUzNi45L1Nv dXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnVsbFNjcmVlbkNvbnRyb2xsZXIubW0JKFJldmlz aW9uIDExNTQ1MikKKysrIGIvdGFncy9TYWZhcmktNTM2LjkvU291cmNlL1dlYktpdC9tYWMvV2Vi Vmlldy9XZWJGdWxsU2NyZWVuQ29udHJvbGxlci5tbQkoQXJiZWl0c2tvcGllKQpAQCAtMzMxLDcg KzM2OSw3IEBACiAjZW5kaWYKICAgICAvLyBJZiB0aGUgdXNlciBoYXMgbW92ZWQgdGhlIGZ1bGxT Y3JlZW4gd2luZG93IGludG8gYSBuZXcgc3BhY2UsIHRlbXBvcmFyaWx5IGNoYW5nZQogICAgIC8v IHRoZSBjb2xsZWN0aW9uQmVoYXZpb3Igb2YgdGhlIHdlYlZpZXcncyB3aW5kb3cgc28gdGhhdCBp dCBpcyBwdWxsZWQgaW50byB0aGUgYWN0aXZlIHNwYWNlOgotICAgIGlmICghW3dlYldpbmRvdyBp c09uQWN0aXZlU3BhY2VdKSB7CisgICAgaWYgKCEoW3dlYldpbmRvdyByZXNwb25kc1RvU2VsZWN0 b3I6QHNlbGVjdG9yKGlzT25BY3RpdmVTcGFjZSldID8gW3dlYldpbmRvdyBpc09uQWN0aXZlU3Bh Y2VdIDogWUVTKSkgewogICAgICAgICBOU1dpbmRvd0NvbGxlY3Rpb25CZWhhdmlvciBiZWhhdmlv ciA9IFt3ZWJXaW5kb3cgY29sbGVjdGlvbkJlaGF2aW9yXTsKICAgICAgICAgW3dlYldpbmRvdyBz ZXRDb2xsZWN0aW9uQmVoYXZpb3I6TlNXaW5kb3dDb2xsZWN0aW9uQmVoYXZpb3JDYW5Kb2luQWxs U3BhY2VzXTsKICAgICAgICAgW3dlYldpbmRvdyBvcmRlcldpbmRvdzpOU1dpbmRvd0JlbG93IHJl bGF0aXZlVG86W1tzZWxmIHdpbmRvd10gd2luZG93TnVtYmVyXV07CkBAIC00MzYsNyArNDc0LDcg QEAKICAgICAgICAgW05TQXBwIHNldFByZXNlbnRhdGlvbk9wdGlvbnM6b3B0aW9uc107CiAgICAg ZWxzZQogI2VuZGlmCi0gICAgICAgIFNldFN5c3RlbVVJTW9kZShfaXNGdWxsU2NyZWVuID8ga1VJ TW9kZU5vcm1hbCA6IGtVSU1vZGVBbGxIaWRkZW4sIDApOworICAgICAgICBTZXRTeXN0ZW1VSU1v ZGUoX2lzRnVsbFNjcmVlbiA/IGtVSU1vZGVBbGxIaWRkZW4gOiBrVUlNb2RlTm9ybWFsLCAwKTsK IH0KIAogI3ByYWdtYSBtYXJrIC0KQEAgLTQ1NCw4ICs0OTIsOCBAQAogICAgIFtvdGhlclZpZXcg c2V0RnJhbWU6W3ZpZXcgZnJhbWVdXTsgICAgICAgIAogICAgIFtvdGhlclZpZXcgc2V0QXV0b3Jl c2l6aW5nTWFzazpbdmlldyBhdXRvcmVzaXppbmdNYXNrXV07CiAgICAgW290aGVyVmlldyByZW1v dmVGcm9tU3VwZXJ2aWV3XTsKLSAgICBbW3ZpZXcgc3VwZXJ2aWV3XSBhZGRTdWJ2aWV3Om90aGVy VmlldyBwb3NpdGlvbmVkOk5TV2luZG93QWJvdmUgcmVsYXRpdmVUbzpvdGhlclZpZXddOwotICAg IFtvdGhlclZpZXcgcmVtb3ZlRnJvbVN1cGVydmlld107CisgICAgW1t2aWV3IHN1cGVydmlld10g YWRkU3VidmlldzpvdGhlclZpZXcgcG9zaXRpb25lZDpOU1dpbmRvd0Fib3ZlIHJlbGF0aXZlVG86 dmlld107CisgICAgW3ZpZXcgcmVtb3ZlRnJvbVN1cGVydmlld107CiAgICAgW0NBVHJhbnNhY3Rp b24gY29tbWl0XTsKIH0KIAo= 140053 2012-05-03 11:11:44 -0700 2012-05-03 15:47:52 -0700 revised patch, containing ChangeLog entries FullScreenController.patch text/plain 4267 tobias.netzel SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTk4OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTAzICBUb2JpYXMg TmV0emVsICA8dG9iaWFzLm5ldHplbEBnb29nbGVtYWlsLmNvbT4KKworICAgICAgICBCdWdzIGlu IFdlYkZ1bGxTY3JlZW5Db250cm9sbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04NTM4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIExlb3BhcmQgc3BlY2lmaWMgZml4ZXM6CisgICAgICAgIE5TV2luZG93 IGRvZXNuJ3QgcmVzcG9uZCB0byBpc09uQWN0aXZlU3BhY2Ugc28gZmluZCBvdXQgZmlyc3QuCisg ICAgICAgIFZhbHVlcyBwYXNzZWQgdG8gU2V0U3lzdGVtVUlNb2RlIHdlcmUgc3dhcHBlZC4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbToK KyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBiZWdhbkV4aXRGdWxsU2Ny ZWVuV2l0aEluaXRpYWxGcmFtZTpXZWJDb3JlOjpmaW5hbEZyYW1lOldlYkNvcmU6Ol0pOgorICAg ICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIF91cGRhdGVNZW51QW5kRG9ja0Zv ckZ1bGxTY3JlZW5dKToKKwogMjAxMi0wNC0yNSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5j b20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0 OTA5CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRv d0NvbnRyb2xsZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21h Yy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCShyZXZpc2lvbiAxMTU5ODcpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIu bW0JKHdvcmtpbmcgY29weSkKQEAgLTMyMyw3ICszNjEsNyBAQCAtICh2b2lkKWJlZ2FuRXhpdEZ1 bGxTY3JlZW5XaXRoSW5pdGlhbEZyCiAjZW5kaWYKICAgICAvLyBJZiB0aGUgdXNlciBoYXMgbW92 ZWQgdGhlIGZ1bGxTY3JlZW4gd2luZG93IGludG8gYSBuZXcgc3BhY2UsIHRlbXBvcmFyaWx5IGNo YW5nZQogICAgIC8vIHRoZSBjb2xsZWN0aW9uQmVoYXZpb3Igb2YgdGhlIHdlYlZpZXcncyB3aW5k b3cgc28gdGhhdCBpdCBpcyBwdWxsZWQgaW50byB0aGUgYWN0aXZlIHNwYWNlOgotICAgIGlmICgh W3dlYldpbmRvdyBpc09uQWN0aXZlU3BhY2VdKSB7CisgICAgaWYgKCEoW3dlYldpbmRvdyByZXNw b25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKGlzT25BY3RpdmVTcGFjZSldID8gW3dlYldpbmRvdyBp c09uQWN0aXZlU3BhY2VdIDogWUVTKSkgewogICAgICAgICBOU1dpbmRvd0NvbGxlY3Rpb25CZWhh dmlvciBiZWhhdmlvciA9IFt3ZWJXaW5kb3cgY29sbGVjdGlvbkJlaGF2aW9yXTsKICAgICAgICAg W3dlYldpbmRvdyBzZXRDb2xsZWN0aW9uQmVoYXZpb3I6TlNXaW5kb3dDb2xsZWN0aW9uQmVoYXZp b3JDYW5Kb2luQWxsU3BhY2VzXTsKICAgICAgICAgW3dlYldpbmRvdyBvcmRlcldpbmRvdzpOU1dp bmRvd0JlbG93IHJlbGF0aXZlVG86W1tzZWxmIHdpbmRvd10gd2luZG93TnVtYmVyXV07CkBAIC00 MjgsNyArNDY2LDcgQEAgLSAodm9pZClfdXBkYXRlTWVudUFuZERvY2tGb3JGdWxsU2NyZWVuCiAg ICAgICAgIFtOU0FwcCBzZXRQcmVzZW50YXRpb25PcHRpb25zOm9wdGlvbnNdOwogICAgIGVsc2UK ICNlbmRpZgotICAgICAgICBTZXRTeXN0ZW1VSU1vZGUoX2lzRnVsbFNjcmVlbiA/IGtVSU1vZGVO b3JtYWwgOiBrVUlNb2RlQWxsSGlkZGVuLCAwKTsKKyAgICAgICAgU2V0U3lzdGVtVUlNb2RlKF9p c0Z1bGxTY3JlZW4gPyBrVUlNb2RlQWxsSGlkZGVuIDoga1VJTW9kZU5vcm1hbCwgMCk7CiB9CiAK IC0gKFdlYlBhZ2VQcm94eSopX3BhZ2UKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEx NTk4OCkKKysrIFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE4IEBACisyMDEyLTA1LTAzICBUb2JpYXMgTmV0emVsICA8dG9iaWFzLm5ldHplbEBn b29nbGVtYWlsLmNvbT4KKworICAgICAgICBCdWdzIGluIFdlYkZ1bGxTY3JlZW5Db250cm9sbGVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTM4OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExlb3BhcmQg c3BlY2lmaWMgZml4ZXM6CisgICAgICAgIE5TV2luZG93IGRvZXNuJ3QgcmVzcG9uZCB0byBpc09u QWN0aXZlU3BhY2Ugc28gZmluZCBvdXQgZmlyc3QuCisgICAgICAgIFZhbHVlcyBwYXNzZWQgdG8g U2V0U3lzdGVtVUlNb2RlIHdlcmUgc3dhcHBlZC4KKworICAgICAgICAqIFdlYlZpZXcvV2ViRnVs bFNjcmVlbkNvbnRyb2xsZXIubW06CisgICAgICAgICgtW1dlYkZ1bGxTY3JlZW5Db250cm9sbGVy IGV4aXRGdWxsU2NyZWVuXSk6CisgICAgICAgICgtW1dlYkZ1bGxTY3JlZW5Db250cm9sbGVyIF91 cGRhdGVNZW51QW5kRG9ja0ZvckZ1bGxTY3JlZW5dKToKKwogMjAxMi0wNC0yNSAgQmV0aCBEYWtp biAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg0OTEzCkluZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dl YkZ1bGxTY3JlZW5Db250cm9sbGVyLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViRnVsbFNjcmVlbkNvbnRyb2xsZXIubW0JKHJldmlzaW9uIDExNTk4NykKKysr IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnVsbFNjcmVlbkNvbnRyb2xsZXIubW0JKHdv cmtpbmcgY29weSkKQEAgLTMzMSw3ICszNjksNyBAQCAtICh2b2lkKWV4aXRGdWxsU2NyZWVuCiAj ZW5kaWYKICAgICAvLyBJZiB0aGUgdXNlciBoYXMgbW92ZWQgdGhlIGZ1bGxTY3JlZW4gd2luZG93 IGludG8gYSBuZXcgc3BhY2UsIHRlbXBvcmFyaWx5IGNoYW5nZQogICAgIC8vIHRoZSBjb2xsZWN0 aW9uQmVoYXZpb3Igb2YgdGhlIHdlYlZpZXcncyB3aW5kb3cgc28gdGhhdCBpdCBpcyBwdWxsZWQg aW50byB0aGUgYWN0aXZlIHNwYWNlOgotICAgIGlmICghW3dlYldpbmRvdyBpc09uQWN0aXZlU3Bh Y2VdKSB7CisgICAgaWYgKCEoW3dlYldpbmRvdyByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9y KGlzT25BY3RpdmVTcGFjZSldID8gW3dlYldpbmRvdyBpc09uQWN0aXZlU3BhY2VdIDogWUVTKSkg ewogICAgICAgICBOU1dpbmRvd0NvbGxlY3Rpb25CZWhhdmlvciBiZWhhdmlvciA9IFt3ZWJXaW5k b3cgY29sbGVjdGlvbkJlaGF2aW9yXTsKICAgICAgICAgW3dlYldpbmRvdyBzZXRDb2xsZWN0aW9u QmVoYXZpb3I6TlNXaW5kb3dDb2xsZWN0aW9uQmVoYXZpb3JDYW5Kb2luQWxsU3BhY2VzXTsKICAg ICAgICAgW3dlYldpbmRvdyBvcmRlcldpbmRvdzpOU1dpbmRvd0JlbG93IHJlbGF0aXZlVG86W1tz ZWxmIHdpbmRvd10gd2luZG93TnVtYmVyXV07CkBAIC00MzYsNyArNDc0LDcgQEAgLSAodm9pZClf dXBkYXRlTWVudUFuZERvY2tGb3JGdWxsU2NyZWVuCiAgICAgICAgIFtOU0FwcCBzZXRQcmVzZW50 YXRpb25PcHRpb25zOm9wdGlvbnNdOwogICAgIGVsc2UKICNlbmRpZgotICAgICAgICBTZXRTeXN0 ZW1VSU1vZGUoX2lzRnVsbFNjcmVlbiA/IGtVSU1vZGVOb3JtYWwgOiBrVUlNb2RlQWxsSGlkZGVu LCAwKTsKKyAgICAgICAgU2V0U3lzdGVtVUlNb2RlKF9pc0Z1bGxTY3JlZW4gPyBrVUlNb2RlQWxs SGlkZGVuIDoga1VJTW9kZU5vcm1hbCwgMCk7CiB9CiAKICNwcmFnbWEgbWFyayAtCg==