85379 2012-05-02 09:03:02 -0700 Possible GCC x86 build error 2012-05-02 12:46:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P3 Normal --- 1 yong.li.webkit webkit-unassigned webkit.review.bot oldest_to_newest 614337 0 yong.li.webkit 2012-05-02 09:03:02 -0700 The linker cannot find getHostCallReturnValue. It could still build if the linker is configured to ignore unreferenced symbols. But it is still good to fix this. 614341 1 139827 yong.li.webkit 2012-05-02 09:06:58 -0700 Created attachment 139827 the patch 614350 2 yong.li.webkit 2012-05-02 09:19:27 -0700 sorry. I thought I had seen ".text" was used in DFG JIT lock... This link error must be due to other cause. 614481 3 yong.li.webkit 2012-05-02 11:39:04 -0700 reopening. 614483 4 139849 yong.li.webkit 2012-05-02 11:40:16 -0700 Created attachment 139849 the patch Always explicitly define the symbols in .text section. 614505 5 139853 yong.li.webkit 2012-05-02 12:04:30 -0700 Created attachment 139853 second try 614511 6 139853 rwlbuis 2012-05-02 12:10:59 -0700 Comment on attachment 139853 second try LGTM. 614547 7 139853 webkit.review.bot 2012-05-02 12:46:32 -0700 Comment on attachment 139853 second try Clearing flags on attachment: 139853 Committed r115867: <http://trac.webkit.org/changeset/115867> 614548 8 webkit.review.bot 2012-05-02 12:46:52 -0700 All reviewed patches have been landed. Closing bug. 139827 2012-05-02 09:06:58 -0700 2012-05-02 09:18:06 -0700 the patch 85379.patch text/plain 1343 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBjYjkwZDguLmZmMjdiNzYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTAyICBZb25nIExpICA8eW9s aUByaW0uY29tPgorCisgICAgICAgIEZpeCBYODYgYnVpbGQgZXJyb3Igd2hlbiBERkcgSklUIGlz IG5vdCBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04NTM3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZCAiLnRleHQiIGJlZm9yZSBkZWZpbmluZyBnZXRIb3N0Q2FsbFJldHVyblZhbHVlKCkK KyAgICAgICAgd2l0aCBpbmxpbmUgYXNzZW1ibHkuCisKKyAgICAgICAgKiBkZmcvREZHT3BlcmF0 aW9ucy5jcHA6CisgICAgICAgIChKU0MpOgorCiAyMDEyLTA0LTEzICBSb2IgQnVpcyAgPHJidWlz QHJpbS5jb20+CiAKICAgICAgICAgRml4IHNvbWUgY29tcGlsZXIgd2FybmluZ3MgKG1pc2NlbGxh bmVvdXMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlv bnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcAppbmRl eCA2OTc2YjQ1Li5iZjQwY2Q4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR09wZXJhdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3Bl cmF0aW9ucy5jcHAKQEAgLTExMDAsNiArMTEwMCw3IEBAIG5hbWVzcGFjZSBKU0MgewogCiAjaWYg Q1BVKFg4Nl82NCkKIGFzbSAoCisiLnRleHQiICJcbiIKICIuZ2xvYmwgIiBTWU1CT0xfU1RSSU5H KGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpICJcbiIKIEhJREVfU1lNQk9MKGdldEhvc3RDYWxsUmV0 dXJuVmFsdWUpICJcbiIKIFNZTUJPTF9TVFJJTkcoZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZSkgIjoi ICJcbiIKQEAgLTExMDksNiArMTExMCw3IEBAIFNZTUJPTF9TVFJJTkcoZ2V0SG9zdENhbGxSZXR1 cm5WYWx1ZSkgIjoiICJcbiIKICk7CiAjZWxpZiBDUFUoWDg2KQogYXNtICgKKyIudGV4dCIgIlxu IgogIi5nbG9ibCAiIFNZTUJPTF9TVFJJTkcoZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZSkgIlxuIgog SElERV9TWU1CT0woZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZSkgIlxuIgogU1lNQk9MX1NUUklORyhn ZXRIb3N0Q2FsbFJldHVyblZhbHVlKSAiOiIgIlxuIgo= 139849 2012-05-02 11:40:16 -0700 2012-05-02 12:04:30 -0700 the patch 85379.patch text/plain 1402 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBjYjkwZDguLjI3OTM5OTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTAyICBZb25nIExpICA8eW9s aUByaW0uY29tPgorCisgICAgICAgIEZpeCBwb3NzaWJsZSBHQ0MgWDg2IGJ1aWxkIGVycm9yCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTM3OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsd2F5cyBleHBs aWNpdGx5IGNsYWltICIudGV4dCIgdG8gbWFrZSBzdXJlCisgICAgICAgIGZ1bmN0aW9ucyBkZWZp bmVkIHdpdGggaW5saW5lIGFzc2VtYmx5IHdpbGwgYmUKKyAgICAgICAgY3JlYXRlZCBpbiB0aGUg Y29ycmVjdCBzZWN0aW9uLgorCisgICAgICAgICogZGZnL0RGR09wZXJhdGlvbnMuY3BwOgorICAg ICAgICAoSlNDKToKKwogMjAxMi0wNC0xMyAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0uY29tPgogCiAg ICAgICAgIEZpeCBzb21lIGNvbXBpbGVyIHdhcm5pbmdzIChtaXNjZWxsYW5lb3VzKQpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAKaW5kZXggNjk3NmI0NS4uMTBj OGVlYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25z LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCkBA IC02MCw2ICs2MCw3IEBACiAKICNkZWZpbmUgRlVOQ1RJT05fV1JBUFBFUl9XSVRIX1JFVFVSTl9B RERSRVNTKGZ1bmN0aW9uLCBvZmZzZXQpIFwKICAgICBhc20oIFwKKyAgICAiLnRleHQiICJcbiIg XAogICAgICIuZ2xvYmwgIiBTWU1CT0xfU1RSSU5HKGZ1bmN0aW9uKSAiXG4iIFwKICAgICBISURF X1NZTUJPTChmdW5jdGlvbikgIlxuIiBcCiAgICAgU1lNQk9MX1NUUklORyhmdW5jdGlvbikgIjoi ICJcbiIgXApAQCAtMTEwOSw2ICsxMTEwLDcgQEAgU1lNQk9MX1NUUklORyhnZXRIb3N0Q2FsbFJl dHVyblZhbHVlKSAiOiIgIlxuIgogKTsKICNlbGlmIENQVShYODYpCiBhc20gKAorIi50ZXh0IiAi XG4iCiAiLmdsb2JsICIgU1lNQk9MX1NUUklORyhnZXRIb3N0Q2FsbFJldHVyblZhbHVlKSAiXG4i CiBISURFX1NZTUJPTChnZXRIb3N0Q2FsbFJldHVyblZhbHVlKSAiXG4iCiBTWU1CT0xfU1RSSU5H KGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpICI6IiAiXG4iCg== 139853 2012-05-02 12:04:30 -0700 2012-05-02 12:46:32 -0700 second try 85379.patch text/plain 1430 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGMxMWIyMDEuLjI1NGUzMGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTAyICBZb25nIExpICA8eW9s aUByaW0uY29tPgorCisgICAgICAgIEZpeCBHQ0MgWDg2IGJ1aWxkIGVycm9yCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTM3OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsd2F5cyBleHBsaWNpdGx5IGNs YWltICIudGV4dCIgdG8gbWFrZSBzdXJlCisgICAgICAgIGZ1bmN0aW9ucyBkZWZpbmVkIHdpdGgg aW5saW5lIGFzc2VtYmx5IHdpbGwgYmUKKyAgICAgICAgY3JlYXRlZCBpbiB0aGUgY29ycmVjdCBz ZWN0aW9uLgorCisgICAgICAgICogZGZnL0RGR09wZXJhdGlvbnMuY3BwOgorICAgICAgICAoSlND KToKKwogMjAxMi0wNC0zMCAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5j b20+CiAKICAgICAgICAgU2hvdWxkIGJlIGFibGUgdG8gdXNlIFlBUlIgSklUIHdpdGhvdXQgdGhl IEpTIGxhbmd1YWdlIEpJVApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdPcGVyYXRpb25zLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9u cy5jcHAKaW5kZXggYTZkYjAxYmRkLi42ZGQ0NjY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAKQEAgLTU5LDYgKzU5LDcgQEAKIAogI2RlZmluZSBGVU5D VElPTl9XUkFQUEVSX1dJVEhfUkVUVVJOX0FERFJFU1MoZnVuY3Rpb24sIG9mZnNldCkgXAogICAg IGFzbSggXAorICAgICIudGV4dCIgIlxuIiBcCiAgICAgIi5nbG9ibCAiIFNZTUJPTF9TVFJJTkco ZnVuY3Rpb24pICJcbiIgXAogICAgIEhJREVfU1lNQk9MKGZ1bmN0aW9uKSAiXG4iIFwKICAgICBT WU1CT0xfU1RSSU5HKGZ1bmN0aW9uKSAiOiIgIlxuIiBcCkBAIC0xMTU2LDYgKzExNTcsNyBAQCBT WU1CT0xfU1RSSU5HKGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpICI6IiAiXG4iCiApOwogI2VsaWYg Q1BVKFg4NikKIGFzbSAoCisiLnRleHQiICJcbiIgXAogIi5nbG9ibCAiIFNZTUJPTF9TVFJJTkco Z2V0SG9zdENhbGxSZXR1cm5WYWx1ZSkgIlxuIgogSElERV9TWU1CT0woZ2V0SG9zdENhbGxSZXR1 cm5WYWx1ZSkgIlxuIgogU1lNQk9MX1NUUklORyhnZXRIb3N0Q2FsbFJldHVyblZhbHVlKSAiOiIg IlxuIgo=