85367 2012-05-02 05:14:16 -0700 [webkit-patch] Return meaningful results from single-result queries. 2012-05-08 06:39:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gavinp gavinp abarth dpranke ojan webkit.review.bot oldest_to_newest 614201 0 gavinp 2012-05-02 05:14:16 -0700 [webkit-patch] Return meaningful results from single-result queries. 614203 1 139792 gavinp 2012-05-02 05:15:56 -0700 Created attachment 139792 Patch 614210 2 gavinp 2012-05-02 05:42:55 -0700 While hacking at bug 85368, I found this bug in bugzilla.py. The fix is a bit hacky, but strictly superior to the old behaviour. dpranke, WDYT? 614669 3 139792 dpranke 2012-05-02 14:30:32 -0700 Comment on attachment 139792 Patch Can you write a test for this? 617617 4 gavinp 2012-05-07 08:38:58 -0700 This change is tricky to write a test for; right now our bugzilla tests are one layer higher: we presume the fetch routines work, and just test the parsers. This isn't to say we shouldn't test our fetching routines (notice this is a bug fix for them!), but that we don't have a way to do that right now. I'm investigating. 618464 5 139792 webkit.review.bot 2012-05-08 06:39:06 -0700 Comment on attachment 139792 Patch Clearing flags on attachment: 139792 Committed r116415: <http://trac.webkit.org/changeset/116415> 618465 6 webkit.review.bot 2012-05-08 06:39:10 -0700 All reviewed patches have been landed. Closing bug. 139792 2012-05-02 05:15:56 -0700 2012-05-08 06:39:05 -0700 Patch bug-85367-20120502081555.patch text/plain 1864 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NjIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzVmZGFkNzdiYjViZmQ0ZTJkNjBjNDZjZTY0MjgxZjM5 ZWYzOTE3Ni4uYzk4Yzk4OGQ1NzYzODIzZDdlYzNmMTdjZWI3MzA4MTJmYmNmZjQ2ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA1LTAyICBHYXZpbiBQZXRlcnMgIDxnYXZpbnBAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFt3ZWJraXQtcGF0Y2hdIFJldHVybiBtZWFuaW5nZnVsIHJlc3VsdHMgZnJvbSBzaW5n bGUtcmVzdWx0IHF1ZXJpZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04NTM2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFNvbWV0aW1lcyBhIHF1aWNrc2VhcmNoIHJldHVybnMgYSBzaW5nbGUgcmVzdWx0 IGJ5IGp1c3QgcmVkaXJlY3RpbmcgdG8gdGhlIHBhZ2UgZm9yIHRoYXQgc2luZ2xlCisgICAgICAg IGJ1Zy4gVGhpcyBwYXRjaCBoYWNrcyBhcm91bmQgdGhhdCBieSBub3RpY2luZyB0aGUgcmVkaXJl Y3QgdGFyZ2V0IGlzIGEgc2luZ2xlIHBhZ2UsIGFuZCBjb25zdHJ1Y3RpbmcKKyAgICAgICAgYSBy ZXN1bHQgbGlzdCBjb25zaXN0aW5nIG9mIHRoYXQgb25lIGJ1Zy4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYS5weToKKyAgICAgICAgKEJ1 Z3ppbGxhUXVlcmllcy5fZmV0Y2hfYnVnc19mcm9tX2FkdmFuY2VkX3F1ZXJ5KToKKwogMjAxMi0w NC0zMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZC4gRml4IG1ha2UgZGlzdGNoZWNrLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5CmluZGV4IDNkMmE5 NjkyMmU2MTdmYmI5NTNlZDNiN2QyZTM1YThkODI2MDIyOTYuLjkxZjFkYTY0MjY1MTcxYTUxNjQ5 N2MwNTUxZjAzMDgxNjhlN2ExN2QgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHkKQEAgLTE1Miw2ICsxNTIsMTEgQEAg Y2xhc3MgQnVnemlsbGFRdWVyaWVzKG9iamVjdCk6CiAKICAgICBkZWYgX2ZldGNoX2J1Z3NfZnJv bV9hZHZhbmNlZF9xdWVyeShzZWxmLCBxdWVyeSk6CiAgICAgICAgIHJlc3VsdHNfcGFnZSA9IHNl bGYuX2xvYWRfcXVlcnkocXVlcnkpCisgICAgICAgICMgU29tZSBzaW1wbGUgc2VhcmNoZXMgY2Fu IHJldHVybiBhIHNpbmdsZSByZXN1bHQuCisgICAgICAgIHJlc3VsdHNfdXJsID0gcmVzdWx0c19w YWdlLmdldHVybCgpCisgICAgICAgIGlmIHJlc3VsdHNfdXJsLmZpbmQoIi9zaG93X2J1Zy5jZ2k/ aWQ9IikgIT0gLTE6CisgICAgICAgICAgICBidWdfaWQgPSBpbnQocmVzdWx0c191cmwuc3BsaXQo Ij0iKVstMV0pCisgICAgICAgICAgICByZXR1cm4gW3NlbGYuX2ZldGNoX2J1ZyhidWdfaWQpXQog ICAgICAgICBpZiBub3Qgc2VsZi5fcGFyc2VfcmVzdWx0X2NvdW50KHJlc3VsdHNfcGFnZSk6CiAg ICAgICAgICAgICByZXR1cm4gW10KICAgICAgICAgIyBCdWd6aWxsYSByZXN1bHRzIHBhZ2VzIGhh dmUgYW4gIlhNTCIgc3VibWl0IGJ1dHRvbiBhdCB0aGUgYm90dG9tCg==