85362 2012-05-02 03:46:49 -0700 Disallow unquoted -webkit-font-feature-settings tags 2012-05-06 20:12:33 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bashi bashi jdaggett macpherson menard mitz tkent webkit.review.bot oldest_to_newest 614158 0 bashi 2012-05-02 03:46:49 -0700 John Daggett’s proposal to restrict syntax of font-feature-settings to well-formed OpenType tags accepted (http://www.w3.org/blog/CSS/2012/04/26/resolutions-32/) and the draft spec was updated(http://dev.w3.org/csswg/css3-fonts/#font-feature-settings-prop). We should disallow unquoted tags. 614160 1 139784 bashi 2012-05-02 03:52:42 -0700 Created attachment 139784 Patch 617275 2 139784 tkent 2012-05-06 19:02:44 -0700 Comment on attachment 139784 Patch Looks good. 617299 3 139784 bashi 2012-05-06 19:35:25 -0700 Comment on attachment 139784 Patch Thanks! 617323 4 139784 webkit.review.bot 2012-05-06 20:12:29 -0700 Comment on attachment 139784 Patch Clearing flags on attachment: 139784 Committed r116263: <http://trac.webkit.org/changeset/116263> 617324 5 webkit.review.bot 2012-05-06 20:12:33 -0700 All reviewed patches have been landed. Closing bug. 139784 2012-05-02 03:52:42 -0700 2012-05-06 20:12:29 -0700 Patch bug-85362-20120502195241.patch text/plain 6500 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1ODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmJlNTExNmRkYTBlYzI3 OWQ4MjgwNzY4N2EwNTc2YWIwODc1ZTlmMi4uNDFkMzQwYTk2MDFlOGMxNzhhYmZkMWVjNTMyNDg5 MmJkZGRkNmI2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTAyICBLZW5p Y2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KKworICAgICAgICBEaXNhbGxvdyB1 bnF1b3RlZCAtd2Via2l0LWZvbnQtZmVhdHVyZS1zZXR0aW5ncyB0YWdzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTM2MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FsbG93IHVucXVvdGVkIHRhZ3Mg dG8gZm9sbG93IHRoZSBjdXJyZW50IGRyYWZ0LgorICAgICAgICBodHRwOi8vZGV2LnczLm9yZy9j c3N3Zy9jc3MzLWZvbnRzLyNmb250LWZlYXR1cmUtc2V0dGluZ3MtcHJvcAorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gY3NzMy9mb250LWZlYXR1cmUtc2V0dGluZ3MtcGFyc2luZy5odG1sIHdhcyB1 cGRhdGVkLgorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDU1NQYXJzZXI6OnBhcnNlRm9udEZlYXR1cmVUYWcpOiBBY2NlcHRzIG9ubHkgNC1jaGFyYWN0 ZXJzIHN0cmluZy4KKwogMjAxMi0wNS0wMiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5j b20+CiAKICAgICAgICAgU3R5bGVTaGVldEludGVybmFsOjpwYXJzZVVzZXJTdHlsZVNoZWV0KCkg c2hvdWxkIGJlIGNhbGxlZCBwYXJzZUF1dGhvclN0eWxlU2hlZXQoKS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1Bh cnNlci5jcHAKaW5kZXggMDVhMzYxYWNhNDI0ZjUzZmE4YmRiNmIwZGIxMjZmZjVkMDkxMDBjMi4u Njk1NDg5MWMzYWM0YTQ3MGZiNWI5MGFlZTM5MzkwNmM0M2YyODhlMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NT U1BhcnNlci5jcHAKQEAgLTc1MjAsNyArNzUyMCw3IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZUZv bnRGZWF0dXJlVGFnKENTU1ZhbHVlTGlzdCogc2V0dGluZ3MpCiAKICAgICBDU1NQYXJzZXJWYWx1 ZSogdmFsdWUgPSBtX3ZhbHVlTGlzdC0+Y3VycmVudCgpOwogICAgIC8vIEZlYXR1cmUgdGFnIG5h bWUgY29tZXMgZmlyc3QKLSAgICBpZiAodmFsdWUtPnVuaXQgIT0gQ1NTUHJpbWl0aXZlVmFsdWU6 OkNTU19TVFJJTkcgJiYgdmFsdWUtPnVuaXQgIT0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19JREVO VCkKKyAgICBpZiAodmFsdWUtPnVuaXQgIT0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19TVFJJTkcp CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAodmFsdWUtPnN0cmluZy5sZW5ndGggIT0g dGFnTmFtZUxlbmd0aCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGJlNjAyYmYyN2Nm MDg1YzVmN2JlMmFiMzQ3ZDFiZjVjODdmMzBkZjIuLjYwOGFjOGQyOWE1MDFhM2E2NTNjYWMwZDU5 YTk4YjhkNDg4MWJkNjMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNS0wMiAgS2VuaWNo aSBJc2hpYmFzaGkgIDxiYXNoaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGlzYWxsb3cgdW5x dW90ZWQgLXdlYmtpdC1mb250LWZlYXR1cmUtc2V0dGluZ3MgdGFncworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODUzNjIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNzczMvZm9udC1mZWF0dXJlLXNldHRp bmdzLXBhcnNpbmctZXhwZWN0ZWQudHh0OiBVcGRhdGVkIHRvIGZvbGxvdyB0aGUgY3VycmVudCBk cmFmdCBzcGVjaWZpY2F0aW9uLgorICAgICAgICAqIGNzczMvZm9udC1mZWF0dXJlLXNldHRpbmdz LXBhcnNpbmcuaHRtbDogRGl0dG8uCisKIDIwMTItMDUtMDIgIFRoaWFnbyBNYXJjb3MgUC4gU2Fu dG9zICA8dGhpYWdvLnNhbnRvc0BpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gQ1NTIHRlc3Rz IG5lZWRzIHJlYmFzZWxpbmluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9mb250LWZl YXR1cmUtc2V0dGluZ3MtcGFyc2luZy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9jc3MzL2Zv bnQtZmVhdHVyZS1zZXR0aW5ncy1wYXJzaW5nLWV4cGVjdGVkLnR4dAppbmRleCBjMGM0YzA3ZDA4 N2IxYjQ0N2EzNjU0NWJkNzMyZjJlODVmMmJiZDBkLi4zYmI2NTg3MzA4ZjMzMjYwNzcwMWUzZDJi YTQ5YWJlYWViNzc0OTE2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9jc3MzL2ZvbnQtZmVhdHVy ZS1zZXR0aW5ncy1wYXJzaW5nLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2Zv bnQtZmVhdHVyZS1zZXR0aW5ncy1wYXJzaW5nLWV4cGVjdGVkLnR4dApAQCAtMTIsMTIgKzEyLDEy IEBAIFBBU1MgcGFyc2VSZXN1bHRPZigidmFsaWRfdmFsdWVfb2ZmIikgaXMgIidsaWdhJyAwIgog UEFTUyBwYXJzZVJlc3VsdE9mKCJ2YWxpZF92YWx1ZV9vbWl0IikgaXMgIidjMnNjJyAxIgogUEFT UyBwYXJzZVJlc3VsdE9mKCJ2YWxpZF92YWx1ZWxpc3QiKSBpcyAiJ3RudW0nIDEsICdoaXN0JyAx IgogUEFTUyBwYXJzZVJlc3VsdE9mKCJ2YWxpZF9zaW5nbGVxdW90ZSIpIGlzICInUEtSTicgMSIK LVBBU1MgcGFyc2VSZXN1bHRPZigidmFsaWRfaWRlbnQiKSBpcyAiJ2RsaWcnIDEiCiBQQVNTIHBh cnNlUmVzdWx0T2YoInZhbGlkX3VudXN1YWxfdGFnIikgaXMgIichQCMkJyAxIgogUEFTUyBwYXJz ZVJlc3VsdE9mKCJ2YWxpZF90YWdfc3BhY2UiKSBpcyAiJ2EgYmMnIDEiCi1QQVNTIHBhcnNlUmVz dWx0T2YoInZhbGlkX2Nhc2VzIikgaXMgIidkbGlnJyAxLCAnRExJRycgMSwgJ0RMaWcnIDEiCi1Q QVNTIHBhcnNlUmVzdWx0T2YoInZhbGlkX2NvbXBvc2l0ZSIpIGlzICInZGxpZycgMSwgJ3NtY3An IDEsICdsaWdhJyAwIgorUEFTUyBwYXJzZVJlc3VsdE9mKCJ2YWxpZF9jb21wb3NpdGUiKSBpcyAi J2RsaWcnIDEsICdzbWNwJyAxLCAnbGlnICcgMCIKIC0gVGVzdHMgaW52YWxpZCBpbnB1dHMuICBS ZXN1bHRzIHNob3VsZCBiZSAibm9ybWFsIi4KK1BBU1MgcGFyc2VSZXN1bHRPZigiaW52YWxpZF9p ZGVudCIpIGlzICJub3JtYWwiCitQQVNTIHBhcnNlUmVzdWx0T2YoImludmFsaWRfY2FzZXMiKSBp cyAibm9ybWFsIgogUEFTUyBwYXJzZVJlc3VsdE9mKCJpbnZhbGlkXzEiKSBpcyAibm9ybWFsIgog UEFTUyBwYXJzZVJlc3VsdE9mKCJpbnZhbGlkX29mZiIpIGlzICJub3JtYWwiCiBQQVNTIHBhcnNl UmVzdWx0T2YoImludmFsaWRfbm9ybWFsX2R1cGxpY2F0ZSIpIGlzICJub3JtYWwiCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9jc3MzL2ZvbnQtZmVhdHVyZS1zZXR0aW5ncy1wYXJzaW5nLmh0bWwg Yi9MYXlvdXRUZXN0cy9jc3MzL2ZvbnQtZmVhdHVyZS1zZXR0aW5ncy1wYXJzaW5nLmh0bWwKaW5k ZXggNzdhZTMwZTgwZjBmNGU5NTQ1ZmE3OGQ4YTY4MjFjZjY0NWIwMTU4NS4uYTBmNWNkZmMzY2Jh NTM2NGQ1NTViMzFhMTYwZWRmNjFjOGJmMDJmZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvY3Nz My9mb250LWZlYXR1cmUtc2V0dGluZ3MtcGFyc2luZy5odG1sCisrKyBiL0xheW91dFRlc3RzL2Nz czMvZm9udC1mZWF0dXJlLXNldHRpbmdzLXBhcnNpbmcuaHRtbApAQCAtMzMsMjQgKzMzLDI0IEBA CiAgICAgLXdlYmtpdC1mb250LWZlYXR1cmUtc2V0dGluZ3M6ICdQS1JOJzsKIH0KIAotI3ZhbGlk X2lkZW50IHsKLSAgICAtd2Via2l0LWZvbnQtZmVhdHVyZS1zZXR0aW5nczogZGxpZzsKLX0KLQog I3ZhbGlkX3VudXN1YWxfdGFnIHsKICAgICAtd2Via2l0LWZvbnQtZmVhdHVyZS1zZXR0aW5nczog IiFAIyQiOwogfQogCi0jdmFsaWRfY2FzZXMgewotICAgIC13ZWJraXQtZm9udC1mZWF0dXJlLXNl dHRpbmdzOiBkbGlnLCBETElHLCBETGlnOwotfQotCiAjdmFsaWRfdGFnX3NwYWNlIHsKICAgICAt d2Via2l0LWZvbnQtZmVhdHVyZS1zZXR0aW5nczogImEgYmMiOwogfQogCiAjdmFsaWRfY29tcG9z aXRlIHsKLSAgICAtd2Via2l0LWZvbnQtZmVhdHVyZS1zZXR0aW5nczogImRsaWciIDEsICdzbWNw JyBvbiwgbGlnYSBvZmY7CisgICAgLXdlYmtpdC1mb250LWZlYXR1cmUtc2V0dGluZ3M6ICJkbGln IiAxLCAnc21jcCcgb24sICdsaWcgJyBvZmY7Cit9CisKKyNpbnZhbGlkX2lkZW50IHsKKyAgICAt d2Via2l0LWZvbnQtZmVhdHVyZS1zZXR0aW5nczogZGxpZzsKK30KKworI2ludmFsaWRfY2FzZXMg eworICAgIC13ZWJraXQtZm9udC1mZWF0dXJlLXNldHRpbmdzOiBkbGlnLCBETElHLCBETGlnOwog fQogCiAjaW52YWxpZF8xIHsKQEAgLTEzNywxMiArMTM3LDEyIEBACiA8ZGl2IGlkPSJ2YWxpZF92 YWx1ZV9vbWl0Ij48L2Rpdj4KIDxkaXYgaWQ9InZhbGlkX3ZhbHVlbGlzdCI+PC9kaXY+CiA8ZGl2 IGlkPSJ2YWxpZF9zaW5nbGVxdW90ZSI+PC9kaXY+Ci08ZGl2IGlkPSJ2YWxpZF9pZGVudCI+PC9k aXY+CiA8ZGl2IGlkPSJ2YWxpZF91bnVzdWFsX3RhZyI+PC9kaXY+CiA8ZGl2IGlkPSJ2YWxpZF90 YWdfc3BhY2UiPjwvZGl2PgotPGRpdiBpZD0idmFsaWRfY2FzZXMiPjwvZGl2PgogPGRpdiBpZD0i dmFsaWRfY29tcG9zaXRlIj48L2Rpdj4KIAorPGRpdiBpZD0iaW52YWxpZF9pZGVudCI+PC9kaXY+ Cis8ZGl2IGlkPSJpbnZhbGlkX2Nhc2VzIj48L2Rpdj4KIDxkaXYgaWQ9ImludmFsaWRfMSI+PC9k aXY+CiA8ZGl2IGlkPSJpbnZhbGlkX29mZiI+PC9kaXY+CiA8ZGl2IGlkPSJpbnZhbGlkX25vcm1h bF9kdXBsaWNhdGUiPjwvZGl2PgpAQCAtMTU5LDcgKzE1OSw3IEBACiA8ZGl2IGlkPSJpbnZhbGlk X29uIj48L2Rpdj4KIDxkaXYgaWQ9ImludmFsaWRfMCI+PC9kaXY+CiAKLTxkaXYgaWQ9Im91dGVy IiBzdHlsZT0iLXdlYmtpdC1mb250LWZlYXR1cmUtc2V0dGluZ3M6IGRsaWc7Ij4KKzxkaXYgaWQ9 Im91dGVyIiBzdHlsZT0iLXdlYmtpdC1mb250LWZlYXR1cmUtc2V0dGluZ3M6ICdkbGlnJzsiPgog ICA8ZGl2IGlkPSJpbm5lciI+PC9kaXY+CiA8L2Rpdj4KIApAQCAtMTgyLDEzICsxODIsMTMgQEAg c2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdwYXJzZVJlc3VsdE9mKCJ2YWxpZF92YWx1ZV9vZmYiKScs ICInbGlnYScgMCIpOwogc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdwYXJzZVJlc3VsdE9mKCJ2YWxp ZF92YWx1ZV9vbWl0IiknLCAiJ2Myc2MnIDEiKTsKIHNob3VsZEJlRXF1YWxUb1N0cmluZygncGFy c2VSZXN1bHRPZigidmFsaWRfdmFsdWVsaXN0IiknLCAiJ3RudW0nIDEsICdoaXN0JyAxIik7CiBz aG91bGRCZUVxdWFsVG9TdHJpbmcoJ3BhcnNlUmVzdWx0T2YoInZhbGlkX3NpbmdsZXF1b3RlIikn LCAiJ1BLUk4nIDEiKTsKLXNob3VsZEJlRXF1YWxUb1N0cmluZygncGFyc2VSZXN1bHRPZigidmFs aWRfaWRlbnQiKScsICInZGxpZycgMSIpOwogc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdwYXJzZVJl c3VsdE9mKCJ2YWxpZF91bnVzdWFsX3RhZyIpJywgIichQCMkJyAxIik7CiBzaG91bGRCZUVxdWFs VG9TdHJpbmcoJ3BhcnNlUmVzdWx0T2YoInZhbGlkX3RhZ19zcGFjZSIpJywgIidhIGJjJyAxIik7 Ci1zaG91bGRCZUVxdWFsVG9TdHJpbmcoJ3BhcnNlUmVzdWx0T2YoInZhbGlkX2Nhc2VzIiknLCAi J2RsaWcnIDEsICdETElHJyAxLCAnRExpZycgMSIpOwotc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdw YXJzZVJlc3VsdE9mKCJ2YWxpZF9jb21wb3NpdGUiKScsICInZGxpZycgMSwgJ3NtY3AnIDEsICds aWdhJyAwIik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ3BhcnNlUmVzdWx0T2YoInZhbGlkX2Nv bXBvc2l0ZSIpJywgIidkbGlnJyAxLCAnc21jcCcgMSwgJ2xpZyAnIDAiKTsKIAogZGVidWcoJy0g VGVzdHMgaW52YWxpZCBpbnB1dHMuICBSZXN1bHRzIHNob3VsZCBiZSAibm9ybWFsIi4nKTsKK3No b3VsZEJlKCdwYXJzZVJlc3VsdE9mKCJpbnZhbGlkX2lkZW50IiknLCAnIm5vcm1hbCInKTsKK3No b3VsZEJlKCdwYXJzZVJlc3VsdE9mKCJpbnZhbGlkX2Nhc2VzIiknLCAnIm5vcm1hbCInKTsKIHNo b3VsZEJlKCdwYXJzZVJlc3VsdE9mKCJpbnZhbGlkXzEiKScsICcibm9ybWFsIicpOwogc2hvdWxk QmUoJ3BhcnNlUmVzdWx0T2YoImludmFsaWRfb2ZmIiknLCAnIm5vcm1hbCInKTsKIHNob3VsZEJl KCdwYXJzZVJlc3VsdE9mKCJpbnZhbGlkX25vcm1hbF9kdXBsaWNhdGUiKScsICcibm9ybWFsIicp Owo=