85343 2012-05-01 20:53:47 -0700 Cursor change fires mousemove event 2012-11-28 05:26:01 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 101857 http://jsfiddle.net/TRF7g/ P2 Normal --- 100550 101857 1 davidbarr webkit-unassigned abarth aivopaas allan.jensen ap eric mitz rbyers simon.fraser webkit.review.bot ytplayers oldest_to_newest 613938 0 davidbarr 2012-05-01 20:53:47 -0700 Upstream bug: http://crbug.com/103041 Simple reproduction: http://jsfiddle.net/TRF7g/ Ran bisect-builds, bug present in WebKit since at least r37376. -- Original report -- Chrome Version : 16.0.912.21 OS Version: OS X 10.6.8 (also checked windows7) URLs (if applicable) : Other browsers tested: Add OK or FAIL after other browsers where you have tested this issue: Safari 5: FAIL Firefox 4.x: OK IE 7/8/9: FAIL* What steps will reproduce the problem? 1. Create an event listener that is triggered by 'mousemove' 2. Change the cursor either with a CSS class change or element.style.cursor 3. Observe the event listener What is the expected result? Cursor changes without firing a mousemove event. What happens instead? Cursor changes and a mousemove event is fired. Please provide any additional information below. Attach a screenshot if possible. Seems like it may be a webkit issue since Safari behaves exactly like Chrome for this issue. *IE9 (haven't tested others) does not change the cursor until the user moves the mouse (this also seems incorrect.) UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/535.7 (KHTML, like Gecko) Chrome/16.0.912.21 Safari/535.7 758701 1 ytplayers 2012-11-05 10:57:55 -0800 This issue is a thorn in the side of anyone wishing to change the cursor based on a mousemove timeout - such as hiding a cursor (during video playback, presentations, etc). 762111 2 rbyers 2012-11-08 13:23:59 -0800 Is this because currently the only way the mouse cursor ever gets changed is via EventHandler::handleMouseMoveEvent? It looks like it shouldn't be too hard to add another function that sets the mouse cursor based on the current position... 762289 3 aivopaas 2012-11-08 16:12:05 -0800 No, it's actually because cursor change is fired through a fake mousemove event. I have a fix that doesn't use the fake mousemove event and thus doesn't fire the event. It also fixes bug 53341. I will propose a patch as soon as I get my environment set up correctly. 763000 4 173305 aivopaas 2012-11-09 07:30:27 -0800 Created attachment 173305 Patch 763031 5 rbyers 2012-11-09 08:03:29 -0800 Something along these lines seems reasonable to me (although I'm not a webkit reviewer). I was thinking of refactoring selectMouseCursor to not take a whole mouse event and hit test result, but I'm not sure if that's better (needs a position, node and a few other little things). You'll need to add tests of course, but my bug 100550 should land soon making it easy to write a layout test for this scenario. Mouse cursors seem like an area that hasn't been touched mouch, I'm not sure who the right reviewers are. 763168 6 173305 rbyers 2012-11-09 11:02:08 -0800 Comment on attachment 173305 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173305&action=review > Source/WebCore/page/EventHandler.cpp:146 > +const double updateMouseCursorInterval = 0.05; Are you sure a timer is necessary in this case? I think fake mouse move codepath has a timer for scrolling where there are lots of updates in a row. If we're getting lots of style updates in a row then I'd guess that there's already a performance problem and mouse cursors might be the least of the concerns. But I guess this is the safer approach without more performance data. But it's a shame to add this complexity if it's not really adding value. > Source/WebCore/page/EventHandler.cpp:1364 > + ASSERT_UNUSED(timer, timer == &m_updateMouseCursorTimer); This function shares a lot of code with fakeMouseMoveTimerFired. We should probably refactor to share common code. 763206 7 aivopaas 2012-11-09 11:45:32 -0800 Yes, it is safer with the timer, but I'll try how it behaves without it. Should be just fine I guess. Regarding the shared code - should dig up why the fake mousemove event was added in the first place. Maybe that problem could also be solved in better way. 763799 8 173492 aivopaas 2012-11-11 00:12:05 -0800 Created attachment 173492 Moved test to the fix in 101857 763808 9 173492 buildbot 2012-11-11 02:50:47 -0800 Comment on attachment 173492 Moved test to the fix in 101857 Attachment 173492 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14792669 New failing tests: fast/events/mouse-cursor-no-mousemove.html 770283 10 173492 rbyers 2012-11-18 19:21:55 -0800 Comment on attachment 173492 Moved test to the fix in 101857 View in context: https://bugs.webkit.org/attachment.cgi?id=173492&action=review > LayoutTests/fast/events/mouse-cursor-no-mousemove.html:42 > + }, 10); We shouldn't rely on specific time outs like this in tests. It's either going to be flaky (under load not long enough) or waste time doing nothing. Is setTimeout 0 not enough here for the style change to take effect? > LayoutTests/fast/events/mouse-cursor-no-mousemove.html:48 > + }, 50); If you've already verified you've got the new cursor, then it shouldn't be necessary to wait any longer, right? Once you change it, does this test fail reliably before your fix? 770284 11 rbyers 2012-11-18 19:24:28 -0800 You probably want to combine the fix with all the tests that it fixes in the same patch (they should be submitted together). 770449 12 aivopaas 2012-11-19 01:04:38 -0800 (In reply to comment #11) > You probably want to combine the fix with all the tests that it fixes in the same patch (they should be submitted together). Tests are already combined with the fix in Bug 101857 I will upload an updated patch with updated timeouts. 777787 13 allan.jensen 2012-11-28 05:26:01 -0800 *** This bug has been marked as a duplicate of bug 101857 *** 173305 2012-11-09 07:30:27 -0800 2012-11-11 00:11:58 -0800 Patch bug-85343-20121109172830.patch text/plain 6540 aivopaas U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTA1YzRiMmQzMTFkZjRi ODc3Yjc1MWFiNTI2MGM2YmVmY2E3MWRlMS4uYmMxZDdmOTUwMmZkMDBlNmVhNGUyMmU1MTMwMGJj NmRmYWY0NzIwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTExLTA5ICBBaXZv IFBhYXMgIDxhaXZvcGFhc0BnbWFpbC5jb20+CisKKyAgICAgICAgQ1NTIGN1cnNvciBjaGFuZ2Ug cmVmbGVjdGVkIHRocm91Z2ggYSBkZWRpY2F0ZWQgZXZlbnQgaGFuZGxlciBpbnN0ZWFkIG9mIGZh a2UgbW91c2Vtb3ZlIGV2ZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODUzNDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGRlZCBhIGRlZGljYXRlZCBtZXRob2QgZm9yIGhhbmRsaW5nIGN1cnNvciBj aGFuZ2VzIHRoYXQgaGFwcGVuIGluIHN0eWxlcy4gQmVmb3JlLAorICAgICAgICBhIGZha2UgbW91 c2Vtb3ZlIGV2ZW50IHdhcyBmaXJlZCwgd2hpY2ggaXMgY2FuY2VsbGVkIGluIGNhc2UgYSBtb3Vz ZSBidXR0b24gaXMgcHJlc3NlZC4KKyAgICAgICAgSXQgYWxzbyBoYXBwZW5lZCB0byBhY3R1YWxs eSBmaXJlIHRoZSBtb3VzZW1vdmUgZXZlbnQgaW4gamF2YXNjcmlwdCB0b28sIHdoaWNoIGlzIHJl cG9ydGVkIGluCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01MzM0MQorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgY3Vyc29yIHRlc3RpbmcgY2FwYWJpbGl0 eSBub3QgdGhlcmUgeWV0OiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAwNTUwCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJD b3JlKToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6RXZlbnRIYW5kbGVyKToKKyAg ICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6Y2xlYXIpOgorICAgICAgICAoV2ViQ29yZTo6 RXZlbnRIYW5kbGVyOjp1cGRhdGVNb3VzZUN1cnNvclNvb24pOgorICAgICAgICBBIG5ldyBleHBv c2VkIG1ldGhvZCB0aGF0IGNhdXNlcyBjdXJzb3IgY2hhbmdlIHRvIGhhcHBlbiBhZnRlciBhIHNt YWxsIGludGVydmFsLgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjp1cGRhdGVNb3Vz ZUN1cnNvclRpbWVyRmlyZWQpOgorICAgICAgICBUaGUgdGltZXIgZXZlbnQgaGFuZGxlciB0aGF0 IGdldHMgdGhlIGVsZW1lbnQgdW5kZXIgbGFzdCBrbm93biBtb3VzZSBwb3NpdGlvbiwgZmV0Y2hl cyBjdXJzb3IKKyAgICAgICAgaW5mb3JtYXRpb24gZnJvbSB0aGUgZWxlbWVudCBhbmQgY2F1c2Vz IHRoZSBhY3R1YWwgY3Vyc29yIGNoYW5nZS4KKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5o OgorICAgICAgICAoRXZlbnRIYW5kbGVyKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6c3R5bGVEaWRDaGFuZ2Up OgorICAgICAgICBTd2l0Y2hlZCBmYWtlIG1vdXNlbW92ZSBtZXRob2QgY2FsbCB0byB0aGUgbmV3 bHkgYWRkZWQgY3Vyc29yIGNoYW5nZSBtZXRob2QuCisKIDIwMTItMTEtMDggIEdyemVnb3J6IEN6 YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gQWRk IGEgbWV0aG9kIHRvIHRoZSBUZXh0Q2hlY2tlckVuY2hhbnQgY2xhc3MgdG8gY2hlY2sgd2hldGhl ciBhbnkgZGljdGlvbmFyeSBpcyBsb2FkZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNw cAppbmRleCAwN2UxYjczYWI5ODIzMmIwZjgzNDQxOTY0NWYzOGQ1Yzk2NWZjNGFhLi41N2ExN2Y0 MWJlMGUyZThiYWU3MzZlZDBlNjUwNzVhZWEyOGFjM2I4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVu dEhhbmRsZXIuY3BwCkBAIC0xNDIsNiArMTQyLDkgQEAgY29uc3QgZG91YmxlIGF1dG9zY3JvbGxJ bnRlcnZhbCA9IDAuMDU7CiBjb25zdCBkb3VibGUgZmFrZU1vdXNlTW92ZVNob3J0SW50ZXJ2YWwg PSAwLjE7CiBjb25zdCBkb3VibGUgZmFrZU1vdXNlTW92ZUxvbmdJbnRlcnZhbCA9IDAuMjUwOwog CisvLyBUaGUgYW1vdW50IG9mIHRpbWUgdG8gd2FpdCBiZWZvcmUgdXBkYXRpbmcgbW91c2UgY3Vy c29yIGFmdGVyIGN1cnNvciBoYXMgY2hhbmdlZCBpbiBzdHlsZXMKK2NvbnN0IGRvdWJsZSB1cGRh dGVNb3VzZUN1cnNvckludGVydmFsID0gMC4wNTsKKwogZW51bSBOb0N1cnNvckNoYW5nZVR5cGUg eyBOb0N1cnNvckNoYW5nZSB9OwogCiBjbGFzcyBPcHRpb25hbEN1cnNvciB7CkBAIC0zMTcsNiAr MzIwLDcgQEAgRXZlbnRIYW5kbGVyOjpFdmVudEhhbmRsZXIoRnJhbWUqIGZyYW1lKQogICAgICwg bV9tb3VzZURvd25NYXlTdGFydEF1dG9zY3JvbGwoZmFsc2UpCiAgICAgLCBtX21vdXNlRG93bldh c0luU3ViZnJhbWUoZmFsc2UpCiAgICAgLCBtX2Zha2VNb3VzZU1vdmVFdmVudFRpbWVyKHRoaXMs ICZFdmVudEhhbmRsZXI6OmZha2VNb3VzZU1vdmVFdmVudFRpbWVyRmlyZWQpCisgICAgLCBtX3Vw ZGF0ZU1vdXNlQ3Vyc29yVGltZXIodGhpcywgJkV2ZW50SGFuZGxlcjo6dXBkYXRlTW91c2VDdXJz b3JUaW1lckZpcmVkKQogI2lmIEVOQUJMRShTVkcpCiAgICAgLCBtX3N2Z1BhbihmYWxzZSkKICNl bmRpZgpAQCAtMzU1LDYgKzM1OSw3IEBAIHZvaWQgRXZlbnRIYW5kbGVyOjpjbGVhcigpCiB7CiAg ICAgbV9ob3ZlclRpbWVyLnN0b3AoKTsKICAgICBtX2Zha2VNb3VzZU1vdmVFdmVudFRpbWVyLnN0 b3AoKTsKKyAgICBtX3VwZGF0ZU1vdXNlQ3Vyc29yVGltZXIuc3RvcCgpOwogICAgIG1fcmVzaXpl TGF5ZXIgPSAwOwogICAgIG1fbm9kZVVuZGVyTW91c2UgPSAwOwogICAgIG1fbGFzdE5vZGVVbmRl ck1vdXNlID0gMDsKQEAgLTEzNDMsNiArMTM0OCw0OCBAQCBzdGF0aWMgYm9vbCBub2RlSXNOb3RC ZWluZ0VkaXRlZChOb2RlKiBub2RlLCBGcmFtZSogZnJhbWUpCiAgICAgcmV0dXJuIGZyYW1lLT5z ZWxlY3Rpb24oKS0+cm9vdEVkaXRhYmxlRWxlbWVudCgpICE9IG5vZGUtPnJvb3RFZGl0YWJsZUVs ZW1lbnQoKTsKIH0KIAordm9pZCBFdmVudEhhbmRsZXI6OnVwZGF0ZU1vdXNlQ3Vyc29yU29vbigp Cit7CisgICAgU2V0dGluZ3MqIHNldHRpbmdzID0gbV9mcmFtZS0+c2V0dGluZ3MoKTsKKyAgICBp ZiAoc2V0dGluZ3MgJiYgIXNldHRpbmdzLT5kZXZpY2VTdXBwb3J0c01vdXNlKCkpCisgICAgICAg IHJldHVybjsKKworICAgIGlmIChtX3VwZGF0ZU1vdXNlQ3Vyc29yVGltZXIuaXNBY3RpdmUoKSkK KyAgICAgICAgbV91cGRhdGVNb3VzZUN1cnNvclRpbWVyLnN0b3AoKTsKKyAgICBtX3VwZGF0ZU1v dXNlQ3Vyc29yVGltZXIuc3RhcnRPbmVTaG90KHVwZGF0ZU1vdXNlQ3Vyc29ySW50ZXJ2YWwpOwor fQorCit2b2lkIEV2ZW50SGFuZGxlcjo6dXBkYXRlTW91c2VDdXJzb3JUaW1lckZpcmVkKFRpbWVy PEV2ZW50SGFuZGxlcj4qIHRpbWVyKQoreworICAgIEFTU0VSVF9VTlVTRUQodGltZXIsIHRpbWVy ID09ICZtX3VwZGF0ZU1vdXNlQ3Vyc29yVGltZXIpOworCisgICAgU2V0dGluZ3MqIHNldHRpbmdz ID0gbV9mcmFtZS0+c2V0dGluZ3MoKTsKKyAgICBpZiAoc2V0dGluZ3MgJiYgIXNldHRpbmdzLT5k ZXZpY2VTdXBwb3J0c01vdXNlKCkpCisgICAgICAgIHJldHVybjsKKworICAgIEZyYW1lVmlldyog dmlldyA9IG1fZnJhbWUtPnZpZXcoKTsKKyAgICBpZiAoIXZpZXcpCisgICAgICAgIHJldHVybjsK KworICAgIGlmICghbV9mcmFtZS0+cGFnZSgpIHx8ICFtX2ZyYW1lLT5wYWdlKCktPmlzT25zY3Jl ZW4oKSB8fCAhbV9mcmFtZS0+cGFnZSgpLT5mb2N1c0NvbnRyb2xsZXIoKS0+aXNBY3RpdmUoKSkK KyAgICAgICAgcmV0dXJuOworCisgICAgYm9vbCBzaGlmdEtleTsKKyAgICBib29sIGN0cmxLZXk7 CisgICAgYm9vbCBhbHRLZXk7CisgICAgYm9vbCBtZXRhS2V5OworICAgIFBsYXRmb3JtS2V5Ym9h cmRFdmVudDo6Z2V0Q3VycmVudE1vZGlmaWVyU3RhdGUoc2hpZnRLZXksIGN0cmxLZXksIGFsdEtl eSwgbWV0YUtleSk7CisKKyAgICBQbGF0Zm9ybU1vdXNlRXZlbnQgdXBkYXRlTW91c2VDdXJzb3JF dmVudChtX2N1cnJlbnRNb3VzZVBvc2l0aW9uLCBtX2N1cnJlbnRNb3VzZUdsb2JhbFBvc2l0aW9u LCBOb0J1dHRvbiwgUGxhdGZvcm1FdmVudDo6Tm9UeXBlLCAwLCBzaGlmdEtleSwgY3RybEtleSwg YWx0S2V5LCBtZXRhS2V5LCBjdXJyZW50VGltZSgpKTsKKworICAgIEhpdFRlc3RSZXF1ZXN0IHJl cXVlc3QoSGl0VGVzdFJlcXVlc3Q6OlJlYWRPbmx5KTsKKyAgICBNb3VzZUV2ZW50V2l0aEhpdFRl c3RSZXN1bHRzIG1ldiA9IHByZXBhcmVNb3VzZUV2ZW50KHJlcXVlc3QsIHVwZGF0ZU1vdXNlQ3Vy c29yRXZlbnQpOworCisgICAgT3B0aW9uYWxDdXJzb3Igb3B0aW9uYWxDdXJzb3IgPSBzZWxlY3RD dXJzb3IobWV2LCBtZXYuc2Nyb2xsYmFyKCkpOworICAgIGlmIChvcHRpb25hbEN1cnNvci5pc0N1 cnNvckNoYW5nZSgpKQorICAgICAgICB2aWV3LT5zZXRDdXJzb3Iob3B0aW9uYWxDdXJzb3IuY3Vy c29yKCkpOworfQorCiBib29sIEV2ZW50SGFuZGxlcjo6dXNlSGFuZEN1cnNvcihOb2RlKiBub2Rl LCBib29sIGlzT3ZlckxpbmssIGJvb2wgc2hpZnRLZXkpCiB7CiAgICAgaWYgKCFub2RlKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaCBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgKaW5kZXggOTNjNmIxMGViOTg3NDRmYmY1NjdhODE5ZjI4 MTY4ZjMyMmExYzFjOC4uMzExMzVjODg4OTIwYjEyOWJjZDc0OGYyMWU3ZmMxNWFlMzY0NmVkOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCkBAIC0yMzYsNiArMjM2LDggQEAgcHVibGlj OgogCiAgICAgYm9vbCB1c2VIYW5kQ3Vyc29yKE5vZGUqLCBib29sIGlzT3ZlckxpbmssIGJvb2wg c2hpZnRLZXkpOwogCisgICAgdm9pZCB1cGRhdGVNb3VzZUN1cnNvclNvb24oKTsKKwogcHJpdmF0 ZToKICNpZiBFTkFCTEUoRFJBR19TVVBQT1JUKQogICAgIHN0YXRpYyBEcmFnU3RhdGUmIGRyYWdT dGF0ZSgpOwpAQCAtMjgzLDYgKzI4NSw4IEBAIHByaXZhdGU6CiAgICAgdm9pZCBmYWtlTW91c2VN b3ZlRXZlbnRUaW1lckZpcmVkKFRpbWVyPEV2ZW50SGFuZGxlcj4qKTsKICAgICB2b2lkIGNhbmNl bEZha2VNb3VzZU1vdmVFdmVudCgpOwogCisgICAgdm9pZCB1cGRhdGVNb3VzZUN1cnNvclRpbWVy RmlyZWQoVGltZXI8RXZlbnRIYW5kbGVyPiopOworCiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykK ICAgICBib29sIGRpc3BhdGNoU3ludGhldGljVG91Y2hFdmVudElmRW5hYmxlZChjb25zdCBQbGF0 Zm9ybU1vdXNlRXZlbnQmKTsKICNlbmRpZgpAQCAtNDA1LDYgKzQwOSw4IEBAIHByaXZhdGU6CiAK ICAgICBUaW1lcjxFdmVudEhhbmRsZXI+IG1fZmFrZU1vdXNlTW92ZUV2ZW50VGltZXI7CiAKKyAg ICBUaW1lcjxFdmVudEhhbmRsZXI+IG1fdXBkYXRlTW91c2VDdXJzb3JUaW1lcjsKKwogI2lmIEVO QUJMRShTVkcpCiAgICAgYm9vbCBtX3N2Z1BhbjsKICAgICBSZWZQdHI8U1ZHRWxlbWVudEluc3Rh bmNlPiBtX2luc3RhbmNlVW5kZXJNb3VzZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ck9iamVjdC5jcHAKaW5kZXggOTgzYWNlZDRlODBjMDhkYTJkZDM4NjMxZWJlNjhmNDM5ZjVlNzcw NS4uMjQ1ZTk5NWZkZjQxZTUxNTg2MDQ1MTc2NjVlYmY2Yzc2OTkxY2Q2ZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKQEAgLTE5NTIsNyArMTk1Miw3IEBAIHZv aWQgUmVuZGVyT2JqZWN0OjpzdHlsZURpZENoYW5nZShTdHlsZURpZmZlcmVuY2UgZGlmZiwgY29u c3QgUmVuZGVyU3R5bGUqIG9sZFN0CiAKICAgICBpZiAob2xkU3R5bGUgJiYgIWFyZUN1cnNvcnNF cXVhbChvbGRTdHlsZSwgc3R5bGUoKSkpIHsKICAgICAgICAgaWYgKEZyYW1lKiBmcmFtZSA9IHRo aXMtPmZyYW1lKCkpCi0gICAgICAgICAgICBmcmFtZS0+ZXZlbnRIYW5kbGVyKCktPmRpc3BhdGNo RmFrZU1vdXNlTW92ZUV2ZW50U29vbigpOworICAgICAgICAgICAgZnJhbWUtPmV2ZW50SGFuZGxl cigpLT51cGRhdGVNb3VzZUN1cnNvclNvb24oKTsKICAgICB9CiB9CiAK 173492 2012-11-11 00:12:05 -0800 2012-11-18 19:21:55 -0800 Moved test to the fix in 101857 bug-85343-20121111101003.patch text/plain 3479 aivopaas U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTcwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDQ3YjllMzI5OTRiYTU3M2I3MmFi YmVkYzU4N2NlNzE1ZTY4NzFiZS4uMTFhMzQwN2QwYzBlN2U4Mjg4NWZhZDEwZjhlYTk3MWVhYzZl YzQ0ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTExLTExICBBaXZvIFBhYXMgIDxhaXZv cGFhc0BnbWFpbC5jb20+CisKKyAgICAgICAgQ3Vyc29yIGNoYW5nZSBzaG91bGQgbm90IGZpcmUg bW91c2Vtb3ZlIGV2ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04NTM0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZmFzdC9ldmVudHMvbW91c2UtY3Vyc29yLW5vLW1vdXNlbW92ZS1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXZlbnRzL21vdXNlLWN1cnNvci1uby1tb3VzZW1v dmUuaHRtbDogQWRkZWQuCisKIDIwMTItMTEtMTAgIE1pa2UgV2VzdCAgPG1rd3N0QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBNdWx0aXBsZSAnJWMnIGZvcm1hdHRpbmcg b3B0aW9ucyBzaG91bGQgYWxsIGhhdmUgZWZmZWN0LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvbW91c2UtY3Vyc29yLW5vLW1vdXNlbW92ZS1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9tb3VzZS1jdXJzb3Itbm8tbW91c2Vtb3ZlLWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi5lMDNiNGQzOGI3ZjA3ZWUzZWU1YWQxM2QyYjk4YTJjYmY3Y2MwYzRiCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvbW91c2UtY3Vyc29yLW5v LW1vdXNlbW92ZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxNiBAQAorVGVzdCB0aGF0IHRoZXJl IGlzIG5vIG1vdXNlbW92ZSBldmVudCBmaXJlZCB3aGVuIGNoYW5naW5nIGN1cnNvci4KKworT24g c3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93 ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK0J1ZyA4NTM0MworCisKK1RFU1QgQ0FTRTogTW91 c2UgaWRsZSwgY2hhbmdlIGN1cnNvciBzaG91bGQgbm90IGZpcmUgbW91c2Vtb3ZlIGV2ZW50CitD dXJzb3IgSW5mbzogdHlwZT1UeXBlUG9pbnRlciBob3RTcG90PTAsMAorQ3Vyc29yIEluZm86IHR5 cGU9VHlwZUhlbHAgaG90U3BvdD0wLDAKKworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1 ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRz L21vdXNlLWN1cnNvci1uby1tb3VzZW1vdmUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRz L21vdXNlLWN1cnNvci1uby1tb3VzZW1vdmUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hNTc0OGI5MTEzMzMw MjYzMDE2NzM4YjczNDMwNmQyMzZiZmY5NDU0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9ldmVudHMvbW91c2UtY3Vyc29yLW5vLW1vdXNlbW92ZS5odG1sCkBAIC0wLDAgKzEs NTQgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9q cy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHN0eWxlIHR5cGU9InRleHQv Y3NzIj4KKzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9w PgorPHA+PGEgaHJlZj1odHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODUz NDM+QnVnIDg1MzQzPC9hPjwvcD4KKzxkaXYgaWQ9InRlc3QtY29udGFpbmVyIj4KKyAgICA8ZGl2 IGlkPSJ0YXJnZXQiIHN0eWxlPSJjdXJzb3I6ZGVmYXVsdCI+TW91c2UgaWRsZSwgY2hhbmdlIGN1 cnNvciBzaG91bGQgbm90IGZpcmUgbW91c2Vtb3ZlIGV2ZW50PC9kaXY+Cis8L2Rpdj4KKzxici8+ Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGVzdCB0 aGF0IHRoZXJlIGlzIG5vIG1vdXNlbW92ZSBldmVudCBmaXJlZCB3aGVuIGNoYW5naW5nIGN1cnNv ci4iKTsKKworaWYgKCF3aW5kb3cuZXZlbnRTZW5kZXIpIHsKKyAgICB0ZXN0RmFpbGVkKCdUaGlz IHRlc3QgcmVxdWlyZXMgRHVtcFJlbmRlclRyZWUnKTsKK30KKworaWYgKHdpbmRvdy50ZXN0UnVu bmVyKSB7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgdGVzdFJ1bm5lci53YWl0 VW50aWxEb25lKCk7CisgICAgd2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOworfQorCisvLyBD YW4ndCBkbyBhbnl0aGluZyB1c2VmdWwgaGVyZSB3aXRob3V0IGV2ZW50U2VuZGVyCitpZiAod2lu ZG93LmV2ZW50U2VuZGVyKSB7CisgICAgdmFyIG5vZGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgndGFyZ2V0Jyk7CisgICAgZGVidWcoJ1RFU1QgQ0FTRTogJyArIG5vZGUudGV4dENvbnRlbnQp OworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKG5vZGUub2Zmc2V0TGVmdCArIDMsIG5vZGUu b2Zmc2V0VG9wICsgMyk7CisgICAgZGVidWcoJ0N1cnNvciBJbmZvOiAnICsgd2luZG93LmludGVy bmFscy5nZXRDdXJyZW50Q3Vyc29ySW5mbyhkb2N1bWVudCkpOworICAgIG5vZGUuYWRkRXZlbnRM aXN0ZW5lcignbW91c2Vtb3ZlJywgZnVuY3Rpb24oKSB7CisgICAgICAgIHRlc3RGYWlsZWQoJ01v dXNlbW92ZSBldmVudCBzaG91bGQgbm90IGJlIGZpcmVkIHdoZW4gY2hhbmdpbmcgY3Vyc29yJyk7 CisgICAgfSk7CisgICAgbm9kZS5zdHlsZS5jdXJzb3IgPSAnaGVscCc7CisgICAgc2V0VGltZW91 dChmdW5jdGlvbigpIHsKKyAgICAgICAgZGVidWcoJ0N1cnNvciBJbmZvOiAnICsgd2luZG93Lmlu dGVybmFscy5nZXRDdXJyZW50Q3Vyc29ySW5mbyhkb2N1bWVudCkpOworICAgICAgICBkZWJ1Zygn Jyk7CisgICAgfSwgMTApOworICAgIAorICAgIC8vIEdpdmUgc29tZSB0aW1lIGZvciB0ZXN0aW5n IHRoYXQgbW91c2Vtb3ZlIGlzIG5vdCBmaXJlZCBvbiB0aGUgbGFzdCB0ZXN0CisgICAgc2V0VGlt ZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3Qt Y29udGFpbmVyJykuc3R5bGUuZGlzcGxheSA9ICdub25lJzsKKyAgICAgICAgZmluaXNoSlNUZXN0 KCk7CisgICAgfSwgNTApOworfQorCis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0 L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1s Pgo=