85331 2012-05-01 18:02:56 -0700 Calendar Picker: Too wide in Japanese locale 2012-05-01 20:00:50 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84826 53961 1 tkent tkent haraken keishi morrita webkit.review.bot oldest_to_newest 613838 0 tkent 2012-05-01 18:02:56 -0700 A calendar picker is too wide in Japanese locale because YearMonthController.attachTo() tests "275760年(平成273772年) N月" to decide the width. 613846 1 139719 tkent 2012-05-01 18:16:06 -0700 Created attachment 139719 Patch 613849 2 139719 haraken 2012-05-01 18:25:15 -0700 Comment on attachment 139719 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139719&action=review Waiting for keishi-san's review. > Source/WebCore/Resources/calendarPicker.js:139 > + if (year > 2087) Nit: You might want to use imperialEraLimit. 613850 3 139719 tkent 2012-05-01 18:26:32 -0700 Comment on attachment 139719 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139719&action=review >> Source/WebCore/Resources/calendarPicker.js:139 >> + if (year > 2087) > > Nit: You might want to use imperialEraLimit. oh, you're right. 613852 4 139720 tkent 2012-05-01 18:29:52 -0700 Created attachment 139720 Patch 2 613882 5 139720 keishi 2012-05-01 19:19:56 -0700 Comment on attachment 139720 Patch 2 ok looks good 613907 6 139720 webkit.review.bot 2012-05-01 20:00:46 -0700 Comment on attachment 139720 Patch 2 Clearing flags on attachment: 139720 Committed r115783: <http://trac.webkit.org/changeset/115783> 613908 7 webkit.review.bot 2012-05-01 20:00:50 -0700 All reviewed patches have been landed. Closing bug. 139719 2012-05-01 18:16:06 -0700 2012-05-01 18:29:40 -0700 Patch bug-85331-20120502101605.patch text/plain 3128 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmJhYTNiNjlmODhlOWRm NGZhZTFlMzIwZTRkMDU2Y2MxM2Q1YWVkYi4uMmZkYWY4YWUwOTQwM2Q1ODhjNDM0YTc2NGYwNzM5 ZWNmYzYxMmI5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA1LTAxICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBDYWxlbmRhciBQaWNrZXI6 IFRvbyB3aWRlIGluIEphcGFuZXNlIGxvY2FsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODUzMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgaXMgYSBsb2NhbGUtc3BlY2lm aWMgYmVoYXZpb3IuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvY2FsZW5kYXJQaWNrZXIuanM6Cisg ICAgICAgIChmb3JtYXRKYXBhbmVzZUltcGVyaWFsRXJhKToKKyAgICAgICAgRG8gbm90IHNob3cg YW4gaW1wZXJpYWwgZXJhIGxhdGVyIHRoYW4g5bmz5oiQOTnlubQgdG8gYXZvaWQgdmVyeSBsb25n CisgICAgICAgIHllYXIgc3RyaW5nIGxpa2UgIjI3NTc2MOW5tCjlubPmiJAyNzM3NzLlubQpLiIK KyAgICAgICAgKFllYXJNb250aENvbnRyb2xsZXIucHJvdG90eXBlLmF0dGFjaFRvKToKKyAgICAg ICAgLSBSZXNwZWN0IHRoZSBtYXhpbXVtIHllYXIgc3BlY2ZpZWQgYnkgPGlucHV0IG1heD0uLi4+ CisgICAgICAgICAgSWYgPGlucHV0IG1heD0iOTk5OS0xMi0zMSI+IGlzIHNwZWNpZmllZCwgd2Ug ZG9uJ3QgbmVlZCB0bworICAgICAgICAgIHNlY3VyZSBzcGFjZSBmb3IgdGhlIHllYXIgMjc1LDc2 MC4KKyAgICAgICAgLSBDaGVjayB0aGUgd2lkdGggZm9yIOW5s+aIkDk55bm0IGFzIHdlbGwgYXMg dGhlIG1heGltdW0geWVhciBiZWNhdXNlCisgICAgICAgICAgIjIwODflubQo5bmz5oiQOTnlubQp IiBpcyB1c3VhbGx5IHdpZGVyIHRoYW4gIjI3NTc2MOW5tCIuCisKIDIwMTItMDUtMDEgIFJ5b3N1 a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgKkNvbW1hbmQuaCBmaWxlcyBz aG91bGRuJ3QgYmUgZXhwb3J0ZWQgdG8gV2ViS2l0IGxheWVyCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9SZXNvdXJjZXMvY2FsZW5kYXJQaWNrZXIuanMgYi9Tb3VyY2UvV2ViQ29yZS9SZXNv dXJjZXMvY2FsZW5kYXJQaWNrZXIuanMKaW5kZXggY2VlYmE3MmQ2NTJmMzUzODY4MWRmNThmMTJi MWNlMTUyMzhhN2FmOS4uNGQxYThkMTVlNzhkYmEzNGZlOTcxMDA5NjFiYzI3MDM0MmQ5NTA1MCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUmVzb3VyY2VzL2NhbGVuZGFyUGlja2VyLmpzCisr KyBiL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9jYWxlbmRhclBpY2tlci5qcwpAQCAtMTIyLDEy ICsxMjIsMjIgQEAgZnVuY3Rpb24gZ2V0TGFuZ3VhZ2UoKSB7CiAgICAgcmV0dXJuIHJlc3VsdFsx XTsKIH0KIAorLyoKKyAqIEBjb25zdAorICogQHR5cGUge251bWJlcn0KKyAqLwordmFyIEltcGVy aWFsRXJhTGltaXQgPSAyMDg3OworCiAvKioKICAqIEBwYXJhbSB7IW51bWJlcn0geWVhcgogICog QHBhcmFtIHshbnVtYmVyfSBtb250aAogICogQHJldHVybiB7IXN0cmluZ30KICAqLwogZnVuY3Rp b24gZm9ybWF0SmFwYW5lc2VJbXBlcmlhbEVyYSh5ZWFyLCBtb250aCkgeworICAgIC8vIFdlIGRv bid0IHNob3cgYW4gaW1wZXJpYWwgZXJhIGlmIGl0IGlzIGdyZWF0ZXIgdGhhbiA5OSBiZWNhc2Ug b2Ygc3BhY2UKKyAgICAvLyBsaW1pdGF0aW9uLgorICAgIGlmICh5ZWFyID4gMjA4NykKKyAgICAg ICAgcmV0dXJuICIiOwogICAgIGlmICh5ZWFyID4gMTk4OSkKICAgICAgICAgcmV0dXJuICIo5bmz 5oiQIiArICh5ZWFyIC0gMTk4OCkgKyAi5bm0KSI7CiAgICAgaWYgKHllYXIgPT0gMTk4OSkKQEAg LTQyNiwxNCArNDM2LDE4IEBAIFllYXJNb250aENvbnRyb2xsZXIucHJvdG90eXBlLmF0dGFjaFRv ID0gZnVuY3Rpb24obWFpbikgewogICAgIHRoaXMuX3dhbGwuYWRkRXZlbnRMaXN0ZW5lcigiY2xp Y2siLCBiaW5kKHRoaXMuX2Nsb3NlUG9wdXAsIHRoaXMpLCBmYWxzZSk7CiAgICAgbWFpbi5hcHBl bmRDaGlsZCh0aGlzLl93YWxsKTsKIAotICAgIC8vIFRoZSBtYXhpbXVtIHllYXIgd2hpY2ggPGlu cHV0IHR5cGU9ZGF0ZT4gc3VwcG9ydHMgaXMgMjc1LDc2MC4KLSAgICAvLyBTZWUgV2ViQ29yZS9w bGF0Zm9ybS9EYXRlQ29tcG9uZW50cy5oCi0gICAgdmFyIE1heGltdW1ZZWFyID0gMjc1NzYwOwor ICAgIHZhciBtYXhpbXVtWWVhciA9IGdsb2JhbC5tYXhpbXVtRGF0ZS5nZXRVVENGdWxsWWVhcigp OwogICAgIHZhciBtYXhXaWR0aCA9IDA7CiAgICAgZm9yICh2YXIgbSA9IDA7IG0gPCAxMjsgKytt KSB7Ci0gICAgICAgIHRoaXMuX21vbnRoLnRleHRDb250ZW50ID0gZm9ybWF0WWVhck1vbnRoKE1h eGltdW1ZZWFyLCBtKTsKKyAgICAgICAgdGhpcy5fbW9udGgudGV4dENvbnRlbnQgPSBmb3JtYXRZ ZWFyTW9udGgobWF4aW11bVllYXIsIG0pOwogICAgICAgICBtYXhXaWR0aCA9IE1hdGgubWF4KG1h eFdpZHRoLCB0aGlzLl9tb250aC5vZmZzZXRXaWR0aCk7CiAgICAgfQorICAgIGlmIChnZXRMYW5n dWFnZSgpID09ICJqYSIgJiYgSW1wZXJpYWxFcmFMaW1pdCA8IG1heGltdW1ZZWFyKSB7CisgICAg ICAgIGZvciAodmFyIG0gPSAwOyBtIDwgMTI7ICsrbSkgeworICAgICAgICAgICAgdGhpcy5fbW9u dGgudGV4dENvbnRlbnQgPSBmb3JtYXRZZWFyTW9udGgoSW1wZXJpYWxFcmFMaW1pdCwgbSk7Cisg ICAgICAgICAgICBtYXhXaWR0aCA9IE1hdGgubWF4KG1heFdpZHRoLCB0aGlzLl9tb250aC5vZmZz ZXRXaWR0aCk7CisgICAgICAgIH0KKyAgICB9CiAgICAgdGhpcy5fbW9udGguc3R5bGUubWluV2lk dGggPSBtYXhXaWR0aCArICdweCc7CiAKICAgICBnbG9iYWwuZmlyc3RGb2N1c2FibGVDb250cm9s ID0gdGhpcy5fbGVmdDI7IC8vIEZJWE1FOiBTaG91ZCBpdCBiZSB0aGlzLm1vbnRoPwo= 139720 2012-05-01 18:29:52 -0700 2012-05-01 20:00:46 -0700 Patch 2 bug-85331-20120502102950.patch text/plain 3140 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmJhYTNiNjlmODhlOWRm NGZhZTFlMzIwZTRkMDU2Y2MxM2Q1YWVkYi4uMmZkYWY4YWUwOTQwM2Q1ODhjNDM0YTc2NGYwNzM5 ZWNmYzYxMmI5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA1LTAxICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBDYWxlbmRhciBQaWNrZXI6 IFRvbyB3aWRlIGluIEphcGFuZXNlIGxvY2FsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODUzMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgaXMgYSBsb2NhbGUtc3BlY2lm aWMgYmVoYXZpb3IuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvY2FsZW5kYXJQaWNrZXIuanM6Cisg ICAgICAgIChmb3JtYXRKYXBhbmVzZUltcGVyaWFsRXJhKToKKyAgICAgICAgRG8gbm90IHNob3cg YW4gaW1wZXJpYWwgZXJhIGxhdGVyIHRoYW4g5bmz5oiQOTnlubQgdG8gYXZvaWQgdmVyeSBsb25n CisgICAgICAgIHllYXIgc3RyaW5nIGxpa2UgIjI3NTc2MOW5tCjlubPmiJAyNzM3NzLlubQpLiIK KyAgICAgICAgKFllYXJNb250aENvbnRyb2xsZXIucHJvdG90eXBlLmF0dGFjaFRvKToKKyAgICAg ICAgLSBSZXNwZWN0IHRoZSBtYXhpbXVtIHllYXIgc3BlY2ZpZWQgYnkgPGlucHV0IG1heD0uLi4+ CisgICAgICAgICAgSWYgPGlucHV0IG1heD0iOTk5OS0xMi0zMSI+IGlzIHNwZWNpZmllZCwgd2Ug ZG9uJ3QgbmVlZCB0bworICAgICAgICAgIHNlY3VyZSBzcGFjZSBmb3IgdGhlIHllYXIgMjc1LDc2 MC4KKyAgICAgICAgLSBDaGVjayB0aGUgd2lkdGggZm9yIOW5s+aIkDk55bm0IGFzIHdlbGwgYXMg dGhlIG1heGltdW0geWVhciBiZWNhdXNlCisgICAgICAgICAgIjIwODflubQo5bmz5oiQOTnlubQp IiBpcyB1c3VhbGx5IHdpZGVyIHRoYW4gIjI3NTc2MOW5tCIuCisKIDIwMTItMDUtMDEgIFJ5b3N1 a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgKkNvbW1hbmQuaCBmaWxlcyBz aG91bGRuJ3QgYmUgZXhwb3J0ZWQgdG8gV2ViS2l0IGxheWVyCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9SZXNvdXJjZXMvY2FsZW5kYXJQaWNrZXIuanMgYi9Tb3VyY2UvV2ViQ29yZS9SZXNv dXJjZXMvY2FsZW5kYXJQaWNrZXIuanMKaW5kZXggY2VlYmE3MmQ2NTJmMzUzODY4MWRmNThmMTJi MWNlMTUyMzhhN2FmOS4uNGVjODJhOTE1MTU4ODU0M2Y1OTY0YmY3ODFkNjlkZmFjMGE3MDM3ZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUmVzb3VyY2VzL2NhbGVuZGFyUGlja2VyLmpzCisr KyBiL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9jYWxlbmRhclBpY2tlci5qcwpAQCAtMTIyLDEy ICsxMjIsMjIgQEAgZnVuY3Rpb24gZ2V0TGFuZ3VhZ2UoKSB7CiAgICAgcmV0dXJuIHJlc3VsdFsx XTsKIH0KIAorLyoKKyAqIEBjb25zdAorICogQHR5cGUge251bWJlcn0KKyAqLwordmFyIEltcGVy aWFsRXJhTGltaXQgPSAyMDg3OworCiAvKioKICAqIEBwYXJhbSB7IW51bWJlcn0geWVhcgogICog QHBhcmFtIHshbnVtYmVyfSBtb250aAogICogQHJldHVybiB7IXN0cmluZ30KICAqLwogZnVuY3Rp b24gZm9ybWF0SmFwYW5lc2VJbXBlcmlhbEVyYSh5ZWFyLCBtb250aCkgeworICAgIC8vIFdlIGRv bid0IHNob3cgYW4gaW1wZXJpYWwgZXJhIGlmIGl0IGlzIGdyZWF0ZXIgdGhhbiA5OSBiZWNhc2Ug b2Ygc3BhY2UKKyAgICAvLyBsaW1pdGF0aW9uLgorICAgIGlmICh5ZWFyID4gSW1wZXJpYWxFcmFM aW1pdCkKKyAgICAgICAgcmV0dXJuICIiOwogICAgIGlmICh5ZWFyID4gMTk4OSkKICAgICAgICAg cmV0dXJuICIo5bmz5oiQIiArICh5ZWFyIC0gMTk4OCkgKyAi5bm0KSI7CiAgICAgaWYgKHllYXIg PT0gMTk4OSkKQEAgLTQyNiwxNCArNDM2LDE4IEBAIFllYXJNb250aENvbnRyb2xsZXIucHJvdG90 eXBlLmF0dGFjaFRvID0gZnVuY3Rpb24obWFpbikgewogICAgIHRoaXMuX3dhbGwuYWRkRXZlbnRM aXN0ZW5lcigiY2xpY2siLCBiaW5kKHRoaXMuX2Nsb3NlUG9wdXAsIHRoaXMpLCBmYWxzZSk7CiAg ICAgbWFpbi5hcHBlbmRDaGlsZCh0aGlzLl93YWxsKTsKIAotICAgIC8vIFRoZSBtYXhpbXVtIHll YXIgd2hpY2ggPGlucHV0IHR5cGU9ZGF0ZT4gc3VwcG9ydHMgaXMgMjc1LDc2MC4KLSAgICAvLyBT ZWUgV2ViQ29yZS9wbGF0Zm9ybS9EYXRlQ29tcG9uZW50cy5oCi0gICAgdmFyIE1heGltdW1ZZWFy ID0gMjc1NzYwOworICAgIHZhciBtYXhpbXVtWWVhciA9IGdsb2JhbC5tYXhpbXVtRGF0ZS5nZXRV VENGdWxsWWVhcigpOwogICAgIHZhciBtYXhXaWR0aCA9IDA7CiAgICAgZm9yICh2YXIgbSA9IDA7 IG0gPCAxMjsgKyttKSB7Ci0gICAgICAgIHRoaXMuX21vbnRoLnRleHRDb250ZW50ID0gZm9ybWF0 WWVhck1vbnRoKE1heGltdW1ZZWFyLCBtKTsKKyAgICAgICAgdGhpcy5fbW9udGgudGV4dENvbnRl bnQgPSBmb3JtYXRZZWFyTW9udGgobWF4aW11bVllYXIsIG0pOwogICAgICAgICBtYXhXaWR0aCA9 IE1hdGgubWF4KG1heFdpZHRoLCB0aGlzLl9tb250aC5vZmZzZXRXaWR0aCk7CiAgICAgfQorICAg IGlmIChnZXRMYW5ndWFnZSgpID09ICJqYSIgJiYgSW1wZXJpYWxFcmFMaW1pdCA8IG1heGltdW1Z ZWFyKSB7CisgICAgICAgIGZvciAodmFyIG0gPSAwOyBtIDwgMTI7ICsrbSkgeworICAgICAgICAg ICAgdGhpcy5fbW9udGgudGV4dENvbnRlbnQgPSBmb3JtYXRZZWFyTW9udGgoSW1wZXJpYWxFcmFM aW1pdCwgbSk7CisgICAgICAgICAgICBtYXhXaWR0aCA9IE1hdGgubWF4KG1heFdpZHRoLCB0aGlz Ll9tb250aC5vZmZzZXRXaWR0aCk7CisgICAgICAgIH0KKyAgICB9CiAgICAgdGhpcy5fbW9udGgu c3R5bGUubWluV2lkdGggPSBtYXhXaWR0aCArICdweCc7CiAKICAgICBnbG9iYWwuZmlyc3RGb2N1 c2FibGVDb250cm9sID0gdGhpcy5fbGVmdDI7IC8vIEZJWE1FOiBTaG91ZCBpdCBiZSB0aGlzLm1v bnRoPwo=