85312 2012-05-01 14:34:42 -0700 Web Inspector: cmd-[ shortcut navigates page and is fr-keyboard incompatible 2012-08-02 08:11:24 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 86955 0 paulirish apavlov apavlov bweinstein cem.kocagil+webkit fishd joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 613682 0 paulirish 2012-05-01 14:34:42 -0700 Two independent, but related, issues: 1) cmd-[ on mac will navigate the parent page in addition to changing the inspector panel. All page state is lost as the page is navigated. 2) On a french keyboard, to type a ], you use `alt+gr + )`. Typed in the console, this trigger the inspector to go to the Elements panel. Interestingly [ causes no problems. This makes it impossible to type an array literal in the console. 629126 1 apavlov 2012-05-21 08:40:14 -0700 *** Bug 86955 has been marked as a duplicate of this bug. *** 629160 2 apavlov 2012-05-21 09:10:43 -0700 (In reply to comment #0) > Two independent, but related, issues: > > 1) cmd-[ on mac will navigate the parent page in addition to changing the inspector panel. All page state is lost as the page is navigated. I'm unable to reproduce this one on a recent build (May 11). > 2) On a french keyboard, to type a ], you use `alt+gr + )`. Typed in the console, this trigger the inspector to go to the Elements panel. Interestingly [ causes no problems. This makes it impossible to type an array literal in the console. Assuming this one conveys the contents of bug 86955, will submit a patch for this one shortly. 629220 3 apavlov 2012-05-21 10:06:45 -0700 Darin, I vaguely remember you hack on the keyboard event handling in Chromium. Do you have a clue if the following behavior is correct or not? Chromium produces exactly the same Event data for "Ctrl"+"Alt"+"[" on the English QUERTY keyboard and for "AltGr"+")" (to enter the "]" character) on the French AZERTY keyboard (yes, in the latter case the event flags are: altGraphKey: false altKey: true ctrlKey: true keyCode: 219 keyIdentifier: "U+00DB" metaKey: false shiftKey: false ). Or should we monitor the modifier key states manually... 629925 4 paulirish 2012-05-21 21:34:32 -0700 (In reply to comment #2) > > 1) cmd-[ on mac will navigate the parent page in addition to changing the inspector panel. All page state is lost as the page is navigated. > > I'm unable to reproduce this one on a recent build (May 11). I can repro in Canary and a recent WebKit nightly. Steps: 1) on this page, click to bug 86955 2) cmd-opt-i to open inspector (mine currently opens to Scripts) 3) cmd-[ Results: Inspector moves to Network while parent page navigates back to this ticket 632818 5 apavlov 2012-05-24 08:08:32 -0700 (In reply to comment #4) > (In reply to comment #2) > > > 1) cmd-[ on mac will navigate the parent page in addition to changing the inspector panel. All page state is lost as the page is navigated. > > > > I'm unable to reproduce this one on a recent build (May 11). > > > I can repro in Canary and a recent WebKit nightly. > > Steps: > > 1) on this page, click to bug 86955 > 2) cmd-opt-i to open inspector (mine currently opens to Scripts) > 3) cmd-[ > > Results: > > Inspector moves to Network while parent page navigates back to this ticket OK, I get the point. This works as intended, since on Mac, Cmd-[ is a standard Chrome shortcut to navigate back to the previous page (and Cmd-] navigates forward in the history). This works the same way as Alt-Left/Right on Win and Linux. 632845 6 apavlov 2012-05-24 08:50:00 -0700 (In reply to comment #5) > OK, I get the point. This works as intended, since on Mac, Cmd-[ is a standard Chrome shortcut to navigate back to the previous page (and Cmd-] navigates forward in the history). This works the same way as Alt-Left/Right on Win and Linux. Oops, we seem to intercept this shortcut, but not quite... 633814 7 144040 apavlov 2012-05-25 04:09:35 -0700 Created attachment 144040 Patch 633847 8 144040 vsevik 2012-05-25 05:20:39 -0700 Comment on attachment 144040 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144040&action=review > Source/WebCore/inspector/front-end/InspectorView.js:46 > + this._filteredKeyIdentifiers = ["U+005B", "U+00DB", "U+005D", "U+00DD"].keySet(); Let's create this._leftBracketKeyIdentifiers and this._rightBracketKeyIdentifiers fields and use them here and in _keyDownInternal to avoid duplicating this confusing unicode magic. > Source/WebCore/inspector/front-end/InspectorView.js:95 > + if (event.charCode === 91 || event.charCode === 93) { Please add a comment saying this is checking for brackets or use some function to convert character to ascii code. > Source/WebCore/inspector/front-end/InspectorView.js:103 > + if (!WebInspector.isWin() || !this._filteredKeyIdentifiers.hasOwnProperty(event.keyIdentifier)) { Please add a comment explaining this workaround (and reasoning) here. 633870 9 apavlov 2012-05-25 06:11:14 -0700 Committed r118520: <http://trac.webkit.org/changeset/118520> 685405 10 paulirish 2012-08-02 08:11:24 -0700 *** Bug 84092 has been marked as a duplicate of this bug. *** 144040 2012-05-25 04:09:35 -0700 2012-05-25 05:20:39 -0700 Patch bug-85312-20120525150934.patch text/plain 5210 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTMxYzU2MjU5Mjc3ZmU5 MTk3ODliZmRhNjBlOTIxYmQxZGFlOWNmMC4uZDJhOTJkYjhkNzQyNDliMDI3MTBjN2QyNzE5NjQ4 YzU5ZTg1N2UzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA1LTI1ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogY21kLVsgc2hvcnRjdXQgbmF2aWdhdGVzIHBhZ2UgYW5kIGlzIGZyLWtleWJvYXJkIGlu Y29tcGF0aWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODUzMTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTdXBwcmVzcyB0aGUgaGFuZGxpbmcgb2YgcGFuZWwgaGlzdG9yeSBuYXZpZ2F0aW9uIGV2ZW50 cyBpZiB0aGUgY29ycmVzcG9uZGluZyBrZXlib2FyZCBhY3Rpdml0aWVzIHByb2R1Y2UKKyAgICAg ICAgdGhlICJrZXlwcmVzcyIgZXZlbnQgKHdoaWNoIGlzIHRoZSBjYXNlIG9uIEZyZW5jaCBrZXli b2FyZHMsIHdoZXJlIEFsdEdyK1sgaXMgdHJhbnNsYXRlZCBpbnRvIEN0cmwrQWx0K1sgb24gV2lu ZG93cykuCisgICAgICAgIFRoZSBldmVudCBpcyBhbHNvIHRvbGQgdG8gcHJldmVudERlZmF1bHQo KSB0byBhdm9pZCBicm93c2VyIGhpc3RvcnkgbmF2aWdhdGlvbiBvbiBNYWMgd2hpbGUgdHJhdmVy c2luZyB0aGUgSW5zcGVjdG9yIHBhbmVsIGhpc3RvcnkuCisKKyAgICAgICAgKiBpbnNwZWN0b3Iv ZnJvbnQtZW5kL0luc3BlY3RvclZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSW5zcGVj dG9yVmlldyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSW5zcGVjdG9yVmlldy5wcm90b3R5cGUu X2tleVByZXNzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5JbnNwZWN0b3JWaWV3LnByb3RvdHlw ZS5fa2V5RG93bik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSW5zcGVjdG9yVmlldy5wcm90b3R5 cGUuX2tleURvd25JbnRlcm5hbCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9VSVV0 aWxzLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmlzV2luKToKKwogMjAxMi0wNS0yNCAgWXVy eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBhZGQgcHJvZmlsZSB0eXBlIGZvciBuYXRpdmUgbWVtb3J5IHNuYXBzaG90cwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbnNwZWN0b3JWaWV3Lmpz IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbnNwZWN0b3JWaWV3LmpzCmlu ZGV4IDUyZjMwMWUxMjk5ODY3MmYxNWRlNzgxZDkwYTY5NjI0MmY4NWYwODUuLjgwMTFiYjljZTY0 ZmQzNDIwMDgyMTU5NGQ2YTBmYzU0MGIyMjE5NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvSW5zcGVjdG9yVmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luc3BlY3RvclZpZXcuanMKQEAgLTQxLDcgKzQxLDkgQEAg V2ViSW5zcGVjdG9yLkluc3BlY3RvclZpZXcgPSBmdW5jdGlvbigpCiAgICAgdGhpcy5faGlzdG9y eSA9IFtdOwogICAgIHRoaXMuX2hpc3RvcnlJdGVyYXRvciA9IC0xOwogICAgIGRvY3VtZW50LmFk ZEV2ZW50TGlzdGVuZXIoImtleWRvd24iLCB0aGlzLl9rZXlEb3duLmJpbmQodGhpcyksIGZhbHNl KTsKKyAgICBkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCJrZXlwcmVzcyIsIHRoaXMuX2tleVBy ZXNzLmJpbmQodGhpcyksIGZhbHNlKTsKICAgICB0aGlzLl9wYW5lbE9yZGVyID0gW107CisgICAg dGhpcy5fZmlsdGVyZWRLZXlJZGVudGlmaWVycyA9IFsiVSswMDVCIiwgIlUrMDBEQiIsICJVKzAw NUQiLCAiVSswMEREIl0ua2V5U2V0KCk7CiB9CiAKIFdlYkluc3BlY3Rvci5JbnNwZWN0b3JWaWV3 LkV2ZW50cyA9IHsKQEAgLTg1LDggKzg3LDI5IEBAIFdlYkluc3BlY3Rvci5JbnNwZWN0b3JWaWV3 LnByb3RvdHlwZSA9IHsKICAgICAgICAgfQogICAgIH0sCiAKKyAgICBfa2V5UHJlc3M6IGZ1bmN0 aW9uKGV2ZW50KQorICAgIHsKKyAgICAgICAgaWYgKCF0aGlzLl9rZXlEb3duVGltZXIpCisgICAg ICAgICAgICByZXR1cm47CisKKyAgICAgICAgaWYgKGV2ZW50LmNoYXJDb2RlID09PSA5MSB8fCBl dmVudC5jaGFyQ29kZSA9PT0gOTMpIHsKKyAgICAgICAgICAgIGNsZWFyVGltZW91dCh0aGlzLl9r ZXlEb3duVGltZXIpOworICAgICAgICAgICAgZGVsZXRlIHRoaXMuX2tleURvd25UaW1lcjsKKyAg ICAgICAgfQorICAgIH0sCisKICAgICBfa2V5RG93bjogZnVuY3Rpb24oZXZlbnQpCiAgICAgewor ICAgICAgICBpZiAoIVdlYkluc3BlY3Rvci5pc1dpbigpIHx8ICF0aGlzLl9maWx0ZXJlZEtleUlk ZW50aWZpZXJzLmhhc093blByb3BlcnR5KGV2ZW50LmtleUlkZW50aWZpZXIpKSB7CisgICAgICAg ICAgICB0aGlzLl9rZXlEb3duSW50ZXJuYWwoZXZlbnQpOworICAgICAgICAgICAgcmV0dXJuOwor ICAgICAgICB9CisKKyAgICAgICAgdGhpcy5fa2V5RG93blRpbWVyID0gc2V0VGltZW91dCh0aGlz Ll9rZXlEb3duSW50ZXJuYWwuYmluZCh0aGlzLCBldmVudCksIDApOworICAgIH0sCisKKyAgICBf a2V5RG93bkludGVybmFsOiBmdW5jdGlvbihldmVudCkKKyAgICB7CiAgICAgICAgIHN3aXRjaCAo ZXZlbnQua2V5SWRlbnRpZmllcikgewogICAgICAgICAgICAgLy8gV2luZG93cyBhbmQgTWFjIGhh dmUgdHdvIGRpZmZlcmVudCBkZWZpbml0aW9ucyBvZiBbLCBzbyBhY2NlcHQgYm90aC4KICAgICAg ICAgICAgIGNhc2UgIlUrMDA1QiI6CkBAIC05NiwxNCArMTE5LDE0IEBAIFdlYkluc3BlY3Rvci5J bnNwZWN0b3JWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICAgICAgdmFyIGluZGV4 ID0gdGhpcy5fcGFuZWxPcmRlci5pbmRleE9mKHRoaXMuY3VycmVudFBhbmVsKCkpOwogICAgICAg ICAgICAgICAgICAgICBpbmRleCA9IChpbmRleCA9PT0gMCkgPyB0aGlzLl9wYW5lbE9yZGVyLmxl bmd0aCAtIDEgOiBpbmRleCAtIDE7CiAgICAgICAgICAgICAgICAgICAgIHRoaXMuX3BhbmVsT3Jk ZXJbaW5kZXhdLnRvb2xiYXJJdGVtLmNsaWNrKCk7Ci0gICAgICAgICAgICAgICAgICAgIGV2ZW50 LmNvbnN1bWUoKTsKKyAgICAgICAgICAgICAgICAgICAgZXZlbnQuY29uc3VtZSh0cnVlKTsKICAg ICAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgICAgIH0KIAogICAgICAgICAg ICAgICAgIHZhciBpc0dvQmFjayA9IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LmV2ZW50 SGFzQ3RybE9yTWV0YShldmVudCkgJiYgZXZlbnQuYWx0S2V5OwogICAgICAgICAgICAgICAgIGlm IChpc0dvQmFjayAmJiB0aGlzLl9jYW5Hb0JhY2tJbkhpc3RvcnkoKSkgewogICAgICAgICAgICAg ICAgICAgICB0aGlzLl9nb0JhY2tJbkhpc3RvcnkoKTsKLSAgICAgICAgICAgICAgICAgICAgZXZl bnQuY29uc3VtZSgpOworICAgICAgICAgICAgICAgICAgICBldmVudC5jb25zdW1lKHRydWUpOwog ICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBicmVhazsKIApAQCAtMTE1LDE0ICsx MzgsMTQgQEAgV2ViSW5zcGVjdG9yLkluc3BlY3RvclZpZXcucHJvdG90eXBlID0gewogICAgICAg ICAgICAgICAgICAgICB2YXIgaW5kZXggPSB0aGlzLl9wYW5lbE9yZGVyLmluZGV4T2YodGhpcy5j dXJyZW50UGFuZWwoKSk7CiAgICAgICAgICAgICAgICAgICAgIGluZGV4ID0gKGluZGV4ICsgMSkg JSB0aGlzLl9wYW5lbE9yZGVyLmxlbmd0aDsKICAgICAgICAgICAgICAgICAgICAgdGhpcy5fcGFu ZWxPcmRlcltpbmRleF0udG9vbGJhckl0ZW0uY2xpY2soKTsKLSAgICAgICAgICAgICAgICAgICAg ZXZlbnQuY29uc3VtZSgpOworICAgICAgICAgICAgICAgICAgICBldmVudC5jb25zdW1lKHRydWUp OwogICAgICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICAgICAgfQogCiAgICAg ICAgICAgICAgICAgdmFyIGlzR29Gb3J3YXJkID0gV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRj dXQuZXZlbnRIYXNDdHJsT3JNZXRhKGV2ZW50KSAmJiBldmVudC5hbHRLZXk7CiAgICAgICAgICAg ICAgICAgaWYgKGlzR29Gb3J3YXJkICYmIHRoaXMuX2NhbkdvRm9yd2FyZEluSGlzdG9yeSgpKSB7 CiAgICAgICAgICAgICAgICAgICAgIHRoaXMuX2dvRm9yd2FyZEluSGlzdG9yeSgpOwotICAgICAg ICAgICAgICAgICAgICBldmVudC5jb25zdW1lKCk7CisgICAgICAgICAgICAgICAgICAgIGV2ZW50 LmNvbnN1bWUodHJ1ZSk7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1VJVXRpbHMuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1VJVXRp bHMuanMKaW5kZXggYzhkNDNlMjEyZTE5M2Q5ZjFkYjgyYmFlY2M5YTBkZmNiNmQ3OWZiZC4uNWMx NWFjNDUxOTBjZTkxNjhjMzgwNjRjY2U2MjA1NmVhYWUyOWUwNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9VSVV0aWxzLmpzCisrKyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVUlVdGlscy5qcwpAQCAtNTEyLDYgKzUxMiwxNCBAQCBX ZWJJbnNwZWN0b3IuaXNNYWMgPSBmdW5jdGlvbigpCiAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5f aXNNYWM7CiB9CiAKK1dlYkluc3BlY3Rvci5pc1dpbiA9IGZ1bmN0aW9uKCkKK3sKKyAgICBpZiAo dHlwZW9mIFdlYkluc3BlY3Rvci5faXNXaW4gPT09ICJ1bmRlZmluZWQiKQorICAgICAgICBXZWJJ bnNwZWN0b3IuX2lzV2luID0gV2ViSW5zcGVjdG9yLnBsYXRmb3JtKCkgPT09ICJ3aW5kb3dzIjsK KworICAgIHJldHVybiBXZWJJbnNwZWN0b3IuX2lzV2luOworfQorCiBXZWJJbnNwZWN0b3IuUGxh dGZvcm1GbGF2b3IgPSB7CiAgICAgV2luZG93c1Zpc3RhOiAid2luZG93cy12aXN0YSIsCiAgICAg TWFjVGlnZXI6ICJtYWMtdGlnZXIiLAo=