85309 2012-05-01 14:15:43 -0700 supportsExpandedScrollbars() should check for the method we actually call rather than a related method 2012-05-02 12:47:47 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin andersca bdakin darin oldest_to_newest 613662 0 bdakin 2012-05-01 14:15:43 -0700 In ScrollbarThemeMac, supportsExpandedScrollbars() checked if NSScrollerImp responds to isExpanded. The result of this function is used to determine whether or not is it safe to call setExpanded. We should just check for setExpanded instead. <rdar://problem/11065691> 613668 1 139678 bdakin 2012-05-01 14:18:11 -0700 Created attachment 139678 Patch 614247 2 bdakin 2012-05-02 06:42:32 -0700 Thanks Anders! http://trac.webkit.org/changeset/115823 614464 3 darin 2012-05-02 11:19:58 -0700 This patch was wrong! The selector is setExpanded: with the colon, not setExpanded without a colon! 614479 4 andersca 2012-05-02 11:35:53 -0700 Oops! 614549 5 bdakin 2012-05-02 12:46:52 -0700 (In reply to comment #3) > This patch was wrong! The selector is setExpanded: with the colon, not setExpanded without a colon! Thanks for noticing that! Added the colon here: http://trac.webkit.org/changeset/115868 139678 2012-05-01 14:18:11 -0700 2012-05-01 15:51:29 -0700 Patch for-review.txt text/plain 1590 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTc0NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTAxICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODUzMDkKKyAgICAgICAgc3VwcG9ydHNFeHBhbmRlZFNjcm9sbGJh cnMoKSBzaG91bGQgY2hlY2sgZm9yIHRoZSBtZXRob2Qgd2UgYWN0dWFsbHkgY2FsbCByYXRoZXIg CisgICAgICAgIHRoYW4gYSByZWxhdGVkIG1ldGhvZAorICAgICAgICAtYW5kIGNvcnJlc3BvbmRp bmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMTA2NTY5MT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9TY3JvbGxiYXJU aGVtZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OnN1cHBvcnRzRXhwYW5kZWRTY3JvbGxiYXJz KToKKwogMjAxMi0wNS0wMSAgVGVycnkgQW5kZXJzb24gIDx0ZGFuZGVyc29uQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBBbGxvdyBhIHByZS10YXJnZXRlZCBub2RlIHRvIGJlIHNwZWNpZmllZCB3 aGVuIGRpc3BhdGNoaW5nIGEgR2VzdHVyZVRhcCBldmVudApJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5tbQkocmV2aXNpb24gMTE1NjI1 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0xNDAsNyArMTQwLDcgQEAgc3RhdGljIFNjcm9sbGJhckJ1dHRvbnNQ bGFjZW1lbnQgZ0J1dHRvbgogc3RhdGljIGJvb2wgc3VwcG9ydHNFeHBhbmRlZFNjcm9sbGJhcnMo KQogewogICAgIC8vIEZJWE1FOiBUaGlzIGlzIHRlbXBvcmFyeSB1bnRpbCBhbGwgcGxhdGZvcm1z IHRoYXQgc3VwcG9ydCBTY3JvbGxiYXJQYWludGVyIHN1cHBvcnQgdGhpcyBwYXJ0IG9mIHRoZSBB UEkuCi0gICAgc3RhdGljIGJvb2wgZ2xvYmFsU3VwcG9ydHNFeHBhbmRlZFNjcm9sbGJhcnMgPSBb TlNDbGFzc0Zyb21TdHJpbmcoQCJOU1Njcm9sbGVySW1wIikgaW5zdGFuY2VzUmVzcG9uZFRvU2Vs ZWN0b3I6QHNlbGVjdG9yKGlzRXhwYW5kZWQpXTsKKyAgICBzdGF0aWMgYm9vbCBnbG9iYWxTdXBw b3J0c0V4cGFuZGVkU2Nyb2xsYmFycyA9IFtOU0NsYXNzRnJvbVN0cmluZyhAIk5TU2Nyb2xsZXJJ bXAiKSBpbnN0YW5jZXNSZXNwb25kVG9TZWxlY3RvcjpAc2VsZWN0b3Ioc2V0RXhwYW5kZWQpXTsK ICAgICByZXR1cm4gZ2xvYmFsU3VwcG9ydHNFeHBhbmRlZFNjcm9sbGJhcnM7CiB9CiAK